R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7044090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88777 0039d316-1c4b-4281-b951-d872f2087c98

R=evan@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7129059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7024021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@88160 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7065074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87979 0039d316-1c4b-4281-b951-d872f2087c98

For a yet unknown reason, a chmod +x on a git svn checkout will set a 'A'
status. Will investigate separately.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6993033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87903 0039d316-1c4b-4281-b951-d872f2087c98

Use p.is_new signal and set it manually with rietveld patches.
Add regression test for +x.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87858 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7112016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87844 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_support.py can now creates a Rietveld object on its own.

This is necessary since the object needs to be recreated out of process. The
commit queue runs the presubmit check out of process for sanity reasons.

Added TODO to push the cookie instead of the password.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7058054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87842 0039d316-1c4b-4281-b951-d872f2087c98

Add is_new to be used in a later patch by checkout classes.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7054048

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87838 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7056045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87827 0039d316-1c4b-4281-b951-d872f2087c98

This enables private issue checking and simplifies testing.

R=dpranke@chromium.org

Review URL: http://codereview.chromium.org/7058025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87743 0039d316-1c4b-4281-b951-d872f2087c98

The "^0" is not needed, and it confuses Windows since
the carret is a special character.
Review URL: http://codereview.chromium.org/6976050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87636 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to dump logging information from a PRESUBMIT script when
calling git cl presubmit -v -v -v for example.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7027031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87603 0039d316-1c4b-4281-b951-d872f2087c98

The regression was introduced in r87253.

TBR=dpranke@chromium.org
BUG=
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87550 0039d316-1c4b-4281-b951-d872f2087c98

While using --jobs, empty lines are adding a lot of noise.

An example output would look like:

>gclient sync --jobs=10
1>
3>
4>
6>
5>
7>
5>
5>________ running 'git clone ...'
Review URL: http://codereview.chromium.org/7101012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87542 0039d316-1c4b-4281-b951-d872f2087c98

On Windows "git clone url path/repo" does not create 'path' if it does
not exist. It fails with:

Fatal: could not create work tree dir 'path\repo'.: No such file or directory

this patch manually creates the subdir if it does not exist.
Review URL: http://codereview.chromium.org/7080063

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87522 0039d316-1c4b-4281-b951-d872f2087c98

This change makes it possible to run 'git cl' from
a Command Prompt using only the auto-installed git
from depot_tools.  It is needed because in MSysGit,
'git cl' invokes 'git' which calls 'git-cl'.  While
'git-cl' is pulled from depot_tools (since it's in
PATH), depot_tools/python_bin is not in PATH, and
so we execute git_cl.py through our auto-installed
python.exe directly.

update_depot_tools is fixed so that if we find
the auto-installed svn and git in depot_tools, we
execute those directly, otherwise falling back to
calling them based on PATH.

In both git-cl and update_depot_tools, we only enable
this new behavior if uname in PATH reports a 'MINGW'
environment.  This should not trigger on any other
environment where uname exists, including Cygwin which
should report 'CYGWIN'.
Review URL: http://codereview.chromium.org/7020035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87510 0039d316-1c4b-4281-b951-d872f2087c98

url is pointing to a git repo, the name of the directory created on disk will not
contain the .git suffix.
Review URL: http://codereview.chromium.org/7104009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87492 0039d316-1c4b-4281-b951-d872f2087c98

correctly.  The current behavior was to call git clone with --no-checkout, which
did not create a working copy, and made the checkout unusable by the users.
Review URL: http://codereview.chromium.org/7104007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87491 0039d316-1c4b-4281-b951-d872f2087c98

TEST=covered by gclient_smoketest.py
Review URL: http://codereview.chromium.org/7062029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87367 0039d316-1c4b-4281-b951-d872f2087c98

It needs to be parsed manually and assumes '=*' for property that do not specify
a value.

Add clearer message on failure like that by specifiying the command line.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7085022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87255 0039d316-1c4b-4281-b951-d872f2087c98

Add "git cl set_commit" command to set the flag more easily.
Add --commit to "git cl upload" to streamline workflow even more.
Continue conversion to Rietveld object.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7084037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87253 0039d316-1c4b-4281-b951-d872f2087c98

This makes it coherent with the commit queue by keeping the lgtm at a single
place.

This simplifies owners check code.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7082029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87251 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7030023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87185 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87106 0039d316-1c4b-4281-b951-d872f2087c98

It is because upload.py doesn't use sane default parameter.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7075029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87012 0039d316-1c4b-4281-b951-d872f2087c98

It's needed to start a mapreduce on GAE with this class.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7076016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79546
TEST=None
R=maruel@google.com
Review URL: http://codereview.chromium.org/7062012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86837 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7008006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86552 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7055025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79546
TEST=None
Review URL: http://codereview.chromium.org/7063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86460 0039d316-1c4b-4281-b951-d872f2087c98

This is causing a failure with dash interpreters.
Will revert this change and do testing in that
environment before next landing.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86211 0039d316-1c4b-4281-b951-d872f2087c98

On at least one platform /usr/bin/env is actually not
a guaranteed method to get to bash.  Fall back to using
/bin/bash for this script.
Review URL: http://codereview.chromium.org/7039045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86185 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/7017005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85596 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7035005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85568 0039d316-1c4b-4281-b951-d872f2087c98

I wonder how it worked at all. That explains some weird behavior when it was
ignoring issues recently.

Also enabled limit=1000 in case there's a huge bottleneck.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7016038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85516 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise it can mess with file permissions.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7016002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85178 0039d316-1c4b-4281-b951-d872f2087c98

The presubmit check complained about long lines in .grd files. This isn't a useful warning since .grd files aren't really source files.

The problem was that callers were passing in a file filter to InputApi.AffectedFiles but it was being ignored. Fix was to use the passed in file filter.

BUG=None
TEST=Ran on a local change and verified that I no longer got long line warnings on .grd files.
Review URL: http://codereview.chromium.org/6932060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85148 0039d316-1c4b-4281-b951-d872f2087c98

This check is also handled by the commit bot so no need to harass people when
uploading.

R=dpranke@chromium.org
BUG=none
TEST=Nobody wrote a test for PanProjectChecks() and I didn't write this function, no way I won't.

Review URL: http://codereview.chromium.org/6998008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84814 0039d316-1c4b-4281-b951-d872f2087c98