BUG=161702

R=maruel@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11438024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171277 0039d316-1c4b-4281-b951-d872f2087c98

We use the fact the dcommit adds a "Committed:" link to the
description.  If we wanted to be more strict, we could make
git cl dcommit post a comment on the CL (which would be nice
since it would notify reviewers that the CL was committed).

Note that this is untested as written, because it doesn't appear
that we have either git-cl integration tests, nor a test for
git cl dcommit adding the word "Committed:" so as written, this
presubmit check is prone to failure.  Would like suggestions to
improve.

Also adding DoNotSubmit checks and a couple others to
PanPresubmitChecks.

R=maruel@chromium.org,dpranke@chromium.org
BUG=161702

Review URL: https://chromiumcodereview.appspot.com/11421050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171158 0039d316-1c4b-4281-b951-d872f2087c98

This can come up when CQ closed an issue but the user's
local branch is still tied to the issue.

BUG=161702


Review URL: https://chromiumcodereview.appspot.com/11348122

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171153 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=163030


Review URL: https://chromiumcodereview.appspot.com/11434048

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161704,161840

Review URL: https://chromiumcodereview.appspot.com/11414098

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170588 0039d316-1c4b-4281-b951-d872f2087c98

Support 'git grep <match> <branch>' type searches in gclient grep.
These searches had a slightly different output so needed more
tweeking to the regex.  I cleaned it up a bit too.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11316213

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170039 0039d316-1c4b-4281-b951-d872f2087c98

Reduce calling SendProfile to long running commands. There's lots of low hanging fruit (slow commands) to optimize before we need perf stats from fast commands.

R=maruel@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/11416230

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170009 0039d316-1c4b-4281-b951-d872f2087c98

settings.GetIsGerrit() would invoke logging.basicConfig() and
preemtps the basicConfig for verbose option in parser.parse_args.

R=maruel@chromium.org,ilevy@chromium.org
BUG=162600

Review URL: https://chromiumcodereview.appspot.com/11418171

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169843 0039d316-1c4b-4281-b951-d872f2087c98

- Many chrome-internal viewvc links do not support https.  UpgradeToHttps
  was added 10 months ago  and continues to generate broken viewvc links.

Reverts part of crrev.com/9214004

BUG=107838

Review URL: https://chromiumcodereview.appspot.com/11412161

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169815 0039d316-1c4b-4281-b951-d872f2087c98

- This will be used by navabi to have his gclient recurse
  command print the current repo.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11308115

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169812 0039d316-1c4b-4281-b951-d872f2087c98

Multiple presubmit checks may call the same function multiple times, so it's
worth caching the results to speed up the presubmit check run.

Convert presubmit_support, git-cl and gcl to use it.

R=dpranke@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11280143

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11414163

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169447 0039d316-1c4b-4281-b951-d872f2087c98

The bash command "local myvar=$(mycommand)" has the exit status of the
bash builtin "local" rather than the exit status of mycommand.  To get
the exit status of mycommand, "local myvar" should be run separately
on a previous line.


Review URL: https://chromiumcodereview.appspot.com/11308129

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169446 0039d316-1c4b-4281-b951-d872f2087c98

Add some logging when CMDupload is passed a verbosity option.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11418148

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169434 0039d316-1c4b-4281-b951-d872f2087c98

This avoids build errors like at http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/64851/steps/update/logs/stdio (search for mtpd).

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11417059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@168521 0039d316-1c4b-4281-b951-d872f2087c98

Currently, if an unversioned directory is present where we would expect
a versioned repository to be, the following error is printed:

  Can't update/checkout %s if an unversioned directory is present.
  Delete the directory and try again.

If --reset and --delete_unversioned_trees are used, gclient should delete
the unversioned directory in this case.

This problem can be reproduced using the following recipe:
  $ rm -rf src/third_party/webrtc/.svn
  $ gclient sync -nRftD

BUG=none
TEST=Verify that above error is fixed. Run all smoke tests.


Review URL: https://chromiumcodereview.appspot.com/11366239

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167942 0039d316-1c4b-4281-b951-d872f2087c98

Turning off could be interpreted as having a lasting impact instead of just being a notice for the current run.

Review URL: https://chromiumcodereview.appspot.com/11359168

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167476 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org
BUG=155511


Review URL: https://chromiumcodereview.appspot.com/11377139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167443 0039d316-1c4b-4281-b951-d872f2087c98

- Adds a gclient grep command to search through git repos.

BUG=157950


Review URL: https://chromiumcodereview.appspot.com/11312116

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167007 0039d316-1c4b-4281-b951-d872f2087c98

Not all developers have =~ support in bash, apparently.
Switching to standard globbing.

R=tapted
TBR=maruel

Review URL: https://codereview.chromium.org/11369147

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166867 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11360150

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166846 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the try slaves run the hooks twice, once in the apply_issue, another
in the runhooks step. It is unnecessary. It will reduce the problem with
apply_issue timeouts.

TBR=xusydoc@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11362176

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166826 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for https://codereview.appspot.com/6814091/
which changes the default ordering on codereview searches.

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11365157

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166822 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11275219

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166808 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/11312153/
Review URL: https://codereview.chromium.org/11275218

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166804 0039d316-1c4b-4281-b951-d872f2087c98

Regex matched substrings, so 'gclient', and 'gclient g' were
excluded.

TBR=maruel@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11370007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166799 0039d316-1c4b-4281-b951-d872f2087c98

In an effort to make some local commands faster, I propose we
exclude them from network dependent update step.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11312143

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166793 0039d316-1c4b-4281-b951-d872f2087c98

This causes an excepiton on Windows,
  File "E:\b\depot_tools\subprocess2.py", line 341, in communicate
TypeError: Using timeout and shell simultaneously will cause a process leak
since the shell will be killed instead of the child process.

TBR=petermayo@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11368148

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166732 0039d316-1c4b-4281-b951-d872f2087c98

svn commit likes to hang indefinitely whenever the svnserve server forgets
about the client. This changes ensures the commit queue won't be blocked by
this problem.

Add --quiet to the git fetch command but do not capture anymore.


R=petermayo@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11358165

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166725 0039d316-1c4b-4281-b951-d872f2087c98

apply_issue step hangs and the output is often in the reverse order. This CL is
to help diagnose the problem.

TBR=cmp@chromium.org
BUG=159868


Review URL: https://chromiumcodereview.appspot.com/11359093

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166505 0039d316-1c4b-4281-b951-d872f2087c98

page output.  Rather than recreate the entire msysgit zip file and
for everyone to download it again, just modify git.bat in place.

TBR=maruel@chromium.org,cmp@chromium.org
Review URL: https://codereview.chromium.org/11358128

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166295 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11364105

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166284 0039d316-1c4b-4281-b951-d872f2087c98

/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: Not a directory
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22: exec:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: cannot execute: Not a directory

TBR=szager@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11366117

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166274 0039d316-1c4b-4281-b951-d872f2087c98

C:\depot_tools\/git-cl

But in msys-git-1.8.0 it's:

C:\depot_tools\\git-cl

Handle either syntax correctly.

TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11359074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166268 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11377002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157979


Review URL: https://chromiumcodereview.appspot.com/11368067

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166247 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/11365070
Review URL: https://codereview.chromium.org/11364056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166237 0039d316-1c4b-4281-b951-d872f2087c98

This is unfortunately imperfect in a number of ways:

* Needs to get info from git commits, so needs a local WebKit git repo, and an explicit option to find it.
* Bugzilla doesn't return nearly as much information as other bug servers, and individual issues would have to be hit (and parsed) to get it.
* Searching for comments includes any issue ever commented on that was changed over the time period requested, so may have false positives.
* Reviews themselves can't be searched from Bugzilla, so can only be detected as "reviews" once landed and "issues" until then.

BUG=158993


Review URL: https://chromiumcodereview.appspot.com/11365078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166100 0039d316-1c4b-4281-b951-d872f2087c98

    
Added checks:
- Block upload of a diff from sha not in current branch
  (this includes tracking against an unrebased local master)
- Block upload of a diff containing shas from origin/master
  (should never happen)

- Use explicit calls to git merge-base instead of calling git diff
   with "<branch>..." which implicitly uses merge-base.

BUG=157503

Review URL: https://chromiumcodereview.appspot.com/11262057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165887 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165720 0039d316-1c4b-4281-b951-d872f2087c98