Commits · 68f2746262982eabbfb31ccb2fae85e0462c4e07 · Linshizhi / Chromium_Depot_tools

14 Mar, 2011 4 commits

thomasvl@chromium.org authored Mar 14, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6690012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78029 0039d316-1c4b-4281-b951-d872f2087c98

68f27462

Revert part of 77946 and 77978 so things work against when EDITOR is set to · ca7953a5

thomasvl@chromium.org authored Mar 14, 2011

something with spaces in it.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6686046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78027 0039d316-1c4b-4281-b951-d872f2087c98

ca7953a5

Fix a regression introduced in r77997. · 602e0a7e

maruel@chromium.org authored Mar 14, 2011

An error message would be printed at each update_depot_tools invocation.

TBR=mhm
BUG=none
TEST=running gclient shouldn't print an error message at each invocation anymore

Review URL: http://codereview.chromium.org/6690008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78021 0039d316-1c4b-4281-b951-d872f2087c98

602e0a7e

Add a message to the screen when depot tools have been updated. · 31ced09f

mhm@chromium.org authored Mar 14, 2011

BUG=none
TEST=message appears only when new revision changes.

Review URL: http://codereview.chromium.org/6691001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77997 0039d316-1c4b-4281-b951-d872f2087c98

31ced09f

13 Mar, 2011 5 commits

Fix prompting - had the logic backwards. The git-cl unit tests actually test... · 5a2fefb9

dpranke@chromium.org authored Mar 13, 2011

Fix prompting - had the logic backwards. The git-cl unit tests actually test the prompting correctly (once they are modified to pass otherwise).

Review URL: http://codereview.chromium.org/6679032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77985 0039d316-1c4b-4281-b951-d872f2087c98

5a2fefb9

Reland Usage of TERM to distinguish between msys and cygwin. · 3e48aa74

mhm@chromium.org authored Mar 13, 2011

BUG=70548
TEST=check $TERM in windows
Review URL: http://codereview.chromium.org/6683035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77978 0039d316-1c4b-4281-b951-d872f2087c98

3e48aa74

Revert 77954 - Use TERM to distinguish between console and msysgit. · 7888d979

jam@chromium.org authored Mar 13, 2011

It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.

BUG=70548
TEST=check $TERM in windows

Review URL: http://codereview.chromium.org/6686027

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6683033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77972 0039d316-1c4b-4281-b951-d872f2087c98

7888d979

Although there appear to be one or two tests that are flaky on both mac and linux. · 330f5347

dpranke@chromium.org authored Mar 13, 2011

Review URL: http://codereview.chromium.org/6681019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77955 0039d316-1c4b-4281-b951-d872f2087c98

330f5347

Use TERM to distinguish between console and msysgit. · eceda5af

mhm@chromium.org authored Mar 13, 2011

It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.

BUG=70548
TEST=check $TERM in windows

Review URL: http://codereview.chromium.org/6686027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77954 0039d316-1c4b-4281-b951-d872f2087c98

eceda5af

12 Mar, 2011 10 commits

Fix win32api and win32con definition order. · 1edee691

maruel@chromium.org authored Mar 12, 2011

It would fail on win32 when these modules are not present.

BUG=75902
TEST=none

R=mhm@chromium.org

Review URL: http://codereview.chromium.org/6683028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77947 0039d316-1c4b-4281-b951-d872f2087c98

1edee691

Reland - Support msysgit in gcl and git-cl · d161d848

mhm@chromium.org authored Mar 12, 2011

An explicit msysgit check is needed since it requires
the usage of 'env' to open the editor.

BUG=70550, 70548
TEST=Win,Linux 
Review URL: http://codereview.chromium.org/6680019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77946 0039d316-1c4b-4281-b951-d872f2087c98

d161d848

Revert 77909 - msysgit - Fix issue where gcl doesn't recognize the editor. · 7b8d18f0

jam@chromium.org authored Mar 12, 2011

gcl is now fully compatible with msysgit.

BUG=70550
TEST=gcl change through msysgit.

Review URL: http://codereview.chromium.org/6689001

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6679026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77929 0039d316-1c4b-4281-b951-d872f2087c98

7b8d18f0

Revert 77913 - Regression: Editor Linux Fix for gcl. · 93efa031

jam@chromium.org authored Mar 12, 2011

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6684022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77928 0039d316-1c4b-4281-b951-d872f2087c98

93efa031

fix prompting if there were errors in the hooks. Still need to write unit tests. · 37248c0b
dpranke@chromium.org authored Mar 12, 2011
```
TBR=maruel@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77922 0039d316-1c4b-4281-b951-d872f2087c98
```
37248c0b

Regression: Editor Linux Fix for gcl. · 38436920

mhm@chromium.org authored Mar 12, 2011

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77913 0039d316-1c4b-4281-b951-d872f2087c98

38436920

msysgit - Fix issue where git cl doesn't recognize editor. · 3d4d7edc

mhm@chromium.org authored Mar 12, 2011

The unix editor doesn't popup resulting in a unsuccessful upload. This change successfully fixes it.

BUG=70550
TEST=git cl upload works as expected under msysgit.
Review URL: http://codereview.chromium.org/6679019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77910 0039d316-1c4b-4281-b951-d872f2087c98

3d4d7edc

msysgit - Fix issue where gcl doesn't recognize the editor. · 0f9ee77b

mhm@chromium.org authored Mar 12, 2011

gcl is now fully compatible with msysgit.

BUG=70550
TEST=gcl change through msysgit.

Review URL: http://codereview.chromium.org/6689001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77909 0039d316-1c4b-4281-b951-d872f2087c98

0f9ee77b

restore accidentally deleted test file · 5dae94ac

dpranke@chromium.org authored Mar 12, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77900 0039d316-1c4b-4281-b951-d872f2087c98

5dae94ac

Make git-cl work with OWNERS file hooks properly. · 970c522f

dpranke@chromium.org authored Mar 12, 2011

This version calls into presubmit_support directly to support the OWNERS hooks. We do not need both this patch and http://codereview.chromium.org/6646009/

This patch depends on http://codereview.chromium.org/6665018/ .

Review URL: http://codereview.chromium.org/6674014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77898 0039d316-1c4b-4281-b951-d872f2087c98

970c522f

11 Mar, 2011 4 commits

Actually check Rietveld for LGTMs ... · 627ea67f

dpranke@chromium.org authored Mar 11, 2011

This change requires us to change the previous signature for the CheckOwners() hook to provide the server address and email regexp to use for parsing approvals from Rietveld.

Review URL: http://codereview.chromium.org/6657028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77891 0039d316-1c4b-4281-b951-d872f2087c98

627ea67f

Remove support for generic "hook files" in git-cl, and just call into · 23beb9e0

dpranke@chromium.org authored Mar 11, 2011

the git_cl_hooks library in depot_tools. Also remove support for
post-commit hooks. This binds git-cl tighter to depot_tools, but also
makes things a lot simpler and cleaner.

Review URL: http://codereview.chromium.org/6665018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77889 0039d316-1c4b-4281-b951-d872f2087c98

23beb9e0

Make git-cl tests work on Mac SnowLeopard · a185145f

dpranke@chromium.org authored Mar 11, 2011

This required making the location on 'true' consistently
path-independent and working around a weird subversion
issue.

Review URL: http://codereview.chromium.org/6646041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77883 0039d316-1c4b-4281-b951-d872f2087c98

a185145f

suppress some unimportant lint warnings · d945f368

dpranke@chromium.org authored Mar 11, 2011

Review URL: http://codereview.chromium.org/6658013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77882 0039d316-1c4b-4281-b951-d872f2087c98

d945f368

10 Mar, 2011 1 commit

suppress messages for PresubmitAddText results · ff5a87ad

dpranke@chromium.org authored Mar 10, 2011

Review URL: http://codereview.chromium.org/6646040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77700 0039d316-1c4b-4281-b951-d872f2087c98

ff5a87ad

09 Mar, 2011 9 commits

add PresubmitAddText() result class to indicate that text needs to be passed back to git cl / gcl. · 3ae183fb

dpranke@chromium.org authored Mar 09, 2011

Also, this properly wires up the presubmit code to the owners code and adds unit tests.

Review URL: http://codereview.chromium.org/6623074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77523 0039d316-1c4b-4281-b951-d872f2087c98

3ae183fb

Add more tests for owners.py, remove unneeded code, make syntax errors more helpful · 86bbf19c

dpranke@chromium.org authored Mar 09, 2011

Review URL: http://codereview.chromium.org/6639010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77522 0039d316-1c4b-4281-b951-d872f2087c98

86bbf19c

use PEP-8 naming for method names in owners.py, tests/owners_unittest.py · 7eea2596

dpranke@chromium.org authored Mar 09, 2011

Review URL: http://codereview.chromium.org/6646007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77521 0039d316-1c4b-4281-b951-d872f2087c98

7eea2596

add owners_unittest to PRESUBMIT.py · 5fe603e8

dpranke@chromium.org authored Mar 09, 2011

Review URL: http://codereview.chromium.org/6651009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77518 0039d316-1c4b-4281-b951-d872f2087c98

5fe603e8

Revert "Don't ignore first argument in TryChange." · b88c38bc

bauerb@chromium.org authored Mar 09, 2011

This reverts commit 39d5bf3d.

TBR=maruel

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77475 0039d316-1c4b-4281-b951-d872f2087c98

b88c38bc

Don't ignore first argument in TryChange. · 39d5bf3d

bauerb@chromium.org authored Mar 09, 2011

BUG=none
TEST=`git try foo` gives a proper error message.

Review URL: http://codereview.chromium.org/6650025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77470 0039d316-1c4b-4281-b951-d872f2087c98

39d5bf3d

Shorten RemoveDirectory and rename to rmtree. Remove rmtree from fake_repos. · f9040728

maruel@chromium.org authored Mar 09, 2011

Keep an alias to RemoveDirectory, will be removed in a later change.

TEST=new unit test to test this function
BUG=none

Review URL: http://codereview.chromium.org/6628032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77463 0039d316-1c4b-4281-b951-d872f2087c98

f9040728

Add code to correctly revert a svn add'ed file. · 924158a7

maruel@chromium.org authored Mar 09, 2011

Improve test to make sure svn status comes out clean.

TEST=improved unit tests and scm.SVN.Revert() should now do the right thing
BUG=none

Review URL: http://codereview.chromium.org/6650011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77391 0039d316-1c4b-4281-b951-d872f2087c98

924158a7

add set noparent just for clarity · ee2fa069

dpranke@chromium.org authored Mar 09, 2011

Review URL: http://codereview.chromium.org/6648015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77385 0039d316-1c4b-4281-b951-d872f2087c98

ee2fa069

08 Mar, 2011 7 commits

fix typo in nicholas's addr · 6477d684

dpranke@chromium.org authored Mar 08, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77371 0039d316-1c4b-4281-b951-d872f2087c98

6477d684

add OWNERS file - split out from #6626065 · 884d11b5

dpranke@chromium.org authored Mar 08, 2011

Review URL: http://codereview.chromium.org/6649007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77368 0039d316-1c4b-4281-b951-d872f2087c98

884d11b5

fix typos in CheckOwners() · add5df4c

dpranke@chromium.org authored Mar 08, 2011

Review URL: http://codereview.chromium.org/6628072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77361 0039d316-1c4b-4281-b951-d872f2087c98

add5df4c

make tests work, implement 'set noparent', owners propagating down · 6dada4ee

dpranke@chromium.org authored Mar 08, 2011

Review URL: http://codereview.chromium.org/6627059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77351 0039d316-1c4b-4281-b951-d872f2087c98

6dada4ee

When listing things for pruning, include anything that has an override dependency of None. · 9ea49d29

thomasvl@chromium.org authored Mar 08, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6621043

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77284 0039d316-1c4b-4281-b951-d872f2087c98

9ea49d29

Add trial_dir to manage automatic trial directory creation and deletion. · 7dfb9b74

maruel@chromium.org authored Mar 08, 2011

The tests now base the directory in mkdtemp() which is much safer than using the
source's file directory as before.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6625018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77278 0039d316-1c4b-4281-b951-d872f2087c98

7dfb9b74

Use reset --soft to squash before dcomitting. · b4a75c4c

bauerb@chromium.org authored Mar 08, 2011

Using reset --soft doesn't require touching the working copy, so it should be faster and not require rebuilds.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6575031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77267 0039d316-1c4b-4281-b951-d872f2087c98

b4a75c4c