Commits · 680a6c37a0fbb29292576f142431f162cb3d814e · Linshizhi / Chromium_Depot_tools

04 Feb, 2021 1 commit

Improve upload_to_google_storage.py missing file handling · 680a6c37

John Chen authored Feb 04, 2021

When there are missing input files, upload_to_google_storage.py
should not display 'Success'.

Bug: 920654
Change-Id: I1bc7ba6e8eb48ea28b634da01e1be9a80af7b719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2647870Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>

680a6c37

03 Feb, 2021 7 commits

Roll recipe dependencies (trivial). · 6dc9cc30

recipe-roller authored Feb 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/bf4208e6ef9b0439c5e43964f96c24ee123e5596
  bf4208e (iannucci@chromium.org)
      [engine] Set status_details.timeout.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I15d79254bae1958926917eb8958f269ef0605de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2674070Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6dc9cc30

win toolchain packager: Put win sdk in "Windows Kits/10/" instead of "win_sdk/" · 3fe941c4

Nico Weber authored Feb 03, 2021

This is so that the packaged toolchain can be used with clang-cl's
new /winsysroot flag added in https://reviews.llvm.org/rG82847436e.
No impact yet on the chrome build yet -- the tooling should
transparently get the new Windows Sdk path via the generated SetEnv
json file and use it with -imsvc. (I tested this locally by tweaking
my installed hermetic win package to look like the one generated
by this CL.)

Once this is deployed, we can switch the chrome build to use
/winsysroot if we want to -- it'd make compile command lines
a bit shorter and easier to work with.

Depends on https://chromium-review.googlesource.com/c/chromium/src/+/2665866

Bug: 1173176
Change-Id: I04c435f2323f26e3c26ed82656929809a7e0b5e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2655836Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>

3fe941c4

split-cl: Use owners client to suggest owners. · a4612847

Edward Lesmes authored Feb 03, 2021

Change-Id: I7aab38306e0699de465d0d2ab83dd37c4a099eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669149
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

a4612847

win toolchain: The SDK path should be checked per toolchain dir · 474cd162

Nico Weber authored Feb 03, 2021

This is a follow-up to crev.com/c/2668127. That patch incorrectly
checked the windows sdk path style for the target toolchain, but
there might be other, older toolchains with the other path style.
We need to check this per toolchain directory.

Also make sure ignored_dirs is compared case-insensitively.

Bug: 1173176
Change-Id: I005eb1b3200b11597978936a970f50f101708bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669048Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>

474cd162

owners-client: Add support for excluding owners. · 0e2aee7e

Edward Lesmes authored Feb 03, 2021

It is useful to exclude the change author when suggesting owners.

Change-Id: I3321c013271f6cea1098abba59b509800818917e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669680
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

0e2aee7e

Roll recipe dependencies (trivial). · 4783d047

recipe-roller authored Feb 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4a45a4a88f60d085cf998a3f4b0d2b34cab7ecdd
4a45a4a (bryner@google.com)
Additional fixes to run extract.py under python 3.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I70b9db14ee875a1108b77fba28f46140c5945f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2670097Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4783d047

Roll recipe dependencies (trivial). · 4e6de222

recipe-roller authored Feb 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b0e8da7877e38dd0d00da76457e776c871689a53
b0e8da7 (bryner@google.com)
Revert "Run extract.py with python3 to handle .tar.xz files."

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib3913f86fd1cb6f9a59f84dfef496f3e61b7a693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669928Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4e6de222

02 Feb, 2021 9 commits

Support main branch as default branch in roll-dep · 69902d09

Josip Sokcevic authored Feb 02, 2021

R=ehmaldonado@google.com

Bug: 1172028
Change-Id: Ica77db151eeb48c65f62043cbe30828dfa17bf95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659510Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

69902d09

Roll recipe dependencies (trivial). · 3d3f7cfa

recipe-roller authored Feb 02, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5de3e62cc86908be22f26c41c8b5bf99003bc82b
5de3e62 (gbeaty@chromium.org)
Set the output gitiles commit in buildbucket.build.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I264b5089af675a8049a31bc2af8dad0cf79037d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669277Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3d3f7cfa

gclient: Split gclient smoke tests. · 15801268

Edward Lesmes authored Feb 02, 2021

Hopefully this will decrease the time it takes to run
presubmit tests and avoid them timing out.

Change-Id: If12abf2f7c64d6f05bb7b492ad53dee1fa6dbbb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666670Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

15801268

split-cl: Walk the tree instead of using owners db. · b1174d73

Edward Lesmes authored Feb 02, 2021

Change-Id: I9dc9cda5a30833938fe13476deb76f4ed5770eab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666668
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

b1174d73

Roll recipe dependencies (trivial). · 13e0b55d

recipe-roller authored Feb 02, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c2aff19048e1fdbf4a421ce9da1007c05f84a665
c2aff19 (gbeaty@chromium.org)
Preserve the commit list state in case a candidate is rejected.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I26b2a4601f304199cd53b902b71bc18a357207c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2668980Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

13e0b55d

Reland "win toolchain: Prepare downloader for windows sdk dir switch" · 499a2fd6

Nico Weber authored Feb 02, 2021

This is a reland of e72789f5

Original change's description:
> win toolchain: Prepare downloader for windows sdk dir switch
>
> crrev.com/c/2655836 tries to move the Windows SDK from
> "win_sdk" to "Windows Kits/10".
>
> get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
> third_party/depot_tools/win_toolchain/data.json which then gets copied
> by a script in the chromium repo to build/win_toolchain.json.
> For the SDK move to work, chromium's pinned depot_tools
> must write the new SDK path when rolling in the new toolchain package.
> This change makes depot_tools handle win packages that have the
> windows sdk either win "win_sdk" or in "Windows Kits\10".
>
> The plan is:
>
> 1. Land this change, which can handle both path styles
> 2. Wait for depot_tools in chromium to update
> 3. Then roll to a win toolchain package with the new layout
>
> In a few years, when we no longer need the old layout,
> we can remove this detection code again and assume the new layout.
>
> Bug: 1173176
> Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

Bug: 1173176,1173393
Change-Id: Ic706f694f8f0260208fa637864e62d7cc4f7ce93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2668127
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

499a2fd6

Roll out new goma client binary VERSION=213 · 8bb35133

Takuto Ikuta authored Feb 02, 2021

Bug: b/178747003
Change-Id: I2dff72f688ea67228dc691e94cc17e419cfc8f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666652Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

8bb35133

Revert "win toolchain: Prepare downloader for windows sdk dir switch" · 98cc028b

Takuto Ikuta authored Feb 02, 2021

This reverts commit e72789f5.

Reason for revert: 
This broke goma builder.

Original change's description:
> win toolchain: Prepare downloader for windows sdk dir switch
>
> crrev.com/c/2655836 tries to move the Windows SDK from
> "win_sdk" to "Windows Kits/10".
>
> get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
> third_party/depot_tools/win_toolchain/data.json which then gets copied
> by a script in the chromium repo to build/win_toolchain.json.
> For the SDK move to work, chromium's pinned depot_tools
> must write the new SDK path when rolling in the new toolchain package.
> This change makes depot_tools handle win packages that have the
> windows sdk either win "win_sdk" or in "Windows Kits\10".
>
> The plan is:
>
> 1. Land this change, which can handle both path styles
> 2. Wait for depot_tools in chromium to update
> 3. Then roll to a win toolchain package with the new layout
>
> In a few years, when we no longer need the old layout,
> we can remove this detection code again and assume the new layout.
>
> Bug: 1173176
> Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

TBR=thakis@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I8d133f4fa199f81978f5245bdb2155c62bc9cc88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1173176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666651Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

98cc028b

win toolchain: Prepare downloader for windows sdk dir switch · e72789f5

Nico Weber authored Feb 02, 2021

crrev.com/c/2655836 tries to move the Windows SDK from
"win_sdk" to "Windows Kits/10".

get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
third_party/depot_tools/win_toolchain/data.json which then gets copied
by a script in the chromium repo to build/win_toolchain.json.
For the SDK move to work, chromium's pinned depot_tools
must write the new SDK path when rolling in the new toolchain package.
This change makes depot_tools handle win packages that have the
windows sdk either win "win_sdk" or in "Windows Kits\10".

The plan is:

1. Land this change, which can handle both path styles
2. Wait for depot_tools in chromium to update
3. Then roll to a win toolchain package with the new layout

In a few years, when we no longer need the old layout,
we can remove this detection code again and assume the new layout.

Bug: 1173176
Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

e72789f5

01 Feb, 2021 4 commits

Remove non-inclusive parameters from presubmit · 8c955950

Josip Sokcevic authored Feb 01, 2021

R=ehmaldonado@google.com

Bug: 1118435, 1118436
Change-Id: Ie66b2cb39a3d8abc83679bee44d2e594eba77442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657981Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

8c955950

Update ListOwners for GerritClient in owners_client · 0f790421

Gavin Mak authored Feb 01, 2021

The REST endpoint used by GerritClient.ListOwners needs to be updated as
of https://gerrit-review.googlesource.com/c/plugins/code-owners/+/293806

Change-Id: I5c142f16443b157c9d8edfa5bcf418cbedd2b193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2658609Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>

0f790421

Roll recipe dependencies (trivial). · 037b0821

recipe-roller authored Feb 01, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2ae42d0673ebd17009f1c13cd4377f43233e21d7
2ae42d0 (bryner@google.com)
Run extract.py with python3 to handle .tar.xz files.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia444e768024f2b99a33967787154a560ed231a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2664735Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

037b0821

git_drover: Replace with instructions on how to cherry-pick. · 1ea23338

Edward Lesmes authored Feb 01, 2021

Change-Id: I4cf7591df2b89bceb5618abb8fad92fd29e066bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2653952
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

1ea23338

30 Jan, 2021 1 commit

win toolchain: Remove some old MSVS 2013 references. · cb07c525

Nico Weber authored Jan 30, 2021

We used to use this many years ago.

Bug: none
Change-Id: I1df268c793bbfe7423ecf86ea99ebbe918e280d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2658676
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

cb07c525

29 Jan, 2021 7 commits

[recipe_modules/depot_tools] Add dirmd_path to api · 25b2cb49

Henrique Nakashima authored Jan 29, 2021

This is required to parse DIR_METADATA files.

Bug: 1135347
Change-Id: I620656d4dbec5e918bfc0f535397869c869446b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644827
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

25b2cb49

[depot_tools] roll rdb to 0c7d9eb · 801121c2

Chan Li authored Jan 29, 2021

To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2648266

Bug: 1030191
Change-Id: I6328efa2cc5acf42d0ec386f70f955fa77237260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659507Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

801121c2

Roll recipe dependencies (trivial). · 1f97007e

recipe-roller authored Jan 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/bf5ee5277758080f98b23bef244704aacffe831f
  bf5ee52 (chanli@chromium.org)
      [ResultDB] recipe_module: remove chromium_derive

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I140894030f83ffcd413deb9c4e611cae83ecf115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2660020Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1f97007e

Roll recipe dependencies (trivial). · 33287176

recipe-roller authored Jan 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d3edd66d0a3aafa4147b2802c2f40aaa589e6522
d3edd66 (bryner@google.com)
Basic python3 compatibility changes for extract.py.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibcab4b76f0b7077c24696ce5de3f4107c8b51ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659495Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

33287176

Roll recipe dependencies (trivial). · 6325d606

recipe-roller authored Jan 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6fbe4305b3989f56b0a153c674f58f148df723d6
6fbe430 (iannucci@chromium.org)
Add integration tests for some gnarlier annotator/bbagent hacks.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I10afde1fd84c6de6258bb762f3e679aebac17fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659113Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6325d606

Roll recipe dependencies (trivial). · 6ff74e1d

recipe-roller authored Jan 29, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ebdb512224702196950b27151e31351c019f7b15
  ebdb512 (chanli@chromium.org)
      [ResultDB] api.resultdb.wrap: support location_tags_file

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idaef48ffd695ed873afab6c0148faa622f6149ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657990Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6ff74e1d

Revert "Change whitespace.txt" · 1ab6dbc0

Edward Lesmes authored Jan 29, 2021

This reverts commit 07bd2522.

Reason for revert: Still testing chromium-behavior

Original change's description:
> Change whitespace.txt
>
> Will use this change to test reverting in the Gerrit UI.
> Using TBR= so as to not spam anyone else.
>
> TBR=
>
> Change-Id: If95898b00d6468512157d120e24c8246c1655f8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2645231
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=

No-Try: true
No-Presubmit: true
Change-Id: Iaf547a6f5916490c85baeb8a32758c4b40abe4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657869
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

1ab6dbc0

28 Jan, 2021 4 commits

Roll out new goma client binary VERSION=212 · 558a3042

Yoshisato Yanagisawa authored Jan 28, 2021

Bug: b/178452801
Change-Id: Ief04267764a1e67219912af0a8a1c8a4aa46a6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654599Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

558a3042

Revert "Add previous_got_revision and previous_got_revision_cp to output" · 2c9dbb89

Josip Sokcevic authored Jan 28, 2021

This reverts commit 6d0c0ffe.

Reason for revert: this appears to  break builders if reference
is a commit hash:

git log --format=%B -n1 HEAD failed with code 128

Original change's description:
> Add previous_got_revision and previous_got_revision_cp to output
>
> As chrome browser infra works to improve CQ times, we would like to
> easily glance at builds and see how many new commits were checked out.
> Currently you have to open up bot_update stdout to see the previous
> HEAD revision and go from there. Having this conveniently outputted
> would be very convenient.
>
> If the bot has previously checked out the repo, output which revision
> and commit position were checked out.
>
> example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com
>
> Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3
> Bug: 1170568
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Stephanie Kim <kimstephanie@google.com>

TBR=infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com,kimstephanie@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1170568
Change-Id: I50d6ef6802c2eb1614cca804391c7826a79a2cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657023Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

2c9dbb89

Roll recipe dependencies (trivial). · 9bdbb8f9

recipe-roller authored Jan 28, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/51dda3f28966704ae269ac7b7a7d485784d1c472
  51dda3f (iannucci@chromium.org)
      [buildbucket] Properly handle set_output_gitiles_commit in luci...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb513b225e97465660fb6f41a5d834f9f2748fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657030Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9bdbb8f9

Roll recipe dependencies (trivial). · ea89b0d6

recipe-roller authored Jan 28, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/01f6be9de786fd07d1c0d213ac77f1c6150152fd
01f6be9 (tikuta@chromium.org)
cas: disallow overriding instance

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib31f328ae203bf7a269661d4f7742122c3a5a2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654717Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ea89b0d6

27 Jan, 2021 5 commits

Add documentation for --inject_current · 9a18e37f

Gavin Mak authored Jan 27, 2021

This change adds documentation and demos missing for the flag
--inject_current used in git new-branch.

Bug: 1167943
Change-Id: Id6305b876ade2c47eb7435a5edd055ae4fe2f323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2648615Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

9a18e37f

Roll recipe dependencies (trivial). · 882bf8a5

recipe-roller authored Jan 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a1296335483bf847f2f1329fcbde629c075e6889
  a129633 (vadimsh@chromium.org)
      [scheduler] Add properties and tags to GitilesTrigger.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib5758aff14710ada26f260c7b030f0eab6b31ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654254Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

882bf8a5

Roll recipe dependencies (trivial). · 92fb40c1

recipe-roller authored Jan 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4e80714e17ff99f6d750d54b69cf9cebd7a2f835
4e80714 (gbeaty@chromium.org)
Return None from CommitList.advance_to for backwards advances.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If35f2ee09a01b6dd859a6eacb8e9f37483594872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654083Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

92fb40c1

Roll recipe dependencies (trivial). · fade894c

recipe-roller authored Jan 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/1cf8c5966f860b5e3cc4d5ed8ec0622b0a660fd3
  1cf8c59 (vadimsh@chromium.org)
      [proto] Update go.chromium.org/luci protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5f27fc78df5b07b43b877ad11274f74b791d8fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651464Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fade894c

Roll recipe dependencies (trivial). · c03bb97e

recipe-roller authored Jan 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/da848b8552a021206e2acd957f9a4520292a7949
  da848b8 (lamontjones@chromium.org)
      [buildbucket] include ref in try_build_message

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7bb907c81a55ffcb43b51f1de77460e19e727e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651456Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c03bb97e

26 Jan, 2021 2 commits

Add previous_got_revision and previous_got_revision_cp to output · 6d0c0ffe

Stephanie Kim authored Jan 26, 2021

As chrome browser infra works to improve CQ times, we would like to
easily glance at builds and see how many new commits were checked out.
Currently you have to open up bot_update stdout to see the previous
HEAD revision and go from there. Having this conveniently outputted
would be very convenient.

If the bot has previously checked out the repo, output which revision
and commit position were checked out.

example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com

Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3
Bug: 1170568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>

6d0c0ffe

[bot_update] Resolve revision only if patching · 76d0e6ac

Josip Sokcevic authored Jan 26, 2021

If bot_update is not patching, it shouldn't look into gitiles patch
information.

R=ehmaldonado@google.com

Bug: 1147625
Recipe-Nontrivial-Roll: build
Change-Id: I111f0dc1c36d588341c02930bf1cda1f5b8cc2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644199Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

76d0e6ac