Commits · 680253d31518b5865a45be4d63bc1ed74a4f16e9 · Linshizhi / Chromium_Depot_tools

17 Mar, 2017 3 commits

git cl description: don't bother if description diff is trailing whitespace. · 680253d3

Andrii Shyshkalov authored Mar 15, 2017

BUG=700239
R=iannucci@chromium.org

Change-Id: Ica4567288c1cd83f72cce5d10c523270b69c36d4
Reviewed-on: https://chromium-review.googlesource.com/455739Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

680253d3

git cl comment: implement adding comment for Gerrit. · 625986db

Andrii Shyshkalov authored Mar 15, 2017

BUG=698236

Change-Id: Ia1a36af71c348be991d77083092c5043c2642c19
Reviewed-on: https://chromium-review.googlesource.com/455877Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

625986db

Pass env via context rather than api.step kwargs · aa534e50

Paweł Hajdan, Jr authored Mar 17, 2017

See https://groups.google.com/a/chromium.org/d/msg/infra-dev/p8Iq9v9Y4k0/w__b1zTWAQAJ
for more context.

BUG=685746

Change-Id: If0bdcbd354b2535de22a7be78dad86e15c9f2cea
Reviewed-on: https://chromium-review.googlesource.com/456217
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

aa534e50

16 Mar, 2017 6 commits

Roll recipe dependencies (trivial). · 12fb9ede

recipe-roller authored Mar 16, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d5a670b19aba7fb9a7f6430d39dab1d3414b578a Make a copy of env in the recipe context (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ieab8f3536096944dac96b1f0424fa8d75b014403
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456378
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

12fb9ede

git cl creds-check: add reporting. · 0a0b067e

Andrii Shyshkalov authored Mar 16, 2017

BUG=689543

Change-Id: I2c5dd9e1ef4a23ba805c8c057ad44c87cfb65a5b
Reviewed-on: https://chromium-review.googlesource.com/455782
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

0a0b067e

git cl creds-check: add methods analysing .gitcookies. · 9780050b

Andrii Shyshkalov authored Mar 16, 2017

These methods are used to produce report in the next CL.

BUG=689543

Change-Id: I71b2705ac8b046103b4982d47f7ec97f8ef7818b
Reviewed-on: https://chromium-review.googlesource.com/455838
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

9780050b

Support JSON output in my_activity.py · e5deedfc

Nicolas Dossou-gbete authored Mar 15, 2017

That JSON output format shows some additional fields such as bug number
for CLs, label and component for issues.

Also does minor changes like replacing the old code.google.com
references and using short urls when possible.

BUG=None

Change-Id: I988d292dc57b72a2f2c6f12096266df8a09a4dd8
Reviewed-on: https://chromium-review.googlesource.com/422203Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>

e5deedfc

Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b · 370ca1bd

Robert Iannucci authored Mar 16, 2017

This will enable it to be compatible with both the textpb and
upcoming jsonpb form of recipes.cfg.

BUG=699379

Change-Id: Iafa3d959190648eca4fa864aaa79430759e568fe
Reviewed-on: https://chromium-review.googlesource.com/455585Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

370ca1bd

Roll recipe dependencies (trivial). · 63b042dc

recipe-roller authored Mar 16, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f605e5c0bc2e748170ca851383cb552c7225316b [doc/recipes.py] allow both json and text proto forms of recipes.cfg. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I3ab97f1a88e615562040ff3e4dce1d9aef60ac78
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456020
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

63b042dc

15 Mar, 2017 10 commits

git_cache.py: Don't bootstrap from Google storage for unrecognized repos. · 3beabd0a

Ryan Tseng authored Mar 15, 2017

Also - Turn on GC for the unrecognized repos.

BUG=skia:6241
TEST=local
  git_cache.py populate with chromium and non-chromium repo.

Change-Id: I100d3665e317b29c5b3f69b49c165ce88cd019d6
Reviewed-on: https://chromium-review.googlesource.com/455979
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

3beabd0a

git-cl patch: set metadata before (failing to) apply patch · d343c635

Aaron Gable authored Mar 15, 2017

If the commit or cherry-pick command fails, git automatically drops
the user into a state where they can try to manually fix it. That's
great. But with the old call order, it would also leave the metadata
unset. This sets the issue and patchset number before doing the
potentially-failing heavy lifting, so that the branch will be in a
consistent state after the user finishes fixing up the failed command.

BUG=701130

Change-Id: I792b9fb9e61ba62626c19aa1837d21f8cd8f594e
Reviewed-on: https://chromium-review.googlesource.com/456039Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

d343c635

Roll recipe dependencies (trivial). · 837cb3ae

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dc075187dabcbce22eb8449410ddaf25740614b9 step: return copy of objects from context (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ifb4db7a6bd2cf1d047480348645e92614adce58d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455440
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

837cb3ae

Roll recipe dependencies (trivial). · 33ed18bc

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c34687df04be337cbf2fdce8e3438e647584f9a0 [doc] add entries for known items. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I4c636e868a606b93b680adb6d68ac099e8312638
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455997
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

33ed18bc

Roll recipe dependencies (trivial). · 31f0605a

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8f704e2ae965ba1aea901c6ee15bf28319fecd83 [doc] Rewrite doc command to produce structured proto directly from python ast. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Idefcac96d647ce0a0cb6465c4be58da0d6b6310c
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455383
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

31f0605a

Workaround Python Issue 26083 in upload.py · edfd7cd8

Aaron Gable authored Mar 15, 2017

This issue is fixed in Python 2.7.12, but we don't guarantee
that we use that version everywhere. The root issue is that,
on certain platforms (e.g. Mac), the exception indicating that
the underlying command (e.g. 'hg') was not found is too large,
and loading the pickle representing the exception fails.

This CL catches this specific exception and treats it identically
to the OS properly raising a 'command not found' code.

BUG=699173

Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f
Reviewed-on: https://chromium-review.googlesource.com/455537Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

edfd7cd8

git cl creds-check: add pretty printing of existing creds. · 34924cd4

Andrii Shyshkalov authored Mar 15, 2017

BUG=689543

Change-Id: I085f3e086059ecf3b57a8e0cd0d716adc54f8644
Reviewed-on: https://chromium-review.googlesource.com/454816
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

34924cd4

git-cl: Make 'failed to add as cc' message less scary · b7cb65a5

Aaron Gable authored Mar 14, 2017

BUG=665263

Change-Id: If72f3e5369ea0df170916c353be5188167c7aecb
Reviewed-on: https://chromium-review.googlesource.com/454977Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

b7cb65a5

git cl creds-check: refactor gitcookies methods into a class. · 517948b6

Andrii Shyshkalov authored Mar 15, 2017

There will be many other methods that will need to share state.

BUG=689543
R=machenbach@chromium.org

Change-Id: I4ce6fe173ff7c92e57737417c65125156606a664
Reviewed-on: https://chromium-review.googlesource.com/455780
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

517948b6

Add `git cl creds-check` to clean Git/Gerrit creds interactively. · 353637c5

Andrii Shyshkalov authored Mar 14, 2017

BUG=689543

Change-Id: I0ba24c46f36c505fae03aaeab3b277e80bca8f8b
Reviewed-on: https://chromium-review.googlesource.com/454696Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

353637c5

14 Mar, 2017 7 commits

Manually roll recipes. · 8e89fa3d

Robert Iannucci authored Mar 14, 2017

recipe_engine:
https://crrev.com/222e52d54fd4816863099034b25b6f74e0e1a06a [package.proto] upgrade to proto3. (iannucci@chromium.org)
https://crrev.com/70340d7caa58896cbcffcccbc5573dd3b488fc5d [doc/recipes.py] proto3 omits empty fields. (iannucci@chromium.org)
https://crrev.com/286c6f5ec8db26ee88eae1bd30855a9f3d0cf426 [doc/recipes.py] protobuf is a dict of lists. (iannucci@chromium.org)
https://crrev.com/78c57c5d69a38ef3db86d9763d539383f98714e6 [doc/recipes.py] Make recipes.py 80-cols. (iannucci@chromium.org)

BUG=

Change-Id: I4c5c9e94e9c64d14ccf0048f1aa392148b5f01c8
Reviewed-on: https://chromium-review.googlesource.com/454888
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

8e89fa3d

Bump cipd client version. · d3f950b9

Vadim Shtayura authored Mar 13, 2017

New version skips unnecessary hash check for files that are already
in the cache.

R=iannucci@chromium.org
BUG=

Change-Id: Icdbd1d171fa77cf7e353c84e82ded8eafd88c88d
Reviewed-on: https://chromium-review.googlesource.com/454241Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

d3f950b9

Roll recipe dependencies (nontrivial). · 6aac92db

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9fdd6d725d8d04125d43ce2be4f5e4b123f705be [json] improve output to get leak_to and better logging. (iannucci@chromium.org)

R=iannucci@chromium.org

Change-Id: Icf48ce2f5211e98b48d794a172be107562cf3b25
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455056
Commit-Queue: <recipe-roller@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6aac92db

git cl: refactor common user interactions. · abc26ac0

Andrii Shyshkalov authored Mar 14, 2017

R=machenbach@chromium.org
BUG=

Change-Id: Id3e3fe6223a875d997ac5569137db270818a08f4
Reviewed-on: https://chromium-review.googlesource.com/453439
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

abc26ac0

Roll recipe dependencies (nontrivial). · ce4ebd07

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org

Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/454341
Commit-Queue: <recipe-roller@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

ce4ebd07

Roll recipe dependencies (trivial). · ef3e07d9

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2606a110184a3effca282bc1dbed36ee790872bb [doc] add methods to emit proto from Config objects (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ia661948b7a41100beecbf6965c2df5393197c5e3
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/454339
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

ef3e07d9

[recipe_modules/cipd] Refactor creation methods. · 85b6d185

Robert Iannucci authored Mar 14, 2017

This clarifies what the 'create' method actually expects,
and adds a nicer approach for recipes that want to synthesize
their own package definition files.

BUG=

Change-Id: Iee5d5c02260bf71d4775ddfc1d4d1ae43937b693
Reviewed-on: https://chromium-review.googlesource.com/440385
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

85b6d185

13 Mar, 2017 3 commits

Add a manual page for git-cl · 96dc085d

Aaron Gable authored Feb 27, 2017

The most important git subcommand in depot_tools never had a man
page until today. And now "git help cl" and "git cl --help" will
work.

BUG=695623

Change-Id: Ic0d05fa8d70d2ef6e71d58e0d7d3e7adc4a2fa32
Reviewed-on: https://chromium-review.googlesource.com/447216Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

96dc085d

Cleanup VS 2013/2015 confusion in toolchain script · b99bc3e1

Bruce Dawson authored Mar 11, 2017

The get-toolchain script still contained leftover goop for installing
the UCRT, even though that misguided plan was abandoned last year. This
change deletes that.

The get-toolchain script also confusingly used the vs2013_files
directory for anything that wasn't VS 2015. It doesn't technically make
any difference now that we use hashes for the toolchain directories, but
it was confusing when experimenting with VS 2017.

R=sebmarchand@chromium.org
BUG=683729

Change-Id: Ie0d3eccffe4796d4c5e23a28276acdd757e290d4
Reviewed-on: https://chromium-review.googlesource.com/453122Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

b99bc3e1

gerrit_util and my_activity: fix fetching >400 changes from Gerrit. · 892e9c26

Andrii Shyshkalov authored Mar 08, 2017

BUG=698625

Change-Id: I892f09e8b7ff752b6a45c556a594f486000530e8
Reviewed-on: https://chromium-review.googlesource.com/451383Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

892e9c26

10 Mar, 2017 2 commits

Roll recipe dependencies (trivial). · 6c895882

recipe-roller authored Mar 10, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/fcd30616c93ac4532e5cfa4324ba5cd18c8b9a76 Add new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: If072f597a1c2d7272d296f5748652a6c952aa465
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/452998
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

6c895882

Gerrit git cl upload: add test for early abort. · 5c3d0b37

Andrii Shyshkalov authored Feb 16, 2017

BUG=689652
R=agable@google.com

Change-Id: Ia0ca4dbacb0131658bbb41fc741f45b5e7f2cba9
Reviewed-on: https://chromium-review.googlesource.com/443545
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

5c3d0b37

09 Mar, 2017 3 commits

Roll recipe dependencies (trivial). · 24d470ce

recipe-roller authored Mar 09, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5f5c9b29d1f6706827f51fb6f7b7d30cdb135d2c [doc] add doc.proto (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I5ce36b8e9c0f57532649add9bc580df36d842b68
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/452040
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

24d470ce

Roll recipe dependencies (trivial). · a822dee7

recipe-roller authored Mar 09, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4e4e32822f4b0aab38308d0d5c7b6561268702ed [protos] Regenerate protos and add documentation. (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I6606c679ed6bebeba47881e398727bd8618a43db
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/452159
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

a822dee7

git-cl: Make BUG_LINE_FORMAT configurable in codereview.settings · 57c4721d

Mark Mentovai authored Mar 09, 2017

The default BUG_LINE_FORMAT is the existing BUG=%s. Projects that wish
to begin using Gerrit-style footers like Bug: %s can now set this in
codereview.settings.

BUG=616753

Change-Id: I4470311a86db228eab2a1655ae884736cce8c380
Reviewed-on: https://chromium-review.googlesource.com/451565
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

57c4721d

08 Mar, 2017 6 commits

[cipd] bump client prod version · 3e25201d

Robert Iannucci authored Mar 08, 2017

BUG=

Change-Id: Id376c1c803a358394f9db06ef625d23a0a6bba1c
Reviewed-on: https://chromium-review.googlesource.com/451738Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

3e25201d

Make git blame test pass independently of core.abbrev setting · f548d08a

Mark Mentovai authored Mar 08, 2017

7-digit hashes are bogus, so I run with core.abbrev = 12.

Non-default settings for core.abbrev caused the git blame test to fail,
because it was hard-coded to look for exactly 7 digits. This change
allows an --abbrev option to be passed to the git-blame wrapper, and
ensures that the same value is used for the git-blame operation and the
computed expectation.

TEST=tests/git_common_test.py GitReadOnlyFunctionsTest.testBlame

Change-Id: I83cbf4dd7267ea36607119bef52f303d59c3f840
Reviewed-on: https://chromium-review.googlesource.com/451124Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

f548d08a

git-cl: Recognize Bug: when reading change descriptions · 600d309d

Mark Mentovai authored Mar 08, 2017

When git-cl doesn’t see a BUG= line, it introduces a new one. The
eventual goal is to switch away from THIS=TYPE of metadata to the footer
field style that’s more natural to git and, most importantly, Gerrit.
With this change, git-cl will treat an existing Bug: line identically to
a BUG= line, and not introduce a new BUG= line if either are present.
This stops short of switching the default format to Bug:, but it allows
projects that wish to switch to the new format now to not be pestered by
git-cl introducing BUG= every time it edits a change description.

This is similar to the bug line parsing done by Bugdroid, which already
undersatnds the Bug: format. See
https://chromium.googlesource.com/infra/infra/+/ba095768d776/infra/services/bugdroid/log_parser.py.

BUG=616753

Change-Id: I23faa55c8275de44b71b031e603f2f55778d7f25
Reviewed-on: https://chromium-review.googlesource.com/451123
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

600d309d

git cl tests: refactor gerrit base calls for readability. · 0293956d

Andrii Shyshkalov authored Feb 16, 2017

R=agable@chromium.org
BUG=689652

Change-Id: I3074eeef2b939d64bcd2e537bbc7ee288241bd79
Reviewed-on: https://chromium-review.googlesource.com/443108
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

0293956d

Add various improvements to my_activity.py · ffb3c439

Tobias Sargeant authored Mar 08, 2017

* convert diagnostic prints to logging
* add -v and -q options to control logging verbosity
* add -d option to fetch patchset data
* add format values:
      (issues, changes,reviews)
  - {created}: the date an activity was created
  - {modified}: the date an activity was modified
  - {status}: a status indicator for the activity
      (changes,reviews)
  - {activity}: a count of the number of comment interactions
      (changes)
  - {delta}: for changes, the number of lines added and removed
* use a default formatter for outputting that skips, rather than
  chokes on, missing values.

Change-Id: Ib50c8c72b98b8ef5939d59ab93c5fc0a1a49599f
Reviewed-on: https://chromium-review.googlesource.com/451278
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

ffb3c439

Roll recipe deps. · 7062cb9b

Robert Iannucci authored Mar 08, 2017

Manual roll to pick up crrev.com/28c10d465e3161ec3b862b525c5351ffe9343399.

TBR=dnj@chromium.org
BUG=

Change-Id: Idfcfe80aa9ada7550b6389ac0aaa8d28682d46b7
Reviewed-on: https://chromium-review.googlesource.com/451602Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

7062cb9b