- 11 Feb, 2016 1 commit
-
-
tandrii@chromium.org authored
Reland of http://crrev.com/1689633002#ps20001 without breaking other repos by means of keeping breakpad.py importable, but otherwise a no-op. R=maruel@chromium.org BUG=585837 Review URL: https://codereview.chromium.org/1687923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298731 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Feb, 2016 2 commits
-
-
thakis@chromium.org authored
Revert of Finally get rid of depot_tools' breakpad. (patchset #2 id:20001 of https://codereview.chromium.org/1689633002/ ) Reason for revert: All chromium bots depend on this: ________ running '/usr/bin/python src/build/android/play_services/update.py download' in '/b/build/slave/linux/build' Traceback (most recent call last): File "src/build/android/play_services/update.py", line 29, in <module> import find_depot_tools # pylint: disable=import-error,unused-import File "/b/build/slave/linux/build/src/build/find_depot_tools.py", line 49, in <module> import breakpad ImportError: No module named breakpad https://www.google.com/url?hl=en&q=http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144739&source=gmail&ust=1455209366639000&usg=AFQjCNH42SEVcJg4J6dX0J9HF0Rcqv81eA Original issue's description: > Finally get rid of depot_tools' breakpad. > > R=maruel@chromium.org > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298710 TBR=maruel@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1683173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298712 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/1689633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298710 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Nov, 2012 1 commit
-
-
ilevy@chromium.org authored
Reduce calling SendProfile to long running commands. There's lots of low hanging fruit (slow commands) to optimize before we need perf stats from fast commands. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11416230 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170009 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jan, 2012 1 commit
-
-
maruel@chromium.org authored
This required fixing the adhoc mock to be more versatile. TBR=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9178019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117896 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jan, 2012 1 commit
-
-
maruel@chromium.org authored
I don't want to receive them even in the case of a direct call to SendStack(). R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117039 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
While re-reading the code, I thought I had found a bug but I hadn't. So I wrote the test to document the behavior to not make the same error again. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8121001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103772 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
When running an interactive python prompt, sys.modules['__main__'] has no __file__ member. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8051027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103055 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Otherwise it's hard to know what's generated from automated testing. R=chase@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6902153 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83673 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/6904055 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83507 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Mostly useful for commit-queue as I want to both send the trace and be able to read it locally. TBR=jam Review URL: http://codereview.chromium.org/5608001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Nov, 2010 2 commits
-
-
maruel@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/5131005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67314 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
When an HTTP exception information is logged, no information is sent by default. Add an helper function to manually extract interesting information to append it to the exception type. Also disable another pylint warning. TEST=manual test BUG=none Review URL: http://codereview.chromium.org/5303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 2 commits
-
-
maruel@chromium.org authored
This causes some code clutter. TEST=Increased pylint warning level BUG=none Review URL: http://codereview.chromium.org/4321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Most of them are style issues or variable aliasing. TEST=Can almost enable pylint warnings BUG=none Review URL: http://codereview.chromium.org/4360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Oct, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/4176004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64049 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
The user will get an idea of what data is sent. Getting the current working directory is useful to know what checkout was used. the repr(last_tb) call was stripping off a lot of useful information for debugging. TEST=none BUG=none Review URL: http://codereview.chromium.org/3384020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/3311023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58982 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 May, 2010 1 commit
-
-
maruel@chromium.org authored
Add an explicit Register() function to be called outside of this file. Send the host fqdn to help know from where the exception comes. It is useful when a build slave throws an exception. Review URL: http://codereview.chromium.org/2327003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48455 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 May, 2010 1 commit
-
-
maruel@chromium.org authored
Otherwise it would return the naked host name most of the time, especially on Windows. Review URL: http://codereview.chromium.org/2239010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48432 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 May, 2010 1 commit
-
-
maruel@chromium.org authored
Add exception information and not just the stack trace. Make the url easier to change at runtime. Review URL: http://codereview.chromium.org/2109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47179 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 May, 2010 1 commit
-
-
maruel@chromium.org authored
The code proved to be robust enough to not do false positive, i.e. no non-googler stack trace has been uploaded up to date. So stop wasting users time and just do it. BUG=none TEST=none Review URL: http://codereview.chromium.org/2014012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46992 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jan, 2010 1 commit
-
-
msb@chromium.org authored
Patch-contributed-by: Alexey Marinichev <amarinichev@chromium.org> Review URL: http://codereview.chromium.org/553139 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37434 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2009 3 commits
-
-
maruel@chromium.org authored
Add a warning message in case the check ever fail. Review URL: http://codereview.chromium.org/460044 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/462022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33686 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Client-side implementation. TODO: Need to automatically disable it for unit tests. Review URL: http://codereview.chromium.org/444009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98
-