Commits · 647e1e79eb7129ecdc021b7535d90e6d06475603 · Linshizhi / Chromium_Depot_tools

19 Sep, 2018 4 commits

Reland "gclient: delete unversioned directory before adding cipd dep for the same path" · 647e1e79

Edward Lemur authored Sep 19, 2018

This is a reland of 67ef3f67

We no longer call cipd unconditionally.

Original change's description:
> gclient: delete unversioned directory before adding cipd dep for the same path
>
> Bug: 882611
> Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050
> Reviewed-on: https://chromium-review.googlesource.com/1228655
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Bug: 882611
Change-Id: I683bfc62bd1eebfec0853583f96f3981c2c6bdf2
Reviewed-on: https://chromium-review.googlesource.com/1232891Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

647e1e79

[buildbucket] Fix printing build url · 69f640ec

Michael Achenbach authored Sep 19, 2018

TBR=smut@chromium.org,nodir@chromium.org

Bug: 711249
Change-Id: I031497eeeec02f16c182fbe2e46c6a02f0745df9
Reviewed-on: https://chromium-review.googlesource.com/1232896Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

69f640ec

Roll recipe dependencies (trivial). · 2fbd3c8e

recipe-roller authored Sep 19, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7a22cddcd7f3255e357a63c73df4396a43def8cd [context] Stringify name_prefix if unicode in api.context (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib38a903cbb92fae8dd5c554f1054b44ef93110d0
Reviewed-on: https://chromium-review.googlesource.com/1232589Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

2fbd3c8e

[windows_sdk] Allow taskkill mspdbsrv to fail. · 77900be4

Robert Iannucci authored Sep 19, 2018

It looks like PNaCl actually depends on MSVC's presance, but doesn't
actually run any compile steps with it (instead using clang). That means
that mspdbsrv never actually runs during their build, and then the
taskkill fails.

R=hinoka@chromium.org, tandrii@chromium.org

Bug: 861512
Change-Id: I004d28f198224adaf16b1d3f14401b0d2a7d700b
Reviewed-on: https://chromium-review.googlesource.com/1232885Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

77900be4

18 Sep, 2018 18 commits

[gclient] Remove is_blink_mode · 79c65133

Nodir Turakulov authored Sep 18, 2018

Not used

R=tandrii@chromium.org

Bug: 694348
Change-Id: I3188881b1f92df1cbfdbf3aafe309abb9488d9b2
Reviewed-on: https://chromium-review.googlesource.com/1232874
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

79c65133

Remove PATCH_PROJECT · 15b586a4

Nodir Turakulov authored Sep 18, 2018

Remove PATCH_PROJECT from gclient config. It is not used.

R=tandrii@chromium.org

Bug: 694348
Change-Id: I56e4aefbe5e9b23296553bb61f878d6426197fa7
Reviewed-on: https://chromium-review.googlesource.com/1232873
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

15b586a4

[gclient] Remove calculate_patch_root · 53e28ecb

Nodir Turakulov authored Sep 18, 2018

It is not used. get_gerrit_patch_root is used instead.

Bug: 694348
Change-Id: Icc717e38cbcaa8050c8ce8a364202b81d7f9cf2c
Reviewed-on: https://chromium-review.googlesource.com/1231282
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

53e28ecb

Revert "gclient: delete unversioned directory before adding cipd dep for the same path" · 07b5283a

Andrii Shyshkalov authored Sep 18, 2018

This reverts commit 67ef3f67.

Reason for revert: might have broken GCE/ccompute fleet.

Original change's description:
> gclient: delete unversioned directory before adding cipd dep for the same path
> 
> Bug: 882611
> Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050
> Reviewed-on: https://chromium-review.googlesource.com/1228655
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Ia2172b1b0d236357edf93dacf57f3bf7d80d5968
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882611
Reviewed-on: https://chromium-review.googlesource.com/1231699Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

07b5283a

[bot_update] Use get_gerrit_patch_root · 78eed01c

Nodir Turakulov authored Sep 18, 2018

Use get_gerrit_patch_root in bot_update.ensure_checkout.

This fixes some tests expectations that expected CI builds to pass --patch_root
flag.

Also unify "root" and "patch_root" variables in ensure_checkout. Simpler.

This CL requires nontrivial rolls in all downstream packages because all
packages have incorrect expectations and/or tests.
In particular, this removes --patch_root flag from non-tryjob test
cases. Some tests are supposed to test tryjob scenario, but they use
properties.generic instead of properties.tryserver (or buildbucket.try_build)

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: skiabuildbot
Bug: 694348
Change-Id: Ibc594fa42e3b4d2823672b41dda2d97154b10d38
Reviewed-on: https://chromium-review.googlesource.com/1231280
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

78eed01c

gerrit_util: document hack. · 86c823e8

Andrii Shyshkalov authored Sep 18, 2018

R=ajp@chromium.org

Bug: 881860
Change-Id: I2608132730cf907ea5bb86476490eafc37e24275
Reviewed-on: https://chromium-review.googlesource.com/1227438
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

86c823e8

[gclient] Update set_patch_project_revision · dd2ce986

Nodir Turakulov authored Sep 18, 2018

Update set_patch_project_revision to use repo_path_map instead of
patch_projects.
Also rename to set_patch_repo_revision.

Bug: 694348
Change-Id: Iba31f4910f8282160000b8fcef197052597530a4
Reviewed-on: https://chromium-review.googlesource.com/1226107
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

dd2ce986

gclient: delete unversioned directory before adding cipd dep for the same path · 67ef3f67

Edward Lemur authored Sep 18, 2018

Bug: 882611
Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050
Reviewed-on: https://chromium-review.googlesource.com/1228655
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

67ef3f67

[bot_update] Update examples to use buildbucket module · 33f71ae4

Nodir Turakulov authored Sep 18, 2018

Update bot_update full.py example to use buildbucket module.
Also remove buidlbucket example.

Bug: 694348
Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc
Reviewed-on: https://chromium-review.googlesource.com/1231281Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

33f71ae4

Add an option to disable adding CC emails automatically · 1aa405fd

Sergiy Byelozyorov authored Sep 18, 2018

R=ehmaldonado@chromium.org, machenbach@chromium.org

Bug: 878303
Change-Id: Ia90001025babe692e481eb74fdbb4a66ce9a22f8
Reviewed-on: https://chromium-review.googlesource.com/1230074
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

1aa405fd

[gclient] Fix typo in get_gerrit_patch_root · 7b54572e

Nodir Turakulov authored Sep 18, 2018

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1217670/17
used solution instead of solution name.

TBR=tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: I829cba9223d73383791b018f9a23598443e8fa2c
Reviewed-on: https://chromium-review.googlesource.com/1231278Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

7b54572e

[bot_update] Add gclient.get_gerrit_patch_root · 0f322bfc

Nodir Turakulov authored Sep 18, 2018

Add a shortcut for getting local path to the patch repo.

In bot_update.api._destination_branch, start using it instead of reading
gclient config directly. This removes one more patch_project usage.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 694348
Change-Id: If05371d0f6d11be6803ffa8392e029f5860dda25
Reviewed-on: https://chromium-review.googlesource.com/1217670
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

0f322bfc

[cipd] Pin hashes of CIPD packages. · 01710d04

Vadim Shtayura authored Sep 18, 2018

Together with already committed cipd_client_version.digests file, this
cryptographically binds contents of CIPD packages used by depot_tools
with depot_tool's git revision (assuming the CIPD client pinned by
cipd_client_version.digests is trusted too, which can presumably be
verified when it is being pinned).

This holds true even if the CIPD backend is compromised. The worst that
can happen is a denial of service (e.g. if the backend refuses to serve
packages at all).

If a bad backend tries to serve a malicious (unexpected) CIPD client,
'cipd' bootstrap script (and its powershell counterpart) will detect
a mismatch between SHA256 of the fetched binary and what's specified in
cipd_client_version.digests, and will refuse to run the untrusted binary.

Similarly, if the bad backend tries to serve some other unexpected
package (in place of a package specified in cipd_manifest.txt), the CIPD
client (already verified and trusted as this point) will detect a mismatch
between what was fetched and what's pinned in cipd_manifest.versions, and
will refuse to install untrusted files.

cipd_manifest.versions was generated from cipd_manifest.txt by:
$ cipd ensure-file-resolve -ensure-file cipd_manifest.txt

This will have to be rerun each time cipd_manifest.txt is updated. There's
a presubmit check that verifies *.versions file is up-to-date (it's part
of 'cipd ensure-file-verify').

BUG=870166
R=nodir@chromium.org, iannucci@chromium.org, tandrii@chromium.org

Change-Id: I25314adf0a9b05c69cd16e75aff01dbc79c87aa5
Reviewed-on: https://chromium-review.googlesource.com/1227435
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

01710d04

Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator" · 05263352

Eric Boren authored Sep 18, 2018

This reverts commit 18b4479c.

Reason for revert: Breaking WebRTC roller: https://luci-milo.appspot.com/buildbot/client.webrtc.fyi/Auto-roll%20-%20WebRTC%20DEPS/12788

Original change's description:
> gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator
> 
> Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91
> Reviewed-on: https://chromium-review.googlesource.com/1221826
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Eric Boren <borenet@chromium.org>

TBR=vadimsh@chromium.org,dnj@chromium.org,borenet@chromium.org,tandrii@chromium.org

Change-Id: I93bbd2d09cd2b27d9a7aa98fc15d60c5033a38cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1231433Reviewed-by: Eric Boren <borenet@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>

05263352

Roll recipe dependencies (trivial). · 80479736

recipe-roller authored Sep 18, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f7a834467c55fc302e5da1bdc0ef78c7bdecf2d9 Add comment to failing_step to indicate that it raises an exception. (erikchen@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b3ab8e2145e52711a7a725d6af77afb93f8ad0b
Reviewed-on: https://chromium-review.googlesource.com/1230793
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

80479736

[buildbucket] Print build url on command line with buildbucket.py · 0639cbc4

Michael Achenbach authored Sep 18, 2018

V8 uses buildbucket.py to trigger flake-bisect jobs on command line.
It's more convenient if the build url is shown.

Bug: 711249
Change-Id: I5737c6f3fd72b60517662e8a4808186d6acc71db
Reviewed-on: https://chromium-review.googlesource.com/1226912
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: smut <smut@google.com>

0639cbc4

gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator · 18b4479c

Eric Boren authored Sep 18, 2018

Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91
Reviewed-on: https://chromium-review.googlesource.com/1221826Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>

18b4479c

[cipd] Bump CIPD client version to 2.2.8, add presubmit check for *.digests. · f9b48459

Vadim Shtayura authored Sep 18, 2018

The new version uses SHA256 for uploads by default. It also fully supports
$ResolvedVersions and 'selfupdate-roll'.

The roll was generated by:
$ ./cipd selfupdate-roll \
  -version-file cipd_client_version \
  -version git_revision:fb963f0f43e265a65fb7f1f202e17ea23e947063

BUG=821194, 870166
R=nodir@chromium.org, iannucci@chromium.org

Change-Id: If7c23c43ff2c1bf50c9c50f4e9e17a23e84859b9
Reviewed-on: https://chromium-review.googlesource.com/1227431
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

f9b48459

17 Sep, 2018 3 commits

git cl upload: print response headers on 404 Gerrit RPC status. · ea4301e5

Andrii Shyshkalov authored Sep 17, 2018

R=ajp@chromium.org

Bug: 881860
Change-Id: I2a5fc981fce05664ea077cad74458bc38c37f1e7
Reviewed-on: https://chromium-review.googlesource.com/1227439
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

ea4301e5

[git_cl] Fix git cl comments json stdout printing · 45b20c41

Leszek Swirski authored Sep 17, 2018

Print "git cl comments" json to stdout when the output file is "-"

Change-Id: I91021317e52019a0d499cccc4f40f062127b300e
Reviewed-on: https://chromium-review.googlesource.com/1228094
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

45b20c41

my_activity: faster Gerrit reviews search. · 4aedec01

Andrii Shyshkalov authored Sep 17, 2018

Test: verified the same reviews list is produced w/o and w/ this change.
Change-Id: I72be85734a84d96a06b74515e64344fc203b1eed
Reviewed-on: https://chromium-review.googlesource.com/1227442Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

4aedec01

14 Sep, 2018 3 commits

[cipd] Add presubmit support for checking *.digests file. · 2174136d

Vadim Shtayura authored Sep 14, 2018

Not enabling it yet, since PRESUBMIT.py uses presubmit_canned_checks.py from
depot_tools at HEAD, not from a CL (thus enabling this check in this CL will
make it fail the presubmit).

R=nodir@chromium.org
BUG=870166

Change-Id: I97802ec37f1f7513dfca3950f7f38a5c51ab0350
Reviewed-on: https://chromium-review.googlesource.com/1227432Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

2174136d

[cipd] More careful error handling during CIPD bootstrap on Windows. · dfedcc06

Vadim Shtayura authored Sep 14, 2018

Errors during the download should be reported as such, not as "failed to grab
the lock file".

R=nodir@chromium.org, iannucci@chromium.org
BUG=853722

Change-Id: If24f4587693852eed0608450bcd311cf3bafd2c3
Reviewed-on: https://chromium-review.googlesource.com/1226106Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

dfedcc06

Roll recipe dependencies (trivial). · 53f9d872

recipe-roller authored Sep 14, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b8db432be1add133ef005e17d5729c537349f2c9 analyze.py: Actually include default fields (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ed2a785a4e25d4c93c1b1c32ea1489ee717d112
Reviewed-on: https://chromium-review.googlesource.com/1226231Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

53f9d872

13 Sep, 2018 6 commits

Roll recipe dependencies (trivial). · b5e87815

recipe-roller authored Sep 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/241d879a3dee0f9f1a0dc8933dc67f24e0d33391 analyze: Output field default values (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefc3478b7e8857a23830a2d0788d3b3e45b1816b
Reviewed-on: https://chromium-review.googlesource.com/1226230
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

b5e87815

Roll recipe dependencies (trivial). · d42dfd42

recipe-roller authored Sep 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/04e26b62818d4848aed3631d9c58c2d41ecc2ed8 [buildbucket] Pass v2 build as a dict, not base64 bytes (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I756d39fb0004d220d4113ef56fffa3065674b32e
Reviewed-on: https://chromium-review.googlesource.com/1225671Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d42dfd42

Roll recipe dependencies (trivial). · 982c7993

recipe-roller authored Sep 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1f3949c4d11c89d35d1e4c688c3a1c14985bdad7 [file] Fix naming conflict bug in flatten_single_directories. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2ff5f1c89486ff05e4e5fba1d29e63d0fed7761
Reviewed-on: https://chromium-review.googlesource.com/1225670Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

982c7993

Roll recipe dependencies (trivial). · 77ed83d5

recipe-roller authored Sep 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5831fa01c47fb7248495566e80d4d049c47d3f78 Fix config.Dict.schema_proto. (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I708632280df12d762cc6e3fbcfdef327e2bf5ef1
Reviewed-on: https://chromium-review.googlesource.com/1225390Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

77ed83d5

Increase gerrit_util retry count and delay. · 56117720

Steve Kobes authored Sep 13, 2018

Bug: 881860
Change-Id: I6402ff2665b70b46558799dbb16ac9c7a9d7d640
Reviewed-on: https://chromium-review.googlesource.com/1224990Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>

56117720

[led] Roll led to handle jobs with multiple swarming TaskSlices. · dfce68bc

Robert Iannucci authored Sep 13, 2018

R=hinoka@chromium.org, nodir@chromium.org, tandrii@chromium.org

Bug: 875089
Change-Id: I6abb7a5d0aebf53c4c3ab6be309ed43e652278c0
Reviewed-on: https://chromium-review.googlesource.com/1222883
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

dfce68bc

11 Sep, 2018 3 commits

Roll recipe dependencies (trivial). · 0425ebd2

recipe-roller authored Sep 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ed19633e4183c8304db2a9bfd8646819c68ba5ba [tricium] Write tricium output as a string (juliehockett@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b14edc9a1a6c1a8eea61ab5573a8fa4a0cf1bf0
Reviewed-on: https://chromium-review.googlesource.com/1220109Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

0425ebd2

Fetch current Gerrit CL info in tryserver · ddda0b5b

Nodir Turakulov authored Sep 11, 2018

Add tryserver.api.gerrit_change_info that returns detailed info about the
current Gerrit CL. It makes a Gerrit RPC in the background on the first read.
This step will be present in all tryjobs.

This mechanism can be used for extra details about the current CL.
This CL starts to use this in bot_update for gerrit_ref, and stops using
patch_ref property, and also update bot_update to use when the destination
branch is needed.

Also this CL removes no longer used properties in bot_update,
namely most of patch_* properties.

build.git manual roll: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1217626

Recipe-Manual-Change: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: skiabuildbot
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
R=tandrii@chromium.org
Bug: 694348
Change-Id: I945d061b74278c3d1d227578abe16a64cdaca647
Reviewed-on: https://chromium-review.googlesource.com/1213557
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

ddda0b5b

Roll recipe dependencies (trivial). · 56e27329

recipe-roller authored Sep 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/fc3791701f0801ab86e840225a7a566fee806ba0 [buildbucket] add revision param to try_build (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01d776eaf2db235ddb8875ae68a84f17dfdd3b75
Reviewed-on: https://chromium-review.googlesource.com/1217693Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

56e27329

10 Sep, 2018 3 commits

Roll recipe dependencies (trivial). · 0f5fff6a

recipe-roller authored Sep 10, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/35df4133e3d4282971f11b531c2e247c8644be81 [buildbucket] Remove gerrit_host param (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2cbe0fe2f514719f6d419f55110302cd8105ca53
Reviewed-on: https://chromium-review.googlesource.com/1217687Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

0f5fff6a

Roll recipe dependencies (trivial). · 727453b2

recipe-roller authored Sep 10, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e7c361bd4185326e511520b11950cab5d4291281 time module: Make sleep shell out sometimes (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie6caee3f0811a3fded54338f3baf0a2685d42f7a
Reviewed-on: https://chromium-review.googlesource.com/1217684Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

727453b2

[bot_update] add ignore_input_commit parameter · 11bc3991

Nodir Turakulov authored Sep 10, 2018

CrOS chromium-pfq builder uses bot_update, but checks out Chromium on its own,
effectively ignoring input commit in bot_update.
To resolve a P0, add ignore_input_commit parameter.
Long term, bot_update API must be redesigned.

TBR=tandrii@chromium.org
Bug: 882094
Change-Id: I4f43348e3d5f81bf603dd2c110829bce58acad16
Reviewed-on: https://chromium-review.googlesource.com/1216787Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

11bc3991