- 16 Oct, 2018 2 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: Ib3120b5fd09c35be691c025d0d69ceda60f2ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1279135 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I980487aacd115535d0ca855cd1edfcfc18fc5cbe Reviewed-on: https://chromium-review.googlesource.com/c/1279138 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 15 Oct, 2018 7 commits
-
-
Andrii Shyshkalov authored
--email --emulate-svn-auto-props R=ehmaldonado Bug: 770408 Change-Id: I645342e5735313055c713bc8f8b68eee353aba49 Reviewed-on: https://chromium-review.googlesource.com/c/1279134 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Also fix a typo in ValidateEmail function which didn't support email addresses with '-' in them, e.g., infra-dev@chromium.org. R=ehmaldonado Bug: 875089 Change-Id: I2d73c1473527c9bf62e25e9f88250196b783fcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1242849 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Also deletes lots of tests which provided coverage for Rietveld only, and hence no longer useful. R=ehmaldonado Bug: 770408 Change-Id: I31195f7819a52d1063ed28064a74fd70fbc39357 Reviewed-on: https://chromium-review.googlesource.com/c/1279133 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: Id070e6084b6beba7309bdc35f0f750decd77e0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1279132 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I5020596ada0c6fef2797fed6b78e7256a35ffc40 Reviewed-on: https://chromium-review.googlesource.com/c/1279131 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
This adds O(reviewers+cc) RPC to Gerrit before upload, though done concurrently in up to 10 threads. This information isn't used yet, but will be in follow up CLs. R=ehmaldonado Bug: 877717 Change-Id: I2374f249ee874a71089244309e50e8e88a3dee7d Reviewed-on: https://chromium-review.googlesource.com/c/1242847Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 877717 Change-Id: Iccfba594369d8c726fd9b077d3ac18046757e4a2 Reviewed-on: https://chromium-review.googlesource.com/c/1242845 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 13 Oct, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 877717 Change-Id: I81e574068687576cc44e41ba00ba650de8aae31b Reviewed-on: https://chromium-review.googlesource.com/c/1242844Reviewed-by:
-
- 12 Oct, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 881860 Change-Id: Ia02905a8b71486d771a691c31114d692e62a369f Reviewed-on: https://chromium-review.googlesource.com/c/1277796Reviewed-by:
-
- 11 Oct, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dffa0b83f071c910d625955d6bb61335696e3a08 Add UUID recipe module (smut@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If0a3cdcf3cf05894b71f73aa15121bdf353193af Reviewed-on: https://chromium-review.googlesource.com/c/1278325 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
Edward Lemur authored
Print the message asking the user to upload gerrit logs for git-cl upload failures after the exception. Also, initialize the error logger only for git-cl upload, so that the headers are not overwritten unless git-cl upload is executed again. Bug: 881860 Change-Id: I8e63432eecca5253e56096e3ad0218eec4058e12 Reviewed-on: https://chromium-review.googlesource.com/c/1277426 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 10 Oct, 2018 2 commits
-
-
Ryan Tseng authored
Some projects that use the git module (eg flutter) require tags. Bug: 870558 Change-Id: Idae50ef5c8a092e5f0109b6c14c562268a2ad236 Reviewed-on: https://chromium-review.googlesource.com/c/1274245Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Edward Lemur authored
And ask the user to report the printed headers to the bug. Bug: 881860 Change-Id: I0a6cc0d90b4a721f72cd7eee4cba59934facbb1e Reviewed-on: https://chromium-review.googlesource.com/c/1266837 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 09 Oct, 2018 2 commits
-
-
Aiden Benner authored
0.24 has just been uploaded see bug. Bug: 890349 Change-Id: Ice1e0c54d3fb60c0da5fde14aafae20c3ac449ce Reviewed-on: https://chromium-review.googlesource.com/c/1261756Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com>
-
Robert Iannucci authored
TBR=tandrii@chromium.org, vadimsh@chromium.org Change-Id: Ie976820701359bb4976d251b3de4f1077d2357ac Reviewed-on: https://chromium-review.googlesource.com/c/1271304 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
- 05 Oct, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/acbe9e3142610d958181460254565ef27ad47dc0 [StepPresentation] Remove all logs from memory during finalization. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id65a77df9f8508f57a28aa77433b141b1a691c9f Reviewed-on: https://chromium-review.googlesource.com/c/1264996Reviewed-by:
-
Robert Iannucci authored
This should allow better integration with buildbucket named cache support. Since this was already parameterized it shouldn't actually break anything; previously the directory would be deleted on every run, now it will still be deleted on every run (but we can add a buildbucket named cache entry for it to preserve it). R=tandrii@chromium.org, vadimsh@chromium.org Bug: 877775 Change-Id: I1184fb59a3ed18bfda5fcb288903201b01527096 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/1263861 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
Edward Lemur authored
It has been True by default for a while, and there is no need to override it. Bug: 891917 Change-Id: I2598a2230b0ea38a647a533757331c541b871971 Reviewed-on: https://chromium-review.googlesource.com/c/1260057Reviewed-by:
-
Eric Boren authored
Bug: skia:8394 Change-Id: I928eaec8459a5905360ce760c6361e4554852b44 Reviewed-on: https://chromium-review.googlesource.com/c/1261796Reviewed-by:
-
Ryan Tseng authored
Picks up https://chromium-review.googlesource.com/c/1260068 Bug: 891925 Change-Id: If2df9ea7ce2d1bcbaca8533935f6e6d30dcd8810 Reviewed-on: https://chromium-review.googlesource.com/c/1263015Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116 [cipd] Fix typo in pkg-deploy method. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5525b0182f7d6395cf66186fba4058dfc0d61496 Reviewed-on: https://chromium-review.googlesource.com/c/1263596 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9f1afcb08b95a9c2cbae653dd320cd84d62287ff raw_io: pipe placeholder name through for input placeholders. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5038f06949f8865afb59e614736923ba29547085 Reviewed-on: https://chromium-review.googlesource.com/c/1263595Reviewed-by:
-
- 04 Oct, 2018 3 commits
-
-
Edward Lemur authored
Bug: 882611 Change-Id: I72646544a164f557ea7d53e0ce0f16d663618a98 Reviewed-on: https://chromium-review.googlesource.com/c/1255446Reviewed-by:
-
Asanka Herath authored
Revision 51049267 removed git-crup which orphaned git-crsync whose only purpose in life is to invoke git-crup. Change-Id: Ic8594150692106d8c6326004adea8ce2977f221d Reviewed-on: https://chromium-review.googlesource.com/c/1262117Reviewed-by:
-
Vadim Shtayura authored
This CL basically replaces "skip if is_gce" with "skip if default auth method is not gitcookies". This presumable makes 'git cl' work on LUCI in a consistent manner. Before, it worked only if the LUCI bot happened to also be GCE bot. R=tandrii@chromium.org BUG=891755 Change-Id: I2caa219a4082438a5e026e728bfb62f46a0c80fd Reviewed-on: https://chromium-review.googlesource.com/c/1260053 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
- 03 Oct, 2018 4 commits
-
-
Oleh Prypin authored
Bug: chromium:836566 Change-Id: I752633cd0f5334b4592e1a1f1d4506bf89c7716d Reviewed-on: https://chromium-review.googlesource.com/1257841Reviewed-by:
-
Aiden Benner authored
Parses git diff for changed python files in a method similar to clang-diff and feeds the resulting line ranges into yapf. Also sets the default style to the yapf file included in depot tools by searching parent directories of each changed file to find a yapf style config (.style.yapf). If none is found the default style file will be the chromium .style.yapf included in depot tools. Note: Even if line ranges are specified, yapf will fix indentation issues for the entire file. This is intended see https://github.com/google/yapf/issues/499 This may cause some issues if git cl format is run on a file with lots of indentation issues or on a file or when run on a third_party file that is formatted with pep8 and does not include a .style.yapf and may make many more changes then the user expects. Still undecided on whether this should be turned on by default but if not I think the non --full support is a positive change anyways. Bug:846432 Change-Id: Ib85797f4a8e1021870901ff465ec10f7e70deb87 Reviewed-on: https://chromium-review.googlesource.com/1249642 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org>
-
Bruce Dawson authored
Nina supports -C out/Default and -Cout/Default to specify the build directory so autoninja should also. This change adds that support. Bug: 890744 Change-Id: I5e824242ed4b333ac99f1ee9a649ffcfa03a812e Reviewed-on: https://chromium-review.googlesource.com/c/1257586Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Robert Iannucci authored
R=tandrii@chromium.org, vadimsh@chromium.org Change-Id: I1f235cf959e92e4430cff7dcd0d292db1721319d Reviewed-on: https://chromium-review.googlesource.com/c/1257585Reviewed-by:
-
- 02 Oct, 2018 1 commit
-
-
Dirk Pranke authored
bradleynelson is no longer active in depot_tools. agable@ is unavailable for the rest of 2018. Change-Id: Idf5be1db84b8f6857f9edd7ed16c56d4c89f81ef Reviewed-on: https://chromium-review.googlesource.com/1256170Reviewed-by:
-
- 27 Sep, 2018 4 commits
-
-
Adrienne Walker authored
Also, sort all the gerrit instances by url for clarity. Change-Id: I89aea98f75de33e8673c929fb07df3b686ea6c15 Reviewed-on: https://chromium-review.googlesource.com/1228659 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7d52a83204be2083edfc82042b13769846db9dff Update the recipes user guide to use post_process. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I61abce116cb3d914f057cdf33eb55579a82b49d2 Reviewed-on: https://chromium-review.googlesource.com/1249641Reviewed-by:
-
Andrii Shyshkalov authored
R=smut@google.com Bug: 881860 Change-Id: I59c337384891f02dbd2cc776318803ac556843ca Reviewed-on: https://chromium-review.googlesource.com/1247584Reviewed-by:
smut <smut@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dc1bf00db5252bb54dd09745865c3160778a882d Fix cmd error in StepCommandContains check (aluo@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic85a74dbbbf78b069d29b26154e9321c96b36cea Reviewed-on: https://chromium-review.googlesource.com/1247821Reviewed-by:
-
- 26 Sep, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/65fffecb2f6a041d71107292b1453a92ab1127fc Add post_process functions for asserting on a step's command. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie68b5d385f6455604d95d89d0b1686e91969c0b2 Reviewed-on: https://chromium-review.googlesource.com/1247041Reviewed-by:
-
- 25 Sep, 2018 3 commits
-
-
Andrii Shyshkalov authored
This removes 1 RPC when tbr-ing second or later patchset. Since tests cover TBR only in first upload, there are no test changes. Since adding test is real PITA here, keep them as is. R=ehmaldonado Change-Id: I90801b06727ce2131a703d6cd6c24ffad798bc8a Reviewed-on: https://chromium-review.googlesource.com/1242212Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ie5522283e84bdec9d98e236577eaad568816519b Reviewed-on: https://chromium-review.googlesource.com/1242211Reviewed-by:
-
Andrii Shyshkalov authored
This will cycle through known gerrit mirrors for chromium-review host if Gerrit HTTP RPC results in 404 after successful initial git push refs/for/refs/... Tested locally by intentionally using wrong change number (2000000): $ PATH=`pwd`:$PATH git cl upload --bypass-hooks ... remote: Processing changes: refs: 1, new: 1, done remote: SUCCESS remote: New Changes: remote: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1227440 * [new branch] ea9aea5faa85b4b289b7add4bc6f4d5dd6a01caf -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=git-cl WARNING:root:404 NotFound error occurred while querying POST https://chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://ap1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://us1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found ^C Bug: 881860 Change-Id: Iac7dbe4e35052007650a7a2646a394caed6bd400 Reviewed-on: https://chromium-review.googlesource.com/1227441 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
