Commits · 63e216c6ef9254da227e3447ef5c7086d727e54b · Linshizhi / Chromium_Depot_tools

30 Mar, 2018 1 commit

gsutil update default version to 4.30 · 63e216c6

Caleb Rouleau authored Mar 29, 2018

Bug: 797463
Change-Id: Ia8f565997dfe2180586a8777c51f1f32229dbf3b
Reviewed-on: https://chromium-review.googlesource.com/986922Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>

63e216c6

28 Mar, 2018 5 commits

Roll recipe dependencies (trivial). · a16b4ccd

recipe-roller authored Mar 28, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/583ce62f5f4bb3a2d4821bc0568e39810c043b14 [buildbucket] add build_input property (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia802c79ca5aee4a715da1871645633725c36659d
Reviewed-on: https://chromium-review.googlesource.com/984740Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

a16b4ccd

Remove dnj from depot_tools OWNERS · 6ceb3453

Nico Weber authored Mar 28, 2018

Add some other people to recipes/OWNERS

Change-Id: I554d1fd354e628d2e62629be7ce20e899364c4a9
Reviewed-on: https://chromium-review.googlesource.com/984972
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6ceb3453

add a standalone angle gclient config · 7bfbb432

Nico Weber authored Mar 28, 2018

To be used in https://chromium-review.googlesource.com/c/chromium/tools/build/+/984433

Bug: 820421
Change-Id: I76d32ed9f7b5caa256bfa85220ac0c256bbc1a48
Reviewed-on: https://chromium-review.googlesource.com/984692Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

7bfbb432

Reland "gclient eval: Expand vars while parsing DEPS files" · 6c24d37f

Edward Lesmes authored Mar 28, 2018

This is a reland of 88f9c40e

We no longer need the vars dict to be declared before vars can be used.
This was causing problems because gclient flatten printed vars after deps,
breaking the above assumption.

Original change's description:
> gclient eval: Expand vars while parsing DEPS files
>
> Introduce a Parse function that takes care of expanding vars while parsing
> the DEPS file.
>
> It wraps Exec and exec calls, and supports deferring the expansion until
> later, so gclient flatten gets access to the unexpanded version.
>
> Bug: 821199
> Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2
> Reviewed-on: https://chromium-review.googlesource.com/973749
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

Bug: 821199
Change-Id: I583df23558f91871e1a2aa2574c20d35e54635f6
Reviewed-on: https://chromium-review.googlesource.com/981086
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

6c24d37f

Roll CIPD and vpython versions to git_revision:4d19637ec2c3d1efd8c6a1b05285118b786919e2 · 96fc3338

Sergey Berezin authored Mar 27, 2018

Bug: 803158
Change-Id: Ie42a726a85d86ff4d62d141a6413886787760835
R=martiniss@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/982599Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

96fc3338

27 Mar, 2018 3 commits

fetch: stop specifying .DEPS.git for any repos · 47f44dc1

Aaron Gable authored Mar 27, 2018

None of these repos has had a .DEPS.git file in over 3.5 years.

R=ehmaldonado

Bug: 824734
Change-Id: I768e247eee5a8eff9fcf8f1891497840909ec9fa
Reviewed-on: https://chromium-review.googlesource.com/982521Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

47f44dc1

Add hierarchy information to flattened "visited DEPS" output. · fe68c91e

Michael Moss authored Mar 23, 2018

This will make it easier to programmatically determine where a flattened
entry originated, which is needed for recursively branching and
unpinning DEPS files.

BUG=825063
R=dpranke@google.com

Change-Id: Id280c0b0a95b8664602e0ec4513722fe4d6d1ebf
Reviewed-on: https://chromium-review.googlesource.com/977326Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

fe68c91e

bot_update: Make gclient experiment a property instead of an argument. · ee04b9a2

Edward Lesmes authored Mar 26, 2018

Is easier to configure experimental bots this way.

Bug: 643346
Change-Id: Idb6d3a68b02949dce71dbcba38e8ef756c467830
Reviewed-on: https://chromium-review.googlesource.com/981515
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

ee04b9a2

26 Mar, 2018 2 commits

bot_update: Add a flag to move applying the patch to gclient. · 385a4fdd

Edward Lesmes authored Mar 26, 2018

This adds a --enable-gclient-experiment flags that tells bot_update.py
to skip applying the patch, and instead forward the flags to gclient.

Bug: 643346
Change-Id: Ia4275a126e6adba54dfcc894d224c50c166db90e
Reviewed-on: https://chromium-review.googlesource.com/962938
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

385a4fdd

Revert (Reland "gclient eval: Expand vars while parsing DEPS files") · 4732b3b1

Egor Pasko authored Mar 26, 2018

This reverts commits:
  dbbf350a Fix trailing whitespace test.
  b4f1d449 Fix actual pylint errors.
  0d9ecc92 Reland "gclient eval: Expand vars while parsing DEPS files"

Reason: http://crbug.com/825724 Clank Official Build Failure - 65.0.3325.193

TBR=agable@chromium.org

Bug: 825724
Change-Id: Icef2d0ccc8a13b782a8e3d6b474b1281820947b5
Reviewed-on: https://chromium-review.googlesource.com/980334
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

4732b3b1

24 Mar, 2018 1 commit

Fix trailing whitespace test. · dbbf350a

Robert Iannucci authored Mar 23, 2018

And write the test better to avoid overzealous editor plugins :)

TBR=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org

Bug: 825290,825174
Change-Id: I0541d4d70bcb256c24cb659bae256fa0aacb6806
Reviewed-on: https://chromium-review.googlesource.com/979116
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

dbbf350a

23 Mar, 2018 5 commits

Fix actual pylint errors. · b4f1d449

Robert Iannucci authored Mar 23, 2018

TBR=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org

Bug: 825290,825174
Change-Id: Ide4f03b0f9100a2110bad9d510921b46b2d4e43a
Reviewed-on: https://chromium-review.googlesource.com/979112Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

b4f1d449

[presubmit_canned_checks] Stop exporting sys.path into PYTHONPATH. · 82a6480a

Robert Iannucci authored Mar 23, 2018

Again, sys.path shouldn't ever be exported into PYTHONPATH :)

R=eakuefner@chromium.org, nodir@chromium.org, vadimsh@chromium.org

Bug: 825290,825174
Change-Id: Ia0594da3ff25972a08fdf74ae2aef5be79cbf3af
Reviewed-on: https://chromium-review.googlesource.com/978594Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

82a6480a

Reland "gclient eval: Expand vars while parsing DEPS files" · 0d9ecc92

Edward Lesmes authored Mar 23, 2018

This is a reland of 88f9c40e

Original change's description:
> gclient eval: Expand vars while parsing DEPS files
> 
> Introduce a Parse function that takes care of expanding vars while parsing
> the DEPS file.
> 
> It wraps Exec and exec calls, and supports deferring the expansion until
> later, so gclient flatten gets access to the unexpanded version.
> 
> Bug: 821199
> Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2
> Reviewed-on: https://chromium-review.googlesource.com/973749
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

Bug: 821199
Change-Id: Ic04af0cae59abc01a0382e2de3497a91cf7e62fd
Reviewed-on: https://chromium-review.googlesource.com/978561Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0d9ecc92

Correct documentation for the --no-referenced-issues argument · b4475ab9

Sergiy Byelozyorov authored Mar 23, 2018

When specified it will skip any issues that were not modified in the specified
time period even if they are owned by the user.

R=tandrii@chromium.org

Change-Id: I230c8fa6cbc517c32edb8618a831a62ec6e45405
Reviewed-on: https://chromium-review.googlesource.com/978170Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

b4475ab9

Clear $VPYTHON_CLEAR_PYTHONPATH when setting $PYTHONPATH. · 23bd7353

Robert Iannucci authored Mar 23, 2018

On buildbot (only), we don't trust PYTHONPATH, so we have set
VPYTHON_CLEAR_PYTHONPATH to make the first invocation of vpython in a
given chain of python invocations clear PYTHONPATH.

This has the unfortunate side-effect that python scripts that set
PYTHONPATH and then call into vpython (like presubmit) end up
having their PYTHONPATH modifications removed.

As a workaround (until I clean up PYTHONPATH in buildbot for real), fix
presubmit_canned_checks so that it clears VPYTHON_CLEAR_PYTHONPATH when it
adjusts PYTHONPATH.

R=charlie@chromium.org, nodir@chromium.org, vadimsh@chromium.org

Bug: 825290,825174
Change-Id: Ib5f73add1726fdf3c335d26fc0af76cfe3b747b2
Reviewed-on: https://chromium-review.googlesource.com/978632Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

23bd7353

22 Mar, 2018 6 commits

Revert "gclient eval: Expand vars while parsing DEPS files" · 728244f7

Benjamin Pastene authored Mar 22, 2018

This reverts commit 88f9c40e.

Reason for revert: suspected to be causing update scripts failures and prevent gce bots from connecting
https://build.chromium.org/deprecated/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/128479/steps/update_scripts/logs/stdio

Original change's description:
> gclient eval: Expand vars while parsing DEPS files
> 
> Introduce a Parse function that takes care of expanding vars while parsing
> the DEPS file.
> 
> It wraps Exec and exec calls, and supports deferring the expansion until
> later, so gclient flatten gets access to the unexpanded version.
> 
> Bug: 821199
> Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2
> Reviewed-on: https://chromium-review.googlesource.com/973749
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=agable@chromium.org,dpranke@chromium.org,ehmaldonado@chromium.org

Change-Id: Ib9b84c13ef9b56735fd8f714b74a6601c61715e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821199
Reviewed-on: https://chromium-review.googlesource.com/976721Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>

728244f7

gclient eval: Expand vars while parsing DEPS files · 88f9c40e

Edward Lesmes authored Mar 22, 2018

Introduce a Parse function that takes care of expanding vars while parsing
the DEPS file.

It wraps Exec and exec calls, and supports deferring the expansion until
later, so gclient flatten gets access to the unexpanded version.

Bug: 821199
Change-Id: I943b021cc4474c9cda67b3816b841dd8ada3f5b2
Reviewed-on: https://chromium-review.googlesource.com/973749
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

88f9c40e

Trigger recipe roll to pick up . · e8703543

Robert Iannucci authored Mar 22, 2018

To make sure that the following CL actually rolls into downstream recipes:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/961865

TBR=nodir@chromium.org, vadimsh@chromium.org

Bug: 821669
Change-Id: Ia530a619e355291a15d849e09c449fc82e31534b
Reviewed-on: https://chromium-review.googlesource.com/976558Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

e8703543

[presubmit_support] Prevent depot_tools' virtualenv from leaking into other repos. · 5025893c

Robert Iannucci authored Mar 19, 2018

Currently in LUCI `git cl` is invoked on chromium_presubmit using vpython. This
means that it operates under the depot_tools .vpython environment (which is
blank).

Some features in presubmit_support allow invocation of python subprocesses, and
previously they would use `sys.executable` (especially on windows, but
occasionally on non-windows as well).

In non-vpython environments, this just picks up the system python and whatever
modules happen to be installed there. Some python unittests work around this on
non-windows systems by having a shebang line which explicitly invokes vpython.

This CL changes presubmit_support so that invocations of 'python', or executions
of '.py' scripts will always end up invoking vpython. In the best case, this will
pick up the invoked scripts' vpython environment. In the worst case, this will
invoke the script under an empty vpython environment (aka "stock python").

R=dpranke@chromium.org, jbudorick@chromium.org, tandrii@chromium.org, tikuta@chromium.org

Bug: 821669
Change-Id: I5d2d5dfd0364022d56833c2c8af4983553a29c7a
Reviewed-on: https://chromium-review.googlesource.com/961865Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

5025893c

gclient sync: Add support to apply gerrit refs. · c621b21a

Edward Lesmes authored Mar 22, 2018

Mimics bot_update's functionality to apply gerrit refs in gclient
via --gerrit-ref flags.
When the patch fails to apply, gclient sync will return exit code 2.

The idea is to move this logic from bot_update to gclient sync to
deal when patches for projects like ANGLE are tried on Chromium bots.
This way the patch is applied before recursively parsing and syncing
ANGLE’s DEPS.chromium file, which doesn't currently happen.

Bug: 643346

Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18
Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c621b21a

Revert "Add debugging info when gclient deletes an old DEPS entry." · 869a2857

Lei Zhang authored Mar 22, 2018

This reverts commit 33bf4953.

Reason for revert: Done debugging.

Original change's description:
> Add debugging info when gclient deletes an old DEPS entry.
> 
> To help figure out why it decided to do so.
> 
> BUG=823586
> 
> Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6
> Reviewed-on: https://chromium-review.googlesource.com/970082
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=thestig@chromium.org,agable@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 823586
Change-Id: I476cbe423b849582f8684426653f0c08062e89e9
Reviewed-on: https://chromium-review.googlesource.com/974458Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

869a2857

21 Mar, 2018 5 commits

gclient eval: Get rid of global_scope, local_scope and functions other than Var. · 9f531298

Edward Lesmes authored Mar 21, 2018

Since we only support Var, and Var only does one thing, we hard code that
into the parser. Then, we don't need global_scope.

local_scope hasn't been needed for a while.

Bug: 760633
Change-Id: I21b171a8b71e7dcaf8e29c780ca88b9f46f368e8
Reviewed-on: https://chromium-review.googlesource.com/972611Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9f531298

bot_update: don't repack, don't gc in main repo of builder's checkout. · b3065fb6

Andrii Shyshkalov authored Mar 21, 2018

The main purpose is to avoid running slow and useless operation in
chromium/src checkouts. Ideally, this should be done in every DEPS-ed
repo, too, but that requires substantially more changes in gclient.
Thus, this CL provides biggest bang for the buck.

Example led build: https://ci.chromium.org/swarming/task/3c62efb31ed3a910?server=chromium-swarm.appspot.com

R=hinoka@chromium.org

Bug: 822437
Change-Id: I347d85e5cb5158b77969a755b67ca2289fb39d40
Reviewed-on: https://chromium-review.googlesource.com/973900
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

b3065fb6

Add progress indicator that prints a dot on nearly each RPCs request · a68d82cb

Sergiy Byelozyorov authored Mar 21, 2018

R=tandrii@chromium.org

Change-Id: Id4fa494c8225c8edefecba064445504065581478
Reviewed-on: https://chromium-review.googlesource.com/966564
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

a68d82cb

Add ability to filter issues precisely by comment publication date · 1b7d56d2

Sergiy Byelozyorov authored Mar 21, 2018

This also parallelises get_changes, get_issues and get_reviews.

R=tandrii@chromium.org

Change-Id: I8ebc69fc6e59637ec576057abf1d9068a340b71a
Reviewed-on: https://chromium-review.googlesource.com/966563
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

1b7d56d2

presubmit_unittest.py: use LUCI for the optional GPU tests on Mac · ba51bb3c

Corentin Wallez authored Mar 20, 2018

BUG=chromium:815092

Change-Id: I3eeb6332be4a2cd8b8d1be6b57859895458a5067
Reviewed-on: https://chromium-review.googlesource.com/971349Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

ba51bb3c

20 Mar, 2018 4 commits

Reland "gclient: Add commands to edit dependencies and variables in DEPS" · 6f64a052

Edward Lesmes authored Mar 20, 2018

This is a reland of 7f4c905f

Original change's description:
> gclient: Add commands to edit dependencies and variables in DEPS
> 
> Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
> and dependencies in a DEPS file.
> 
> Bug: 760633
> Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
> Reviewed-on: https://chromium-review.googlesource.com/950405
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

Bug: 760633
Change-Id: Ia46c74d02e5cc3b67517dfa248f597cb3d98ef3d
Reviewed-on: https://chromium-review.googlesource.com/969457
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

6f64a052

[gclient] Use a single CIPD root for an entire gclient checkout. · d3ba72bb

John Budorick authored Mar 20, 2018

gclient previously used a CIPD root per DEPS file. This didn't work
in cases in which a DEPS file wanted to specify a CIPD package outside
of its directory hierarchy, though, as is the case with buildspecs.

Bug: 755920
Change-Id: I0d6c3db567f17f9171c0feaaf9ed6bc64db22757
Reviewed-on: https://chromium-review.googlesource.com/955933
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

d3ba72bb

Add debugging info when gclient deletes an old DEPS entry. · 33bf4953

Lei Zhang authored Mar 20, 2018

To help figure out why it decided to do so.

BUG=823586

Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6
Reviewed-on: https://chromium-review.googlesource.com/970082
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

33bf4953

Remove nested ifs in GClientSmokeBase.splitBlock(). · 083471af

Lei Zhang authored Mar 20, 2018

This helps make it slightly easier to understand.

Change-Id: Iaf68409374be67e03d5708b409c1ad9229c68b1d
Reviewed-on: https://chromium-review.googlesource.com/970161Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

083471af

19 Mar, 2018 2 commits

Revert "gclient: Add commands to edit dependencies and variables in DEPS" · 0b89935a

Edward Lesmes authored Mar 19, 2018

This reverts commit 7f4c905f.

Reason for revert:
When running "gclient sync" on a V8 checkout, it says:

  File "/work/chrome/depot_tools/gclient.py", line 995, in run
   self.ParseDepsFile()
 File "/work/chrome/depot_tools/gclient.py", line 874, in ParseDepsFile
   self._postprocess_deps(deps, rel_prefix), use_relative_paths)
 File "/work/chrome/depot_tools/gclient.py", line 660, in _postprocess_deps
   dval['condition'], self.condition)
TypeError: '_NodeDict' object does not support item assignment

on the recursive descent into third_party/android_tools/DEPS. Any chance that's related to https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/950405 ?

Original change's description:
> gclient: Add commands to edit dependencies and variables in DEPS
> 
> Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
> and dependencies in a DEPS file.
> 
> Bug: 760633
> Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
> Reviewed-on: https://chromium-review.googlesource.com/950405
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org

Change-Id: If58f6b15d31b19fc53294f1e41d26b4e684a2cf9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760633
Reviewed-on: https://chromium-review.googlesource.com/969165Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0b89935a

gclient: Add commands to edit dependencies and variables in DEPS · 7f4c905f

Edward Lesmes authored Mar 19, 2018

Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
and dependencies in a DEPS file.

Bug: 760633
Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
Reviewed-on: https://chromium-review.googlesource.com/950405
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

7f4c905f

16 Mar, 2018 1 commit

Add option for printing changes grouped by issue · 544b7446

Sergiy Byelozyorov authored Mar 16, 2018

This also adds support for V8 project on issue tracker.

R=tandrii@chromium.org

Change-Id: Ie90ae664573d36030267b639e8a55bc349cad872
Reviewed-on: https://chromium-review.googlesource.com/966623
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

544b7446

14 Mar, 2018 4 commits

presubmit_unittest.py: use LUCI for the optional GPU tests on Linux · a3a80b69

Corentin Wallez authored Mar 14, 2018

TBR=maruel@chromium.org

BUG=chromium:815092

Change-Id: I2d9e63000cbe48fea636a3d0f6fd69f040495697
Reviewed-on: https://chromium-review.googlesource.com/962994Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

a3a80b69

[led] Bump to support CIPD Recipes. · 1c9c0034

Robert Iannucci authored Mar 14, 2018

TBR=tandrii@chromium.org

Bug: 811974
Change-Id: I1ace75471dfbe2798c7c848f76d6607b34ff1033
Reviewed-on: https://chromium-review.googlesource.com/962082
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

1c9c0034

[git_cl] Remove rietveld CMDland implementation. · 2e73d438

Robert Iannucci authored Mar 14, 2018

R=agable@chromium.org, tandrii@chromium.org

Change-Id: I2bfed54a9a1bde3335340e5949eac313c3fdda32
Reviewed-on: https://chromium-review.googlesource.com/961970
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

2e73d438

[bot_update] Remove support for rietveld patches. · 456b0d64

Robert Iannucci authored Mar 14, 2018

R=agable@chromium.org, tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Change-Id: I518335e7b8fdce316b5566caccd3c4c7c2ae741a
Reviewed-on: https://chromium-review.googlesource.com/960161
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

456b0d64

13 Mar, 2018 1 commit

Roll recipe dependencies (trivial). · 06493714

recipe-roller authored Mar 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d17fa9994d031c525a5a732218667d41b827c8ec Use more common term in recipe-api docu (machenbach@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idef0e59985a9500e49b5a313be021f1bb88a1be4
Reviewed-on: https://chromium-review.googlesource.com/961082
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

06493714