- 01 Mar, 2014 1 commit
-
-
machenbach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/178223016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254321 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Feb, 2014 1 commit
-
-
nick@chromium.org authored
clang-format: Allow .proto files to be formatted (supported by an upcoming binary/script; this change is safe if you are running an older binary); remove warnings. BUG=344916 Review URL: https://codereview.chromium.org/177213013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253295 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Feb, 2014 2 commits
-
-
thestig@chromium.org authored
Relative root no longer makes sense after an os.chdir(). This is effectively a partial revert of r250248. Review URL: https://codereview.chromium.org/135213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250478 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Additionally: - replace some RunCommand(['git', ...]) calls with RunGit(). - replace Settings._GetConfig('rietveld.foo') _GetRietveldConfig('foo'). - merge and cache calls to git rev-parse --show-cdup. - merge some calls to git merge-base. Review URL: https://codereview.chromium.org/157913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Feb, 2014 1 commit
-
-
thakis@chromium.org authored
(It's a bit unfortunate that we're duplicating the default -regex list in clang-format-diff.py here :-/ But the .js and .proto stuff is probably not quite ready yet anyhow, so I'm only adding .mm for now.) TEST=Edit a .mm file, commit, run `git cl format`, `git diff` shows formatted output. TBR=iannucci@chromium.org Review URL: https://codereview.chromium.org/152303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248424 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jan, 2014 1 commit
-
-
enne@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/143903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247723 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Jan, 2014 1 commit
-
-
enne@chromium.org authored
For simplicity, the canned presubmit check just calls git cl format directly with a new option --dry-run which does not change the files on disk. Because some users may not have git or clang-format might somehow have errors, this canned check is a warning. Additionally, if git cl format fails with an error then the presubmit check will silently report success to avoid spamming misconfigured users during upload. BUG=none Review URL: https://codereview.chromium.org/141493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246066 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Jan, 2014 1 commit
-
-
nick@chromium.org authored
BUG=240309 TEST='git cl format' and 'git cl format --full' indent by 4 when run inside of third_party/WebKit TBR=iannucci@chromium.org Review URL: https://codereview.chromium.org/136333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245694 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2014 1 commit
-
-
nick@chromium.org authored
as part of the Chromium checkout. This follows the approach used by gn. Changes include: - in-the-PATH clang-format trampoline scripts - clang_format.py, which finds clang-format binaries inside of Chrome - Hook 'git cl format' to the new binaries and scripts - Rearrange some code, for reuse between clang_format.py and gn.py BUG=240309 TEST=presubmits (one failure on mac, but it fails on a clean checkout too) Review URL: https://codereview.chromium.org/134313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245074 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Jan, 2014 2 commits
-
-
rmistry@google.com authored
This change will allow projects other than chromium to specify 'BUG_PREFIX: project_name:' in their codereview.settings file. Currently, the change is created with 'BUG=', entering a project's bug number there will point it to chromium's issue tracker. Adding a project specific prefix will make the links point to the project's issue tracker without the developer having to know about the magic prefix. BUG=skia:1983 Review URL: https://codereview.chromium.org/132233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244801 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none R=iannucci@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/130803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jan, 2014 1 commit
-
-
pgervais@chromium.org authored
Passing the email address used to connect to Rietveld on the command line is useful for testing purposes, in particular with a test server. BUG=331123 Review URL: https://codereview.chromium.org/122583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244017 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2014 1 commit
-
-
pgervais@chromium.org authored
These options have been added to the 'git cl config' subcommand. --deactivate-update tells git cl not to update the values inside .git/config from the codereview.settings file. --activate-update does the opposite. This is designed for testing/development purposes only, for example, to be able to change the rietveld URL. BUG=327901 Review URL: https://codereview.chromium.org/104043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242943 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Dec, 2013 1 commit
-
-
fischman@chromium.org authored
BUG=330321 Review URL: https://codereview.chromium.org/107963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242301 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Dec, 2013 1 commit
-
-
binji@chromium.org authored
i.e. the output looks like: my-branch-name : https://codereview.chromium.org/1234567 my-other-branch : https://codereview.chromium.org/8675309 This makes it possible to double-click the branch name to use it in a subsequent command. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/118613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241731 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Dec, 2013 2 commits
-
-
stip@chromium.org authored
BUG=278554 Review URL: https://codereview.chromium.org/106763010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241629 0039d316-1c4b-4281-b951-d872f2087c98
-
yujie.mao@intel.com authored
BUG=None TEST=Error log print Review URL: https://codereview.chromium.org/112123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241544 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Dec, 2013 1 commit
-
-
szager@chromium.org authored
MatchSvnGlob uses the root url to grep for existing svn commits by matching the git-svn-id lines in the commit messages. If there is a rewriteRoot config, then the git-svn-id lines will have the rewritten url's, and the code should match against that. R=blundell@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/103053011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241043 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2013 2 commits
-
-
jsbell@chromium.org authored
R=dpranke@chromium.org Review URL: https://codereview.chromium.org/94033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239830 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
This will also enable git cl format to be more easily runnable by presubmit within a subdirectory. BUG=none Review URL: https://codereview.chromium.org/108353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239821 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2013 1 commit
-
-
thestig@chromium.org authored
R=maruel@chromium.org Review URL: https://codereview.chromium.org/92533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238220 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Nov, 2013 1 commit
-
-
ukai@chromium.org authored
BUG=maruel@chromium.org,szager@chromium.org Review URL: https://codereview.chromium.org/90763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237657 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2013 1 commit
-
-
ukai@chromium.org authored
Tell download tools/hooks/commit-msg mannually if it looks broken. chrome-internal-reviews.googlesource.com requires authentication to access tools/hooks/commit-msg, and we'll get Google Sign-in page rather than expected shell script. R=szager@chromium.org,maruel@chromium.org,ilevy@chromium.org BUG= Review URL: https://codereview.chromium.org/87173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237454 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Nov, 2013 1 commit
-
-
sbc@chromium.org authored
BUG=321279 Review URL: https://codereview.chromium.org/86133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237110 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2013 1 commit
-
-
pgervais@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/65933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235857 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Oct, 2013 1 commit
-
-
digit@chromium.org authored
Newer versions of clang-format-diff.py now require a -i flag to explicitely apply edits, otherwise they just print a diff, which make "git cl format" a no-op. This patch fixes the issue by probing the script's help text to see if the flag is needed. If it is, it is added automatically. BUG=NONE R=maruel@chromium.org Review URL: https://codereview.chromium.org/44263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231020 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2013 1 commit
-
-
teravest@chromium.org authored
Currently, running "git cl issue 0" in a client prints a confusing error message if there's no issue assigned. This changes the code so that the issue number isn't "unset" if it's not currently set. BUG= Review URL: https://codereview.chromium.org/32193016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@230499 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2013 1 commit
-
-
qsr@chromium.org authored
Review URL: https://codereview.chromium.org/27316002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228926 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Oct, 2013 1 commit
-
-
marq@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/25808003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@226611 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Sep, 2013 1 commit
-
-
tyoshino@chromium.org authored
This prevents private CLs to be automatically CC-ed to public mailing lists unintentionally. Review URL: https://chromiumcodereview.appspot.com/24257014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225925 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Sep, 2013 1 commit
-
-
adam.treat@samsung.com authored
I have clang-format-3.3 installed and it appears to default to stripping one leading slash. BUG=294188 Review URL: https://chromiumcodereview.appspot.com/24217002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225705 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Sep, 2013 1 commit
-
-
sbc@chromium.org authored
This command shows the differences between local branch and the last patch uploaded to rietveld. The idea being that you can see what would be uploaded before you actually upload. This can useful when using 'git cl patch' to move changes between checkouts and working from more than one machine at once. Review URL: https://chromiumcodereview.appspot.com/24276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225552 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Sep, 2013 1 commit
-
-
ikarienator@chromium.org authored
BUG=77248 Review URL: https://chromiumcodereview.appspot.com/12712002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224264 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Sep, 2013 1 commit
-
-
agable@chromium.org authored
R=maruel@chromium.org, thakis@chromium.org BUG=253589 Review URL: https://chromiumcodereview.appspot.com/23072039 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@222801 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Aug, 2013 1 commit
-
-
maruel@chromium.org authored
Update subcommand to support examples, always disable format_description and format_epilog and add colors when enabled. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/22824018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@218180 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Aug, 2013 1 commit
-
-
maruel@chromium.org authored
Use the code in git_cl.py, since it was the more evolved. Add documentation and clean up the structure along the way. This makes it possible to easily reuse the generic subcommand handling code. As a first step, only git_cl.py is using it. Eventually, gclient and gcl could be switch over. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23250002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@218072 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Aug, 2013 1 commit
-
-
agable@chromium.org authored
Having "Description: u'Foo\nBUG=1234\nR=bar@chromium.org\nReview Url: baz'" is not actually that useful in my experience. I'd rather be able to easily read the final CL description that is being committed. Review URL: https://chromiumcodereview.appspot.com/23185006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@217834 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2013 1 commit
-
-
ilevy@chromium.org authored
Rietveld rejects tryjobs from non-latest patchsets anyway, change logic to always use latest patchset. R=iannucci@chromium.org Review URL: https://chromiumcodereview.appspot.com/22415012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@216023 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Aug, 2013 1 commit
-
-
mdempsky@google.com authored
BUG= Review URL: https://chromiumcodereview.appspot.com/22308002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@215724 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jul, 2013 1 commit
-
-
maruel@chromium.org authored
upload.py returns them as string, eventually leading to a crash. R=iannucci@chromium.org BUG=265546 Review URL: https://chromiumcodereview.appspot.com/21020008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214247 0039d316-1c4b-4281-b951-d872f2087c98
-