Commits · 61bf6e8d69c4cb084b1541a996fc3f4990cd2535 · Linshizhi / Chromium_Depot_tools

23 Apr, 2021 1 commit

Add support for running PRESUBMIT.py checks under Python2 or 3. · 61bf6e8d

Dirk Pranke authored Apr 23, 2021

This CL adds support for running PRESUBMIT.py under either Python2
or Python3 as specified in each PRESUBMIT.py file.

To run the checks under Python3, the PRESUBMIT.py file must contain
a line exactly matching "^USE_PYTHON3 = True$". If the file
does not contain this string, the checks will run under Python2.

Different PRESUBMIT.py files in a single CL may thus contain
a mix of 2- and 3-compatible checks, but each individual file will
only be run in one or the other (it doesn't likely make sense to run
them in both by default).

Bug: 1157663
Change-Id: Ic74977941a6519388089328b6e1dfba2e885924b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2832654
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

61bf6e8d

22 Apr, 2021 1 commit

recipes: Specify refs/heads/master instead of origin/master for gclient config. · 3600164d

Edward Lesmes authored Apr 22, 2021

Bug: 1200657
Change-Id: I9362a66d12d75d26e1236f9d8516b03561fb9383
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837689
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3600164d

21 Apr, 2021 4 commits

Update cpython3 package to the latest 3.8 build for bleeding-edge. · 447e0b72

Brian Ryner authored Apr 21, 2021

This is a prerequisite to enabling the native Mac ARM64 cpython3,
since we don't have that package built at the old 3.8.0 version.

Bug: 1184767
Change-Id: I68a7de836f9fae25ecbb2fc84aff389a24c32e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842053Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>

447e0b72

non-win: Make goma_ctl use vanilla python · 03bd99c6

Nico Weber authored Apr 21, 2021

This was switched from python to vpython in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721
for a Windows module. Since vpython doesn't yet work on arm macs, switch
this back to vanilla python on non-win for now.

Bug: 1103236
Change-Id: Id083ad88d8474e283fb9f48d91e343b66aa67e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842346
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

03bd99c6

Update lucicfg v1.23.3 -> v1.23.6 · bc1f5c75

Weiwei Lin authored Apr 21, 2021

The most notable change is to add support for configuring test
presentation.

Change list:
 * https://crrev.com/c/2788979
 * https://crrev.com/c/2794800
 * https://crrev.com/c/2830173

R=tandrii, vadimsh

Change-Id: Ic38099e4748783699dcc9579cd7aa9d94918c2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842052
Auto-Submit: Weiwei Lin <weiweilin@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

bc1f5c75

Roll recipe dependencies (trivial). · ba7007f5

recipe-roller authored Apr 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d8993f4684839b58f5f966dd6273d1d8fd001eae
  d8993f4 (weiweilin@google.com)
      [recipe] Update test presentation config to match lucicfg imple...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4975618c9153b37a8139a6ab49822bd2b1988afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842550
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ba7007f5

20 Apr, 2021 5 commits

Reland "git-cache: Add option to fetch commits." · 07a68343

Edward Lesmes authored Apr 20, 2021

This is a reland of 4c67f856
Issues should have been fixed by crrev.com/c/2838026

Original change's description:
> git-cache: Add option to fetch commits.
>
> Add option to git cache to fetch commits.
> And use it in bot_update and gclient sync to make sure
> the needed commits are present on the checkout.
>
> Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: Ie5a29737f5a75d28bc7c5c2f6cb99ec7f87cd9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2841046Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

07a68343

update led · ce8bb16e

Takuto Ikuta authored Apr 20, 2021

This is to have the latest version of underlying library.

Bug: 1200494
Change-Id: I43f1628280e75b94b21c2c6a399f55a12970252c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2838848
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

ce8bb16e

gclient: Map origin/foo to refs/remotes/origin/foo · 4ea67bbd

Edward Lesmes authored Apr 20, 2021

Bug: 1200657
Change-Id: Ib719b984a71cd944bbccf3ec7065aaa17f60e638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2838026Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4ea67bbd

Revert "git-cache: Add option to fetch commits." · 93d80d86

Edward Lesmes authored Apr 20, 2021

This reverts commit 4c67f856.

Reason for revert: crbug.com/1200657

Original change's description:
> git-cache: Add option to fetch commits.
>
> Add option to git cache to fetch commits.
> And use it in bot_update and gclient sync to make sure
> the needed commits are present on the checkout.
>
> Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I31a1defb26119bcb46894ab4084d626b65c45fed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837413
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

93d80d86

Switch download_from_google_storage to py3 · bc8802fd

Linkun Chen authored Apr 20, 2021

Bug: 1199969
Change-Id: I5dcc5fc631cc417fd295d753171f3696f1c7ad0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837688Reviewed-by: Linkun Chen <lkchen@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Linkun Chen <lkchen@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

bc8802fd

19 Apr, 2021 6 commits

git-cache: Add option to fetch commits. · 4c67f856

Edward Lesmes authored Apr 19, 2021

Add option to git cache to fetch commits.
And use it in bot_update and gclient sync to make sure
the needed commits are present on the checkout.

Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4c67f856

repo: update to v2.14 · 496b2258

Mike Frysinger authored Apr 19, 2021

Change-Id: I60ed3a0c67d6dbc5c06afde928b7138d0837e8ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837647
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Stephane Belmon <sbelmon@google.com>

496b2258

Reland "Reland "Remove ANGLE recipe config."" · b8848852

Jamie Madill authored Apr 19, 2021

This is a reland of 75271a07

Should be safe to re-land now, as the roller will catch the
build error. Then we can re-land in conjunction with the
change to rename the angle gclient config.

Original change's description:
> Reland "Remove ANGLE recipe config."
>
> This is a reland of b8686d26
> Must land after https://crrev.com/c/2831999
>
> Original change's description:
> > Remove ANGLE recipe config.
> >
> > This config is now located in the ANGLE recipe_module.
> >
> > Bug: angleproject:5114
> > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> > Auto-Submit: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: angleproject:5114
> Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5114
Change-Id: I85c3d6218b790ef62b19c62eb42ec9a8622d613f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836327
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

b8848852

Revert "Reland "Remove ANGLE recipe config."" · 980c1abc

Garrett Beaty authored Apr 19, 2021

This reverts commit 75271a07.

Reason for revert: breaks CQ for chromium/tools/build 

Original change's description:
> Reland "Remove ANGLE recipe config."
>
> This is a reland of b8686d26
> Must land after https://crrev.com/c/2831999
>
> Original change's description:
> > Remove ANGLE recipe config.
> >
> > This config is now located in the ANGLE recipe_module.
> >
> > Bug: angleproject:5114
> > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> > Auto-Submit: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: angleproject:5114
> Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5114
Change-Id: I8dc93e365f8f0615207050a306350461082efafa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836638
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

980c1abc

Switch gsutil.py to py3 · fb12b3f3

Josip Sokcevic authored Apr 19, 2021

R=ehmaldonado@chromium.org

Bug: 1199969
Change-Id: If05401f3f6c5c8e302220a52c4c237be0f721da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836346Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

fb12b3f3

Reland "Remove ANGLE recipe config." · 75271a07

Jamie Madill authored Apr 19, 2021

This is a reland of b8686d26
Must land after https://crrev.com/c/2831999

Original change's description:
> Remove ANGLE recipe config.
>
> This config is now located in the ANGLE recipe_module.
>
> Bug: angleproject:5114
> Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: angleproject:5114
Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

75271a07

16 Apr, 2021 4 commits

Change whitespace. · efd29f6f

Edward Lesmes authored Apr 16, 2021

Change-Id: Ib731a761674d7ee7db4d67f197611f7d1f8b2f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829987
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

efd29f6f

repo: restore fstrings for Python 3.6 · 3d7cc837

Mike Frysinger authored Apr 16, 2021

We're looking at dropping Python 3.5 support from repo. Lets roll
this back out in Chromium a little early to get a better idea of
who is still relying on it.

Change-Id: Idcdd5b0a957f5a2f8b146149c407c26347be0aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830590Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

3d7cc837

Roll out new goma client binary VERSION=218 · f959d170

Fumitoshi Ukai authored Apr 16, 2021

Bug: 1182961, b/185198549, b/180579630,
Change-Id: If4aaffe3ec17745cd1a2d36a563b4c25176e9883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830398Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

f959d170

Revert "Remove ANGLE recipe config." · 9ceff715

Jamie Madill authored Apr 16, 2021

This reverts commit b8686d26.

Reason for revert: Breaks presubmit bot.
https://ci.chromium.org/ui/p/angle/builders/try/presubmit/20928/overview

Original change's description:
> Remove ANGLE recipe config.
>
> This config is now located in the ANGLE recipe_module.
>
> Bug: angleproject:5114
> Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: angleproject:5114
Change-Id: Ifcf762d5a9e2c57a2ac5963b765042534bc9769f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830370
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

9ceff715

15 Apr, 2021 6 commits

[git-cl] Add option to git-cl upload to prohibit changeid manipulation. · 48d9e1e5

Gregory Nisbet authored Apr 15, 2021

I recently encountered an error where I forgot to add a changeid locally to
some-but-not-all commits in a stack of commits. When attempting to upload
these commits via `git cl upload --no-squash`, I received a confusing message
instructing me to install the Gerrit commit-msg hook even after the hook was
installed. In order to debug this problem locally, I added the ability to
prevent `git cl upload ...` from attempting to change the contents of
messages. If the --no-add-changeid flag is passed, then the command will
simply fail quasi-informatively.

BUG=None
TEST=attempted to upload this CL via `git cl upload --no-squash --no-add-changeid`, confirm that it fails.

Change-Id: Id5f721c18143448db801095946f490880bb61786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828775Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>

48d9e1e5

bot_update: Fetch required commit/refs directly. · 1dbd65b1

Edward Lesmes authored Apr 15, 2021

Change-Id: Ie6bee1743859df364025350fc1a607f331346bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825426Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1dbd65b1

Revert "Remove TAGS_REFSPEC if no_fetch_tags is true" · 784f5c89

Josip Sokcevic authored Apr 15, 2021

This reverts commit 9a94a95e.

Reason for revert: crbug/1199445

Original change's description:
> Remove TAGS_REFSPEC if no_fetch_tags is true
>
> Bug: 1188627
> Change-Id: I6ee14ee9976b9aab60ce409ddd17f018ad966055
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2797933
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 1188627, 1199445
Change-Id: I776639709221d8e0505315c451f847d6cf592b62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828772
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

784f5c89

Roll recipe dependencies (trivial). · 449467a1

recipe-roller authored Apr 15, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/91d88f5f33de9779cc396cfe0e8d17edb078a8ab
  91d88f5 (iannucci@chromium.org)
      [led] Default to RBE-CAS, add helper for rbh value.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie182491703dd1dc52e789aba2a154e0a2d53574a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828771
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

449467a1

Remove ANGLE recipe config. · b8686d26

Jamie Madill authored Apr 15, 2021

This config is now located in the ANGLE recipe_module.

Bug: angleproject:5114
Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

b8686d26

Fix "expr: syntax error" on macOS · 5506fbfb

Sylvain Defresne authored Apr 15, 2021

The version of expr shipped on macOS does not support `substr`
command and prints `expr: syntax error`. Change the invocation
of `expr` to use the `:` operator which match rhs regexp into
lhs string and return the length of the match.

This should be supported by all versions of `expr` that are
POSIX compliant.

Bug: 1199260
Change-Id: Ib932702fedbbbc772d65086ebc371dc0a9023c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827931Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

5506fbfb

14 Apr, 2021 7 commits

Revert "Switch download_from_google_storage scripts to invoke python3." · b1cc5ed9

Dirk Pranke authored Apr 14, 2021

This reverts commit f6e3b7fb.

Reason for revert: See https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/665976/overview - looks like the bots don't have depot_tools populated :(.

Original change's description:
> Switch download_from_google_storage scripts to invoke python3.
>
> Bug: 941669
> Change-Id: I65a9ca3453858c447f6533d9a3a4eade4a825aa7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825441
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>

Bug: 941669
Change-Id: I69856a8c68394ac42126ac68b38d68a6c0104872
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827161
Auto-Submit: Dirk Pranke <dpranke@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

b1cc5ed9

Switch download_from_google_storage scripts to invoke python3. · f6e3b7fb

Mirko Bonadei authored Apr 14, 2021

Bug: 941669
Change-Id: I65a9ca3453858c447f6533d9a3a4eade4a825aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825441Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>

f6e3b7fb

autoninja: Invoke python3, or batch file on Win. · 5f16d6dc

Jamie Madill authored Apr 14, 2021

Bug: 941669
Change-Id: I7f196860d87566cdbd2dda99da151124d9ba917f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826237Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f16d6dc

Roll recipe dependencies (trivial). · d548d5a9

recipe-roller authored Apr 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/bbbf2ecbd0d4f1623b1e3e9f2d4372cda30c4670
  bbbf2ec (olivernewman@google.com)
      [tricium] Fix pylint analyzer executable name

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4f9b1505d0dfce4289bed1d327ff996dc3281745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827152
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d548d5a9

Switch gn wrapper scripts to invoke python3. · ea4e399c

Mirko Bonadei authored Apr 14, 2021

Bug: 941669
Change-Id: I515459793f2a406a959c361f9884b183e21ebdf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825439Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>

ea4e399c

[vpython] Update to 58604ec32e265 · 3cee7aff

Owen Rodley authored Apr 14, 2021

This contains two CLs of interest:
* https://crrev.com/c/2807199, which strips the 'm' ABI tag and fixes
  https://crbug.com/1187476
* https://crrev.com/c/2820342, which generalises the Python 3 tag logic
  to more than just 3.8

Bug: 1187476,1176014
Change-Id: I2138e9a7b2147c8c72cb99daa08642919a30708c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823254
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

3cee7aff

Roll recipe dependencies (trivial). · f9d141ab

recipe-roller authored Apr 14, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7c1ba3120b3633136efcb655aa4755008eec52c3
  7c1ba31 (weiweilin@google.com)
      [recipe] support configuring test presentation in MiloApi.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22f39bf7f8d263fc3704c55e1a864dd339fc5308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2824176
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f9d141ab

13 Apr, 2021 3 commits

Increase bot_update http low speed time · 3d9cab4f

Josip Sokcevic authored Apr 13, 2021

Windows builders have issues fetching from chromium/src, and increasing
timeout may help - recommended by git team.

Bug: 1198581
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: build
Change-Id: Ic650dea2a175e9642a6d3d5b8f1c54fa9979e12a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823020
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3d9cab4f

Run yapf with vpython3 · d73d069a

Josip Sokcevic authored Apr 13, 2021

R=ehmaldonado@chromium.org

Bug: 1197346
Change-Id: Ifc56ff316954eaa3c532b212371de57f8884ff97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2822446Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d73d069a

Roll out new goma client binary VERSION=217 · 99559360

Fumitoshi Ukai authored Apr 13, 2021

disable ATS on Windows by default.
fix http_proxy in mac-arm64

Bug: b/184911357, b/183118231, b/183895446
Change-Id: I88fcfa6cbbb49a104525e9b9612a1a8790f4d6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823397Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

99559360

10 Apr, 2021 1 commit

Recipe: Add timeout for fetching gerrit commit message in tryserver API · 057831ef

Haiyang Pan authored Apr 10, 2021

In crbug.com/1196159, a build got stuck at "gerrit changes" step for 3
hours. It would be good to add a timeout so that it fails early.

Also adjust the timeout for get_changes to 60s, from 600s

Bug: 1196159
Change-Id: Id2327ab40dd2fd8d95aaad6bb724f7ed06e6c244
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811899
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

057831ef

09 Apr, 2021 2 commits

[led] Update led. · b2c07b23

Robert Iannucci authored Apr 09, 2021

This picks up a change to make 'debug sleep' work on luciexe jobs.

R=yiwzhang

Bug: 1197300
Change-Id: Iea7a061e84f7011b6a7f1cc64cca34b0267b6ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2818885
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>

b2c07b23

[dirmd] roll dirmd · 5d9af919

Chan Li authored Apr 09, 2021

To include https://chromium-review.googlesource.com/c/infra/infra/+/2815945

Change-Id: I74dcb46948700b02bffb867fd1ff51baa3979d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2818896
Auto-Submit: Chan Li <chanli@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

5d9af919