- 23 Dec, 2015 1 commit
-
-
bratell@opera.com authored
R=dpranke@chromium.org,tandrii@chromium.org BUG= Review URL: https://codereview.chromium.org/1545913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298097 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Dec, 2015 1 commit
-
-
bratell@opera.com authored
If the stderr buffer used in git diff became full before stdout was completely consumed, git cl upload would deadlock. This also sets GIT_PAGER to be perfectly sure no pager is triggered by the git commands run. I haven't seen that as a problem but it's a reasonable (and common) precaution. BUG=558726 Review URL: https://codereview.chromium.org/1544813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298090 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Dec, 2015 2 commits
-
-
sergiyb@chromium.org authored
R=tandrii@chromium.org BUG=564557 Review URL: https://codereview.chromium.org/1534813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298053 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
BUG= TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1533853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298052 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Dec, 2015 1 commit
-
-
machenbach@chromium.org authored
BUG=chromium:561530 Review URL: https://codereview.chromium.org/1490473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297753 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2015 2 commits
-
-
tandrii@chromium.org authored
R=sergiyb@chromium.org BUG= Review URL: https://codereview.chromium.org/1479983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297729 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
R=akuegel@chromium.org BUG=562427 Review URL: https://codereview.chromium.org/1475033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2015 3 commits
-
-
sergiyb@chromium.org authored
Original CL: https://codereview.chromium.org/1437483002/. R=dnj@google.com, tandrii@chromium.org, dnj@chromium.org, pgervais@chromium.org BUG=542922, 503067 Review URL: https://codereview.chromium.org/1407953011 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297494 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@google.com authored
Revert of Removed virtualenv from depot_tools (patchset #1 id:1 of https://codereview.chromium.org/1437483002/ ) Reason for revert: This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this. update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems. I'm reverting to restore the toolchain so we can create new Windows bots. Original issue's description: > Removed virtualenv from depot_tools > > This effectively reverts http://crrev.com/1195423002 and > http://crrev.com/1205873002. > > R=pgervais@chromium.org, tandrii@chromium.org > TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) > BUG=542922,503067 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491 TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542922,503067 Review URL: https://codereview.chromium.org/1431173002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
This effectively reverts http://crrev.com/1195423002 and http://crrev.com/1205873002. R=pgervais@chromium.org, tandrii@chromium.org TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) BUG=542922,503067 Review URL: https://codereview.chromium.org/1437483002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Oct, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=akuegel@chromium.org Review URL: https://codereview.chromium.org/1412393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297201 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Oct, 2015 1 commit
-
-
stip@chromium.org authored
Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ ) Reason for revert: Outage is now over Original issue's description: > Temporary fix for codereview cert issue. > > BUG=537763 > R=stip@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 TBR=tandrii@google.com,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537763 Review URL: https://codereview.chromium.org/1374223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Sep, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=537763 R=stip@chromium.org Review URL: https://codereview.chromium.org/1376333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Sep, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org, rmistry@chromium.org Review URL: https://codereview.chromium.org/1309393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296530 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Aug, 2015 1 commit
-
-
petermayo@chromium.org authored
This issue is cloned from https://codereview.chromium.org/1273083004/ for andreyu BUG=chromium:517460 R=vapier@chromium.org Review URL: https://codereview.chromium.org/1281273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296285 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jul, 2015 1 commit
-
-
iannucci@chromium.org authored
* make RunTest's multiprocessing.Pool in the constructor of InputApi to avoid getting tripped up by chdir manipulation. * Don't do the split cyclic-import check when the invoker of the Pylint presubmit checks explicitly sends cyclic import check parameters via extra_args * fix pseudobug where ownership of the files variable was unclear, and pass all arguments on stdin (instead of mix of CLI + stdin). * fix bug in pylint which caused it to manipulate sys.path before spawning its subprocesses, which caused multiprocessing to fail on windows. * Note: This may carry a slight semantic change. Before, pylint would add all .py files' directories to sys.path while checking any of them. Now in parallel mode, pylint will only add the path of the single file to sys.path. This behavior actually mirrors Python's own behavior, so the check should be more-correct than before (and should cut down on pylint import scanning time with very large sys.path's). * If someone encounters an issue with this, please note that the GetPylint check also includes an extra_paths_list which is expressly for this purpose. R=dpranke@chromium.org, kbr@chromium.org, maruel@chromium.org BUG=501012 Review URL: https://codereview.chromium.org/1208743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org BUG=503067 Review URL: https://codereview.chromium.org/1195423002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295843 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=akuegel@chromium.org, pgervais@chromium.org BUG=472612, 503068 Review URL: https://codereview.chromium.org/1200863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295818 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 1 commit
-
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
TBR=pgervais@chromium.org R=akuegel@chromium.org, tandrii@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1183363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295718 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jun, 2015 1 commit
-
-
sheyang@chromium.org authored
BUG=457428 Review URL: https://codereview.chromium.org/1177953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295680 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2015 2 commits
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org Review URL: https://codereview.chromium.org/1162993005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295512 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
This introduces changes from https://chromereviews.googleplex.com/206957013/. R=akuegel@chromium.org TBR=pgervais@chromium.org BUG=471767 Review URL: https://codereview.chromium.org/1156373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295506 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
This allows to avoid conflicts with libraries in users' PATH R=pgervais@chromium.org, tandrii@chromium.org Review URL: https://codereview.chromium.org/1161803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295497 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 May, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=pgervais@chromium.org Review URL: https://codereview.chromium.org/1153333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295461 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Apr, 2015 1 commit
-
-
sheyang@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/1091163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294877 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Apr, 2015 2 commits
-
-
akuegel@chromium.org authored
Revert of Upgrade 3rd packages (patchset #4 id:60001 of https://codereview.chromium.org/1085893002/) Reason for revert: This might have broken some internal tryserver bots. Original issue's description: > Upgrade 3rd packages > > BUG=461614 > R=nodir@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294835 TBR=nodir@chromium.org,sheyang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461614 Review URL: https://codereview.chromium.org/1094533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294841 0039d316-1c4b-4281-b951-d872f2087c98
-
sheyang@google.com authored
BUG=461614 R=nodir@chromium.org Review URL: https://codereview.chromium.org/1085893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294835 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
Internal Rietveld exposes OAuth2 compatible API via /bots/* endpoints, not via /* as public one does. See crbug.com/476690. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1082033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
This CL introduces new top level command for managing cached auth tokens: $ depot-tools-auth login codereview.chromium.org $ depot-tools-auth info codereview.chromium.org $ depot-tools-auth logout codereview.chromium.org All scripts that use rietveld.Rietveld internally should be able to use cached credentials created by 'depot-tools-auth' subcommand. Also 'depot-tools-auth' is the only way to run login flow. If some scripts stumbles over expired or revoked token, it dies with the error, asking user to run 'depot-tools-auth login <hostname>'. Password login is still default. OAuth2 can be enabled by passing --oauth2 to all scripts. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1074673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294764 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Apr, 2015 1 commit
-
-
dnj@chromium.org authored
Use 'realpath' instead of 'abspath' for self-discovery. This fixes an issue where 'gsutil' cannot find its dependencies when it is referenced through a symbolic link. Specifically, the symlink was: /b/scripts => /b/build/scripts 'gsutil' was called as: /b/scripts/slave/../../../depot_tools/third_party/gsutil/gsutil Because '/b/scripts/slave' resolves to '/b/build/scripts/slave', the three parent directory operators actually resolve to '/b', but 'os.path.abspath' blindly resolves them to '/'. BUG=chromium:474442 TEST=live - Signed onto failing bot, made this change, 'gsutil' works. R=hinoka@chromium.org Review URL: https://codereview.chromium.org/1060353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294712 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2015 5 commits
-
-
dnj@chromium.org authored
BUG=chromium:356813 TEST=local - Actually failed login, watched error message get printed. Review URL: https://codereview.chromium.org/1063143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294705 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@google.com authored
BUG=chromium:356813 TEST=None R=vadimsh@chromium.org, stip@chromium.org Review URL: https://codereview.chromium.org/1060633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294704 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@chromium.org authored
BUG=chromium:356813 TEST=local - Deleted cookies file, ran without patch, 404. - Deleted cookies file, ran on internal network, works! Review URL: https://codereview.chromium.org/1068973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294701 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
The corresponding Rietveld change is here: https://codereview.chromium.org/1054683003/ BUG=chromium:472690 Review URL: https://codereview.chromium.org/1053653004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294699 0039d316-1c4b-4281-b951-d872f2087c98
-
sheyang@google.com authored
BUG=356813 R=nodir@chromium.org, vadimsh@chromium.org Review URL: https://codereview.chromium.org/963953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294698 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jan, 2015 1 commit
-
-
vapier@chromium.org authored
This is largely a bugfix release, so should be much easier to transition. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/876793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293806 0039d316-1c4b-4281-b951-d872f2087c98
-