Commits · 5f2a196ca67bb4a72aa89b0676058b475cb32a8c · Linshizhi / Chromium_Depot_tools

10 Sep, 2010 7 commits

Change the way to detect build slave. · 5f2a196c

maruel@chromium.org authored Sep 10, 2010

It seems sys.stdout.isatty() is not a good signal on the build slaves.

TBR=bradnelson
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3342028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59131 0039d316-1c4b-4281-b951-d872f2087c98

5f2a196c

Add a cheap trick to disable parallel sync on the buildbot until they are fixed. · e75e8e68

maruel@chromium.org authored Sep 10, 2010

This way engineers can still enjoy the perf benefit while someone fixes the
buildbot stdio parsing issue.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3334017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59127 0039d316-1c4b-4281-b951-d872f2087c98

e75e8e68

Revert parallel checkout as the default. · 0d2bf39c

maruel@chromium.org authored Sep 10, 2010

This is because buildbot can't parse gclient output with parallel checkout,
causing got_revision to not be set, causing some scripts to fail.

TBR=bradnelson
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3325023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59121 0039d316-1c4b-4281-b951-d872f2087c98

0d2bf39c

Enable parallel checkout by default to --jobs=8 and smoke tests. · 3b84d4c9

maruel@chromium.org authored Sep 10, 2010

BUG=54084
TEST=updated smoke test and added a new one + stdout untangling

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59002

Review URL: http://codereview.chromium.org/3357020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59116 0039d316-1c4b-4281-b951-d872f2087c98

3b84d4c9

Rewrite chrome-update.py and .bat. · c989674f

maruel@chromium.org authored Sep 10, 2010

Now reuse compile.py and almost make them platform agnostic.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/306031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59108 0039d316-1c4b-4281-b951-d872f2087c98

c989674f

Add pylint to presubmit checks. · fa410372

maruel@chromium.org authored Sep 10, 2010

This tool has been quite useful noticing errors in the past and I'd have avoided a breakage in r58936 if I had run it.

Had to fix a few scripts first.

BUG=none
TEST=new test

Review URL: http://codereview.chromium.org/3337018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59107 0039d316-1c4b-4281-b951-d872f2087c98

fa410372

Automatically disable progress for non tty output, i.e. when it's redirected. · 5b3f8851

maruel@chromium.org authored Sep 10, 2010

Otherwise, a VT100 terminal will soon be assumed.

TEST=touch foo.txt; gclient sync >> foo.txt &; tail -F foo.txt doesn't show progress.
BUG=none

Review URL: http://codereview.chromium.org/3310026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59101 0039d316-1c4b-4281-b951-d872f2087c98

5b3f8851

09 Sep, 2010 9 commits

Enable parallel checkout by default to --jobs=8 and smoke tests. · acc45671

maruel@chromium.org authored Sep 09, 2010

BUG=54084
TEST=updated smoke test and added a new one + stdout untangling

Review URL: http://codereview.chromium.org/3357020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59002 0039d316-1c4b-4281-b951-d872f2087c98

acc45671

Enable annotated output for --jobs N!=1. · cb1e97a1

maruel@chromium.org authored Sep 09, 2010

TEST=none
BUG=54084

Review URL: http://codereview.chromium.org/3347019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58985 0039d316-1c4b-4281-b951-d872f2087c98

cb1e97a1

Add some doc to breakpad.py and add support for NO_BREAKPAD environment variable. · fa877020

maruel@chromium.org authored Sep 09, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3311023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58982 0039d316-1c4b-4281-b951-d872f2087c98

fa877020

Add a check when people specify wrong change list name to give a meaningful message. · c8f3cf80

maruel@chromium.org authored Sep 09, 2010

I saw that in the exceptions and the current error (file not found) is not useful.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3332017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58978 0039d316-1c4b-4281-b951-d872f2087c98

c8f3cf80

Add the infrastructure necessary to support annotated stdout. · 3742c845

maruel@chromium.org authored Sep 09, 2010

Simplify ExecutionQueue.run() by moving code into utility functions.

Reduce the amount of code in WorkerThread.run() to improve reliability.

Don't trap exceptions in single-threaded usage!

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3336015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58974 0039d316-1c4b-4281-b951-d872f2087c98

3742c845

Fix git-try, was broken by r58936. · 24b74202

maruel@chromium.org authored Sep 09, 2010

TBR=bradnelson
TEST=git-try works
BUG=54084

Review URL: http://codereview.chromium.org/3311021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58941 0039d316-1c4b-4281-b951-d872f2087c98

24b74202

Simplify GIT.Capture() code to always redirect stderr by default and always... · ad80e3b9

maruel@chromium.org authored Sep 09, 2010

Simplify GIT.Capture() code to always redirect stderr by default and always throw an exception on failure.

Make gclient_scm_test silent.

Replace raise Exception() with raise gclient_utils.Error().

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3353018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58936 0039d316-1c4b-4281-b951-d872f2087c98

ad80e3b9

Improve tests and remove some unused GIT test. · 389d6dea

maruel@chromium.org authored Sep 09, 2010

This is needed to improve the git tests further in a later change.

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3294017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58934 0039d316-1c4b-4281-b951-d872f2087c98

389d6dea

Change scm.SVN.Capture to redirect stderr and throw an exception on call failure. · 54019f3c

maruel@chromium.org authored Sep 09, 2010

Added try/except to the places where errors are tolerated.

Renamed scm.SVN.CaptureBaseRevision to CaptureRevision and removed CaptureHeadRevision.

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3307016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58932 0039d316-1c4b-4281-b951-d872f2087c98

54019f3c

08 Sep, 2010 5 commits

Update branch path-finding regex to work directly with WebKit repository. · 7aae8fb1

dglazkov@chromium.org authored Sep 08, 2010

R=laforge
TEST=use drover.py with WebKit repo -- it should work!
BUG=none

Review URL: http://codereview.chromium.org/3368007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58844 0039d316-1c4b-4281-b951-d872f2087c98

7aae8fb1

Enter a description of the change. · 9c53126d

maruel@chromium.org authored Sep 08, 2010

Add back support for python 2.4.

Looks like a few slaves haven't been updated yet.

TBR=bradnelson
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3338017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58820 0039d316-1c4b-4281-b951-d872f2087c98

9c53126d

Add automatic auto-flushing stdout. · db111f71

maruel@chromium.org authored Sep 08, 2010

An automated work around for python lack of stdout flushing.
This design simplifies life once parallel checkout is enabled.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3342024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58819 0039d316-1c4b-4281-b951-d872f2087c98

db111f71

Fix small nits. · 6985efce

maruel@chromium.org authored Sep 08, 2010

pylint is useful to catch errors before they go live so fix little annoyances.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3372001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58817 0039d316-1c4b-4281-b951-d872f2087c98

6985efce

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 20760a54

jochen@chromium.org authored Sep 08, 2010

BUG=54238
TEST=gclient_smoketest.py
Review URL: http://codereview.chromium.org/3342020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58800 0039d316-1c4b-4281-b951-d872f2087c98

20760a54

07 Sep, 2010 4 commits

Improve exception handling. · 7b194c1a

maruel@chromium.org authored Sep 07, 2010

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3320012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58756 0039d316-1c4b-4281-b951-d872f2087c98

7b194c1a

Add options argument to _Run() to redirect output. · 37e89873

maruel@chromium.org authored Sep 07, 2010

Add automatic 'header' on command execution

BUG=54084
TEST=none

Review URL: http://codereview.chromium.org/3319008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58700 0039d316-1c4b-4281-b951-d872f2087c98

37e89873

Rename retcode to returncode to be consistent with subprocess. · 66c83e68

maruel@chromium.org authored Sep 07, 2010

Change CheckCallError to inherit from Error. This will simplify try/except changes.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3324007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58695 0039d316-1c4b-4281-b951-d872f2087c98

66c83e68

Split _Run() in two to make redirection simpler in a later change. · 6cafa13a

maruel@chromium.org authored Sep 07, 2010

Simplify GitWrapper._Run() and move logging at the right place.

TEST=none
BUG=54084

Review URL: http://codereview.chromium.org/3358015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58694 0039d316-1c4b-4281-b951-d872f2087c98

6cafa13a

03 Sep, 2010 3 commits

Remove kwargs copy, it is not necessary. Remove ordered argument support from popen to simplify it. · a1693bef

maruel@chromium.org authored Sep 03, 2010

Move logging call to the base function.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3300008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58523 0039d316-1c4b-4281-b951-d872f2087c98

a1693bef

Replace a few os.path.join() calls to use self.checkout_path instead. · 8469bf93

maruel@chromium.org authored Sep 03, 2010

Fix SVN pack.

TEST=smoke tests
BUG=none

Review URL: http://codereview.chromium.org/3309005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58519 0039d316-1c4b-4281-b951-d872f2087c98

8469bf93

gclient: exponential backoff of SCM commands on known failure types. · 2aee2298

cbentzel@chromium.org authored Sep 03, 2010

This starts at 5 seconds (used to be 15) and goes up to ~60 seconds on the tenth round.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3326004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58488 0039d316-1c4b-4281-b951-d872f2087c98

2aee2298

02 Sep, 2010 7 commits

Revert "Do not blindly assume that a .gclient file in a parent directory belongsto the cu..." · 15804091

maruel@chromium.org authored Sep 02, 2010

This reverts commit 58371

TBR=jochen
BUG=
TEST=

Review URL: http://codereview.chromium.org/3357005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58372 0039d316-1c4b-4281-b951-d872f2087c98

15804091

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 2509f866

jochen@chromium.org authored Sep 02, 2010

BUG=54238
TEST=GClientSmoke.testWrongConfig

Review URL: http://codereview.chromium.org/3300007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58371 0039d316-1c4b-4281-b951-d872f2087c98

2509f866

Revert "Do not blindly assume that a .gclient file in a parent directory belongs to the cur..." · d765d9c8

maruel@chromium.org authored Sep 02, 2010

This reverts commit 58352.

TBR=jochen
BUG=breaks build bots

Review URL: http://codereview.chromium.org/3334005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58355 0039d316-1c4b-4281-b951-d872f2087c98

d765d9c8

If no description is given, use the log messages of all commits for presubmit checks. · b96b92f6

jochen@chromium.org authored Sep 02, 2010

BUG=54240
TEST=none

Review URL: http://codereview.chromium.org/3345003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58353 0039d316-1c4b-4281-b951-d872f2087c98

b96b92f6

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. · 9806750e

jochen@chromium.org authored Sep 02, 2010

BUG=54238
TEST=GClientSmoke.testWrongConfig

Review URL: http://codereview.chromium.org/3304007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58352 0039d316-1c4b-4281-b951-d872f2087c98

9806750e

Convert all print statements to use options.stdout. · f5d37bf9

maruel@chromium.org authored Sep 02, 2010

Needed to fix a few function calls to make it work.

BUG=54084
TEST=unit tests

Review URL: http://codereview.chromium.org/3303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58287 0039d316-1c4b-4281-b951-d872f2087c98

f5d37bf9

Fix try jobs not within a gclient checkout · 21779a56

maruel@chromium.org authored Sep 02, 2010

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3331004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58286 0039d316-1c4b-4281-b951-d872f2087c98

21779a56

01 Sep, 2010 4 commits

Fix GetCachedFile. · 1736800a

thestig@chromium.org authored Sep 01, 2010

BUG=none
TEST=gcl upload works when there's no codereview.settings in the cache.
Review URL: http://codereview.chromium.org/3366001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58270 0039d316-1c4b-4281-b951-d872f2087c98

1736800a

Remove scm.SVN.Run() and all stdout argument to more calls. · 669600d3

maruel@chromium.org authored Sep 01, 2010

BUG=54084
TEST=unit tests

Review URL: http://codereview.chromium.org/3338003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58214 0039d316-1c4b-4281-b951-d872f2087c98

669600d3

Cleanup the code in gclient_utils to standardize on CheckCall nomenclature. · 17d01795

maruel@chromium.org authored Sep 01, 2010

Simplify code by removing fail_status
Rename print_messages to always
Simplify the doc.

Review URL: http://codereview.chromium.org/3104036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58201 0039d316-1c4b-4281-b951-d872f2087c98

17d01795

Remove --webkit from trychange.py since it never really worked correctly. · 48c4160e

maruel@chromium.org authored Sep 01, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3328002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58200 0039d316-1c4b-4281-b951-d872f2087c98

48c4160e

31 Aug, 2010 1 commit

Don't cache the fact that codereview.settings wasn't found. · b3b494f3

maruel@chromium.org authored Aug 31, 2010

It must always be present.

BUG=none
TBR=none

Review URL: http://codereview.chromium.org/3280013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58060 0039d316-1c4b-4281-b951-d872f2087c98

b3b494f3