BUG=493885
TESTED=See https://paste.googleplex.com/5622248052359168

Review URL: https://codereview.chromium.org/1164363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=497943
R=hinoka@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/1163403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295568 0039d316-1c4b-4281-b951-d872f2087c98

Because some interfaces aren't linkifying the URL when the commit message ends with it.

BUG=480922
TESTED=tests/git_cl_test.py; presubmit ok

Review URL: https://codereview.chromium.org/1165293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295566 0039d316-1c4b-4281-b951-d872f2087c98

Based on yapf (https://github.com/google/yapf) this
formatter currently only works with --full.  It defaults
to pep8 style and projects that use a different style
can add .style.yapf to the top level.

Review URL: https://codereview.chromium.org/1156743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295547 0039d316-1c4b-4281-b951-d872f2087c98

The last remaining failing test is fixed now, so we
should be fine with enabling this trybot for CQ.

BUG=420910

Review URL: https://codereview.chromium.org/1149943010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295540 0039d316-1c4b-4281-b951-d872f2087c98

After changing this to '%f%' instead of just '%' this doesn't
work anymore. It should be '%f%%' instead.

BUG=
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/1156023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295539 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the check for base URL to a query to the json endpoint.
This makes the test pass on the trybot.

BUG=353718

Review URL: https://codereview.chromium.org/1160273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=495944
R=sebmarchand@chromium.org

Review URL: https://codereview.chromium.org/1162003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295527 0039d316-1c4b-4281-b951-d872f2087c98

Based on some fiddling on a local VM (see bug), but possibly still insufficient.

TBR=sebmarchand@chromium.org
BUG=492774, 495944

Review URL: https://codereview.chromium.org/1160683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295521 0039d316-1c4b-4281-b951-d872f2087c98

Since we no longer have a 32-bit Linux GN binary, we shouldn't
try to point to one in the gn.py wrapper; this was hiding a
bug on one of the NaCl bots.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1152163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295520 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/1162993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295512 0039d316-1c4b-4281-b951-d872f2087c98

This must land in sync with https://chromereviews.googleplex.com/202077014 and
revert in sync.

R=akuegel@chromium.org
TBR=pgervais@chromium.org
BUG=471767

Review URL: https://codereview.chromium.org/1157843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295509 0039d316-1c4b-4281-b951-d872f2087c98

This introduces changes from https://chromereviews.googleplex.com/206957013/.

R=akuegel@chromium.org
TBR=pgervais@chromium.org
BUG=471767

Review URL: https://codereview.chromium.org/1156373013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=420910

Review URL: https://codereview.chromium.org/1129153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295504 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
R=sebmarchand@chromium.org,davidben@chromium.org

Review URL: https://codereview.chromium.org/1155973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295498 0039d316-1c4b-4281-b951-d872f2087c98

This allows to avoid conflicts with libraries in users' PATH

R=pgervais@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/1161803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295497 0039d316-1c4b-4281-b951-d872f2087c98

Revert of win: Fix current toolchain path with old packaging (patchset #1 id:1 of https://codereview.chromium.org/1159433006/)

Reason for revert:
Breaking chromium waterfall.

Original issue's description:
> win: Fix current toolchain path with old packaging
> 
> I broke boringssl's use of depot_tools toolchain as I changed the
> name of the sdk path key. This happened to work in Chrome because
> src/ has fallback behaviour.
> 
> Restore the 'win8sdk' name when unpacking a current/old-style
> toolchain package (i.e. what everyone is still using).
> 
> TBR=dpranke@chromium.org
> R=davidben@chromium.org
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295492

TBR=davidben@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1167753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295493 0039d316-1c4b-4281-b951-d872f2087c98

I broke boringssl's use of depot_tools toolchain as I changed the
name of the sdk path key. This happened to work in Chrome because
src/ has fallback behaviour.

Restore the 'win8sdk' name when unpacking a current/old-style
toolchain package (i.e. what everyone is still using).

TBR=dpranke@chromium.org
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/1159433006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295492 0039d316-1c4b-4281-b951-d872f2087c98

When using a raw URL from a different Rietveld instance than the one
in codereview.settings, you get an error like this:

File "depot_tools/git_cl.py", line 2767, in PatchIssue
    RunGit(['commit', '-m', (cl.GetDescription() + '\n\n' +
UnboundLocalError: local variable 'cl' referenced before assignment

This fixes that. It is needed for the WebRTC transition to the
Chromium Rietveld instance using https://codereview.webrtc.org

BUG=webrtc:3884
TESTED=In a WebRTC checkout: ran 'git cl patch https://codereview.webrtc.org/download/issue1135893005_1.diff'
on a clean branch and had it apply correctly.
In a Chromium checkout, ran 'git cl patch 1154023002' and verified
the commit message was correct.
I also ran using the raw URL and verified the result was the same.

Review URL: https://codereview.chromium.org/1166673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295491 0039d316-1c4b-4281-b951-d872f2087c98

Also removed part of the message that encourages users to disable updates to
depot_tools. If the users do not enable updates, it prevents landing changes into
project repositories that depend on having latest version of the depot_tools, e.g.
https://codereview.chromium.org/1152823005/.

R=akuegel@chromium.org
TBR=maruel@chromium.org, iannucci@chromium.org
BUG=475320

Review URL: https://codereview.chromium.org/1162153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295486 0039d316-1c4b-4281-b951-d872f2087c98

This is the other side of https://codereview.chromium.org/1163723003/

The changes here are to remove the use of 'vs2013_files' and 'win8sdk'
(as those will be different numbers soon enough) but still maintain
behaviour for the old "style" while in transition.

Secondarily, to remove the dependence of these two scripts on
'toolchain2013.py' as most of the script is now unused.

R=dpranke@chromium.org
BUG=440500, 492774

Review URL: https://codereview.chromium.org/1165563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295485 0039d316-1c4b-4281-b951-d872f2087c98

Allows the command line itself to be distinguished
from the surrounding error message.

Review URL: https://codereview.chromium.org/1152443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295481 0039d316-1c4b-4281-b951-d872f2087c98

Include links to the tracking bug and to request creating git repositories. Also
include note how to keep subversion support, if users require this.

It won't warn when git-svn clones are used.

There is no functional change except printing a warning to stderr.

Remove stale code. The CHROMIUM_SRC_URL variable is also defined in gclient.py
so it looks like a copy-paste error.

R=iannucci@chromium.org
BUG=475320

Review URL: https://codereview.chromium.org/1154173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295478 0039d316-1c4b-4281-b951-d872f2087c98

This makes for cleaner code and better --help.

Also, handle case when deps directory does not exist.

Review URL: https://codereview.chromium.org/1160833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295475 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to run the presubmit commit checks.
Tested this CL by running git cl presubmit locally.

BUG=420910

Review URL: https://codereview.chromium.org/1156923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295472 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/1154623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295468 0039d316-1c4b-4281-b951-d872f2087c98

Also, unify error handling to use exceptions.

Review URL: https://codereview.chromium.org/1152013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295465 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/1153333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295461 0039d316-1c4b-4281-b951-d872f2087c98

Before this change, the commit message only contains issue number and
patchset number. Adding CL description should be more informative.

Review URL: https://codereview.chromium.org/1128473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295449 0039d316-1c4b-4281-b951-d872f2087c98

It was not very obvious what kind of date format is expected.

Review URL: https://codereview.chromium.org/1114093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295448 0039d316-1c4b-4281-b951-d872f2087c98

I started to build a package for setting up a VS2015 bot, and realized
I didn't really remember how the toolchain setup worked. So I wrote
a readme for this directory.

I see I will live to regret putting way too many "2013"s in various
places in these scripts. :/

R=dpranke@chromium.org
BUG=492774

Review URL: https://codereview.chromium.org/1150033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1160663007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295430 0039d316-1c4b-4281-b951-d872f2087c98

The default encoding for python 2.7 strings is ascii.  Some of
the titles of issues, such as http://crbug.com/477941, contain
non-ascii characters, and cause my_activity.py to throw an
exception.  Re-encode the unicode title string to ascii with
the 'replace' option, to replace non-ascii characters with '?'.

R=maruel@chromium.org
BUG=none
TEST=Run `my_activity.py` with #477941 in my issues list; correctly
     lists issues without throwing an exception.

Review URL: https://codereview.chromium.org/1151053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1091373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295416 0039d316-1c4b-4281-b951-d872f2087c98

This command no longer makes sense here, it should only be used from the chromite bootstrap workflow.

This is basically a revert of cl:896393003

BUG=None

Review URL: https://codereview.chromium.org/1138363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295415 0039d316-1c4b-4281-b951-d872f2087c98

Subversion usage is going away, tests get the kick first.

R=iannucci@chromium.org
BUG=475320

Review URL: https://codereview.chromium.org/1158043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295411 0039d316-1c4b-4281-b951-d872f2087c98

Didn't have any shell=True for git.bat/cmd.

Was able to upload https://codereview.chromium.org/1151373003 after
this CL (though the printed description didn't make it to Rietveld,
not sure if it normally does that.)

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/1151373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295397 0039d316-1c4b-4281-b951-d872f2087c98

TBR=smut@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1150413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295391 0039d316-1c4b-4281-b951-d872f2087c98

It is inspired by src/tools/roll_swarming_client.py but generalized.

R=dpranke@chromium.org, stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1147033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295386 0039d316-1c4b-4281-b951-d872f2087c98

BUG=487172

Review URL: https://codereview.chromium.org/1150663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295375 0039d316-1c4b-4281-b951-d872f2087c98