- 30 Oct, 2015 1 commit
-
-
mmoss@chromium.org authored
Retrying the change in https://codereview.chromium.org/1415993003/, with fixes to properly handle being called with either Windows- or POSIX-style paths (the previous attempt assumed it was always called with POSIX-style paths under MSYS, which itself was attempting to fix the assumption that it was always called with Windows-style paths, but neither assumption was right). This change doesn't actually use the wrapper in any new places, but subsequent changes will be made to use it in places where 'exec python' is called directly, like gclient and fetch. BUG=411518 R=iannucci@google.com, sky@google.com Review URL: https://codereview.chromium.org/1411793006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297401 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Oct, 2015 2 commits
-
-
akuegel@chromium.org authored
Revert of Generalize python_git_runner for use in non-git scripts. (patchset #1 id:1 of https://codereview.chromium.org/1415993003/ ) Reason for revert: Speculative revert in case this caused the bots to fail bot_update. Original issue's description: > Generalize python_git_runner for use in non-git scripts. > > Also fixes an msys (git-bash) incompatibility, similar to the one > fixed in crrev.com/4845f0ed. > > This change doesn't actually use the wrapper in any new places, but > subsequent changes will be made to use it in places where > 'exec python' is called directly, like gclient and fetch. > > BUG=411518 > R=iannucci@google.com > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297357 TBR=iannucci@google.com,iannucci@chromium.org,mmoss@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=411518 Review URL: https://codereview.chromium.org/1414923008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297358 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
Also fixes an msys (git-bash) incompatibility, similar to the one fixed in crrev.com/4845f0ed. This change doesn't actually use the wrapper in any new places, but subsequent changes will be made to use it in places where 'exec python' is called directly, like gclient and fetch. BUG=411518 R=iannucci@google.com Review URL: https://codereview.chromium.org/1415993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297357 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Oct, 2014 1 commit
-
-
agable@chromium.org authored
R=iannucci@chromium.org Review URL: https://codereview.chromium.org/621783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292379 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jul, 2014 1 commit
-
-
dnj@chromium.org authored
Added the 'git-retry' bootstrap command. This can be used to wrap other 'git' commands around a fault-tolerant retry wrapper. BUG=295109 TEST=localtest R=iannucci@chromium.org, petermayo@chromium.org Review URL: https://codereview.chromium.org/401673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285939 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Jun, 2014 1 commit
-
-
r.c.ladan@gmail.com authored
Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. TEST=run "git cl owners" on FreeBSD BUG= Review URL: https://codereview.chromium.org/197213008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274320 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2014 1 commit
-
-
iannucci@chromium.org authored
R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/181043018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2014 1 commit
-
-
iannucci@chromium.org authored
This introduces python_git_runner.sh, and makes git-cl, git-cache, git-number, and git-try use it. R=agable@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/188383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256131 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Feb, 2014 1 commit
-
-
agable@chromium.org authored
The git cache command is a central place to manage a machine's git cache. It provides two subcommands: * populate -- creates or updates the cache of a given repository * exists -- prints the path to the cache of a repo, if it exists Gclient, deps2git, bot_update, and any other tools that touch the cache will be able to use this command to make sure that everyone is interacting with the cache in the same way. R=hinoka@chromium.org, iannucci@chromium.org BUG=339168 Review URL: https://codereview.chromium.org/164823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253007 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2013 1 commit
-
-
iannucci@chromium.org authored
Compatible with any git topology (multiple roots, weird branching/merging, etc.) I can't get it to be any faster (in python). Suggestions welcome :). On z600/linux, this takes 5.1s to calculate the initial count for 2e3de954ef0a (HEAD on src.git at the time of writing). Subsequent lookups take ~0.06s. For reference, this machine takes 3s to just list the revisions in sorted order without any additional processing (using rev-list). All calculations are stored in a git-notes-style ref with the exception that the leaf 'tree' object which would normally be stored in a git-notes world is replaced with a packed binary file which consists of records [hash int]. Each run of this script will create only 1 commit object on this internal ref which will have as its parents: * The previous git number commit * All of the target commits we calculated numbers for. This ref is then excluded on subsequent invocations of rev-list, which means that git-number will only ever process commit objects which it hasn't already calculated a value for. It also prevents you from attempting to number this special ref :). This implementation only has a 1-byte fanout which seems to be the best performance for the repos we're dealing with (i.e. on the order of 500k commit objects). Bumping this up to a 2-byte fanout became extremely slow (I suspect the internal caching structures I'm using are not efficient in this mode and could be improved). Using no fanout is slower than the 1 byte fanout for lookups by about 30%. R=agable@chromium.org, stip@chromium.org, szager@chromium.org BUG=280154,309692,skia:1639 Review URL: https://codereview.chromium.org/26109002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@236035 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Nov, 2013 1 commit
-
-
maruel@chromium.org authored
Using "%@" will correctly requote quoted arguments. Tested with repro case. The fix in r232184 missed the necessary argument quoting. R=iannucci@chromium.org BUG=314192 BUG=241769 Review URL: https://codereview.chromium.org/47873010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Oct, 2013 2 commits
-
-
maruel@chromium.org authored
Tested to work now with the repro case of bug 313552. "/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :( Using //c seems to be passed through properly. There is probably other escaping problem but this should be good enough at this stage. Ref: http://www.mingw.org/wiki/Posix_path_conversion R=iannucci@chromium.org BUG=241769 BUG=313552 Review URL: https://codereview.chromium.org/50143013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232184 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This broke git cl patch due to escaping. I tried removing the double quotes but it didn't work out. Reverting in the meantime to unblock people until I figure out a permanent way. BUG=313552,241769 TBR=iannucci Review URL: https://codereview.chromium.org/50293009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232112 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Oct, 2013 1 commit
-
-
maruel@chromium.org authored
Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore. The previous python wrapping scripts assumed python_bin\python.exe. This CL modifies the wrapping scripts to use python.bat. This requires some quoting magic and explicitly defer to cmd.exe. This may break some cases where double quotes are used as arguments. We can't do miracles on Windows. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/50563008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231888 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Nov, 2012 3 commits
-
-
szager@google.com authored
TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/11364105 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166284 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22: /usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: Not a directory /usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22: exec: /usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: cannot execute: Not a directory TBR=szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11366117 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166274 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@google.com authored
C:\depot_tools\/git-cl But in msys-git-1.8.0 it's: C:\depot_tools\\git-cl Handle either syntax correctly. TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/11359074 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166268 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Feb, 2012 1 commit
-
-
maruel@chromium.org authored
The major use case was for ChromiumOS devs who were using repo. It's not a frequent use case anymore. Having git-cl sync on each invocation is costly. TBR=nsylvain@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9389030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121834 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Since we clobber the .pyc, it's not useful to generate them in the first place. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8060026 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103066 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jun, 2011 1 commit
-
-
cmp@chromium.org authored
This change makes it possible to run 'git cl' from a Command Prompt using only the auto-installed git from depot_tools. It is needed because in MSysGit, 'git cl' invokes 'git' which calls 'git-cl'. While 'git-cl' is pulled from depot_tools (since it's in PATH), depot_tools/python_bin is not in PATH, and so we execute git_cl.py through our auto-installed python.exe directly. update_depot_tools is fixed so that if we find the auto-installed svn and git in depot_tools, we execute those directly, otherwise falling back to calling them based on PATH. In both git-cl and update_depot_tools, we only enable this new behavior if uname in PATH reports a 'MINGW' environment. This should not trigger on any other environment where uname exists, including Cygwin which should report 'CYGWIN'. Review URL: http://codereview.chromium.org/7020035 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87510 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 May, 2011 1 commit
-
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/7008006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86552 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 May, 2011 1 commit
-
-
cmp@chromium.org authored
Review URL: http://codereview.chromium.org/7055025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86501 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Remove git_cl_hooks.py since it's now unnecessary. BUG= TEST= Review URL: http://codereview.chromium.org/6758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79715 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Dec, 2010 1 commit
-
-
chase@chromium.org authored
BUG=none TEST=git-cl works after move Review URL: http://codereview.chromium.org/5012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70011 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Oct, 2010 3 commits
-
-
msb@chromium.org authored
Also, modify git-cl to also update depot_tools. Otherwise, the git-cl script never gets updated for folks that only use git-cl but not gclient. This fixes a bug ChromiumOS developers are currently seeing where there git-cl checkout is still pointing to src.chromium.org and not git.chromium.org. BUG=none TEST=Verified that git-cl help and gclient help work. Review URL: http://codereview.chromium.org/3817011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62948 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This is nicer than an error message. TEST=manually tested the url was overwritten BUG=none Review URL: http://codereview.chromium.org/3796010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62923 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=none TEST=git-cl works TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/3757006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62916 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Oct, 2010 1 commit
-
-
msb@chromium.org authored
python does not seem to be able to import for a dir with dashes in it. BUG=none TEST=Ran git-cl help and verified it worked and new dir was created. Review URL: http://codereview.chromium.org/3530012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61694 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Jul, 2010 1 commit
-
-
msb@chromium.org authored
Rather than updating git-cl whenever gclient is invoked, update it whenever git-cl is invoked. In the chromium-os workflow, folks often run git-cl but rarely run gclient. This results in folks running an older git-cl which may not have the latest features/fixes. TEST= Tested that git-cl is updated when it is stale, git-cl is cloned when it doesn't exist and is not updated when DEPOT_TOOLS_UPDATE=0 Review URL: http://codereview.chromium.org/2962013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@52236 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Feb, 2010 1 commit
-
-
derat@chromium.org authored
I broke this in my last change. TBR=msb Review URL: http://codereview.chromium.org/627004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39277 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Feb, 2010 1 commit
-
-
derat@chromium.org authored
It would previously delete and recreate git-cl-repo if it saw that the remote was different than expected. This looks like it was added for the transition from the old SVN repo to the new git one, but it also has the effect of losing any local changes that have been made in the repo. :-( Everyone should be updated by now, so print a helpful error and exit instead. Review URL: http://codereview.chromium.org/609002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39099 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Nov, 2009 1 commit
-
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/397029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32259 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Aug, 2009 1 commit
-
-
maruel@chromium.org authored
Add .gitignore for causual ignores. TEST=none BUG=none Review URL: http://codereview.chromium.org/159855 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22380 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
Otherwise, all the parameters are coagulated into a single one. TEST=none BUG=none Review URL: http://codereview.chromium.org/119308 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17968 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Jun, 2009 1 commit
-
-
maruel@chromium.org authored
They automatically git clone the original repository and execute the original script. So if they are first in the path, they will be executed. If a user has another git-cl/try in the path prior, these stubs won't be used at all and won't mess with the user's setup. Also fix a bug with git handling in trychange.py Review URL: http://codereview.chromium.org/119244 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17737 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/113205 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15757 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Apr, 2009 1 commit
-
-
maruel@google.com authored
Review URL: http://codereview.chromium.org/92087 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
-