Commits · 5a644f8276363ceebabdd9f7a8c349e5635ef59a · Linshizhi / Chromium_Depot_tools

18 Mar, 2020 4 commits

Reland "git-cl: Refactor CMDUploadChange" · 5a644f82

Edward Lemur authored Mar 18, 2020

This is a reland of 9f29465e

Original change's description:
> git-cl: Refactor CMDUploadChange
>
> Changes:
> - Add _GetDescriptionForUpload and _GetTitleForUpload.
> - Add ensure_change_id to ChangeDescription, that ensures the
>   description has a particular Change-Id.
> - If more than a Change-Id was entered on new issue upload, remove
>   all, and add a new one.
>
> Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: Ib2c0ad61b169f6b0c3141674591b0d3fa42bc664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2103532
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

5a644f82

Add unit tests for git_find_releases · 1850bf6d

Josip Sokcevic authored Mar 18, 2020

R=ehmaldonado@chromium.org

Change-Id: Ib11ada368fda13bbef62c8be26ddb9c78a528a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107839Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

1850bf6d

Roll out new goma client binary VERSION=195 · 30d08dd0

Simon Que authored Mar 18, 2020

Bug: b/151197414
Change-Id: I6bf1aa388bf38fe855bae8e7290ec07fce2f8426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107341Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Simon Que <sque@chromium.org>

30d08dd0

[Presubmit] Allow GetUnitTestsRecursively() to restrict Python versions. · c1e1d099

Samuel Huang authored Mar 18, 2020

GetUnitTests() has named params {run_on_python2, run_on_python3}.
This CL adds these params to GetUnitTestsRecursively() so they can be
forwarded to GetUnitTests().

Bug: https://crbug.com/1054018
Change-Id: I06ac25a37f94cdea1cdc91954b70113e54cfdd15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2107610Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>

c1e1d099

17 Mar, 2020 2 commits

Move subcommand_test to py3 · a30b7bd3

Josip Sokcevic authored Mar 17, 2020

Change-Id: Iabc6ceb75da8a71f089c8fd89c94890f7b3f428e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2106513
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

a30b7bd3

Add gerrit_client unit tests · c99efb2f

Josip Sokcevic authored Mar 17, 2020

Change-Id: Id4ca28da6c38f6403636ef8c4de5dae1206cb499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2106518Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

c99efb2f

16 Mar, 2020 2 commits

Allow customizable build-type grouping · 34d90beb

Bruce Dawson authored Mar 16, 2020

The post_build_ninja_summary.py script, which autoninja automatically
runs if NINJA_SUMMARIZE_BUILD=1 is set, summarizes build time by file
extension. This is a good default summary but it can be handy to create
additional output categories. This change allows using fn_match style
wildcards to create additional categories which will then be summarized.
For instance:

  python post_build_ninja_summary.py -C out/Def -s prec*.obj;blink*.obj

In addition the chromium_step_types environment variable can be set so
that when autoninja runs this script there will be additional summary
categories.

This has been used most recently when measuring the cost of creating and
using blink precompiled header files.

Bug: 1061326
Change-Id: I080b4ddd06d045a2351220e202cd9eec111bf00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2093145
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

34d90beb

Roll recipe dependencies (trivial). · 8cf12290

recipe-roller authored Mar 16, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/bf0168d315c0b612412c236f115464b36c28a580 (iannucci@chromium.org)
    [proto_support] Add absolute import directives to all generated protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3fe18a447b0466758236d689972791470bfa4143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2104640Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8cf12290

13 Mar, 2020 4 commits

Revert "git-cl: Refactor CMDUploadChange" · c48fb842

Edward Lesmes authored Mar 13, 2020

This reverts commit 9f29465e.

Reason for revert:
line 2302, in CMDUploadChange
    change_id = change_ids[0]
IndexError: list index out of range

Original change's description:
> git-cl: Refactor CMDUploadChange
> 
> Changes:
> - Add _GetDescriptionForUpload and _GetTitleForUpload.
> - Add ensure_change_id to ChangeDescription, that ensures the
>   description has a particular Change-Id.
> - If more than a Change-Id was entered on new issue upload, remove
>   all, and add a new one.
> 
> Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: Ibb76539066c103ec951fa8d02684bc10f84549bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2103531Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c48fb842

git-cl: Refactor CMDUploadChange · 9f29465e

Edward Lemur authored Mar 13, 2020

Changes:
- Add _GetDescriptionForUpload and _GetTitleForUpload.
- Add ensure_change_id to ChangeDescription, that ensures the
  description has a particular Change-Id.
- If more than a Change-Id was entered on new issue upload, remove
  all, and add a new one.

Change-Id: I0eae474eb07ea3036973b18571f72a80da425b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101811Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9f29465e

Add unit tests for fetch.py · 06c8bce1

Josip Sokcevic authored Mar 13, 2020

R=ehmaldonado@chromium.org

Change-Id: I298d5f962e03520a93be1a7e32943934f1bde0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101809Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

06c8bce1

Roll lucicfg tool to @ 7def9ec8 · 7011463f

Andrii Shyshkalov authored Mar 13, 2020

Old revision: 3b479f0e

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/3b479f0e..7def9ec8
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/ae97ada2..0d1cb386/lucicfg

Bug: 1001182
Change-Id: I4f474185cd0c730b48e0a762837318de5176cbe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101884Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

7011463f

12 Mar, 2020 6 commits

Roll recipe dependencies (trivial). · 7499c627

recipe-roller authored Mar 12, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/fb1417de1c1bea92905177d69dfe8214956d664b (robertocn@google.com)
Do not use hostname flag when calling rdb.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67406ff752a8c8342c0b1aabc766ac205a40ad5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101256Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7499c627

git-cl: Stop using Change class from presubmit support. · 2c62b334

Edward Lemur authored Mar 12, 2020

Bug: 1042324
Change-Id: I72db082f086f69bf49256d0613c39dc92ae0a07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101471
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

2c62b334

git-cl: Set the right Change-Id footer automatically. · 5fb22249

Edward Lemur authored Mar 12, 2020

If the Change-Id in the description is different from the one fetched
from Gerrit, automatically set the right one instead of asking the
user to do so.

Change-Id: I0f681d9e7d98f3ed50adc4b6e4929981530e901c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101368
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

5fb22249

PRESUBMIT.py: Add timeout to tests. · 595eb191

Edward Lemur authored Mar 12, 2020

Interrupt tests after 3 min, so that failures can be
surfaced before the presubmit step gets interrupted
on the bot.

Change-Id: Ia0efebaac5a0c5072b974a4fbbcb14fe672017ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098942Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

595eb191

gclient_eval: Raise an error on implicitly concatenated strings. · 3c117949

Edward Lemur authored Mar 12, 2020

Implicitly concatenated strings are not supported when setting new
revisions, so raise an error when attempting to do se.

Bug: 1060772
Change-Id: I74d39b9eb8dcc420e9b7787c90bee642beb783cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099407Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3c117949

git cl: use short URLs in `git cl status`. · 1ee78cda

Andrii Shyshkalov authored Mar 12, 2020

This also applies to git map-branches.

R=ehmaldonado

Change-Id: Ica9bc92660716c15cbdd6bfd77b93f08bd0d8f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099329
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

1ee78cda

11 Mar, 2020 6 commits

Roll recipe dependencies (trivial). · 4c7c4b4b

recipe-roller authored Mar 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/caf3b9371438a8ef80c7cc977f770d8ed939731b (mikenichols@chromium.org)
update.py: Add GCE Provider protos to list of protos

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie47304611f9964f9d2137fa3c3b23e05bae191ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099426Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4c7c4b4b

gclient: Fix auto-fetching refs. · e0ba7b8e

Edward Lemur authored Mar 11, 2020

gclient executes `git rev-parse <ref>` to check if <ref>
already exists in the local clone, which succeeds when
<ref> is a git revision hash, even if it doesn't exist.

We execute `git rev-parse <ref>^{commit}` instead, which only
succeeds when <ref> resolves to a valid commit in the local
repo.

Change-Id: Ia1cdf7162c4c82a7e4214c6af375c1a9522d7b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095745Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e0ba7b8e

scm: Fix bug when checking for valid revision and add tests. · d52eddaa

Edward Lemur authored Mar 11, 2020

When running `git rev-parse REV^{commit}` in Windows, `^` must be
escaped.
However, it was escaped more times than necessary.

Split IsValidRevision to call ResolveCommit, add tests to ResolveCommit,
and run scm.py tests on Windows.

Change-Id: I761a820394c8b5410d68b6ccd6c352c41c30c88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2092904Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d52eddaa

Roll recipe dependencies (trivial). · 53effe84

recipe-roller authored Mar 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/6b8de18a4a0c44f518f2c68e119cb71bee118e5a (mikenichols@chromium.org)
go.chromium.org: Update recipe protos

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4deee1c7c503722ecf71865bdeb1aeaca47ff1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098123Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

53effe84

Fix OWNERS: full regexps not allowed, it's matched by fnmatch. · 96c9784d

Andrii Shyshkalov authored Mar 11, 2020

R=apolito@google.com

Bug: 1060018
Change-Id: I384e8bda14341159674e941abb6f723329ca5d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097341Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

96c9784d

subprocess2: Fix CalledProcessError str() method on Python 3. · 7ad1d093

Edward Lemur authored Mar 11, 2020

stdout and stderr are bytes in Python 3 and must be decoded before
printing the exception.

Bug: 1060409
Change-Id: Ib855f6104919734b7505aa5e978ebe394a1e9db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097595Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7ad1d093

10 Mar, 2020 4 commits

recipe_modules: git_cl no longer has codereview --gerrit param · 552ddbf3

George Engelbrecht authored Mar 10, 2020

BUG=chromium:1060257
TEST=./recipes.py test run

Change-Id: Ie081430ff5f83964a53401099ce3c9bee682c7fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097040Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: David Burger <dburger@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
Commit-Queue: George Engelbrecht <engeg@google.com>

552ddbf3

git cl: better detection of messages from CQ. · 8aa9d62e

Andrii Shyshkalov authored Mar 10, 2020

CQ added support to project-scoped accounts instead of previously
hardcoded commit-bot@ for working with Gerrit.

R=ehmaldonado

Test: `git cl status` on this very CL :)
Bug: 911811
Change-Id: I8f48a7bdc9dad9a5b71d266ccf7e9a493aa94aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095986Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

8aa9d62e

Roll luci-auth. · f8ceb227

John Budorick authored Mar 10, 2020

Updating to match crrev.com/i/2720965.

Bug: 1059948
Change-Id: I36a24a488978d00e164504e9a6d3eeb51aab6da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095862Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

f8ceb227

Roll out new goma client binary VERSION=194 · 0c4a3c25

Yoshisato Yanagisawa authored Mar 10, 2020

Bug: b/150814527
Change-Id: I58e5590de034b02a25be5eb35d36932b53607716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095605
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Ye Kuang <yekuang@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

0c4a3c25

09 Mar, 2020 1 commit

git-cl: Use _create_description_from_log instead of GetLocalDescription · a12175c2

Edward Lemur authored Mar 09, 2020

Also refactor code to eliminate multiple calls to _create_description_from_log.

Change-Id: I113134fbd90f396bdb6d561ed0369ea5ee9c78ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2090448Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a12175c2

07 Mar, 2020 1 commit

Roll recipe dependencies (trivial). · ffd02955

recipe-roller authored Mar 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/e15cecbc906eef0583e364eeaeef4fd2b4352e6f (yiwzhang@google.com)
Profile memory before every step execution if enabled in properties

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I113d4203995f482739be105b79ce7470c28a29b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2093096Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ffd02955

06 Mar, 2020 4 commits

git-cl: Tell users to set SKIP_GCE_AUTH_FOR_GIT=1 when running on cloudtop. · 57d4742b

Edward Lemur authored Mar 06, 2020

Bug: 1059141
Change-Id: I0a4501946014bd567548fb5396c3dd761606a9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091584
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

57d4742b

Roll recipe dependencies (trivial). · 83217f0f

recipe-roller authored Mar 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/0e747474f9f9d02568598aec9070c361cd057163 (yuanjunh@google.com)
Buildbucket recipe raises infraFailure on HTTP 500 rpc failures

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I88bfaf4ddeddd3bf9ab09903f42ef4522aac40e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091925Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

83217f0f

Improve tests for api.tryserver. · 4d2824af

Andrii Shyshkalov authored Mar 06, 2020

R=yiwzhang

Bug: 1056725
Change-Id: Id09e1a243e7071b5dc5715d156063e4b08230e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080764Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

4d2824af

add instruction for download failure due to 401 · 94bafe03

Takuto Ikuta authored Mar 06, 2020

context: http://shortn/_nIAnsMynAk

Change-Id: I578779b3a235bf32094cf0769e69dfae73727be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091174
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

94bafe03

05 Mar, 2020 2 commits

git-cl: Don't throw AttributeError in git cl upload --retry-failed · ee8be8a3

Quinten Yearsley authored Mar 05, 2020

Bug: 1057745
Change-Id: Ic1b977634e15b163e627c0f389047a26f7b0c7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083677
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

ee8be8a3

git-cl: Check if author exists before adding to presubmit command line. · 99df04e8

Edward Lemur authored Mar 05, 2020

When user.email is not configured in git, git-cl tries to call
presubmit support with --author None, which makes git-cl crash.

Bug: b/150870673
Change-Id: Idc42ba2b970340ed93e1e92f65850fc1a12336d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2090375Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

99df04e8

04 Mar, 2020 4 commits

Roll out new goma client binary VERSION=193 · 3ccfc90f

Fumitoshi Ukai authored Mar 04, 2020

Bug: b/150257427
Change-Id: I82358c1c0d9e1e980433b4923244e7983ae4fd09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2087351Reviewed-by: Ye Kuang <yekuang@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

3ccfc90f

gclient: Don't allow duplicate entries on deps · c00ac8de

Edward Lemur authored Mar 04, 2020

Bug: 809671
Change-Id: I74103304651417e6b6889cb713fe494c95279d69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088422Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c00ac8de

depot_tools: git-cl: Rename try job to tryjob for consistency · 777660f3

Quinten Yearsley authored Mar 04, 2020

Change-Id: I3310db47604dafead241db4d8d3540277daeb07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083675
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

777660f3

Roll recipe dependencies (trivial). · 83bc671b

recipe-roller authored Mar 04, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/529c1c9fa9ed3a118c777ca6a09033bfb0b56853 (olivernewman@google.com)
    [docs] Add recipes.cfg option to disable doc generation

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If605022323d0b94bb6cc447f985b9fbcf2c4d350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088428Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

83bc671b