Commits · 589d4563baa8c6b5bfbcab884d9d56e8e37e981a · Linshizhi / Chromium_Depot_tools

21 Nov, 2019 2 commits

depot_tools: Run watchlists tests on Python 3 · 589d4563

Edward Lemur authored Nov 21, 2019

Bug: 1002209
Change-Id: I64aecc5e06be13237b73ae568a1beae046ba4962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925324Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

589d4563

depot_tools: Run auth, cipd_bootstrap, git_number tests on python3. · 2e2f5875

Edward Lemur authored Nov 21, 2019

Bug: 1009809
Change-Id: Ia02460a24f4ac048bd7f0072e70856f9ee22a997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925314
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2e2f5875

20 Nov, 2019 2 commits

Roll recipe dependencies (trivial). · bea1635c

recipe-roller authored Nov 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2a3717d7299123f93cc91c42c8a492838e8ec03b Stop accepting None in with_user or with_tags (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5bd45ad0ee45864202ccee417023840f99d4df35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1926570Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bea1635c

roll out new goma client binary · 50696684

Fumitoshi Ukai authored Nov 20, 2019

https://chromium.googlesource.com/infra/goma/client/+/f6867ba895ff67bd3604cbf3dd66bc657eaa3cc0

BUG=1026184

Change-Id: I150df7d3eb8ce000e161bd1b5a0b8532a74a4e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925945
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

50696684

19 Nov, 2019 4 commits

Roll recipe dependencies (trivial). · 639872c8

recipe-roller authored Nov 19, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8143132bb9539bb3ab7ba8dc222941c6a0a2f51f [buildbucket] Expose DEFAULT_FIELDS (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I32048fb9fd66835427448d32f961fb77dea73b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1925317Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

639872c8

gclient: Make smoke tests use local dir instead of git daemon. · e9024d00

Edward Lemur authored Nov 19, 2019

Running gclient_smoketests times out on windows when using git daemon,
so use a local directory as remote instead.

Bug: 1024683
Change-Id: I6ca506d74de463d914317f176eefbe74996298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879723
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

e9024d00

Reland "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt" · 6ec8b51b

John Budorick authored Nov 19, 2019

This reverts commit b2bfd55f.

Reason for revert: not responsible for crbug.com/1025659

Original change's description:
> Revert "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt"
> 
> This reverts commit bf26b167.
> 
> Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1025659
> 
> Original change's description:
> > depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt
> > 
> > Bug: 1017812
> > Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> 
> TBR=dpranke@chromium.org,ehmaldonado@chromium.org,apolito@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1017812
> Change-Id: I8e10894a2e835c20ece7d555c21f6ce1f76528a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922949
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>

Bug: 1017812
Change-Id: I251c6b1a3e3a7b9ac9d21dabe745466c668a8246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1924494Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6ec8b51b

Revert "depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt" · b2bfd55f

John Budorick authored Nov 19, 2019

This reverts commit bf26b167.

Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1025659

Original change's description:
> depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt
> 
> Bug: 1017812
> Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=dpranke@chromium.org,ehmaldonado@chromium.org,apolito@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017812
Change-Id: I8e10894a2e835c20ece7d555c21f6ce1f76528a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922949Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

b2bfd55f

18 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 35a67a57

recipe-roller authored Nov 18, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7c426bbd1c09baf26a19be775d10b7ff332fa139 Remove BOGUS_FIELDS (guterman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e872e9dec9044f02fe6bc309fbfef5f35d3a27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1922947Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

35a67a57

15 Nov, 2019 5 commits

gclient: Support setting local directories as dependency URLs. · 1f392b83

Edward Lemur authored Nov 15, 2019

Using git daemon for smoke tests times out on Windows.
This CL adds support for local directory URLs to gclient so we can tests
using local directories as remotes instead.

Bug: 1024683
Change-Id: I6dcefa6eb0a93713cf46ea1e4c6b29311ad37565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915416Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1f392b83

presubmit: Print executed command along with test name. · 7cf9438c

Edward Lemur authored Nov 15, 2019

Useful when runnig the same test both on Python 2 and Python 3.

Change-Id: I6074e4cbd64318985cf438a2d491182b7b9ccc7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913259Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7cf9438c

depot_tools: Ensure Python is bootstrapped before reading python3_bin_reldir.txt · bf26b167

Edward Lemur authored Nov 15, 2019

Bug: 1017812
Change-Id: I7013e5445ff5917fab813a54fed416d9770d2684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913269
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

bf26b167

Changed "gclient sync -D" logic to compare against the expected DEPS version · bb457349

Anthony Polito authored Nov 15, 2019

Also add a better warning if 'gclient sync -D' fails due to a modified file.
I've tested this code via deleting a DEP and running gclient sync -D.

Bug: 981149
Change-Id: I97035ac238d163ccb1684c3ee423c223ed0f6299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891830Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

bb457349

Fix CMDUploadTestCase in presubmit · 46689b09

Anthony Polito authored Nov 15, 2019

Bug: 1025293
Change-Id: I41ca2fba3855ecad3036e94a3bdc39b399c1a276
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1918609
Commit-Queue: Anthony Polito <apolito@google.com>
Auto-Submit: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

46689b09

14 Nov, 2019 5 commits

Reland "Fetch the input commit ref when both ref and id are specified." · 90c88f09

Garrett Beaty authored Nov 14, 2019

This is a reland of 72a245e4

The "git checkout master --detach" operation has been modified to run in the solution
directory.

Original change's description:
> Fetch the input commit ref when both ref and id are specified.
>
> This causes --refs refs/head/master to be added to bot_update calls when
> the input build message contains a commit id and the refs/head/master
> ref. This is an effective no-op.
>
> When bot_update clones a git repository, it results in HEAD referring to
> master in contrast to the non-clone case which results in a detached
> HEAD. This prevents fetching refs/heads/master, so detach the HEAD after
> cloning.
>
> Bug: 922150
> Change-Id: I357a78305020218e9f5d350832a706b8f2b27967
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735
> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 922150
Change-Id: I7dc6ebed2dcbd880ff4d515f7e9fc6428ff24099
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1910260Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>

90c88f09

depot_tools: Execute tests using bot's vpython instead of depot_tools' vpython · 336e51f6

Edward Lemur authored Nov 14, 2019

On Windows, scripts on the current directory take precedence over PATH, so
that when testing depot_tools on Windows, calling `vpython.bat` will
execute the copy of vpython of the depot_tools under test instead of the
one in the bot.
As a workaround, we run the tests from the parent directory instead.

Change-Id: I5187943b6cf7499d50b3f1a2ec906a5e8fd84835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1910448Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

336e51f6

Revert git cache diagnostic tracing. · 3da78c4b

John Budorick authored Nov 14, 2019

This reverts commit ebba8d75.
This reverts commit fcde3ba0.
This reverts commit fd843fa4.

Bug: 1019824
Change-Id: I14ad2d4f620ac316421f1c3d168b66176af2d26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1917496
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

3da78c4b

Roll recipe dependencies (trivial). · e6e5db55

recipe-roller authored Nov 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/838fce779fcaec9469266d6bca9ec753eebd7414 Accept None in with_user and with_tags (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I81329b109e171b59a59ee26d0c9697865f53b1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915417Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e6e5db55

Randomize results of git cl owners · 37740e2b

Bruce Dawson authored Nov 14, 2019

git cl owners orders owners by score with alphabetization being the tie
breaker. This leads to some owners being suggested far more often than
others.

Adding a tiny amount of randomization to the scoring leads to an even
distribution of equally qualified reviewers. Less qualified reviewers
will still be sorted into distinct buckets - the randomness is too small
to do anything except break ties.

The tests were updated so that they can tolerate the randomness, but
only for breaking ties.

Bug: 1024083
Change-Id: If7d39d1b3bbd980b80b46ab3f62c65215309bdc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913642
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

37740e2b

13 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 088977a7

recipe-roller authored Nov 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9ab6dcc77364de001bb752e5d1fb42e1dd256371 isolated: update client (tikuta@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie95f7e8b84f9d110065847594744b449eddcfe91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1913387Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

088977a7

12 Nov, 2019 3 commits

git-cl: Make tests run on Python 3. · 0db01f0f

Edward Lemur authored Nov 12, 2019

Bug: 1002209
Change-Id: I90de660afd901e544e5557f3af3a56cef4d6adaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891667
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

0db01f0f

depot_tools: Don't add a python3 shim to depot_tools on bootstrap. · 9577daf6

Edward Lemur authored Nov 12, 2019

pythond and python3 are still downloaded from cipd, but python3 is no longer shim'd into
depot_tools on Linux, so is not available on PATH.
Modify PATH in vpython and vpython3 on Linux to point to the python3 download directory,
so that the version downloaded from cipd is used.

Bug: 1017812
Change-Id: I70bc8e7d460f60dcbfa5e141127edecfc2b44744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1893982
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

9577daf6

Add fetch configs for devtools-frontend · 89863242

Yang Guo authored Nov 12, 2019


Change-Id: Ib416a8a00c57c21d31d16d928932fcd16f39426f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1903486
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>

89863242

11 Nov, 2019 4 commits

Reland "git-cl: Fix some python3 compatibility errors." · 79d4f995

Edward Lemur authored Nov 11, 2019

This is a reland of c87ed606
Fix on the reland: Encode change description before writing to temporary file.

Original change's description:
> git-cl: Fix some python3 compatibility errors.
>
> Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though
> it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist.
>
> [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info
>
> Bug: 1002209
> Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Anthony Polito <apolito@google.com>

Bug: 1002209
Change-Id: I2f0fc779ea3e361e6d32ee7ce1e53cbddb5cfdea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898702
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

79d4f995

depot_tools: Add ehmaldonado to WATCHLISTS. · 5803e496

Edward Lemur authored Nov 11, 2019

Change-Id: I086ebb327ca9ad3021c50bbc159867ea150daabd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898695Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5803e496

fetch: Fix GCLIENT_PY3 on Windows · 7e557008

Edward Lesmes authored Nov 11, 2019

Bug: 939847
Change-Id: Ic5f87c7423ab72086ca928fecc15ed60408fbedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900165Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7e557008

git-cl: Fix error message when -B is not specified. · 5ef16a37

Edward Lemur authored Nov 11, 2019

Bug: 1018293
Change-Id: I9b915c3b4a1218e6318efde005c4f38243a35055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900309Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5ef16a37

08 Nov, 2019 5 commits

Roll recipe dependencies (trivial). · ea1884b6

recipe-roller authored Nov 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2102e819b3d68cf17a7dc72bc2b45b7431292215 Reland "Add swarming.TaskRequest.from_jsonish()" (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4785ca6804bbd9e660e3d208d898dab398cc753f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1907457Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ea1884b6

Change "CPU time" to "elapsed time" · 0e9afd2a

Bruce Dawson authored Nov 08, 2019

The "CPU time" values printed by post_build_ninja_summary.py are not
actually measure of CPU time, they are measures of wall-clock time or
elapsed time. This just changes the labeling of the numbers - the actual
numbers printed are unchanged.

The "weighted time" number continues to be the more important number
since it is an approximation of how much the build step(s) are affecting
build time. See the comments in the script for details.

Change-Id: Ibdb4efdd327ece34492ab10337c234a826514197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900019
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

0e9afd2a

Roll recipe dependencies (trivial). · 039522eb

recipe-roller authored Nov 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8eb3985beff2b4d0cf0bae61a7a3dab29271849f [recipe_modules/cipd] Expose default test data input for cipd.search. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icc009c79b72f02eac992b2c415903d68a0106056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1906737Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

039522eb

Use git fetch --no-tags to fetch commits to apply via cherry-pick. · d5c0b56e

danakj authored Nov 08, 2019

This changes the behaviour when applying a patch to not fetch tags
along with the patch being applied. The fetch to apply a patch only
needs the commits that will be cherry picked, it does not need tags.

Fetching tags creates slow bottlenecks if a repo such as chromium has
10k+ tags. Using --no-tags prevents the server from sending the list
of all tags and the client from processing them.

Bug: 1019824
Change-Id: I756beb8c2b0c7ec3c0fc48b7431d0cf8c0bbbbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894393Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>

d5c0b56e

Revert "Fetch the input commit ref when both ref and id are specified." · 1917f7a0

Stephen Martinis authored Nov 08, 2019

This reverts commit 72a245e4.

Reason for revert: crbug.com/1022617

Original change's description:
> Fetch the input commit ref when both ref and id are specified.
> 
> This causes --refs refs/head/master to be added to bot_update calls when
> the input build message contains a commit id and the refs/head/master
> ref. This is an effective no-op.
> 
> When bot_update clones a git repository, it results in HEAD referring to
> master in contrast to the non-clone case which results in a detached
> HEAD. This prevents fetching refs/heads/master, so detach the HEAD after
> cloning.
> 
> Bug: 922150
> Change-Id: I357a78305020218e9f5d350832a706b8f2b27967
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735
> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,gbeaty@chromium.org

Change-Id: Ibd6c6ed272b0c98f82be50cefa521aaee0444f11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922150, 1022617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1904099Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

1917f7a0

07 Nov, 2019 3 commits

Roll recipe dependencies (trivial). · a14152fd

recipe-roller authored Nov 07, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/71729a14269530e56e9a74c0335e7d4385969153 Allow StepPresentation logs to be a single string (mheikal@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8217341fadf2da2394bbdd2bf5060e006faaf874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1904729Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a14152fd

Fetch the input commit ref when both ref and id are specified. · 72a245e4

Garrett Beaty authored Nov 07, 2019

This causes --refs refs/head/master to be added to bot_update calls when
the input build message contains a commit id and the refs/head/master
ref. This is an effective no-op.

When bot_update clones a git repository, it results in HEAD referring to
master in contrast to the non-clone case which results in a detached
HEAD. This prevents fetching refs/heads/master, so detach the HEAD after
cloning.

Bug: 922150
Change-Id: I357a78305020218e9f5d350832a706b8f2b27967
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

72a245e4

[tricium] Add string_view to list of C++ headers · 9ab047e7

Jasper Chapman-Black authored Nov 07, 2019

Recipe-Nontrivial-Roll: build
Change-Id: I76c2db161677852b005f2b934ff96f7369844fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900486
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

9ab047e7

06 Nov, 2019 4 commits

Don't fetch tags when fetching to deapply a patch. · 23247b99

danakj authored Nov 06, 2019

Bug: 1019824
Change-Id: Ibec0b47067345150dbd2083265c49fb9b6769a3a
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894408
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

23247b99

Roll recipe dependencies (trivial). · 2fa5e571

recipe-roller authored Nov 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9aeddce5ce569741c849c155d94b4966832356eb Add swarming.TaskRequest.from_jsonish() (garymm@google.com)
  https://crrev.com/ce6248afeab2c85d8e9eebc934339c26d048d0fb Revert "Add swarming.TaskRequest.from_jsonish()" (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87a944c18c3cf2af24d3f8617c9b04d9978b07e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900365Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2fa5e571

Roll recipe dependencies (trivial). · 41be80f6

recipe-roller authored Nov 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/97ead225e3da23cbd18605e0f4cec0417412da64 isolated: roll isolated (tikuta@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icf7453d63b380f64d03fec04e43a81eeceb5094b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900598Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

41be80f6

[lucicfg] Update from v1.11.5 to v1.11.6. · d39c0496

Vadim Shtayura authored Nov 06, 2019

Contains a fix for crbug.com/1021520.

R=nodir@chromium.org, tandrii@chromium.org
BUG=1021520

Change-Id: I7f0ac984f9740613b34adf45a2f3d8013923c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900490
Auto-Submit: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

d39c0496

05 Nov, 2019 1 commit

Roll recipe dependencies (trivial). · 2150a694

recipe-roller authored Nov 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/482cd39e373ee9af9c4726064a1a62efcc8bfb2a [buildbucket] Don't accept project=None in schedule_request (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie312133f20be523ac0b6f463348ad21a8256d87d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900323Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2150a694