Commits · 55ab41d1856de3fbfaf3aea1aabbccb8efdf8547 · Linshizhi / Chromium_Depot_tools

28 Feb, 2020 10 commits

Roll recipe dependencies (trivial). · 55ab41d1

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/cda5bed0ae2531e7252f80da471f675158ab694c (gbeaty@chromium.org)
Add a property for previous_test_failures to RecipeDeps.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1c1da5357df6f449c746c9894d878c9a622efe3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080207Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

55ab41d1

depot_tools: Make it possible to run custom git scripts using Python 3. · 4d7d53b3

Edward Lemur authored Feb 28, 2020

Run custom git commands (e.g. git-cl, git-new-branch) using Python 3
when GCLIENT_PY3 is set to 1.

Bug: 984182
Change-Id: I81635b6cb83b2e0945d6596a7dc363f702075466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079704Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4d7d53b3

Roll recipe dependencies (trivial). · 9f6558d3

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/695991201368bcca73189853a28f9679f2668da9 (atyfto@google.com)
    [file] Add flag to skip logs on write_raw & write_text

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2d75290cbfadfa7ffd2482dc58036dfac9963cf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080915Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9f6558d3

Print content of description backup on exit · 953278ad

Josip Sokcevic authored Feb 28, 2020

Change-Id: I9607035c8ee5e5f4423b7526c67f384cfebb2f1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079708
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

953278ad

Revert "my_activity.py: Run using vpython3 by default." · eb5dabf9

Edward Lesmes authored Feb 28, 2020

This reverts commit 488712ab.

Reason for revert: Breaks when running on vpython3

Original change's description:
> my_activity.py: Run using vpython3 by default.
> 
> Also, prompt users to use vpython3 when running my_activity.py
> using Python 2.
> 
> Change-Id: I078517832520b3c7baf3324f83e9a3b5194a5bcb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079703
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: Ib217e8ec3613ee6645149f3d78ef9534ac68af8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080201Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

eb5dabf9

roll-dep: Make it possible to run using Python 3. · 4f489240

Edward Lemur authored Feb 28, 2020

Run roll-dep using Python 3 when GCLIENT_PY3 is set to 1.

Bug: 984182
Change-Id: I511b4cf34b4f5522218a24dff6d0ce9ef5c36c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080614Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4f489240

Roll recipe dependencies (trivial). · 1e247059

recipe-roller authored Feb 28, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/33340afc751dd03e69ec96a67311e6d56a6ab50b (yuanjunh@google.com)
Add --no-docs for the command 'test run'

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77b4bac44b57f8a6e3f4dbcad4b47bbb7775d7e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079414Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1e247059

Revert "Print content of description backup on exit" · b10ba796

Edward Lesmes authored Feb 28, 2020

This reverts commit 8c5cdf18.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1056958

Original change's description:
> Print content of description backup on exit
> 
> R=apolito@google.com
> 
> Bug: 1056193
> Change-Id: I656149b8ddad61f6b673193b72d780b72a585f43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078308
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

TBR=apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I5190f4e0f342d0ee06474e6c432004ef95bec85b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1056193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079307Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b10ba796

my_activity.py: Run using vpython3 by default. · 488712ab

Edward Lemur authored Feb 28, 2020

Also, prompt users to use vpython3 when running my_activity.py
using Python 2.

Change-Id: I078517832520b3c7baf3324f83e9a3b5194a5bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079703Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

488712ab

gclient: Allow setting GCLIENT_PY3 to 0 to run on Python 2. · 780e6bf8

Edward Lemur authored Feb 28, 2020

As we update scripts to run Python 3 by default, we want to provide
developers a way to execute scripts on Python 2 if they encounter
any problems.

This change only affects Linux/Mac and not Windows developers.

Bug: 984182
Change-Id: I7c7bd2a45ef50e340f6f2b85e9bc8b63f22d8678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079701Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

780e6bf8

27 Feb, 2020 9 commits

git-cl: Run PostUpload hooks via CLI. · 7552630e

Edward Lemur authored Feb 27, 2020

Bug: 1042324
Change-Id: Iae90e632e9c1b2c798575ab940d82a145b47204a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2070681
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

7552630e

presubmit_support: Refactor and add tests for DoPostUploadExecuter. · 6eb1d32f

Edward Lemur authored Feb 27, 2020

Remove input and output stream, that always pointed to sys.stdin
and sys.stdout.
Add tests for DoPostUploadExecuter.

Bug: 1042324
Change-Id: Ib5d092706a242ae97ec877af5dbceef6db7cbb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079411Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6eb1d32f

my_activity: search gerrit review too · 24fd8630

Mike Frysinger authored Feb 27, 2020

This is where PolyGerrit & repo & other Gerrit CLs land.

Change-Id: If584cfce7d6e78f01e30531e5eee70a51a354164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079413Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

24fd8630

my_activity: add short url for android CLs · fdf027a7

Mike Frysinger authored Feb 27, 2020

Change-Id: I7e9c7c38b82d746cad28685f0eb8e24cc2f41572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079412
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fdf027a7

Roll recipe dependencies (trivial). · c1371134

recipe-roller authored Feb 27, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/aed02b3aa61d3d56bfe5616667ab09cafc08fb4a (iannucci@chromium.org)
    [test] Fix location of --stop flag.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieaa3ba8c0ff179a1822367f802246e2642733ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078309Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c1371134

Print content of description backup on exit · 8c5cdf18

Josip Sokcevic authored Feb 27, 2020

R=apolito@google.com

Bug: 1056193
Change-Id: I656149b8ddad61f6b673193b72d780b72a585f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2078308
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

8c5cdf18

git-cl: Add tests for git-cl presubmit · 9468eba7

Edward Lemur authored Feb 27, 2020

Bug: 1056309, 1042324
Change-Id: I69815044c199f2321a66760bbdfe251ed916154a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2076037Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9468eba7

Refactor OWNERS for LUCI-related tools. · a4f9aa03

Robert Iannucci authored Feb 27, 2020

R=ehmaldonado@chromium.org, maruel@chromium.org, nodir@chromium.org, tandrii@chromium.org

Change-Id: I72e842bb07cf0a19d7afc417027ee7a70dddfd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077460Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

a4f9aa03

fix git cl presubmit · 29d5cf85

Gregory Nisbet authored Feb 27, 2020

BUG=chromium:1056534
TEST=run git cl presubmit

Change-Id: I22a7951623b241b8b1cc49f107f024d95054506d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077357
Auto-Submit: Gregory Nisbet <gregorynisbet@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

29d5cf85

26 Feb, 2020 3 commits

Roll recipe dependencies (trivial). · 005269a5

recipe-roller authored Feb 26, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a36bdfd1c28f088e1c39736babb987e71284d646 (yiwzhang@google.com)
    [warning] Support recipe warning registration

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a333b850ee5791df514a01171b7488b1644fe44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2076682Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

005269a5

Reland "cros: switch CrOS programs to python3" · b847c567

Mike Frysinger authored Feb 26, 2020

This is a reland of 35b70cac.
With the recent vpython3 PATH fixes, hopefully this should pass now.

Original change's description:
> cros: switch CrOS programs to python3
>
> We start warning if people have outdated systems.
>
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

Bug: 997354
Change-Id: Ic7e040af6a34d112cd0a1c1421cdd25bc557ee19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052625
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

b847c567

Roll out new goma client binary VERSION=192 · 2a9042f8

Ye Kuang authored Feb 26, 2020

Bug: b/149963110
Change-Id: Iced9b2db2f93c42c78a94430c5ba4f06f4e971a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072501Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Ye Kuang <yekuang@google.com>

2a9042f8

25 Feb, 2020 5 commits

git-cl: Invoke presubmit checks via subprocess execution instead of via module. · 227d5108

Edward Lemur authored Feb 25, 2020

PRESUBMIT.py scripts are executed in presubmit_support.py using exec().
Since PRESUBMIT.py scripts might not be yet compatible with python 3, we
have to execute presubmit_support.py using python 2.

git_cl.py imports presubmit_support.py, and executes presubmit checks using
presubmit_support as a module. This forces git_cl.py to be executed using
python 2 to maintain compatibility for PRESUBMIT.py scripts.

This change allows git_cl.py to be executed using python 3, while
presubmit_support.py is executed using python 2.

Similar changes for post-submit hooks and git-cl try masters will follow.

Bug: 1042324
Change-Id: Ic3bb1c2985459baf6aa04d0cc65017a1c2578153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068945Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

227d5108

Reland "gerrit-util: Fix GCE check from behind proxy." · 3b44ac67

Edward Lemur authored Feb 25, 2020

This is a reland of 9ee86e5a

Fix: s/Httplib2Error/HttpLib2Error

Original change's description:
> gerrit-util: Fix GCE check from behind proxy.
>
> Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
> to fail.
>
> The behavior of an unreachable server behind proxy is different from a direct
> connection, it won't throw a httplib2.ServerNotFoundError error,
> so catch httplib2.Httplib2Error instead.
>
> Bug: 1050380
> Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1050380
Change-Id: I9aec01088b0b1c408a1292106d0b21e6d8997040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2066666Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3b44ac67

my_activity: Add some tests and fix some bugs · ab9cc2c1

Edward Lemur authored Feb 25, 2020

Change-Id: Ib5625ae9d052eca9d6c6b64f12f64e6697aef7a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072874Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ab9cc2c1

[vpython] Update depot_tools vpython to match fleet. · 63832e90

Robert Iannucci authored Feb 25, 2020

This will make `vpython3` explicitly opt-in (so it will now behave the
same way that it does on bots).

R=qyearsley@chromium.org, smut@google.com, tandrii@chromium.org, vadimsh@chromium.org

Bug: 1051595
Change-Id: I80cbc640ec76756381d8b1cc2755363180534b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072361
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

63832e90

git-cl: Add GetAuthor method and cache GetLocalDescription results · 9aa1a967

Edward Lemur authored Feb 25, 2020

Bug: 1051631
Change-Id: I5da32978bbed16bcc9854f15db91a901f5892cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067402Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9aa1a967

24 Feb, 2020 2 commits

git-cl: Fix get_cl_statuses for Python 3 and add tests. · 61bf4177

Edward Lemur authored Feb 24, 2020

In Python 3 the semantics of `raise StopIteration` inside a generator
function changed.

Bug: 1002209
Change-Id: I51222a5006c4024b3a6a06d344423ee36870825a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2071056Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

61bf4177

Roll bb tool to @36780e0 · f95054fa

Yiwei Zhang authored Feb 24, 2020

Old revision: 37d9960

infra/infra change log:
  https://chromium.googlesource.com/infra/infra/+log/37d9960..36780e0

luci_go change log:
  https://chromium.googlesource.com/infra/luci/luci-go/+log/7ffc196..f45bbc1

R=tandrii

Change-Id: Ic7e342c356d5e91d37aa89f70faae4adf3525e7f
Bug: 1054982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2070062
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>

f95054fa

22 Feb, 2020 1 commit

gclient_utils: Add temporary_file method. · 1773f37d

Edward Lemur authored Feb 22, 2020

Useful when passing information to a subcommand via a temporary file.

Bug: 1051631
Change-Id: I0b8deda921effd24a37109544e1e7ca22e00ba4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068942Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1773f37d

21 Feb, 2020 6 commits

git-cl: Fix invocation of git new-branch · 8410164a

Edward Lemur authored Feb 21, 2020

Bug: 1054787, 1051631
Change-Id: Ib36740a3f8158977897431c5b52e5ecbdaeb16b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068506
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

8410164a

presubmit: Add should_continue and more_cc to presubmit json output. · 1dc66e16

Edward Lemur authored Feb 21, 2020

Also, rename --all-files to --all_files to be consistent with other
options, and remove reviewers, since it's never set in presubmit_support.

Bug: 1042324
Change-Id: I34fa3162c56e39bcdd52ad1e19058357de934f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067351Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1dc66e16

git-cl: Fix Change object construction for git-cl split · 7c34a225

Edward Lesmes authored Feb 21, 2020

Changelist.GetChange signature was changed in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038050

Bug: 1042324, 1054880
Change-Id: I6ba63e7f2f6c13bd8e8bef4e76cd66ee0525bba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067623Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7c34a225

git-cl: Fix split branch name · 4dc5b779

Edward Lesmes authored Feb 21, 2020

Bug: 998922, 1054888
Change-Id: I4ae14700cbd6eb483f318f6ed9f4d1f30b58153e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068492Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4dc5b779

Fix build summary to classify *.mojom*.obj as .obj · 1eb16f67

Bruce Dawson authored Feb 21, 2020

The build summary script was overly aggressive about summarizing .mojom
files under the mojo category. This was intended to measure the cost of
generating source from mojo files but it accidentally pulled in the
.mojom object files.

Categorizing different types of object files might be worthwhile but
that should be done intentionally and consistently.

Change-Id: Iab6b7e94797ce7f1ed46805034b4f274c88617e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067647
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

1eb16f67

Roll out new goma client binary VERSION=191 · 7e4c38a4

Simon Que authored Feb 21, 2020

Bug: b/149440210
Change-Id: I818c556baa84b032172ea40263a1bc1cb7a592a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2064233Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

7e4c38a4

20 Feb, 2020 2 commits

gclient: setdep writes binary for windows newline support · 7aa68240

John Emau authored Feb 20, 2020

This fixes an issue on Windows where running `gclient setdep` would convert the DEPS file from LF to CRLF line endings.

From the python 2.7 docs:

" On Windows, 'b' appended to the mode opens the file in binary mode, so there are also modes like 'rb', 'wb', and 'r+b'. Python on Windows makes a distinction between text and binary files; the end-of-line characters in text files are automatically altered slightly when data is read or written. "

- https://docs.python.org/2.7/tutorial/inputoutput.html#reading-and-writing-files

Change-Id: I94183918789a8cdd4aa655db4b3dadfaae23d13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067477Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: John Emau <John.Emau@microsoft.com>

7aa68240

git-cl: Mock DieWithError and GitSanityTests · d55c5077

Edward Lemur authored Feb 20, 2020

Bug: 1051631
Change-Id: I20f68db7dd0a901ff53513998e148cf4ba2c3eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2065133Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d55c5077

19 Feb, 2020 2 commits

repo: update to 2.4 launcher · 56c9bd5a

Mike Frysinger authored Feb 19, 2020

Bug: None
Test: `repo sync` still works
Change-Id: Ibef61ccda4640dfc6a28b9a919e50f7a8162bf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062618Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

56c9bd5a

git-cl: Mock GetChangeDetail on tests. · 7677e5cc

Edward Lesmes authored Feb 19, 2020

Mock GetChangeDetail instead of using self.calls to make the code
easier to change.

Bug: 1051631
Change-Id: I77361caccaf694644839825d890343864267688f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062716
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

7677e5cc