Commits · 542224ebd6bffa431150da4b13986c94c3e5fb28 · Linshizhi / Chromium_Depot_tools

13 May, 2021 4 commits

Replace processObservers with a class that doesn't constantly recreate threads · 542224eb

Anthony Polito authored May 13, 2021

I'm not saying this is why bot_update is failing, but I never trust python threads, especially not at scale. I also think the new implementation is easier to understand and less likely to have subtle mistakes if it is extended later

Change-Id: I29be55594a400fda845ea31893789104373fd0f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892185Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>

542224eb

[dirmd] Roll dirmd · 170ef527

Nodir Turakulov authored May 13, 2021

To pickup https://chromium-review.googlesource.com/c/infra/infra/+/2891608

R=dpranke@chromium.org

Bug: 1179786
Change-Id: I023e85e96660ee3acef8eaca345e5e89d3bf03e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2894371
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

170ef527

Revert "[dirmd] Roll dirmd" · b073879a

Nodir Turakulov authored May 13, 2021

This reverts commit c4575f80.

Reason for revert: git.exe is not present everywhere. We should check for git.bat

Original change's description:
> [dirmd] Roll dirmd
>
> To pickup
> - https://chromium-review.googlesource.com/c/infra/infra/+/2889534
> - https://chromium-review.googlesource.com/c/infra/infra/+/2889536
> - https://chromium-review.googlesource.com/c/infra/infra/+/2893228
> - https://chromium-review.googlesource.com/c/infra/infra/+/2893224
>
> Bug: 1201822
> Change-Id: I000db40b88d3c2e2b2047a993ed3983a2f09519e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891365
> Auto-Submit: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1201822
Change-Id: I21c21b6be6f816485a849980fe7ae60b85c436fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892386
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

b073879a

Pretty-Print the win_toolchain JSON Output · f5c054ce

Robert Liao authored May 13, 2021

This makes the file easier to read.

Change-Id: Ie5eac66582bd6f3ce3c31def6f591e001de9a79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2893667
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

f5c054ce

12 May, 2021 12 commits

Add more users warning to git cl split · 0614591e

Olivier Li authored May 12, 2021

Change-Id: I1306728d73701b2444d382f579aa8894d9857ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892214
Commit-Queue: Olivier Li <olivierli@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>

0614591e

[dirmd] Roll dirmd · c4575f80

Nodir Turakulov authored May 12, 2021

To pickup
- https://chromium-review.googlesource.com/c/infra/infra/+/2889534
- https://chromium-review.googlesource.com/c/infra/infra/+/2889536
- https://chromium-review.googlesource.com/c/infra/infra/+/2893228
- https://chromium-review.googlesource.com/c/infra/infra/+/2893224

Bug: 1201822
Change-Id: I000db40b88d3c2e2b2047a993ed3983a2f09519e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891365
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

c4575f80

[mac_toolchain] Roll mac_toolchain version for builders using osx_sdk · 1af6d426

Zhaoyang Li authored May 12, 2021

The roll takes new feature to download Xcode & iOS runtimes separately.
The interface used by builder machines is untouched, but implementation
changed for new Xcode packages.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 1191260
Change-Id: If0554e116bcb92c0b125693e1f555e52e22c10f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890331Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>

1af6d426

Detect uploadvalidator error message · 740825ec

Josip Sokcevic authored May 12, 2021

If git push refs/for/ errors out, inspect stdout message to detect
uploadvalidator rejection. If present, present user a solution.

R=ajp@google.com

Change-Id: I70aee7615f3d905127a31bd5679968ade75c234a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2888475Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

740825ec

Handle spaces in Gerrit search options · f5c6d8a2

Josip Sokcevic authored May 12, 2021

Gerrit rejects requests with 400 Bad request if query string `q`
contains any spaces. Replace spaces with a plus sign solves the problem.

R=thakis@chromium.org

Bug: 1199692
Change-Id: Ic13dda378527594c6cf57b8cb2edf740517811ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2832653Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

f5c6d8a2

Respect GOMA_DIR in autoninja instead of always assuming .cipd_bin. · 942a1eef

Brandon DeRosier authored May 12, 2021

Chromium + Fuchsia + Flutter Engine tools use GOMA_DIR to determine the
location of goma's scripts and binaries. Goma installs track some state
separately, and so when a different goma distribution's `compiler_proxy`
is launched and autoninja attempts to run `.cipd_bin/gomacc port`, the
check fails even though goma is running.

Additional context:
https://github.com/flutter/flutter/issues/81510#issuecomment-839489061
Change-Id: I93775628c6efba62bb226ac1995301c3ae7f5fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891250Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Brandon DeRosier <bdero@google.com>

942a1eef

Fix a Py3 bug in presubmit_canned_checks.py. · 04cf3de9

Dirk Pranke authored May 12, 2021

There were a couple of references to using filter() that
needed to be replaced with list comprehensions as the return
values may be used repeatedly.

Bug: 1207012
Change-Id: Iae0abd38aeb186d6f7945f8c848c1f7312cb45bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890329Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

04cf3de9

Fix a Python3-compatibility issue in get_toolchain_if_necessary. · 3b9d2d85

Dirk Pranke authored May 12, 2021

Bug: 1207012
Change-Id: I9205089c3a7d9f2d3e2eb9aac7ef6da9ae9b0876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890330
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

3b9d2d85

Roll recipe dependencies (trivial). · 8ac2b642

recipe-roller authored May 12, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/955bddfc919a5f22042d9f001e6f751dd89b3401~..dc36545f92232c37f4af4080296258fc1e240258
  955bddf (olivernewman@google.com)
      Do trivial s/master/main substitutions
  2200d7d (bryner@google.com)
      Upgrade cffi to 1.14.5 for the recipe engine.
  dc36545 (iannucci@chromium.org)
      [python3] Add test and do futurize --stage1.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icc1683726c3db84472f77333f6f6b9024f07dab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891350
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8ac2b642

Roll recipe dependencies (nontrivial). · b47c95a5

recipe-roller authored May 12, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f4c9a77634665e42da92a9d7005ec920a3e38c9e
  f4c9a77 (olivernewman@google.com)
      [buildbucket] Make default git_ref consistent

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6b5526f445bbb7337ce8d18e10e855f7a91c587f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885939
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

b47c95a5

Update cffi wheel version to one that is available for Mac ARM64. · 6e5b0a5c

Brian Ryner authored May 12, 2021

Bug: 1205263
Change-Id: I0a2297c7a7d66807afe2ebf11558bc89afa793dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890609
Commit-Queue: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

6e5b0a5c

add a big of debugging info to figure out more abour bot_update failures · f7157cee

Anthony Polito authored May 12, 2021

Change-Id: If324a6af154c4ded3b4c8d5e07a4740722318a59
BUG:1206377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2889824
Auto-Submit: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

f7157cee

11 May, 2021 4 commits

Include original traceback in _run_check_function. · b65bbfe4

Allen Webb authored May 11, 2021

This is a followup to CL:2797935 to make it easier to debug exceptions.

Bug: 1206782
Change-Id: Ibb649e94fd562919737de152e3203ca6b02b38ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880843Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

b65bbfe4

gclient: Stop running git under "arch" on macOS · 4bd1522a

Nico Weber authored May 11, 2021

We now have an arm python binary, so this should no longer be needed.

Bug: 1103326,1184767,1103236
Change-Id: I5510bf2c61adc2d0d505a886956a6677303df271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2888957
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

4bd1522a

repo: update to latest version · 4bedb9d8

Mike Frysinger authored May 11, 2021

Change-Id: I81a29cf241f1633ed3fac830c0982a2dab7cc7fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2887605Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

4bedb9d8

Roll out new goma client binary VERSION=220 · cb17bc60

Yoshisato Yanagisawa authored May 11, 2021

Bug: b/186808715
Change-Id: Ice17a51b9a0bcd40b4662d0507dd20845f6c1160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885984Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

cb17bc60

10 May, 2021 3 commits

[lucicfg] release 1.24.4 version. · c4991420

Scott Lee authored May 10, 2021

Notable changes:
  move the cipd pin for cloud logging params in logdog
  https://crrev.com/c/2879575

Bug: 1164124
Change-Id: Ife6d6346b77379ed30f6e977751a4b7f4950c3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885198
Commit-Queue: Scott Lee <ddoman@chromium.org>
Auto-Submit: Scott Lee <ddoman@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

c4991420

download_from_google_storage: Use vpython3 instead of vpython · 524cdd8b

Nico Weber authored May 10, 2021

We have vpython wheels for py3 but not for py2 on mac/arm. With this,
download_from_google_storage.py works on arm mac even without the
vpython bypass. (Also, moving from py2 to py3 seems like a good thing
in general.)

Bug: 1205263,1103236
Change-Id: I6cb08b7c56e5e6fc160fb5abc86d68e04a01f8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2881917
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

524cdd8b

Roll vpython in depot_tools to the latest version. · 1039f6ca

Brian Ryner authored May 10, 2021

This version will no longer enforce that wheels exist for linux-x86
when running in "verify" mode. This is a prerequisite to rolling out
new wheels to vpython specs that use verification, since we no longer
build for Linux 32-bit.

Bug: 1176014
Change-Id: I13e77fe7b9ccc3741fa05ae493d171d0ed9aecac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2878769
Commit-Queue: Brian Ryner <bryner@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

1039f6ca

09 May, 2021 1 commit

Roll depot_tools cpython3 version. · 03dfb00f

Brian Ryner authored May 09, 2021

See https://chromium.googlesource.com/chromium/tools/depot_tools/+/e77e3c879a3f795161d3efa096c9caa33c7a0c2b

Bug: 1175200
Change-Id: I340be41bd2c7e796de5d153b95873e4b45e5280e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2879116
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

03dfb00f

07 May, 2021 4 commits

Roll recipe dependencies (trivial). · b865acd3

recipe-roller authored May 07, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b64b15afdf9f3fe3b6bf8e662c4795b9c0e902e1
  b64b15a (iannucci@chromium.org)
      [python3] Add test and fix syntax+warnings for py3.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibda2918e076d774608ec0b49f15beaefb7827b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880846
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b865acd3

Bump python2 to 2.7.18 again, and pull it on mac/arm · 360f9819

Nico Weber authored May 07, 2021

This time, the mac/intel binary was built with an older macOS SDK
which makes the runtime believe that the macOS version on Big Sur is
10.16 instead of 11.0, which should work around the Big Sur issue we had
in the last attempt.

This version was pushed to bleeding_edge in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311

Bug: 1124119,1103236,1184768,1175200
Change-Id: I8614d6f22704d46bfa78b81c8e4b9ff7e6668487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880559
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

360f9819

metrics: Wait until upload is complete on bots. · 73faeeae

Edward Lesmes authored May 07, 2021

Otherwise, when the step completes, it won't be able to close
files used for stdout/stderr, since the metrics process is still
running.

Bug: 1206429
Change-Id: Id88578cbd9dab070e07f92e545ec137245566d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877608
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

73faeeae

Roll recipe dependencies (trivial). · f9be70c9

recipe-roller authored May 07, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/972327732abad5d5eb1b90182c2b0b4290b3812f
  9723277 (iannucci@chromium.org)
      [python3] Add a python3 unittest which does nothing.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic95165944ec7285f5e8ee37a36b3b92bc4598c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2879164
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f9be70c9

06 May, 2021 4 commits

Update bleeding edge python versions. · e77e3c87

Brian Ryner authored May 06, 2021

The new version is built with an older Xcode version for mac-amd64,
using the 10.15 SDK, which gives us better Big Sur compatibility for
some of the very old Python libraries we have in use. In particular,
it will see the OS version as 10.16 rather than 11.0, and recognize
the 10.x-built vpython wheels as compatible.

Bug: 1175200
Change-Id: I23be64b11c8a2fb31910ce5e13b98bd5b38eeb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

e77e3c87

Roll recipe dependencies (trivial). · b3429589

recipe-roller authored May 06, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/609ceedcf6b576d9ccc030fd99b288cf83a2b3bf
  609ceed (iannucci@chromium.org)
      [.vpython] Bump protobuf and six versions.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c41f4530c3191dd8cd1abf2f2ebd1daa26df016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877607
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b3429589

Reland "git-cache: Start collecting metrics." · cb04744f

Edward Lesmes authored May 06, 2021

This is a reland of a84eaf51

Original change's description:
> git-cache: Start collecting metrics.
>
> Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I80091d78deb0b1aaba280572a1384848990d9d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877262Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

cb04744f

metrics: Don't print notice if reporting build metrics. · 9c34906c

Edward Lesmes authored May 06, 2021

Change-Id: Ib7e23cd1b57c6d0497f0e0ff1fe31b38f11bfc00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876082Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9c34906c

05 May, 2021 4 commits

Revert "git-cache: Start collecting metrics." · 5009fd68

Edward Lesmes authored May 05, 2021

This reverts commit a84eaf51.

Reason for revert:
Should not print notice.
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8848034039500209104/+/u/bot_update/stdout

Original change's description:
> git-cache: Start collecting metrics.
>
> Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I5d73cfccbcfc75ec26c7ba7127c1320002224e47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876069
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

5009fd68

git-cache: Start collecting metrics. · a84eaf51

Edward Lesmes authored May 05, 2021

Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a84eaf51

gclient: Set DEPOT_TOOLS_REPORT_BUILD to report bot metrics. · 75229247

Edward Lesmes authored May 05, 2021

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: chromiumos
Change-Id: I5c7b2188a84580a0575e9e748946e66cc7140787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872856Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

75229247

git cl upload: Use default patchset message when user's message is "y" · 3da91715

mlcui authored May 05, 2021

Users sometimes type in "y" to confirm the default patchset message,
resulting in a patchset being uploaded with "y" as the message.

We can make a fair assumption that no-one would willingly use a patchset
message of "y", so this CL uses the default patchset message whenever
this happens.

(I have personally done this myself and have seen at least one other
person do the same.)

Bug: None
Change-Id: Iad314d35aa830b62152ab2910eb37d876b7e450b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861643Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>

3da91715

04 May, 2021 4 commits

[cipd] Roll led to @c7e0fe5a · 6b022d1e

Yuanjun Huang authored May 04, 2021

Release the led which has the `-adjust-priority` flag

change logs:
infra/infra: https://chromium.googlesource.com/infra/infra/+log/bf50da1e..c7e0fe5a
luci-go: https://chromium.googlesource.com/infra/luci/luci-go/+log/5c64c54..26c1d75b

Bug: 1138533
Change-Id: Idd19d44f375143db0f5e7bf256b7b32567e8b393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872927Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>

6b022d1e

[git-rebase-update] Disallow `git gc` during git-rebase-update. · d3acb16c

Robert Iannucci authored May 04, 2021

In theory this should prevent `git rebase-update` from invoking
potentially expensive `git gc` operations after every `git rebase`
(ideally once per branch, but sometimes as many as three per branch (!)).

This has outsized effects as the size of the repo or number of branches
increases, and additionally has penalties on Windows due to git's
POSIXey assumptions around how disk I/O works.

After doing all rebase stuff, we run `git gc --auto` from rebase-update
once (assuming we were successful; if the command failed then we don't
run gc at all).

R=apolito@google.com

Bug: 617218
Change-Id: I37a8f7953779f15b320e4ed7bb85119cb4bb665a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2868766
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

d3acb16c

[auth] log errors from luci-auth token invocation. · 0f402641

Andrii Shyshkalov authored May 04, 2021

Motivating example -- seemingly empty output in this build:
https://luci-milo.appspot.com/ui/p/devtools-internal/builders/ci/Auto-roll%20-%20frontend/587/overview
R=vadimsh

Change-Id: I12f1acb1b4852f57057684b26fb153ab74e2da39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2871721Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>

0f402641

Revert "Bump python2 to 2.7.18" · e038acc7

Nico Weber authored May 04, 2021

This reverts commit 02927937.

Reason for revert: https://crbug.com/1175200

Original change's description:
> Bump python2 to 2.7.18
>
> That version was pushed to bleeding_edge in
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861642
>
> Bug: 1124119
> Change-Id: Id4ab5cb599dc85f3da7784163ddd46b2cd7c7980
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867872
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1124119
Change-Id: I70124c502c84713e2bbb809793353c74e2e40645
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872006
Auto-Submit: Nico Weber <thakis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

e038acc7