Commits · 531d992f00bbd6861b45ebff44c73f66fa172d5f · Linshizhi / Chromium_Depot_tools

10 Aug, 2020 2 commits

Saagar Sanghavi authored Aug 10, 2020

presubmit:gerrit_host/folder/to/repo:path/to/file/:CheckName
Example
presubmit:chromium-review.googlesource.com/chromium/src/:services/viz/

Bug: 1112667
Change-Id: I095a2c04e73c64d67fa1bb3dbf7e6dfd1d93fe26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2335873Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

531d992f

[Backward Compatible] Timing and RDB for Lower-level checks · 03b15131

Saagar Sanghavi authored Aug 10, 2020

Allows presubmit_support to perform Timing and RDB reporting for each of
the lower-level "CheckXYZ" functions, provided that
ENABLE_NEW_PRESUBMIT_CHECKS is called in the PRESUBMIT.py
file that we are running. I am using the variable to avoid the breakage
caused by the similar previous CL (2332321) which was not backwards
compatible.
In addition, asks for "-realm" with ResultDB so it can maintain the
security boundary.

Bug: 1106943
Change-Id: Ia49e8884e2653bee7de7ed7d254452d55dd5c617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2341828
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

03b15131

07 Aug, 2020 1 commit

ResultDB wrapping for CQ/CI builds. · 0fa91d0f

Saagar Sanghavi authored Aug 07, 2020

Add ('rdb', 'stream', '--') to wrapper.
Uses -- to send args to subprocess. (This was the bug with original CL)

Note - to test this, we will have to push changes and revert
immediately if we notice any breakage.

Recipe-Nontrivial-Roll: build
Change-Id: Ibe46314c2f791a99c0e670ff6cc44f6f24fb9f70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2342254Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

0fa91d0f

06 Aug, 2020 3 commits

Roll git to 2.28.0 on Windows · 24289f2e

Edward Lesmes authored Aug 06, 2020

Bug: 1070694
Change-Id: I18d5686738917869ada2ebdd8995d39ed84ec851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340256Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

24289f2e

Revert "[Fixed from older branch] Timing/RDB for lower-level checks" · 8351dc1f

Ben Pastene authored Aug 06, 2020

This reverts commit dba1d65a.

Reason for revert: "Check* takes exactly 3 arguments (2 given)" presubmit errors
eg: https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/933062?
https://crbug.com/1113506

Original change's description:
> [Fixed from older branch] Timing/RDB for lower-level checks
> 
> presubmit: Report timing to rdb for individual checks
> Rather than using CheckChangeOnCommit() or CheckChangeOnUpload() as the
> sole entry points for PRESUBMIT.py files, this cl enables presubmit_support.py
> to use any CheckXYZ[OnCommit/Upload] function to serve as an entry point.
> 
> This way, we can perform timing and RDB reporting for each of the
> presubmit check functions and have check-specific data.
> 
> Bug: 1106943
> Change-Id: Ifdabd68c0904a6d70a828f12de157369c6c1571d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2332321
> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

TBR=dpranke@google.com,estaab@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,saagarsanghavi@google.com

Change-Id: Ibd80f70661d2196f903f0c6b79eb74eda6c94d44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1106943, 1113506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340692Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

8351dc1f

Remove dpranke@chromium.org from OWNERS. · b932a7fe

Dirk Pranke authored Aug 06, 2020

I've consistently switched over to using dpranke@google.com for all
my work and should no longer have the @chromium.org address listed
in OWNERS.

Change-Id: Ibafa6d0fe0c0673a3216ade62b5997af62b06e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2335909Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

b932a7fe

05 Aug, 2020 6 commits

[Fixed from older branch] Timing/RDB for lower-level checks · dba1d65a

Saagar Sanghavi authored Aug 05, 2020

presubmit: Report timing to rdb for individual checks
Rather than using CheckChangeOnCommit() or CheckChangeOnUpload() as the
sole entry points for PRESUBMIT.py files, this cl enables presubmit_support.py
to use any CheckXYZ[OnCommit/Upload] function to serve as an entry point.

This way, we can perform timing and RDB reporting for each of the
presubmit check functions and have check-specific data.

Bug: 1106943
Change-Id: Ifdabd68c0904a6d70a828f12de157369c6c1571d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2332321
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

dba1d65a

[ResultDB] Update rdb version · 92e5a929

Chan Li authored Aug 05, 2020

Update rdb version to git_revision:2e0910d2a82300df629ff979a8a958392b69714b to include change

2020-08-05 chanli@chromium.org [ResultDB] Update url schema for test result UI

Change-Id: Ib6d04f3d1a216e51b2b6a12bb5feed11f2606baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340081Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

92e5a929

Handle BUG_PREFIX correctly when populating Bug: lines. · 8a0efc18

Lei Zhang authored Aug 05, 2020

Right now git_cl.py inserts an extra colon if the bug prefix ends with
a colon. Fix this by detecting whether the bug prefix ends with a colon
or not, and only inserting the colon when necessary.

Bug: 1111955
Change-Id: I3db199435087abb17b9600fc208b11d2d8e6a615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2333426Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

8a0efc18

Revert "ResultDB reporting for bot-triggered builds" · fb9c1110

Ben Pastene authored Aug 05, 2020

This reverts commit bd650534.

Reason for revert: "flag provided but not defined: -u"
https://crbug.com/1113350

Original change's description:
> ResultDB reporting for bot-triggered builds
> 
> Recipe-Nontrivial-Roll: build
> Change-Id: Id062a66c8a37aeedc85eaa16b1aa1eea4304f5c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2330655
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

TBR=nodir@chromium.org,estaab@chromium.org,ehmaldonado@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,saagarsanghavi@google.com

Bug: 1113350
Change-Id: I2c496d6c170a2ffb9226c5bb201d467f5847de6a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340035Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

fb9c1110

Add a newline between commit messages · e3644869

Manh Nguyen authored Aug 05, 2020

Git commit message presubmit test might merge multiple commit messages
together if there is no newline in between.

Bug: angleproject:4923
Change-Id: I668b7d1f3c7e17d7499bf1fd2b9390d77ce70d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2339754Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e3644869

ResultDB reporting for bot-triggered builds · bd650534

Saagar Sanghavi authored Aug 05, 2020

Recipe-Nontrivial-Roll: build
Change-Id: Id062a66c8a37aeedc85eaa16b1aa1eea4304f5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2330655Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

bd650534

04 Aug, 2020 4 commits

Add a little bit more context to a failure case for debugging reasons · 486f1812

Anthony Polito authored Aug 04, 2020

Bug: 1110152
Change-Id: I4b525a62aa87ea98590741445b4273068edb7f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2332373Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

486f1812

Fix reference to enable_js_type_check · 9e633036

Bruce Dawson authored Aug 04, 2020

A TODO in ninjalog_uploader.py referred to the closure_compile gn arg
which was recently renamed (as of crrev.com/c/2248564) to
enable_js_type_check. This updates it (and adds a missing space and a
bug number). This is purely a comment fix.

Change-Id: I117fa7910663491fd7c6e017fe98e2a977a75f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2336176
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

9e633036

Roll lucicfg tool to @ 61acc468 · a0c3f906

Andrii Shyshkalov authored Aug 04, 2020

Old revision: 405cae5b

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/405cae5b..61acc468
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/0510800a..9f34234f/lucicfg

Bug: 1112433
Change-Id: I405cb80f1981b4656aa388fc0672f444a461a2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2337114Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

a0c3f906

Roll out new goma client binary VERSION=204 · 4fdf5625

Ye Kuang authored Aug 04, 2020

Bug: b/161659417
Change-Id: Ib9340e4a5eba211c5ac8a2fff481ef7a394ce63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2336122Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ye Kuang <yekuang@google.com>

4fdf5625

03 Aug, 2020 2 commits

remove reference to jumbo build · 6c7b829e

Takuto Ikuta authored Aug 03, 2020

Bug: 994387
Change-Id: I0c675bb6aca04d64593de420c7936cb88ff6a051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2334503
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>

6c7b829e

Roll recipe dependencies (trivial). · 01a0945e

recipe-roller authored Aug 03, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5d50d5f744305222468fed128a8b369ce873ce19
  5d50d5f (akashmukherjee@google.com)
      [3pp] Added compute_hash function to file module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibfa256fd08fb9c78e0a3417b363d7155a9a747c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2334982Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

01a0945e

31 Jul, 2020 1 commit

Fixed relative path to work when presubmit run from any directory · 98b332f2

Saagar Sanghavi authored Jul 31, 2020

Bug: 1111829
Change-Id: I75c616f4fa9c16c19e732e43ba740bb67f3eb827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2327839Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>

98b332f2

29 Jul, 2020 3 commits

[resultdb] Bump up the cipd pin of rdb in depot_tools · 343f6364

Roberto Carrillo authored Jul 29, 2020

cipd-link: https://chrome-infra-packages.appspot.com/p/infra/tools/rdb/linux-amd64/+/git_revision:0689318992ebca6ef8accbb4f9b6df138e863f9c

R=nodir,vadimsh

Bug: 1110107
Change-Id: I6e49740137e6ace978bf55781c8abd816a559f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2327212Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

343f6364

cros: raise python version requirement to 3.6 · a8d01735

Mike Frysinger authored Jul 29, 2020

We moved chromite to require python 3.6 all the time, so update
the wrappers to match.

Bug: 997354
Test: `cros_sdk` still works
Change-Id: I78f5dc101f98a074fdc92a1f270395e2d04a2ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2324825Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

a8d01735

Generate revisions in json output for refs/ and origin/. · 3e5d86a2

Garrett Beaty authored Jul 29, 2020

Right now the default test data for bot_update doesn't transform
revisions specifying refs for the revision except for refs starting with
refs/ on the first solution. This means that the output will just have
the ref name as the revision value, which isn't compatible with code
that requires an actual revision value.

Bug: 1047893
Change-Id: I016ad5e8db5a293dd5e6dacb5b8beba51e000949
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2325761
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3e5d86a2

28 Jul, 2020 1 commit

presubmit: Add dirmd_bin to CheckDirMetadataFormat. · 7291750a

Edward Lesmes authored Jul 28, 2020

dirmd is not available on bots, so we'll need to receive the path
where it's available as an argument.

Bug: 1102997
Change-Id: I8966225d8ded3eb06c504797280baaa6c6c64a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2321510Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7291750a

24 Jul, 2020 1 commit

presubmit: Also validate metadata in OWNERS files. · a58287b8

Edward Lesmes authored Jul 24, 2020

Bug: 1102997
Change-Id: Id847129d320004fcd121941f2e14cf9ad56ab4a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2318335Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a58287b8

23 Jul, 2020 3 commits

[resultdb] Bump up the cipd pin of rdb in depot_tools · 9e8b8f31

Scott Lee authored Jul 23, 2020

cipd-link: https://chrome-infra-packages.appspot.com/p/infra/tools/rdb/linux-amd64/+/git_revision:155c9bca589d3bf0a95ae58d62f72a4cf1554e9e

Change-Id: I8d11242de7204cf4dadfb65862746efc1fc7bc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316810Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

9e8b8f31

Make presubmit_canned_checks inclusive · d855b927

Josip Sokcevic authored Jul 23, 2020

This modifies CheckAuthorizedAuthor parameters to be inclusive while
being backwards compatbile. Also, it fixes issue with empty lists.

R=ehmaldonado@chromium.org

Bug: 1098560
Change-Id: I992b25d6408d6cb906fa1696209de253e50c5156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316706Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d855b927

gclient: Apply on patch of remote's branch-heads instead of local. · f627d9fc

Edward Lesmes authored Jul 23, 2020

refs/branch-heads/ might be out of date, as bot_update is now fetching
refs/branch-heads/* as refs/remotes/branch-heads/*.

Bug: 1108638
Change-Id: I5a221e8e01017552f42c0c52d7ef7327acc5f63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316327Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f627d9fc

22 Jul, 2020 9 commits

Adding --skip-title option to git cl upload · cebfb4e6

Mario Bianucci authored Jul 22, 2020

Adding an optional --skip-title argument to git cl upload to
automatically use the latest commit message as the patch title, without
requiring the user to hit "enter" to accept.

Change-Id: I0e37b68c809d907a4f980f2be59865e14b1a2db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2297803Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>

cebfb4e6

Roll recipe dependencies (trivial). · dc3f2b55

recipe-roller authored Jul 22, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c89555ad4aad0d235c318a660be9bb34a5d51c60
  c89555a (vadimsh@chromium.org)
      [context] Add api.context.realm property.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5465b16fbe3aaa5fe2b89645afccf104e919f07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2314837Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

dc3f2b55

Roll dirmd to 6c4507c0 · caa2f149

Nodir Turakulov authored Jul 22, 2020

Roll dirmd to 6c4507c06f51a54a6fabaf2bdf8cc2b1a6ed106e
in order to pick up
https://chromium-review.googlesource.com/c/infra/infra/+/2314058

Bug: 1106176
Change-Id: Iddf639aeb1e847b77f1176a90cf06f373303e328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2313790Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

caa2f149

Add explicit "python" to script for Windows compatibility · 71fd8abb

Greg Guterman authored Jul 22, 2020

Remove cwd augmentation for good measure. This should be done by the
caller.

Bug: 923016
Change-Id: I7f6618d7a9e56f70168fc71046412c6d462f40fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2311320
Auto-Submit: Gregory Guterman <guterman@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

71fd8abb

bot_update: Map refs to remote refs and don't checkout after clone. · e4e1fb30

Edward Lesmes authored Jul 22, 2020

Map refs to remote refs when fetching refs from origin
(e.g. refs/heads/master -> refs/remotes/origin/master)
so that a detached HEAD is not necessary.

Bug: 1104182
Change-Id: Icb751505de1bf443e5d45c4b37425223dbf6e088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310849Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e4e1fb30

Modify bot_update to support setting blamelist pins. · 6081b23b

Garrett Beaty authored Jul 22, 2020

This adds a parameter to bot_update.ensure_checkout that will cause
blamelist pins to be set for all of the repos whose revision is not
determined by DEPS files: the repo for the gitiles input, the repo for
each solution in the gclient config and any repos with the revision set
by the revisions field of the gclient config.

Bug: 1047893
Change-Id: Ie3eee41dbf15be014185b6f255ee3d4cfd40b4e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2293514
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6081b23b

Use fixed revisions in bot_update's test API output_json. · c8c88f9c

Garrett Beaty authored Jul 22, 2020

Currently the output_json method generates revisions for projects that
are in the revision_mapping and only those projects appear in the
manifest and source_manifest, using the generated revision. This method
is used to construct the default json output for bot_update in tests.
This has 2 problems:
1. If a project has a fixed revision, its manifest entries and the
property used the generated revision, meaning the gitiles input revision
will not be used in the json output.
2. If a project has a fixed revision and isn't present in
revision_mapping then manifest entries aren't generated for it.

This changes the method to use the revisions in the fixed_revisions dict
and to create manifest entries for the projects that appear in the
fixed_revisions dict which should make fewer situations where
bot_update's output_json needs to be explicitly set.

Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>

c8c88f9c

gclient: print use_relative_hooks deprecation on stderr. · 33e6e046

Corentin Wallez authored Jul 22, 2020

Printing to stdout breaks tools that parse the output of running
gclient.

TBR=ehmaldonado@chromium.org
Bug: chromium:1107325
Bug: chromium:1108301
Change-Id: I77f6eef9bdffd0534efb0b919304dab5b3df8c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2312678
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

33e6e046

[lucicfg] Update to v1.18.4. · c07c59dd

Vadim Shtayura authored Jul 22, 2020

Two notable changes:
* luci.builder(experiments={...}, ...)
* When realms are enabled, scheduler configs include `realm` field.

R=tandrii@chromium.org
CC=yulanlin@google.com

Change-Id: I17e773bdd33058b71b64c7222f4e8471bf33e83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2311565Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

c07c59dd

21 Jul, 2020 2 commits

Decode "git cl" error messages to avoid printing Python bytes · 594fd332

Alan Cutter authored Jul 21, 2020

We were not decoding the stdout bytes before printing them when git
commands returned an error status. This CL fixes that.

Before:
Command "git cherry-pick FETCH_HEAD" failed.
b'Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc\nAuto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nCONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nAuto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc\nAuto-merging chrome/browser/ui/views/frame/browser_frame.h\nAuto-merging chrome/browser/ui/views/frame/browser_frame.cc\n'

After:
Command "git cherry-pick FETCH_HEAD" failed.
Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc
Auto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
CONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
Auto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
Auto-merging chrome/browser/ui/views/frame/browser_frame.h
Auto-merging chrome/browser/ui/views/frame/browser_frame.cc
Change-Id: I162e666ca9f3a70259e6178d2e6d3b72f15b1f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310016
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

594fd332

Revert "bot_update: Refactor branch to detach and checkout." · 720e010b

Edward Lesmes authored Jul 21, 2020

This reverts commit b99e61c5.

Reason for revert:
Doesn't work for refs/branch-heads/*

Original change's description:
> bot_update: Refactor branch to detach and checkout.
> 
> Refactor _git_checkout to use information from
> get_target_branch_and_revision to know what branch to checkout after
> cloning.
> 
> Bug: 1104182
> Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: If51423df99fd9c164f8e42e0220ee2d9bc2a39f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310293Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

720e010b

20 Jul, 2020 2 commits

Preliminary changes to git cl and presubmit_support · 9949ab7a

Saagar Sanghavi authored Jul 20, 2020

Added an rdb wrapper and use it to time CheckChangeOn{Commit, Upload} from every PRESUBMIT.py file, then reports the results to ResultSink.

Bug: http://crbug.com/1107588

Change-Id: I9bc8a18ba615a76f3e0611eae5b2c4adc5924276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2242097
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

9949ab7a

bot_update: Refactor branch to detach and checkout. · b99e61c5

Edward Lesmes authored Jul 20, 2020

Refactor _git_checkout to use information from
get_target_branch_and_revision to know what branch to checkout after
cloning.

Bug: 1104182
Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b99e61c5