- 06 Sep, 2018 4 commits
-
-
Nodir Turakulov authored
Use repo_path_map in all places where patch_projects is currently used. Add gclient.get_repo_path function to resolve path to a repo given its URL. infra.git requires a non-trivial roll because of incorrect expectations. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Bug: 877161 Change-Id: Iaea0a3f14609bf0c18d4ecdf8564153b8052584d Reviewed-on: https://chromium-review.googlesource.com/1208363 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Nodir Turakulov authored
This reverts commit 01f0c698. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1211422 Original change's description: > bot_update: Specify the target branch for patch_refs. > > Bug: 870279 > Recipe-Manual-Change: build > Recipe-Manual-Change: infra > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Manual-Change: skia > Recipe-Manual-Change: release_scripts > Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 > Reviewed-on: https://chromium-review.googlesource.com/1174988 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ic78a264ccf5e2ca15452659e17d41da264560eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870279 Reviewed-on: https://chromium-review.googlesource.com/1211462Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Daniel Bratell authored
Running git cl issue -r in a tree with dozens/hundreds of branches could be a bit slow since the code parsed .git/config twice per local branch. By parsing it only once and then looking things up in a hashtable it becomes much faster. (For my local tree with 700 branches 13 seconds became 0.3 seconds) Bug: 880734 Change-Id: I67f45de32fb7f2cc5960174e59f3476ef3021a3a Reviewed-on: https://chromium-review.googlesource.com/1206352 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Corentin Wallez authored
BUG=875245 Change-Id: I50425aef624d00c1aa6fd7c18244fea128c15842 Reviewed-on: https://chromium-review.googlesource.com/1209643 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 05 Sep, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2138a9dddaede3f377b838d0227bf4c88d6e7aa0 [cipd] Add better describe simulation behavior. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I186c41b0fbbcc1933da7f56aa15844c0ec41acb2 Reviewed-on: https://chromium-review.googlesource.com/1208332 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
Edward Lemur authored
Bug: 870279 Recipe-Manual-Change: build Recipe-Manual-Change: infra Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: skia Recipe-Manual-Change: release_scripts Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 Reviewed-on: https://chromium-review.googlesource.com/1174988 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b93bbf63414b69ca70b4fc85020c31518fbed812 [buildbucket] Remove tags from test_api.py (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb0c788d18c1e89505ed98c581f8c3d3adaf8ddb Reviewed-on: https://chromium-review.googlesource.com/1208330Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3810d923a1db3efaa75734efef8708fa5e0d6a1d Add a sentinel object for representing all return codes are ok. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9bbfe5a29940e4b7932315db4624fa7f3e7f6433 Reviewed-on: https://chromium-review.googlesource.com/1207430Reviewed-by:
-
Daniel Cheng authored
Files that control ownership have special ownership rules, to disallow someone from self-approving a CL that adds themselves to a file that controls ownership. owners.py now requires that they be named OWNERS or end with a suffix of _OWNERS to ensure the special ownership rules are correctly applied. Bug: 801315 Change-Id: I083a2d15bdc9c749e3838fb1c983286d5a7c4af9 Reviewed-on: https://chromium-review.googlesource.com/1204917Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
-
- 04 Sep, 2018 1 commit
-
-
Nodir Turakulov authored
Add a function to parse a Gitiles repo URL supporting various edge cases. R=tandrii@chromium.org Bug: 877161 Change-Id: Ib4d6a28a2ace2e594f1a4ca31460a446fc6fa052 Reviewed-on: https://chromium-review.googlesource.com/1204914 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
- 31 Aug, 2018 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87 [buildbucket] add support for parent_got_revision (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I89ec3f6739de006026b5cb2257328166c4cdbbfe Reviewed-on: https://chromium-review.googlesource.com/1199579Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574 [buildbucket] Ignore "repository" and "branch" properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I698424bcf4c45304fb78fa09241cf054e9011ce9 Reviewed-on: https://chromium-review.googlesource.com/1199577Reviewed-by:
-
Nodir Turakulov authored
repository and revision have less to do with each other than it seems: revision is for checkout and the part of code that reads revision does not read repository. repository property is used to determine what to apply the patchset to. When initializing their values from buildbucket.build.input, do it separately. Also, initialize repository from Gerrit changes, not Gitiles commit. See also https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199854 https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199856 Bug: 877161, 694348 Change-Id: I4907a31ce055a3526b15f1a3c8e8f15c2c831437 Reviewed-on: https://chromium-review.googlesource.com/1200065Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34 Reland [buildbucket] Parse CL from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iccc8b337c6e7de9d36a4933c1d3938cdbb84226f Reviewed-on: https://chromium-review.googlesource.com/1199568Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82 Reland "[buildbucket] fill gitiles commit from legacy properties" (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie75d1ca16b851b28db0f9f72e5df44f66cd7189a Reviewed-on: https://chromium-review.googlesource.com/1199562Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78 [buildbucket] Include child build tags in legacy tests (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a6e5a47b962de34ecfbb085f6873d0bafa76a77 Reviewed-on: https://chromium-review.googlesource.com/1199008Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715 Revert "[buildbucket] fill gitiles commit from legacy properties" (machenbach@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I97ad9323de56241eaeb9fa2fdb29094718120276 Reviewed-on: https://chromium-review.googlesource.com/1199005 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b Revert "[buildbucket] Parse CL from legacy properties" (machenbach@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3e5f4a2c3ab7a9a9cd81d489d4d575605bb109ba Reviewed-on: https://chromium-review.googlesource.com/1199003Reviewed-by:
-
- 30 Aug, 2018 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0 [buildbucket] Parse CL from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I543c3261779df35ebe27db69a754a6fda2ab54b0 Reviewed-on: https://chromium-review.googlesource.com/1197684Reviewed-by:
-
Nodir Turakulov authored
When checking if buildbucket.build_input.gitiles_commit exists, use HasField protobuf method, as opposed to truth check. A protobuf message field is always true. Bug: 877161 Change-Id: Ie4a7e22b985776441a74283b09646e8837c326f1 Reviewed-on: https://chromium-review.googlesource.com/1196930 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60 [buildbucket] fill gitiles commit from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I804bd9a80b90e48c9b906420edbf70d13af7e8ae Reviewed-on: https://chromium-review.googlesource.com/1197682 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b [buildbucket] Rewrite buildbucket recipe module (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7ad9615899c39c4ce16c1317e739ceab09841661 Reviewed-on: https://chromium-review.googlesource.com/1197182 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
- 29 Aug, 2018 1 commit
-
-
Stephen Martinis authored
`git cl split` currently runs a cq dry run for every uploaded CL. This has overloaded our infrastructure a few times in the past. This CL changes the command to not dry run by default, and adds a flag to enable this. The flag has a warning about doing this, and tells the user to email infra-dev@chromium.org if they're going to be generating >~10 CLs. Bug: 878117 Change-Id: Ic865c09b188b8d4f202785f4763f7b7b8910c9cf Reviewed-on: https://chromium-review.googlesource.com/1191927Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
- 28 Aug, 2018 7 commits
-
-
Peter K. Lee authored
Adds status:merged to gerrit filter. Bug: 878433 Change-Id: Ica081fa0cd0e8a267ec0a8d711f749b4e91faec5 Reviewed-on: https://chromium-review.googlesource.com/1194310Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: Ibc631bf049440d158de757da0a225ed28f892891 Reviewed-on: https://chromium-review.googlesource.com/1194314Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I218a8198d06e51ac2eb57636bbccca9aadc7d81a Reviewed-on: https://chromium-review.googlesource.com/1194312Reviewed-by:
-
erikchen authored
This causes git cl patch to unnecessarily fail for the build repo. e.g. """ Trying to patch a change from https://chromium.googlesource.com/chromium/tools/build but this repo appears to be https://chromium.googlesource.com/chromium/tools/build/. """ Change-Id: I91d6ab1325bb88c001c20c20007c30e111ab8f64 Reviewed-on: https://chromium-review.googlesource.com/1194485Reviewed-by:
-
Tomasz Śniatowski authored
Change-Id: Ifb598565e0a048cc0acbb8afa506762ab05ce42c Reviewed-on: https://chromium-review.googlesource.com/1192443Reviewed-by:
-
Edward Lemur authored
Bug: 877902 Change-Id: I77a1f213318d1e09ae050c2ea0113b2976bd259e Reviewed-on: https://chromium-review.googlesource.com/1191928Reviewed-by:
-
Andrii Shyshkalov authored
* remove tests which weren't actually testing any new code path. * remove Rietveld tests, except 1. * change default to Gerrit. R=ehmaldonado Bug: 719954 Change-Id: I27e59036bbafb870cadc4d6208d21ba17c48c8c0 Reviewed-on: https://chromium-review.googlesource.com/1188992Reviewed-by:
-
- 27 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: I6e288283c0033fb48a0b8ece8c06f6813f9a9d8a Reviewed-on: https://chromium-review.googlesource.com/1186158 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 25 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I258efa0a95f20b80819bc89cccfb5e0a29e09d5c Reviewed-on: https://chromium-review.googlesource.com/1188989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 23 Aug, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597 [file] Add flatten_single_directories function. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I44ccca7d3d6c580d3df711d8c3b4ca2f2f22d192 Reviewed-on: https://chromium-review.googlesource.com/1187602 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
This fixes Gerrit project detection based on remote URL, accounting for potential 'a/' prefix in the URL path component, which isn't part of the Gerrit project name. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I473ae8c6c9e0f2034b350901abd67db151e0a3d3 Reviewed-on: https://chromium-review.googlesource.com/1187573Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Broke release process. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I02ea424632f5c5522af0010adce1c993e2610b48 Reviewed-on: https://chromium-review.googlesource.com/1187548Reviewed-by:
-
John Budorick authored
Bug: 876734 Change-Id: I5741b526f14d79f7a8eb42808c1eef93434739cb Reviewed-on: https://chromium-review.googlesource.com/1187368Reviewed-by:
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: Ie8a2dbf4c135f9f84c00c4d04d7ef1c2e9480e45 Reviewed-on: https://chromium-review.googlesource.com/1186157Reviewed-by:
-
Andrii Shyshkalov authored
Sadly, this makes maintaining one test handling covering exceptional circumstance very complex, so it was removed. I've decoupled test that ensures that GetRemoteUrl works from upload codepath. R=ehmaldonado@chromium.org Bug: 876910 Change-Id: I39de410c72d893e73492d5c3fc8f60a6ebc4f11f Reviewed-on: https://chromium-review.googlesource.com/1186142Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado@chromium.org Testing patched my own depot_tools in $PATH and uploaded https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1186072 which set reviewers and ccs as expected. Bug: 876910 Change-Id: I43c0f2284941cf703133bb51132226d4a0472d8e Reviewed-on: https://chromium-review.googlesource.com/1186068 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 22 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ia35da60783cfbfd472646176d8fc669d8f4d9839 Reviewed-on: https://chromium-review.googlesource.com/1185989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
