- 13 Jul, 2017 1 commit
-
-
Matt Giuca authored
A regression in git-blame prints an incorrect error message which causes this test case to fail. Alter the test to only check the start of the string, until the bug is fixed upstream. Bug: 737688 Change-Id: I4045cb8792d8abe984215c7198e213b23e9f6f5d Reviewed-on: https://chromium-review.googlesource.com/567778 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org>
-
- 11 Apr, 2017 1 commit
-
-
Matt Giuca authored
BUG=709835 Change-Id: Ia203cf24adf752ef3acdf660b4fe0990503782b9 Reviewed-on: https://chromium-review.googlesource.com/472587Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
-
- 10 Apr, 2017 1 commit
-
-
Matt Giuca authored
This could, in extreme cases, result in a crash due to the wrong line number being out of bounds of the file line count. BUG=709831 Change-Id: I08ec75362d49c4a72e7ee9fd489d5f9baa6d31bd Reviewed-on: https://chromium-review.googlesource.com/472648Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
-
- 17 Jun, 2016 1 commit
-
-
mgiuca authored
Review-Url: https://codereview.chromium.org/2075923003
-
- 16 Jun, 2016 1 commit
-
-
vapier authored
Review-Url: https://codereview.chromium.org/2076613002
-
- 22 Feb, 2016 1 commit
-
-
mgiuca@chromium.org authored
Added --ignore-file argument, so you can specify ignored commits in a file rather than as raw command-line arguments. Also, automatically searches for a file called .git-blame-ignore-revs, which is automatically used as an ignore list by default. Also, specifying an unknown revision (either on the command line or in a file) now generates a warning, not an error. Notes on some decisions: - The file is called .git-blame-ignore-revs (not mentioning hyper-blame) because we may use the same list in tools other than hyper-blame in the future. - We look at the *currently checked out* version of .git-blame-ignore-revs (not the version at the specified revision) for consistency with .git-ignore. Because we only expect revisions to be added (not deleted), it should be fine to use an ignore list from a newer version than the revision being blamed. - We considered using git notes for the ignore list so that you could add a revision to the ignore list without needing a follow-up CL. However, there are some problems with this approach. git notes is not automatically synced with git clone/pull. Also the Chromium infra tools (Reitveld, CQ) are not set up to allow modification of git notes, nor are changes to git notes subject to OWNERS checks. Using a regular file ensures all users synced to a particular revision are using the same ignore list. BUG=574290 Review URL: https://codereview.chromium.org/1697423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298897 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Feb, 2016 1 commit
-
-
mgiuca@chromium.org authored
Previously, when a commit was skipped, it would be blamed on the line number the line had *after* the skipped commit. This could mean a totally unrelated commit gets blamed. Now, a heuristic analyses the diff of the skipped commit to discover approximately what line number the line had *before* the skipped commit, so it can hopefully be blamed on the right commit. BUG=574290 Review URL: https://codereview.chromium.org/1629253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298609 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Feb, 2016 1 commit
-
-
mgiuca@chromium.org authored
Currently, the script requires you to pass the unwanted commits on the command line, but eventually, you could configure it with a file (checked into the repo) that provides a fixed set of commits to always skip (such as commits that do a huge amount of renaming and nothing else). BUG=574290 Review URL: https://codereview.chromium.org/1559943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298544 0039d316-1c4b-4281-b951-d872f2087c98
-