- 16 Apr, 2012 2 commits
-
-
maruel@chromium.org authored
This completely broke syncing on Windows. TBR=mukai@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9956149 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132451 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=114483 TEST=manually Review URL: http://codereview.chromium.org/10034011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132446 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2012 2 commits
-
-
maruel@chromium.org authored
Enable it for git-cl and gcl. R=nsylvain@chromium.org BUG=107838 TEST=New connections go through https:// Review URL: http://codereview.chromium.org/9214004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117857 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
So any modification to the defaults is coded at only one place. TBR=nsylvain@chromium.org BUG=107838 TEST= Review URL: http://codereview.chromium.org/9214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117853 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
Windows users wouldn't get the same behavior on git cl vs gcl. Improve automatic CRLF<->LF conversion, some gcl users would be \n repeated in their description depending on the editor used. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8360007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@107106 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
Otherwise isatty() could not be proxied correctly. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8370004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106864 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Oct, 2011 1 commit
-
-
maruel@chromium.org authored
directory doesn't exist, on fresh checkout and --jobs >1. It happens in the case where there is 3 dependencies: a a/b/c/d a/b/c/e 'a' is processed first. Then 'a/b/c/d' and 'a/b/c/e' are fired simultaneously. If both are not present, both svn checkout tries to mkdir b and b/c and a race condition occurs between their call for isdir() and mkdir(). This works around the issue by creating the intermediary directories ourself before calling out svn and managing the error ourself. TBR=dpranke@chromium.org BUG= TEST=fresh checkout shouldn't be flaky Review URL: http://codereview.chromium.org/8359018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
I had forgot one access to _requirements. Now that tests are run, this change is safer to commit. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7909012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101856 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add a warning when RunUnitTestsInDirectory() finds no test to run to catch this kind of regression. Fix all the regressions that where introduced in the meantime... TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7906009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Apr, 2011 1 commit
-
-
floitsch@google.com authored
When specifying a revision (with -r) propagates the date of the revision to its children. Review URL: http://codereview.chromium.org/6873110 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83313 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 3 commits
-
-
maruel@chromium.org authored
Reapply r80770 "Switch from xml.dom.minidom to xml.etree". TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Throws exceptions on mac. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6811020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6799021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Horked windows slaves this time. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6689023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80220 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It should be fine now that I've fixed python2.5 compatilibity issues in subprocess2.py. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6759074 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80216 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Makes all the tests runnable on python 2.5. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6690034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80068 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Mar, 2011 2 commits
-
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79781 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6770028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79779 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Mar, 2011 2 commits
-
-
dpranke@chromium.org authored
TBR=maruel@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79005 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
The parsing of change descriptions had a lot of overlap and inconsistencies between gcl and git-cl. In particular, we weren't handling TBR= consistently, or probably a few other things. This change moves most of the code into presubmit_support and gclient_utils and just leaves the formatting differences for the messages between the two tools. Review URL: http://codereview.chromium.org/6719004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79002 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Keep an alias to RemoveDirectory, will be removed in a later change. TEST=new unit test to test this function BUG=none Review URL: http://codereview.chromium.org/6628032 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77463 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Change RunPylint to parse all .py files when one is modified. Make all depot_tools/tests pass on pylint. That mostly meant fixing some builtins aliasing, wrong alignment and turning off most remaining warnings. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/5695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Nov, 2010 1 commit
-
-
maruel@chromium.org authored
Python standard library is not thread safe. Work around it by leaking a bit. The problem is particularly visible on python 2.4. TEST=none BUG=60623 Review URL: http://codereview.chromium.org/4465001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65048 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 1 commit
-
-
maruel@chromium.org authored
Most of them are style issues or variable aliasing. TEST=Can almost enable pylint warnings BUG=none Review URL: http://codereview.chromium.org/4360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Oct, 2010 1 commit
-
-
maruel@chromium.org authored
Contributed by Torsten Becker <torsten.becker@gmail.com> BUG= TEST=gclient config 'ssh://user-name@asd.com/~/asd.git' && gclient sync # fails in SplitUrlRevision Review URL: http://codereview.chromium.org/4144002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63877 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Oct, 2010 1 commit
-
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/3737001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62400 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
Had to update a few tests, removed redundant code in gclient_scm_tests. TEST=more readable unit tests BUG=none Review URL: http://codereview.chromium.org/3473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59959 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
In the next change, we can now remove all the options.stdout bookeeping since it's not unnecessary. TEST=none BUG=none Review URL: http://codereview.chromium.org/3398008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59795 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The end goal is to remove options.stdout, to remove a lot of bookkeeping. TEST=none BUG=none Review URL: http://codereview.chromium.org/3418014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59792 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
TEST=none BUG=54084 Review URL: http://codereview.chromium.org/3347019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58985 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Simplify ExecutionQueue.run() by moving code into utility functions. Reduce the amount of code in WorkerThread.run() to improve reliability. Don't trap exceptions in single-threaded usage! BUG=54084 TEST=none Review URL: http://codereview.chromium.org/3336015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58974 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
An automated work around for python lack of stdout flushing. This design simplifies life once parallel checkout is enabled. TEST=none BUG=none Review URL: http://codereview.chromium.org/3342024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58819 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
Change CheckCallError to inherit from Error. This will simplify try/except changes. TEST=none BUG=none Review URL: http://codereview.chromium.org/3324007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58695 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
Simplify code by removing fail_status Rename print_messages to always Simplify the doc. Review URL: http://codereview.chromium.org/3104036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58201 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
This way the function is much more similar to subprocess.call(). Further changes will be done, to be able to convert all the function, to be able to parallelize output without corrupting it. Used pylint to verify call graph correctness, causing some other unrelated changes. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/3117039 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57369 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Aug, 2010 3 commits
-
-
maruel@chromium.org authored
It will eventually replace 'print_messages' and be used to annotate printed lines when using --jobs. Review URL: http://codereview.chromium.org/3174020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57092 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Original Description: Remove code duplication and improve style. Create a Popen function to reduce code duplication. Use RemoveDirectory where relevant. Make drover slightly more posix friendly. Review URL: http://codereview.chromium.org/3199011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57083 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Improve gclient_utils to test output lacking trailing LF BUG=none TEST=new unit tests Review URL: http://codereview.chromium.org/3140023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57047 0039d316-1c4b-4281-b951-d872f2087c98
-