TBR=pgervais@chromium.org
R=akuegel@chromium.org, tandrii@chromium.org, phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1183363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295718 0039d316-1c4b-4281-b951-d872f2087c98

The properties are removed by this CL: https://codereview.chromium.org/1178923007 and https://codereview.chromium.org/1177953005/ https://codereview.chromium.org/1182053004/

BUG=500735
R=dnj@chromium.org, sergiyb@chromium.org

Review URL: https://codereview.chromium.org/1184143006.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295690 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 78624b68.

The reason is that install-build-deps.sh isn't meant to be run on mac
or windows, and this implementation ran it everywhere.

TBR=dpranke@chromium.org
BUG=229270

Review URL: https://codereview.chromium.org/1186893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=457428

Review URL: https://codereview.chromium.org/1177953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295680 0039d316-1c4b-4281-b951-d872f2087c98

R=mmoss@chromium.org
BUG=229270

Review URL: https://codereview.chromium.org/1187913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295679 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=479837,499650

Review URL: https://codereview.chromium.org/1181103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295664 0039d316-1c4b-4281-b951-d872f2087c98

TBR=agable@chromium.org
BUG=499031

Review URL: https://codereview.chromium.org/1182713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295642 0039d316-1c4b-4281-b951-d872f2087c98

  * When aborting a failed rebase, don't cascade errors if the abort itself
    fails.
  * When starting a rebase-update cycle, cd to the root of the repo. This avoids
    an issue when you run rebase-update from inside of a branch which adds a
    new folder.

R=agable@chromium.org
BUG=499031

Review URL: https://codereview.chromium.org/1180673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=496892

Review URL: https://codereview.chromium.org/1156223008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295634 0039d316-1c4b-4281-b951-d872f2087c98

R=agable@chromium.org
BUG=437397

Review URL: https://codereview.chromium.org/1150353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=491889

Review URL: https://codereview.chromium.org/1176243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295626 0039d316-1c4b-4281-b951-d872f2087c98

CL https://codereview.chromium.org/1172223002 changed the meaning of the
third value in the tuple returned by get_cl_statuses from a color to the
status of the branch and broke the formatting of output.

Convert the status to the color using color_for_status helper function.

BUG=499189

Review URL: https://codereview.chromium.org/1175103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230693
R=agable@chromium.org

Review URL: https://codereview.chromium.org/1169403002.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295611 0039d316-1c4b-4281-b951-d872f2087c98

R=agable@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/1135563005.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295609 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Specify GIT_DIR when running git-config in a mirror. (patchset #4 id:60001 of https://codereview.chromium.org/1167193002/)

Reason for revert:
Potentially broke the NaCl toolchain builders:
crbug.com/498942

Speculative revert.

Original issue's description:
> Specify GIT_DIR when running git-config in a mirror.
> 
> BUG=497894
> R=hinoka@chromium.org,agable@chromium.org
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295587

TBR=agable@chromium.org,szager@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497894

Review URL: https://codereview.chromium.org/1179593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295607 0039d316-1c4b-4281-b951-d872f2087c98

Example of output:

$ git cl status
Branches associated with reviews:
  git-cl-status : None
         master : None
          owner : https://codereview.chromium.org/983843003 (closed)
     testfilter : None

Current branch: no issue assigned.

R=vadimsh@chromium.org
BUG=362198

Review URL: https://codereview.chromium.org/1172223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=497894
R=hinoka@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/1167193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295587 0039d316-1c4b-4281-b951-d872f2087c98

In git version 2.4 the git branch command prints "* (HEAD detached at"
or "* (HEAD detached from" instead of "* (detached from". Adjust the parsing to make our tests
still work with git 2.4.

BUG=487172

Review URL: https://codereview.chromium.org/1162763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1157543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295572 0039d316-1c4b-4281-b951-d872f2087c98

This cl ensures that gclient enforces sane revision overrides and
onfiguration when running a revert, just like it does on a normal sync/update.

R=iannucci@chromium.org
BUG=420919

Review URL: https://codereview.chromium.org/1160113003.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=493885
TESTED=See https://paste.googleplex.com/5622248052359168

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295569

R=nodir@chromium.org

Review URL: https://codereview.chromium.org/1164363003.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=493885
TESTED=See https://paste.googleplex.com/5622248052359168

Review URL: https://codereview.chromium.org/1164363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=497943
R=hinoka@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/1163403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295568 0039d316-1c4b-4281-b951-d872f2087c98

Because some interfaces aren't linkifying the URL when the commit message ends with it.

BUG=480922
TESTED=tests/git_cl_test.py; presubmit ok

Review URL: https://codereview.chromium.org/1165293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295566 0039d316-1c4b-4281-b951-d872f2087c98

Based on yapf (https://github.com/google/yapf) this
formatter currently only works with --full.  It defaults
to pep8 style and projects that use a different style
can add .style.yapf to the top level.

Review URL: https://codereview.chromium.org/1156743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295547 0039d316-1c4b-4281-b951-d872f2087c98

The last remaining failing test is fixed now, so we
should be fine with enabling this trybot for CQ.

BUG=420910

Review URL: https://codereview.chromium.org/1149943010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295540 0039d316-1c4b-4281-b951-d872f2087c98

After changing this to '%f%' instead of just '%' this doesn't
work anymore. It should be '%f%%' instead.

BUG=
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/1156023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295539 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the check for base URL to a query to the json endpoint.
This makes the test pass on the trybot.

BUG=353718

Review URL: https://codereview.chromium.org/1160273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=495944
R=sebmarchand@chromium.org

Review URL: https://codereview.chromium.org/1162003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295527 0039d316-1c4b-4281-b951-d872f2087c98

Based on some fiddling on a local VM (see bug), but possibly still insufficient.

TBR=sebmarchand@chromium.org
BUG=492774, 495944

Review URL: https://codereview.chromium.org/1160683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295521 0039d316-1c4b-4281-b951-d872f2087c98

Since we no longer have a 32-bit Linux GN binary, we shouldn't
try to point to one in the gn.py wrapper; this was hiding a
bug on one of the NaCl bots.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1152163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295520 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/1162993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295512 0039d316-1c4b-4281-b951-d872f2087c98

This must land in sync with https://chromereviews.googleplex.com/202077014 and
revert in sync.

R=akuegel@chromium.org
TBR=pgervais@chromium.org
BUG=471767

Review URL: https://codereview.chromium.org/1157843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295509 0039d316-1c4b-4281-b951-d872f2087c98

This introduces changes from https://chromereviews.googleplex.com/206957013/.

R=akuegel@chromium.org
TBR=pgervais@chromium.org
BUG=471767

Review URL: https://codereview.chromium.org/1156373013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=420910

Review URL: https://codereview.chromium.org/1129153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295504 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dpranke@chromium.org
R=sebmarchand@chromium.org,davidben@chromium.org

Review URL: https://codereview.chromium.org/1155973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295498 0039d316-1c4b-4281-b951-d872f2087c98

This allows to avoid conflicts with libraries in users' PATH

R=pgervais@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/1161803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295497 0039d316-1c4b-4281-b951-d872f2087c98

Revert of win: Fix current toolchain path with old packaging (patchset #1 id:1 of https://codereview.chromium.org/1159433006/)

Reason for revert:
Breaking chromium waterfall.

Original issue's description:
> win: Fix current toolchain path with old packaging
> 
> I broke boringssl's use of depot_tools toolchain as I changed the
> name of the sdk path key. This happened to work in Chrome because
> src/ has fallback behaviour.
> 
> Restore the 'win8sdk' name when unpacking a current/old-style
> toolchain package (i.e. what everyone is still using).
> 
> TBR=dpranke@chromium.org
> R=davidben@chromium.org
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295492

TBR=davidben@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1167753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295493 0039d316-1c4b-4281-b951-d872f2087c98

I broke boringssl's use of depot_tools toolchain as I changed the
name of the sdk path key. This happened to work in Chrome because
src/ has fallback behaviour.

Restore the 'win8sdk' name when unpacking a current/old-style
toolchain package (i.e. what everyone is still using).

TBR=dpranke@chromium.org
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/1159433006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295492 0039d316-1c4b-4281-b951-d872f2087c98

When using a raw URL from a different Rietveld instance than the one
in codereview.settings, you get an error like this:

File "depot_tools/git_cl.py", line 2767, in PatchIssue
    RunGit(['commit', '-m', (cl.GetDescription() + '\n\n' +
UnboundLocalError: local variable 'cl' referenced before assignment

This fixes that. It is needed for the WebRTC transition to the
Chromium Rietveld instance using https://codereview.webrtc.org

BUG=webrtc:3884
TESTED=In a WebRTC checkout: ran 'git cl patch https://codereview.webrtc.org/download/issue1135893005_1.diff'
on a clean branch and had it apply correctly.
In a Chromium checkout, ran 'git cl patch 1154023002' and verified
the commit message was correct.
I also ran using the raw URL and verified the result was the same.

Review URL: https://codereview.chromium.org/1166673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295491 0039d316-1c4b-4281-b951-d872f2087c98