- 31 Aug, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34 Reland [buildbucket] Parse CL from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iccc8b337c6e7de9d36a4933c1d3938cdbb84226f Reviewed-on: https://chromium-review.googlesource.com/1199568Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82 Reland "[buildbucket] fill gitiles commit from legacy properties" (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie75d1ca16b851b28db0f9f72e5df44f66cd7189a Reviewed-on: https://chromium-review.googlesource.com/1199562Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78 [buildbucket] Include child build tags in legacy tests (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a6e5a47b962de34ecfbb085f6873d0bafa76a77 Reviewed-on: https://chromium-review.googlesource.com/1199008Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715 Revert "[buildbucket] fill gitiles commit from legacy properties" (machenbach@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I97ad9323de56241eaeb9fa2fdb29094718120276 Reviewed-on: https://chromium-review.googlesource.com/1199005 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b Revert "[buildbucket] Parse CL from legacy properties" (machenbach@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3e5f4a2c3ab7a9a9cd81d489d4d575605bb109ba Reviewed-on: https://chromium-review.googlesource.com/1199003Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 30 Aug, 2018 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1a9239db3740a699a5b7ba732cd0be42b89548e0 [buildbucket] Parse CL from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I543c3261779df35ebe27db69a754a6fda2ab54b0 Reviewed-on: https://chromium-review.googlesource.com/1197684Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Nodir Turakulov authored
When checking if buildbucket.build_input.gitiles_commit exists, use HasField protobuf method, as opposed to truth check. A protobuf message field is always true. Bug: 877161 Change-Id: Ie4a7e22b985776441a74283b09646e8837c326f1 Reviewed-on: https://chromium-review.googlesource.com/1196930 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60 [buildbucket] fill gitiles commit from legacy properties (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I804bd9a80b90e48c9b906420edbf70d13af7e8ae Reviewed-on: https://chromium-review.googlesource.com/1197682 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b [buildbucket] Rewrite buildbucket recipe module (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7ad9615899c39c4ce16c1317e739ceab09841661 Reviewed-on: https://chromium-review.googlesource.com/1197182 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 29 Aug, 2018 1 commit
-
-
Stephen Martinis authored
`git cl split` currently runs a cq dry run for every uploaded CL. This has overloaded our infrastructure a few times in the past. This CL changes the command to not dry run by default, and adds a flag to enable this. The flag has a warning about doing this, and tells the user to email infra-dev@chromium.org if they're going to be generating >~10 CLs. Bug: 878117 Change-Id: Ic865c09b188b8d4f202785f4763f7b7b8910c9cf Reviewed-on: https://chromium-review.googlesource.com/1191927Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
- 28 Aug, 2018 7 commits
-
-
Peter K. Lee authored
Adds status:merged to gerrit filter. Bug: 878433 Change-Id: Ica081fa0cd0e8a267ec0a8d711f749b4e91faec5 Reviewed-on: https://chromium-review.googlesource.com/1194310Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: Ibc631bf049440d158de757da0a225ed28f892891 Reviewed-on: https://chromium-review.googlesource.com/1194314Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I218a8198d06e51ac2eb57636bbccca9aadc7d81a Reviewed-on: https://chromium-review.googlesource.com/1194312Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
erikchen authored
This causes git cl patch to unnecessarily fail for the build repo. e.g. """ Trying to patch a change from https://chromium.googlesource.com/chromium/tools/build but this repo appears to be https://chromium.googlesource.com/chromium/tools/build/. """ Change-Id: I91d6ab1325bb88c001c20c20007c30e111ab8f64 Reviewed-on: https://chromium-review.googlesource.com/1194485Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org>
-
Tomasz Śniatowski authored
Change-Id: Ifb598565e0a048cc0acbb8afa506762ab05ce42c Reviewed-on: https://chromium-review.googlesource.com/1192443Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Edward Lemur authored
Bug: 877902 Change-Id: I77a1f213318d1e09ae050c2ea0113b2976bd259e Reviewed-on: https://chromium-review.googlesource.com/1191928Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
* remove tests which weren't actually testing any new code path. * remove Rietveld tests, except 1. * change default to Gerrit. R=ehmaldonado Bug: 719954 Change-Id: I27e59036bbafb870cadc4d6208d21ba17c48c8c0 Reviewed-on: https://chromium-review.googlesource.com/1188992Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 27 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: I6e288283c0033fb48a0b8ece8c06f6813f9a9d8a Reviewed-on: https://chromium-review.googlesource.com/1186158 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I258efa0a95f20b80819bc89cccfb5e0a29e09d5c Reviewed-on: https://chromium-review.googlesource.com/1188989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 23 Aug, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597 [file] Add flatten_single_directories function. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I44ccca7d3d6c580d3df711d8c3b4ca2f2f22d192 Reviewed-on: https://chromium-review.googlesource.com/1187602 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Andrii Shyshkalov authored
This fixes Gerrit project detection based on remote URL, accounting for potential 'a/' prefix in the URL path component, which isn't part of the Gerrit project name. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I473ae8c6c9e0f2034b350901abd67db151e0a3d3 Reviewed-on: https://chromium-review.googlesource.com/1187573Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Broke release process. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I02ea424632f5c5522af0010adce1c993e2610b48 Reviewed-on: https://chromium-review.googlesource.com/1187548Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
John Budorick authored
Bug: 876734 Change-Id: I5741b526f14d79f7a8eb42808c1eef93434739cb Reviewed-on: https://chromium-review.googlesource.com/1187368Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado, hinoka Bug: 876910 Change-Id: Ie8a2dbf4c135f9f84c00c4d04d7ef1c2e9480e45 Reviewed-on: https://chromium-review.googlesource.com/1186157Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Sadly, this makes maintaining one test handling covering exceptional circumstance very complex, so it was removed. I've decoupled test that ensures that GetRemoteUrl works from upload codepath. R=ehmaldonado@chromium.org Bug: 876910 Change-Id: I39de410c72d893e73492d5c3fc8f60a6ebc4f11f Reviewed-on: https://chromium-review.googlesource.com/1186142Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado@chromium.org Testing patched my own depot_tools in $PATH and uploaded https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1186072 which set reviewers and ccs as expected. Bug: 876910 Change-Id: I43c0f2284941cf703133bb51132226d4a0472d8e Reviewed-on: https://chromium-review.googlesource.com/1186068 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 22 Aug, 2018 3 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ia35da60783cfbfd472646176d8fc669d8f4d9839 Reviewed-on: https://chromium-review.googlesource.com/1185989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: I5be27cb025f8237cef0186c90eb7b99d000076d9 Reviewed-on: https://chromium-review.googlesource.com/1185986 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Corentin Wallez authored
BUG=chromium:875245 Change-Id: Ieed7554c55bab2bc5820cf4ffbbf57b72492b90f Reviewed-on: https://chromium-review.googlesource.com/1183432Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
- 21 Aug, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2310fc75c6b6cd672558934d92f04e6ccd449140 Keep fewer copies of data to sanitize utf-8 in OutputPlaceholders too. (thakis@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I78a3487320c2dc90b346e36b072504ce24432a7b Reviewed-on: https://chromium-review.googlesource.com/1183992Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 20 Aug, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f32ed079ee0ee36fd060da830393d7bee5c0e590 Cleanup changes related to step_text/log post_process functions. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9f05ee744fc91d75cba2244447b2f1526cd76be2 Reviewed-on: https://chromium-review.googlesource.com/1182364 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Raul E Rangel authored
BUG=none TEST=Made sure my coreboot commits show up Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: If4e3fd501d844da56555a065e2911748a450b36c Reviewed-on: https://chromium-review.googlesource.com/1173069Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918 Add service-account support to recipe-py's cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If6d04864ff9665e3ca319095555581a733895089 Reviewed-on: https://chromium-review.googlesource.com/1181781 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/53053ef702fea3816a322b4ecc697348e7002555 Don't keep multiple copies of data in memory to sanitize utf-8. (thakis@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibd8941968da44700c473a8a996365484828febea Reviewed-on: https://chromium-review.googlesource.com/1181473 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Raul E Rangel authored
The `DST Root CA X3` certificate was missing from cacerts.txt in the old version. This resulted in failure to connect to Let's Encrypt hosts. e.g., https://review.coreboot.org BUG=none TEST=Made sure my_activity.py continues to function and it can also connect to review.coreboot.org Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I519916b58a59b8f13c227218e93c392a63a24800 Reviewed-on: https://chromium-review.googlesource.com/1173064Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 18 Aug, 2018 1 commit
-
-
Ben Pastene authored
Change-Id: Id1c0ab59864c0e1043751f8825828f7ae9cf9ac4 Reviewed-on: https://chromium-review.googlesource.com/1180479 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 17 Aug, 2018 1 commit
-
-
John Budorick authored
Bug: 865882 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Change-Id: I4a04c4c28c7dc63ad282f54604c300bbfe654f11 Reviewed-on: https://chromium-review.googlesource.com/1157687 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Aug, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/99a5a657f34715544dae41925c0d418482dc00c4 Fix type-checking for default tuple vals in cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2487e3acb9d7b093f11ea78f1b67d1174eaa1771 Reviewed-on: https://chromium-review.googlesource.com/1179083 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/373fc6c634e2082536176f66e106260fed801485 Add pkg-var support to cipd recipe_module. (bpastene@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1dc9adfa4f26ea4ed4f2576f13e811f7065d13d2 Reviewed-on: https://chromium-review.googlesource.com/1178721Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Vadim Shtayura authored
This is Windows counterpart to https://chromium-review.googlesource.com/1171957 Also cleanup code style in cipd.ps1 script. It appears the common convention for global variables in PowerShell is $GlobalVar and for locals is $localVar. R=nodir@chromium.org, iannucci@chromium.org BUG=870166 Change-Id: Ib8ffbad85497db31f7f5d44fdca6ed843e56f220 Reviewed-on: https://chromium-review.googlesource.com/1175248 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-