- 14 Jan, 2014 2 commits
-
-
jochen@chromium.org authored
BUG=none R=iannucci@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/130803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244793 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Write a small HowTo to help confused people by confusing checks. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/137653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244717 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Jan, 2014 1 commit
-
-
dtseng@chromium.org authored
With the addition of this method, rietveld.py can be used to create cli-based tools to review Chromium code. BUG=none Review URL: https://codereview.chromium.org/127083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244529 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jan, 2014 1 commit
-
-
hinoka@google.com authored
When download_from_google_storage --config is run, it should be implied that the user just wants to download, not upload. This change passes the '-r' flag into gsutil config, which requests a read-only scoped token rather than write token. This is saved in ~/.boto.depot_tools so that it doesn't conflict with a ~/.boto file crated later that may have write permissions. BUG= Review URL: https://codereview.chromium.org/135153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244276 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jan, 2014 2 commits
-
-
pgervais@chromium.org authored
Passing the email address used to connect to Rietveld on the command line is useful for testing purposes, in particular with a test server. BUG=331123 Review URL: https://codereview.chromium.org/122583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244017 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
It takes more than 10 seconds to lint some CLs. Silently ignore the expected timeout. R=maruel@chromium.org,iannucci@chromium.org BUG=290402 TEST=none Review URL: https://codereview.chromium.org/130493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243968 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jan, 2014 1 commit
-
-
bradnelson@google.com authored
BUG=None TEST=local R=agable@chromium.org Review URL: https://codereview.chromium.org/128403007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243697 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Jan, 2014 4 commits
-
-
thestig@chromium.org authored
BUG=332101 R=thakis@chromium.org Review URL: https://codereview.chromium.org/126143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243436 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/126923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243431 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
A lot of folks have asked me how to do this while reviewing chrome changes with dependant blink changes, or when they're starting blink development. Hopefully this extra example makes figuring this out easier for blink developers. R=dpranke@chromium.org BUG=None Review URL: https://codereview.chromium.org/97983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243290 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
BUG=327494 Review URL: https://codereview.chromium.org/103803006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243221 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Jan, 2014 1 commit
-
-
jsbell@chromium.org authored
Support --output-format-heading for the headings ('Issues:', etc), and a simple --markdown flag that sets item and heading formats to something markdown friendly. R=deymo@chromium.org, szager@chromium.org, deymo Review URL: https://codereview.chromium.org/116873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243204 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2014 2 commits
-
-
pgervais@chromium.org authored
These options have been added to the 'git cl config' subcommand. --deactivate-update tells git cl not to update the values inside .git/config from the codereview.settings file. --activate-update does the opposite. This is designed for testing/development purposes only, for example, to be able to change the rietveld URL. BUG=327901 Review URL: https://codereview.chromium.org/104043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242943 0039d316-1c4b-4281-b951-d872f2087c98
-
stip@chromium.org authored
BUG=278558 Review URL: https://codereview.chromium.org/112503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242918 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Dec, 2013 1 commit
-
-
fischman@chromium.org authored
BUG=330321 Review URL: https://codereview.chromium.org/107963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242301 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Dec, 2013 1 commit
-
-
binji@chromium.org authored
i.e. the output looks like: my-branch-name : https://codereview.chromium.org/1234567 my-other-branch : https://codereview.chromium.org/8675309 This makes it possible to double-click the branch name to use it in a subsequent command. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/118613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241731 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Dec, 2013 3 commits
-
-
stip@chromium.org authored
BUG=278554 Review URL: https://codereview.chromium.org/106763010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241629 0039d316-1c4b-4281-b951-d872f2087c98
-
stip@chromium.org authored
Allow PRESUBMIT.py files to have old and new-style trybot specifications (as long as each file is consistent). BUG=278554 Review URL: https://codereview.chromium.org/74163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241590 0039d316-1c4b-4281-b951-d872f2087c98
-
yujie.mao@intel.com authored
BUG=None TEST=Error log print Review URL: https://codereview.chromium.org/112123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241544 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Dec, 2013 3 commits
-
-
szager@chromium.org authored
MatchSvnGlob uses the root url to grep for existing svn commits by matching the git-svn-id lines in the commit messages. If there is a rewriteRoot config, then the git-svn-id lines will have the rewritten url's, and the code should match against that. R=blundell@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/103053011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241043 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
It has happened (possibly due to a bug in deps2submodules.py) that people have wound up with an empty submodule.<name>.url entry in their git config. If that happens, crup-runner.sh should update it. TBR=adamk@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/116583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240973 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
It's possible in gclient to list multiple operating systems on the command line and while handling them all perfectly might not be possible it's possible to make it better than today. This patch makes sure None never overrides any previous value and it adds some output to indicate what kind of dangerous choices it made. BUG=248168 Review URL: https://codereview.chromium.org/23875029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240892 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Dec, 2013 1 commit
-
-
digit@chromium.org authored
'fetch chromium' will fail if the build dependencies are not already installed on the host machine, because it runs 'gclient sync' which, by default, will run hooks that will try to run build/gyp_chromium (which will then fail). This introduces a --nohooks option that solve the problem by allowing the user to do the following: 1) fetch --nohooks <recipe> 2) src/build/install-build-deps.sh 3) fetch <recipe> BUG=325795 TEST=Run 'fetch --nohooks chromium' in a temporary 'clean' chroot directory. R=maruel@chromium.org,jochen@chromium.org,scottmg@chromium.org,agable@chromium.org Review URL: https://codereview.chromium.org/106403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240680 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Dec, 2013 3 commits
-
-
bratell@opera.com authored
If os.kill(os.getpid(), signal.CTRL_C_EVENT) doesn't do what the test author hopes it will do, the test will hang until it has calculated a million out-of-thread/process results. That is approximately an infinite hang. BUG= Review URL: https://codereview.chromium.org/110883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240319 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
Actually, don't run presubmit checks on anything starting with python and ending with _bin. BUG=326975 Review URL: https://codereview.chromium.org/111643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240316 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Code path: 1. plugins.sso_auth is imported, which adds the AuthHandler class to the global state. 2. HasConfiguredCredentials() in gslib/utils.py is called by gsutil, and will return true if "prodaccess" exists on the system, which tells the system that we don't want a no-op auth handler. 3. When a command is called, all the auth handlers are cycled through and sso_auth.SSOAuth is called, which calls a stubby command to emit a gaiamint'ed oauth2 access token, which is then used as the Authorization Header if --bypass_prodaccess is passed in, then: 1. HasConfiguredCredentials() will bypass the check for prodaccess, as if it didn't exist. 2. plugins.sso_auth does not get imported. Which will essentially cause gsutil to behave as if this patch never existed. So the expected behavior is: =.boto file does not exist, prodaccess exists, but unauthenticated= Failure: No handler was ready to authenticate. 3 handlers were checked. ['OAuth2Auth', 'HmacAuthV1Handler', 'SSOAuth'] Check your credentials. =.boto file exists, prodaccess exists, but unauthenticated= sso_auth will raise NotReadyToAuthenticate, and the .boto file will be used instead =.boto file exists, prodaccess exists, authenticated= sso_auth will be run _after_ the default gsutil authenticator, which causes the sso_auth to be used over whatever the default authentication is. bypass_prodaccess is passed in by default to upload_to_google_storage because we expect people who use upload_to_google_storage to not need prodaccess and have their own boto file already. Also the sso_auth plugin will only request a readonlyi token, which will not work for uploading. BUG=258152 Review URL: https://codereview.chromium.org/86123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240266 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2013 2 commits
-
-
jsbell@chromium.org authored
R=dpranke@chromium.org Review URL: https://codereview.chromium.org/94033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239830 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
This will also enable git cl format to be more easily runnable by presubmit within a subdirectory. BUG=none Review URL: https://codereview.chromium.org/108353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239821 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Dec, 2013 2 commits
-
-
bratell@opera.com authored
I hope this will fix the problem with presubmits trying to check the coding styles inside python. BUG=326975 Review URL: https://codereview.chromium.org/103543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239489 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
Not all Linux machines have vim preinstalled (example: Ubuntu 12.04). All machines have vi though. And it's actually vim but stripped down. BUG= Review URL: https://codereview.chromium.org/101823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239488 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Dec, 2013 1 commit
-
-
brettw@chromium.org authored
This should make Cygwin work to match "win32". Review URL: https://codereview.chromium.org/108743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239244 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2013 2 commits
-
-
brettw@chromium.org authored
Review URL: https://codereview.chromium.org/107323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@239057 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This normalizes sys.platform so people running cygwin are treated like Windows. Review URL: https://codereview.chromium.org/104763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238999 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Dec, 2013 1 commit
-
-
cranger@google.com authored
googlesource.com runs close to master and the latest gerrit RC is closest to that. Furthermore, this allows the tests to use the latest REST api endpoints (including create account). Fix the sorting of gerrit versions to extend the major revsion numbers before the RC numbers. This makes 2.7-rc4 comparable to 2.7.1. The gerrit init command now requires download-commands plugin to be installed in order for the revisions fetch field to be populated (i.e to show the download schemes). NOTRY=true Review URL: https://codereview.chromium.org/69373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238631 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2013 2 commits
-
-
maruel@chromium.org authored
This is useful to diagnose slow tests. Make this multiprocessing aware. Stop printing when the commands are added but use the proper message system instead. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/99453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238388 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@google.com authored
I've unified the checks for language specific exceptions to line length. There is a behavior change where cpp compiler directives no longer have a maximum line length (previously they were restricted to 150% of max line length). This change was made to match the behavior for java files. BUG=NONE Review URL: https://codereview.chromium.org/100163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238268 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2013 1 commit
-
-
thestig@chromium.org authored
R=maruel@chromium.org Review URL: https://codereview.chromium.org/92533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@238220 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Nov, 2013 1 commit
-
-
ukai@chromium.org authored
BUG=maruel@chromium.org,szager@chromium.org Review URL: https://codereview.chromium.org/90763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237657 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2013 1 commit
-
-
ukai@chromium.org authored
Tell download tools/hooks/commit-msg mannually if it looks broken. chrome-internal-reviews.googlesource.com requires authentication to access tools/hooks/commit-msg, and we'll get Google Sign-in page rather than expected shell script. R=szager@chromium.org,maruel@chromium.org,ilevy@chromium.org BUG= Review URL: https://codereview.chromium.org/87173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237454 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Nov, 2013 1 commit
-
-
maruel@chromium.org authored
Internal teams are relying on git-try as the sole mean to run try jobs so revert this. Hopefully most target users (chromium folks) got the message at least once. R=cmp@chromium.org BUG= Review URL: https://codereview.chromium.org/88743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237361 0039d316-1c4b-4281-b951-d872f2087c98
-