Commits · 3e5d86a2375ad13321f225166444419fcf1f6b08 · Linshizhi / Chromium_Depot_tools

29 Jul, 2020 1 commit

Generate revisions in json output for refs/ and origin/. · 3e5d86a2

Garrett Beaty authored Jul 29, 2020

Right now the default test data for bot_update doesn't transform
revisions specifying refs for the revision except for refs starting with
refs/ on the first solution. This means that the output will just have
the ref name as the revision value, which isn't compatible with code
that requires an actual revision value.

Bug: 1047893
Change-Id: I016ad5e8db5a293dd5e6dacb5b8beba51e000949
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2325761
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3e5d86a2

28 Jul, 2020 1 commit

presubmit: Add dirmd_bin to CheckDirMetadataFormat. · 7291750a

Edward Lesmes authored Jul 28, 2020

dirmd is not available on bots, so we'll need to receive the path
where it's available as an argument.

Bug: 1102997
Change-Id: I8966225d8ded3eb06c504797280baaa6c6c64a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2321510Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7291750a

24 Jul, 2020 1 commit

presubmit: Also validate metadata in OWNERS files. · a58287b8

Edward Lesmes authored Jul 24, 2020

Bug: 1102997
Change-Id: Id847129d320004fcd121941f2e14cf9ad56ab4a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2318335Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a58287b8

23 Jul, 2020 3 commits

[resultdb] Bump up the cipd pin of rdb in depot_tools · 9e8b8f31

Scott Lee authored Jul 23, 2020

cipd-link: https://chrome-infra-packages.appspot.com/p/infra/tools/rdb/linux-amd64/+/git_revision:155c9bca589d3bf0a95ae58d62f72a4cf1554e9e

Change-Id: I8d11242de7204cf4dadfb65862746efc1fc7bc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316810Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

9e8b8f31

Make presubmit_canned_checks inclusive · d855b927

Josip Sokcevic authored Jul 23, 2020

This modifies CheckAuthorizedAuthor parameters to be inclusive while
being backwards compatbile. Also, it fixes issue with empty lists.

R=ehmaldonado@chromium.org

Bug: 1098560
Change-Id: I992b25d6408d6cb906fa1696209de253e50c5156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316706Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d855b927

gclient: Apply on patch of remote's branch-heads instead of local. · f627d9fc

Edward Lesmes authored Jul 23, 2020

refs/branch-heads/ might be out of date, as bot_update is now fetching
refs/branch-heads/* as refs/remotes/branch-heads/*.

Bug: 1108638
Change-Id: I5a221e8e01017552f42c0c52d7ef7327acc5f63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2316327Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f627d9fc

22 Jul, 2020 9 commits

Adding --skip-title option to git cl upload · cebfb4e6

Mario Bianucci authored Jul 22, 2020

Adding an optional --skip-title argument to git cl upload to
automatically use the latest commit message as the patch title, without
requiring the user to hit "enter" to accept.

Change-Id: I0e37b68c809d907a4f980f2be59865e14b1a2db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2297803Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>

cebfb4e6

Roll recipe dependencies (trivial). · dc3f2b55

recipe-roller authored Jul 22, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c89555ad4aad0d235c318a660be9bb34a5d51c60
  c89555a (vadimsh@chromium.org)
      [context] Add api.context.realm property.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5465b16fbe3aaa5fe2b89645afccf104e919f07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2314837Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

dc3f2b55

Roll dirmd to 6c4507c0 · caa2f149

Nodir Turakulov authored Jul 22, 2020

Roll dirmd to 6c4507c06f51a54a6fabaf2bdf8cc2b1a6ed106e
in order to pick up
https://chromium-review.googlesource.com/c/infra/infra/+/2314058

Bug: 1106176
Change-Id: Iddf639aeb1e847b77f1176a90cf06f373303e328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2313790Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

caa2f149

Add explicit "python" to script for Windows compatibility · 71fd8abb

Greg Guterman authored Jul 22, 2020

Remove cwd augmentation for good measure. This should be done by the
caller.

Bug: 923016
Change-Id: I7f6618d7a9e56f70168fc71046412c6d462f40fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2311320
Auto-Submit: Gregory Guterman <guterman@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

71fd8abb

bot_update: Map refs to remote refs and don't checkout after clone. · e4e1fb30

Edward Lesmes authored Jul 22, 2020

Map refs to remote refs when fetching refs from origin
(e.g. refs/heads/master -> refs/remotes/origin/master)
so that a detached HEAD is not necessary.

Bug: 1104182
Change-Id: Icb751505de1bf443e5d45c4b37425223dbf6e088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310849Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e4e1fb30

Modify bot_update to support setting blamelist pins. · 6081b23b

Garrett Beaty authored Jul 22, 2020

This adds a parameter to bot_update.ensure_checkout that will cause
blamelist pins to be set for all of the repos whose revision is not
determined by DEPS files: the repo for the gitiles input, the repo for
each solution in the gclient config and any repos with the revision set
by the revisions field of the gclient config.

Bug: 1047893
Change-Id: Ie3eee41dbf15be014185b6f255ee3d4cfd40b4e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2293514
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6081b23b

Use fixed revisions in bot_update's test API output_json. · c8c88f9c

Garrett Beaty authored Jul 22, 2020

Currently the output_json method generates revisions for projects that
are in the revision_mapping and only those projects appear in the
manifest and source_manifest, using the generated revision. This method
is used to construct the default json output for bot_update in tests.
This has 2 problems:
1. If a project has a fixed revision, its manifest entries and the
property used the generated revision, meaning the gitiles input revision
will not be used in the json output.
2. If a project has a fixed revision and isn't present in
revision_mapping then manifest entries aren't generated for it.

This changes the method to use the revisions in the fixed_revisions dict
and to create manifest entries for the projects that appear in the
fixed_revisions dict which should make fewer situations where
bot_update's output_json needs to be explicitly set.

Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>

c8c88f9c

gclient: print use_relative_hooks deprecation on stderr. · 33e6e046

Corentin Wallez authored Jul 22, 2020

Printing to stdout breaks tools that parse the output of running
gclient.

TBR=ehmaldonado@chromium.org
Bug: chromium:1107325
Bug: chromium:1108301
Change-Id: I77f6eef9bdffd0534efb0b919304dab5b3df8c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2312678
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

33e6e046

[lucicfg] Update to v1.18.4. · c07c59dd

Vadim Shtayura authored Jul 22, 2020

Two notable changes:
* luci.builder(experiments={...}, ...)
* When realms are enabled, scheduler configs include `realm` field.

R=tandrii@chromium.org
CC=yulanlin@google.com

Change-Id: I17e773bdd33058b71b64c7222f4e8471bf33e83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2311565Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

c07c59dd

21 Jul, 2020 2 commits

Decode "git cl" error messages to avoid printing Python bytes · 594fd332

Alan Cutter authored Jul 21, 2020

We were not decoding the stdout bytes before printing them when git
commands returned an error status. This CL fixes that.

Before:
Command "git cherry-pick FETCH_HEAD" failed.
b'Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc\nAuto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nCONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc\nAuto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc\nAuto-merging chrome/browser/ui/views/frame/browser_frame.h\nAuto-merging chrome/browser/ui/views/frame/browser_frame.cc\n'

After:
Command "git cherry-pick FETCH_HEAD" failed.
Auto-merging chrome/browser/ui/web_applications/app_browser_controller.cc
Auto-merging chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
CONFLICT (content): Merge conflict in chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
Auto-merging chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
Auto-merging chrome/browser/ui/views/frame/browser_frame.h
Auto-merging chrome/browser/ui/views/frame/browser_frame.cc
Change-Id: I162e666ca9f3a70259e6178d2e6d3b72f15b1f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310016
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

594fd332

Revert "bot_update: Refactor branch to detach and checkout." · 720e010b

Edward Lesmes authored Jul 21, 2020

This reverts commit b99e61c5.

Reason for revert:
Doesn't work for refs/branch-heads/*

Original change's description:
> bot_update: Refactor branch to detach and checkout.
> 
> Refactor _git_checkout to use information from
> get_target_branch_and_revision to know what branch to checkout after
> cloning.
> 
> Bug: 1104182
> Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: If51423df99fd9c164f8e42e0220ee2d9bc2a39f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2310293Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

720e010b

20 Jul, 2020 6 commits

Preliminary changes to git cl and presubmit_support · 9949ab7a

Saagar Sanghavi authored Jul 20, 2020

Added an rdb wrapper and use it to time CheckChangeOn{Commit, Upload} from every PRESUBMIT.py file, then reports the results to ResultSink.

Bug: http://crbug.com/1107588

Change-Id: I9bc8a18ba615a76f3e0611eae5b2c4adc5924276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2242097
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

9949ab7a

bot_update: Refactor branch to detach and checkout. · b99e61c5

Edward Lesmes authored Jul 20, 2020

Refactor _git_checkout to use information from
get_target_branch_and_revision to know what branch to checkout after
cloning.

Bug: 1104182
Change-Id: Ib3ba57ca0b6803f172b85121c2a4b123f17bfb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303291Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b99e61c5

gclient: deprecated use_relative_hooks · 801c2021

Corentin Wallez authored Jul 20, 2020

And merge it in use_relative_paths. In all Chromium repos,
use_relative_hooks is True iff:

 - use_relative_paths is True, and
 - there is at least one hook

It makes sense that you'd want to use relative hooks if you use relative
paths so this CL merges both flags into use_relative_paths.

Bug: chromium:1107325
Change-Id: I0fe40eba1e1c61be26c812c7ca4329efb72c7f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2306795
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

801c2021

Roll recipe dependencies (trivial). · b655a28e

recipe-roller authored Jul 20, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/79f951ca7bfd9a119dbe0cb27a51bf78493836bd
  79f951c (iannucci@chromium.org)
      [raw_io] Reland: Make output_dir lazy.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I928c1bb09fc0b453e2bc8c3151a7907802a725c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2308250Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b655a28e

git-cl: Fix "git cl tree" issues with Python 3. · 8b4eeffd

Daniel McArdle authored Jul 20, 2020

* First, we were treating the return value of HTTPResponse.read() as a
  string when it is really a byte string.

* Second, the urlparse library was renamed to urllib.parse in Python 3,
  so I made the appropriate substitution.

Change-Id: I0b23716e990eca8ddf77742f378ab54eda3d3717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2307509Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>

8b4eeffd

Roll out new goma client binary VERSION=203 · 39d31783

Yoshisato Yanagisawa authored Jul 20, 2020

Bug: b/159183955
Change-Id: I7cfd3dd84bb9be0c9d5a57aa9886cddacdfec593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2306989Reviewed-by: Ye Kuang <yekuang@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

39d31783

18 Jul, 2020 1 commit

Roll recipe dependencies (trivial). · 642be1d2

recipe-roller authored Jul 18, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0dbd020e420e02fc734492071693cb0c2cc62667
  0dbd020 (ddoman@chromium.org)
      [swarming] integrate TaskRequest with resultdb and realm

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61c828df74eea4f15a1eb2c1d35d961179088e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2305450Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

642be1d2

17 Jul, 2020 2 commits

Roll recipe dependencies (trivial). · 4bbdfa58

recipe-roller authored Jul 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/742a272b323d92aa97865daa3b806a8ee665eeb2
742a272 (bpastene@chromium.org)
Revert "[raw_io] Make output_dir lazy."

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I998005b279006438cf456ae3a7276cadde24855a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303884Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4bbdfa58

Roll recipe dependencies (trivial). · 320ceb93

recipe-roller authored Jul 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c1b7a3041fc0dedb1ee46bcb206e0b048ce7a20f
  c1b7a30 (iannucci@chromium.org)
      [raw_io] Make output_dir lazy.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id287a3112147a80e5478bb41cb5e71baa08503dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303880Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

320ceb93

16 Jul, 2020 3 commits

[dirmd] Roll to the latest version · 233589f2

Nodir Turakulov authored Jul 16, 2020

Latest dirmd tool to 8dba585435d2d50d5c9bfc9a347580ff275456d5

Bug: 1106176
Change-Id: Ia6939ef3b1d7342c3207148bd20b4619e36a61cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2303639
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

233589f2

Revert "Roll git to 2.27.0 on Windows" · 78a6bf63

Sébastien Marchand authored Jul 16, 2020

This reverts commit 5fcb4853.

Reason for revert: Broke Git on my gWindows machine, it fails for many Git operations with the following error message:

git pull                                                                                                    
  2 [main] sh (54140) shared_info::initialize: size of shared memory region changed from 45944 to 38776
fatal: Could not read from remote repository

I've confirmed that reverting this CL fixes the problem.

Original change's description:
> Roll git to 2.27.0 on Windows
> 
> Bug: 1070694
> Change-Id: I37af08864661ca92116776569b9285ceb6ff465c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300204
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I4d27eaa1b17cb056635dceed5ad1562debfc2e06
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1070694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2302489Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>

78a6bf63

Roll recipe dependencies (trivial). · e9e8c01f

recipe-roller authored Jul 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/faf8628f68d07cb3cab497eaa207b0184099b304
faf8628 (tikuta@chromium.org)
update isolated client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib80020f86a84b8f1e859403fe496cb3204ced37c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2301460Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e9e8c01f

15 Jul, 2020 9 commits

Roll git to 2.27.0 on Windows · 5fcb4853

Edward Lesmes authored Jul 15, 2020

Bug: 1070694
Change-Id: I37af08864661ca92116776569b9285ceb6ff465c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300204Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

5fcb4853

bot_update: Don't checkout 'master' after clone. · ed9e5acd

Edward Lesmes authored Jul 15, 2020

Checkout 'HEAD' instead. This is needed to have a detached HEAD, so we
can fetch refs/heads/main:refs/heads/main, where main is the default
branch.

Bug: 1104182
Change-Id: I7b7457b21b7d98d29583555b62e27e96e900adb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300533
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

ed9e5acd

gclient: Unset core.worktree after cloning on Windows. · d4e20f24

Edward Lesmes authored Jul 15, 2020

Caused by https://github.com/git-for-windows/git/issues/2569

Bug: 1070694
Change-Id: Ice39e0f61e5c571562736a35e6441d01cb76ea06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300652Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d4e20f24

Roll recipe dependencies (trivial). · 4531a053

recipe-roller authored Jul 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/034831f3848fd44d3bf28cd04a625e06e6a0e5c7
  034831f (iannucci@chromium.org)
      [luciexe] zlib compress build.proto output.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8db59cfe720ff1c7e25c85d575af85d169b4b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300762Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4531a053

Add default filters to git cl lint. · b8c62cf5

Lei Zhang authored Jul 15, 2020

Use the same set of default filters as presubmit checks. Presubmit
checks use filters to give better lint results as expected by Google C++
style. Give git-cl's lint subcommand the same benefit.

Bug: 1106028
Change-Id: I51ff0737b310990ab424376d2721e8a6a50dfc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298122
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b8c62cf5

Simplify a block of conditionals for git cl lint. · 379d1ad1

Lei Zhang authored Jul 15, 2020

Use continues to reduce the amount of nesting in a loop. At the same
time, give the variable involved better names.

Bug: 1097674
Change-Id: I105ed4a99da783fb235e304bbad4edd1f8a38889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298659Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

379d1ad1

presubmit_canned_checks: Add DIR_METADATA presubmit checks. · 6d938a0d

Edward Lesmes authored Jul 15, 2020

- Add a check to validate DIR_METADATA files.
- Add a check to enforce that OWNERS files contain no metadata if a
  DIR_METADATA file is present in the same directory.

Bug: 1102997
Change-Id: Iedb09941001577dc81b1dda2241481ff667b2568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298330
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

6d938a0d

Roll recipe dependencies (trivial). · 2f6667ed

recipe-roller authored Jul 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f4cd7a476cb9287e3c8fd2b615fb517a9cd0974e
  f4cd7a4 (yiwzhang@google.com)
      [luciexe] Set the initial build status to running

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iafe30b0f8ef09c4f86491f60a6d7c848c171bcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2300522Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2f6667ed

[led] Roll to latest · 9d9199a5

Chan Li authored Jul 15, 2020

Bug: 1099018
Change-Id: Ie40d213670f41f946c3111cee2247fbb8fa12754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298121Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

9d9199a5

14 Jul, 2020 2 commits

Add gerrit_change_owner field to tryserver recipe api · 35dec5f1

Greg Guterman authored Jul 14, 2020

Bug: 923016
Change-Id: I1d55fb2403306763a06b44d2ea65caa0014936d3
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2292235
Commit-Queue: Gregory Guterman <guterman@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

35dec5f1

[dirmd] Add dirmd executables · 672e1dcf

Nodir Turakulov authored Jul 14, 2020

This should have been a part of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2298244

Bug: 1104246
Change-Id: I3a1ef07cb4443aa2d62af7f3cb28e0d58bd3951a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2297804
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

672e1dcf