- 18 Mar, 2014 1 commit
-
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/203383005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257738 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2014 2 commits
-
-
iannucci@chromium.org authored
R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/181043018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256778 0039d316-1c4b-4281-b951-d872f2087c98
-
stip@chromium.org authored
depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo. If broken dev_appserver.py instances are left around, they will conflict with master ports. BUG=351926 Review URL: https://codereview.chromium.org/197073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256721 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Mar, 2014 1 commit
-
-
iannucci@chromium.org authored
git-map: Show your local repo's history in a pseudo-graphical format from the command line. git-map-branches: Show the topology of all of your branches, and their upstream relationships. git-nav-upstream: Navigate (checkout) to the upstream branch of the current branch. git-nav-downstream: Navigate (checkout) to a downstream branch of the current branch. If there's more than one downstream branch, then present a menu to select which one you want. R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG= Review URL: https://codereview.chromium.org/184113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256384 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2014 1 commit
-
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/134223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256289 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Mar, 2014 2 commits
-
-
thakis@chromium.org authored
Revert of Another attempt: gclient: delete mismatching checkouts (https://codereview.chromium.org/183283003/) Reason for revert: Broke `gclient sync` for me, failing with: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. For someone else, it broke it with: % gclient sync ________ unmanaged solution; skipping src Error: Command svn info --xml returned non-zero exit status 1 in /Users/pawliger/chromium/src/. <?xml version="1.0" encoding="UTF-8"?> <info> svn: E155007: '/Users/pawliger/chromium/src' is not a working copy Original issue's description: > Another attempt: gclient: delete mismatching checkouts > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255930 TBR=iannucci@chromium.org,szager@chromium.org,maruel@chromium.org,mmoss@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/192323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256005 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/183283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255930 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Mar, 2014 1 commit
-
-
machenbach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/178223016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254321 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Feb, 2014 1 commit
-
-
hinoka@google.com authored
Instead of having custom logic for dealing with cache directories, use git_cache.py to populate caches. Also fixes a bug in git_cache.py where it was looking for lockfiles in cwd rather than the cache dir. Other changes: * _Run now returns output. * Always print to stdout in CheckCallAndFilterOutput, even if it gets a carriage return. This is done because git progress report are carriage returns and not newlines and we don't want everything on the same line and not strip out the CRs. * Removed members changed tests, its not very useful to know a new import is added. BUG=339171 Review URL: https://codereview.chromium.org/180243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2014 3 commits
-
-
szager@chromium.org authored
This reverts commit 6ff54485. 'fetch --nohooks chromium' is broken with this change. BUG= Review URL: https://codereview.chromium.org/177003023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253640 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/164053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253616 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyberezin@chromium.org authored
ssl.SSLError does NOT have 'reason' attribute. Use str() to get a reliable string. Fixed the silly bug in another CL: https://codereview.chromium.org/180273003/ The ssl.SSLError does NOT have attribute 'reason', and must use the generic 'strerror' instead. This is what happens when I submit a CL too fast... BUG=346845 R=stip@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/180723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253317 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Feb, 2014 1 commit
-
-
agable@chromium.org authored
The git cache command is a central place to manage a machine's git cache. It provides two subcommands: * populate -- creates or updates the cache of a given repository * exists -- prints the path to the cache of a repo, if it exists Gclient, deps2git, bot_update, and any other tools that touch the cache will be able to use this command to make sure that everyone is interacting with the cache in the same way. R=hinoka@chromium.org, iannucci@chromium.org BUG=339168 Review URL: https://codereview.chromium.org/164823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253007 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Feb, 2014 1 commit
-
-
sergeyberezin@chromium.org authored
BUG=345117 Review URL: https://codereview.chromium.org/174313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252452 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Feb, 2014 1 commit
-
-
iannucci@chromium.org authored
One line for the fix, 30 lines for the test :) R=kbr@chromium.org, mmoss@chromium.org, stip@chromium.org, szager@chromium.org BUG=345073 Review URL: https://codereview.chromium.org/165443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252138 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Feb, 2014 2 commits
-
-
mmoss@chromium.org authored
> Re-reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") > > BUG= > > Review URL: https://codereview.chromium.org/133073015 TBR=borenet@google.com Review URL: https://codereview.chromium.org/146583013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250878 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
> gclient: Use the correct bot hostnames to enable experimental deletion behavior > > BUG=skia:1638 > > Review URL: https://codereview.chromium.org/132313017 TBR=borenet@google.com Review URL: https://codereview.chromium.org/143183008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250877 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Feb, 2014 4 commits
-
-
borenet@google.com authored
BUG=skia:1638 Review URL: https://codereview.chromium.org/132313017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250524 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
BUG= Review URL: https://codereview.chromium.org/133073015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250482 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Relative root no longer makes sense after an os.chdir(). This is effectively a partial revert of r250248. Review URL: https://codereview.chromium.org/135213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250478 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Additionally: - replace some RunCommand(['git', ...]) calls with RunGit(). - replace Settings._GetConfig('rietveld.foo') _GetRietveldConfig('foo'). - merge and cache calls to git rev-parse --show-cdup. - merge some calls to git merge-base. Review URL: https://codereview.chromium.org/157913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250248 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Feb, 2014 1 commit
-
-
borenet@google.com authored
Revert of Reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") (https://codereview.chromium.org/131743022/) Reason for revert: This is still failing third_party DEPS for git-svn... Original issue's description: > Reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249143 TBR=iannucci@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/152933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249216 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Feb, 2014 1 commit
-
-
borenet@google.com authored
BUG= Review URL: https://codereview.chromium.org/131743022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249143 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Jan, 2014 1 commit
-
-
raphael.kubo.da.costa@intel.com authored
urllib.urlopen() has issues with proxies similar to the ones reported in bug 134165 that are not present in urllib2.urlopen() -- namely, it does not perform HTTP tunneling with proxy servers when fetching HTTPS URLs. TEST=Pass --url=https://someurl to trychange.py behind a corporate proxy R=maruel@chromium.org,iannucci@chromium.org,dpranke@chromium.org BUG= Review URL: https://codereview.chromium.org/133933007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247914 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jan, 2014 1 commit
-
-
bauerb@chromium.org authored
Merge ALL the things! BUG=none Review URL: https://codereview.chromium.org/61823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246575 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Jan, 2014 1 commit
-
-
enne@chromium.org authored
For simplicity, the canned presubmit check just calls git cl format directly with a new option --dry-run which does not change the files on disk. Because some users may not have git or clang-format might somehow have errors, this canned check is a warning. Additionally, if git cl format fails with an error then the presubmit check will silently report success to avoid spamming misconfigured users during upload. BUG=none Review URL: https://codereview.chromium.org/141493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246066 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jan, 2014 3 commits
-
-
hinoka@google.com authored
A very common pattern for the users of this script is to have binaries in three different folders, eg: some/folder/win/bin.exe some/folder/mac/bin some/folder/linux/bin Instead of using --platform to specify three different paths, we can recognize this usage and pass in --auto_platform, and then --directory some/folder/ as the target. When enumerating files, it will match each individual file to see if they have (win|mac|linux) as a parent folder name, and filter out non-matching platforms. BUG= TEST= src/third_party/clang_format/bin$ download_from_google_storage --auto_platform --no_auth -b chromium-clang-fomat -dr . 0> Downloading ./linux/clang-format... Review URL: https://codereview.chromium.org/126893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245643 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Revert of If the destination directory doesn't contain the desired repo, delete it (https://codereview.chromium.org/61623008/) Reason for revert: This breaks `gclient sync` for me. Before this patch: ________ found .git directory; skipping src After this patch: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. Original issue's description: > If the destination directory doesn't contain the desired repo, delete it > > Basic functionality - this may not be in quite the right place. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245404 TBR=iannucci@chromium.org,ilevy@chromium.org,cmp@chromium.org,maruel@chromium.org,morrita@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/141633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245530 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Basic functionality - this may not be in quite the right place. Review URL: https://codereview.chromium.org/61623008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245404 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2014 1 commit
-
-
nick@chromium.org authored
as part of the Chromium checkout. This follows the approach used by gn. Changes include: - in-the-PATH clang-format trampoline scripts - clang_format.py, which finds clang-format binaries inside of Chrome - Hook 'git cl format' to the new binaries and scripts - Rearrange some code, for reuse between clang_format.py and gn.py BUG=240309 TEST=presubmits (one failure on mac, but it fails on a clean checkout too) Review URL: https://codereview.chromium.org/134313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245074 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Jan, 2014 3 commits
-
-
rmistry@google.com authored
This change will allow projects other than chromium to specify 'BUG_PREFIX: project_name:' in their codereview.settings file. Currently, the change is created with 'BUG=', entering a project's bug number there will point it to chromium's issue tracker. Adding a project specific prefix will make the links point to the project's issue tracker without the developer having to know about the magic prefix. BUG=skia:1983 Review URL: https://codereview.chromium.org/132233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244801 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none R=iannucci@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/130803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244793 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Write a small HowTo to help confused people by confusing checks. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/137653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244717 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jan, 2014 1 commit
-
-
wtc@chromium.org authored
It takes more than 10 seconds to lint some CLs. Silently ignore the expected timeout. R=maruel@chromium.org,iannucci@chromium.org BUG=290402 TEST=none Review URL: https://codereview.chromium.org/130493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243968 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2014 1 commit
-
-
pgervais@chromium.org authored
These options have been added to the 'git cl config' subcommand. --deactivate-update tells git cl not to update the values inside .git/config from the codereview.settings file. --activate-update does the opposite. This is designed for testing/development purposes only, for example, to be able to change the rietveld URL. BUG=327901 Review URL: https://codereview.chromium.org/104043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@242943 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Dec, 2013 1 commit
-
-
binji@chromium.org authored
i.e. the output looks like: my-branch-name : https://codereview.chromium.org/1234567 my-other-branch : https://codereview.chromium.org/8675309 This makes it possible to double-click the branch name to use it in a subsequent command. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/118613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241731 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Dec, 2013 1 commit
-
-
stip@chromium.org authored
Allow PRESUBMIT.py files to have old and new-style trybot specifications (as long as each file is consistent). BUG=278554 Review URL: https://codereview.chromium.org/74163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@241590 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Dec, 2013 1 commit
-
-
bratell@opera.com authored
It's possible in gclient to list multiple operating systems on the command line and while handling them all perfectly might not be possible it's possible to make it better than today. This patch makes sure None never overrides any previous value and it adds some output to indicate what kind of dangerous choices it made. BUG=248168 Review URL: https://codereview.chromium.org/23875029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240892 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Dec, 2013 2 commits
-
-
bratell@opera.com authored
If os.kill(os.getpid(), signal.CTRL_C_EVENT) doesn't do what the test author hopes it will do, the test will hang until it has calculated a million out-of-thread/process results. That is approximately an infinite hang. BUG= Review URL: https://codereview.chromium.org/110883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240319 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Code path: 1. plugins.sso_auth is imported, which adds the AuthHandler class to the global state. 2. HasConfiguredCredentials() in gslib/utils.py is called by gsutil, and will return true if "prodaccess" exists on the system, which tells the system that we don't want a no-op auth handler. 3. When a command is called, all the auth handlers are cycled through and sso_auth.SSOAuth is called, which calls a stubby command to emit a gaiamint'ed oauth2 access token, which is then used as the Authorization Header if --bypass_prodaccess is passed in, then: 1. HasConfiguredCredentials() will bypass the check for prodaccess, as if it didn't exist. 2. plugins.sso_auth does not get imported. Which will essentially cause gsutil to behave as if this patch never existed. So the expected behavior is: =.boto file does not exist, prodaccess exists, but unauthenticated= Failure: No handler was ready to authenticate. 3 handlers were checked. ['OAuth2Auth', 'HmacAuthV1Handler', 'SSOAuth'] Check your credentials. =.boto file exists, prodaccess exists, but unauthenticated= sso_auth will raise NotReadyToAuthenticate, and the .boto file will be used instead =.boto file exists, prodaccess exists, authenticated= sso_auth will be run _after_ the default gsutil authenticator, which causes the sso_auth to be used over whatever the default authentication is. bypass_prodaccess is passed in by default to upload_to_google_storage because we expect people who use upload_to_google_storage to not need prodaccess and have their own boto file already. Also the sso_auth plugin will only request a readonlyi token, which will not work for uploading. BUG=258152 Review URL: https://codereview.chromium.org/86123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@240266 0039d316-1c4b-4281-b951-d872f2087c98
-