Commits · 36de4be91ef66852c49aa5fd9e0cc31d5ec05ae9 · Linshizhi / Chromium_Depot_tools

16 Mar, 2021 2 commits

presubmit: Use code-owners plugin if available. · 36de4be9

Edward Lesmes authored Mar 16, 2021

Change-Id: I56734de985731d007360a4a4e65f2b16de28b69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753894
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

36de4be9

Provide step_test_data in gerrit.get_revision_info. · a0606115

Garrett Beaty authored Mar 16, 2021

This will reduce the need to manually mock steps: calls to get revision
info will now return CLs that match the requested change and patchset
numbers. Manually mocking will only be required if specific values for
other field are desired or if the test case should not have revision
info that matches the change and patchset.

Change-Id: Ibc6ec62100616680e36d9a842449ac9c6fb2440b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2765162
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

a0606115

15 Mar, 2021 7 commits

Fetch all refs/heads/* on depot_tools update · 593a6b57

Josip Sokcevic authored Mar 15, 2021

If user downloaded depot_tools.zip before 2021-03-11, it contained only
fetch for refs/heads/master. As main branch is a new default branch,
users need to update fetch ref in order to fetch chanes from main
branch.

R=ehmaldonado@google.com

Bug: 1187238
Change-Id: I78041fc74f1bb505db375b9c1dced38cdfc9b144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753834Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

593a6b57

[infra-puppet] add gclient recipe config · ef6fe0d6

Elliott Friedman authored Mar 15, 2021

R=bpastene

Bug: 1182311
Change-Id: I42f8ea93c304b00c6957091b5a87a8cab53c30d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2761278Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Elliott Friedman <friedman@chromium.org>

ef6fe0d6

Roll recipe dependencies (trivial). · 8e2667e0

recipe-roller authored Mar 15, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c6627c1d2201fd582e7ca4b777c4749798d6c4db
  c6627c1 (mohrr@google.com)
      [file][raw_io] Future-proof octal constants

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I306e7a1e5fc7909706d6980a2d639fc2d4ca42e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2761167
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8e2667e0

Roll recipe dependencies (trivial). · b05b97d9

recipe-roller authored Mar 15, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/21743b2ace212ec94c9093b8010ef314b0fba2b1
  21743b2 (mohrr@google.com)
      [file] Future-proof fileutil.py syntax

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7a490ec1f0e8c3a642057a1b27fc340c97392cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2761161
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b05b97d9

code-owners: Use Gerrit code-owners if available · 88f712e0

Edward Lesmes authored Mar 15, 2021

Problems interpreting OWNERS files have been fixed upstream.

Bug: 1183447
Change-Id: Ifd065d87b4244fc3ce2f27291b603acfedbb5d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753447
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edwin Kempin <ekempin@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

88f712e0

Revert "Make autoninja.py work again w/ Python3 and MSYS/MinGW bash." · e7dc8c3a

Fumitoshi Ukai authored Mar 15, 2021

This reverts commit 9e2dfdcc.

Reason for revert:
build failure
https://chrome-internal-review.googlesource.com/c/goma/client/+/3683303
e.g. https://ci.chromium.org/ui/p/goma-client-internal/builders/try/Goma%20Trusty64%20Presubmit/b8852734992897102240/overview
https://logs.chromium.org/logs/goma-client-internal/buildbucket/cr-buildbucket.appspot.com/8852734992897102240/+/steps/build/0/stdout

 /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 11: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory
 /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 20: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory
 /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 30: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory

Original change's description:
> Make autoninja.py work again w/ Python3 and MSYS/MinGW bash.
>
> We switched autoninja.py to python3 in https://crrev.com/c/2752772
> but that assumes `python3` is in $PATH (which is likely true on
> Mac and Linux but less likely to be true on Windows, especially
> in MSYS/MinGW/git bash shells.
>
> It's safer to use the `python3` bundled into depot_tools in
> `$depot_tools/python-bin` and more hermetic to boot.
>
> Bug: 1187609
> Change-Id: I65efd1a2b87135ac4e25ba377309c3374cfda085
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2756889
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>

Bug: 1187609
Change-Id: I07b04d615624d3dc6bc071920ec97ed39583b64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2758609
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

e7dc8c3a

Roll recipe dependencies (trivial). · 159efcae

recipe-roller authored Mar 15, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3662309be345ee9178bd0d2045938ec4a15a8484
  3662309 (bryner@google.com)
      Fix archive extraction issues on Windows.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7d102e722eed24c077c36a806a784faa058eba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2758066
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

159efcae

13 Mar, 2021 1 commit

Roll recipe dependencies (trivial). · bb890d61

recipe-roller authored Mar 13, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5c5a9267101b2aa5b01d60b6917e0854a1824b93
  5c5a926 (yuanjunh@google.com)
      [buildbucket] Remove HOST_PROD_BEEFY

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If62ad2b3fe9ab46176858c14d8e7b6b913741233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2757138
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bb890d61

12 Mar, 2021 4 commits

Roll recipe dependencies (trivial). · ab030a7b

recipe-roller authored Mar 12, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/852fd411c26654207705fb9e0581942ce291f803
  852fd41 (ddoman@chromium.org)
      with_resultdb() always set enable=True

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If7767509d9ebf7d43abef1bcb6a247562d27f13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2757134
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ab030a7b

Make autoninja.py work again w/ Python3 and MSYS/MinGW bash. · 9e2dfdcc

Dirk Pranke authored Mar 12, 2021

We switched autoninja.py to python3 in https://crrev.com/c/2752772
but that assumes `python3` is in $PATH (which is likely true on
Mac and Linux but less likely to be true on Windows, especially
in MSYS/MinGW/git bash shells.

It's safer to use the `python3` bundled into depot_tools in
`$depot_tools/python-bin` and more hermetic to boot.

Bug: 1187609
Change-Id: I65efd1a2b87135ac4e25ba377309c3374cfda085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2756889Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

9e2dfdcc

Revert "autoninja: roll back to python from python3" · bd1729d9

Takuto Ikuta authored Mar 12, 2021

This reverts commit 3253a1de.

Reason for revert:
Blocker is fixed in https://crbug.com/1168365#c8

Original change's description:
> autoninja: roll back to python from python3
>
> python3 is currently not recognized on git bash.
> https://crrev.com/c/2629087/15#message-b5093e69201df42adb7ac643e4f97f9f366a299d
>
> This is partial revert of
> https://crrev.com/c/2629087
> https://crrev.com/c/2631396
>
> Bug: b/177465438
> Change-Id: I1b2698f5fc27144035598249c43800d25801a0f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638834
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>

Bug: b/177465438, 1168365
Change-Id: I368e28aeec9c585a96c8b44f030609eac58698f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2752772Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>

bd1729d9

Have autoninja.bat run depot_tools python3 · 0e6d5ed1

Bruce Dawson authored Mar 12, 2021

This changes autoninja.bat so that it refers explicitly to the
depot_tools version of Python rather than depending on what is in the
path. This helps to make autoninja behave more consistently and makes it
easier for us to remove python.bat from the path.

Bug: 777069
Change-Id: I6d878f58e2f8be70d06a182d059caa9fbedaedbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753458Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

0e6d5ed1

11 Mar, 2021 4 commits

Fix get_footer None AttributeError · e8b56fbf

Greg Guterman authored Mar 11, 2021

R: nodir@chromium.org
Change-Id: Ib052dabd7a92b3643f7f2fa3cc7933eb7a60dd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753457
Auto-Submit: Gregory Guterman <guterman@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

e8b56fbf

owners: Simplify logic to score and suggest owners. · 23c3bdc9

Edward Lesmes authored Mar 11, 2021

Keep adding owners in the order suggested by Gerrit until coverage is
achieved instead of finding a minimal set of owners, as that takes too
long

Bug: 1186420
Change-Id: Id2ab172db0b2e83ab950191958813163099181be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2751343Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

23c3bdc9

Add python batch wrappers · 8d727180

sokcevic authored Mar 11, 2021

Bug:  777069
Change-Id: I32094c81f6050acc7e84d9eb9b1900071a937552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748948
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

8d727180

Roll out new goma client binary VERSION=215 · 2f8ba755

Yoshisato Yanagisawa authored Mar 11, 2021

Bug: b/179630263
Change-Id: Iec0fbe3af1c206d9b5ccf5706156c1b7008f3200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2752426Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

2f8ba755

10 Mar, 2021 5 commits

Revert "Update depot_tools using main branch" · 89d2cc1e

Josip Sokcevic authored Mar 10, 2021

This reverts commit c2c576e9.

Reason for revert: windows zip archived linked in documentation
only fetches master branch, so that needs to resolved first.

Original change's description:
> Update depot_tools using main branch
>
> R=ehmaldonado@chromium.org
>
> Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I873f84f8fbe3a6cde60955ca63eb81e6976dd1f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748946
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

89d2cc1e

Update depot_tools using main branch · c2c576e9

Josip Sokcevic authored Mar 10, 2021

R=ehmaldonado@chromium.org

Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

c2c576e9

Revert "Remove py batch wrappers from root dir" · 7e3ad9ee

Dirk Pranke authored Mar 10, 2021

This reverts commit 0e8b3107.

Reason for revert: wrappers aren't being created in python2-bin, other disruptions

Original change's description:
> Remove py batch wrappers from root dir
>
> This removes python.bat and python3.bat batch wrappers from root of this
> repository. This change brings Windows set up closer to unix.
>
> depot_tools provides batch wrappers in python-bin and python2-bin
> directories and user can opt in to use it by adding them to PATH.
>
> Bug: 777069
> Change-Id: Ie7571a49f940e7a69b6c18779499c39aee94d06a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2742181
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 777069
Change-Id: Ieaadb032249fa5d6eea39668355c0c7de06dfbeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747702
Auto-Submit: Dirk Pranke <dpranke@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

7e3ad9ee

Roll recipe dependencies (trivial). · eff460bc

recipe-roller authored Mar 10, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7c53ea7f7671c0e33dc0a95a2f87abbcb76c95fc
  7c53ea7 (olivernewman@google.com)
      [cipd] Accept ensure files as paths

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I565726b2174532143028591d5641ec1610232675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747353
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

eff460bc

Roll recipe dependencies (trivial). · 57af8c37

recipe-roller authored Mar 10, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/921d2cffbab87ffa5cf8f86cc48e01954b251d46
  921d2cf (jwata@google.com)
      add jwata@ to recipe_modules/swarming/OWNERS

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I156204f6e860fd7f9179223867e7b4d4209b79a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747014
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

57af8c37

09 Mar, 2021 4 commits

Remove py batch wrappers from root dir · 0e8b3107

Josip Sokcevic authored Mar 09, 2021

This removes python.bat and python3.bat batch wrappers from root of this
repository. This change brings Windows set up closer to unix.

depot_tools provides batch wrappers in python-bin and python2-bin
directories and user can opt in to use it by adding them to PATH.

Bug: 777069
Change-Id: Ie7571a49f940e7a69b6c18779499c39aee94d06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2742181Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

0e8b3107

Roll recipe dependencies (trivial). · 1f9fc8b2

recipe-roller authored Mar 09, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/396b52a55bb1fbb4937b9489be668822f5d952cb
  396b52a (iannucci@chromium.org)
      [step_runner/subproc] Track and kill all processes on Windows a...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I721de3238dcad999204ad5245840aa1cd487e610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2746094
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1f9fc8b2

Roll recipe dependencies (trivial). · fb184700

recipe-roller authored Mar 09, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/02b67c942554ede07fe6d9b57c379d13e0d2d836
  02b67c9 (vadimsh@chromium.org)
      [cipd] Add `-metadata` and `set-metadata` support.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I12e2df5730dad62f82d1d118d40aea3b1b84f570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2745675
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fb184700

Roll recipe dependencies (trivial). · d071f2a8

recipe-roller authored Mar 09, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9e63c4c60a1eb5b7db07f8e12593b6c3975b9a5e
9e63c4c (bryner@google.com)
Fix recipes.py on Windows.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, sokcevic@google.com, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I197756661f65205dd08f2ec04591ddb4effa6234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2744255
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d071f2a8

08 Mar, 2021 2 commits

repo: update to latest version · 75c98324

Mike Frysinger authored Mar 08, 2021

Change-Id: I2f16f0fda382d25af55c735de69cd97e95f4b61f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727068Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

75c98324

Roll recipe dependencies (trivial). · 092299bb

recipe-roller authored Mar 08, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0dfd500e7b91f883ce716ead0b3c0a9dae0ad669
  0dfd500 (chanli@chromium.org)
      [ResultDB] wrap: add require_build_inv flag

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id5f585876350bdc22a0c951e98b41941fa45a9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2743199
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

092299bb

05 Mar, 2021 2 commits

Revert "Modify fix_encodng to make it use fix_win_sys_argv for python2 only and" · 4ec3fd36

Takuto Ikuta authored Mar 05, 2021

This reverts commit 20815505.

Reason for revert:
This is not necessary after https://crrev.com/c/1929653

Original change's description:
> Modify fix_encodng to make it use fix_win_sys_argv for python2 only and
> not for python3 on windows.
>
> The function works around <https://bugs.python.org/issue2128>, and the bug is fixed for python3 now.
>
> Bug: 1182016
> Change-Id: I3880843b109d5b9779e5bbd1e39a3132f925ecc4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738234
> Commit-Queue: Momo Sasaki <momosasaki@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

Bug: 1182016
Change-Id: I153640b174a78990e39b3597208b6785003ca321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738936Reviewed-by: Junji Watanabe <jwata@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

4ec3fd36

Modify fix_encodng to make it use fix_win_sys_argv for python2 only and · 20815505

Momo Sasaki authored Mar 05, 2021

not for python3 on windows.

The function works around <https://bugs.python.org/issue2128>, and the bug is fixed for python3 now.

Bug: 1182016
Change-Id: I3880843b109d5b9779e5bbd1e39a3132f925ecc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738234
Commit-Queue: Momo Sasaki <momosasaki@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>

20815505

04 Mar, 2021 1 commit

pinpoint: Update Pinpoint CLI · 3f58a798

Dean Michael Berris authored Mar 04, 2021

This update includes:

  - Support for job result downloads
  - Support for job cancellation
  - Support for waiting for started and ongoing jobs

R=dpranke@google.com

Bug: chromium:1175615
Change-Id: Ica3617413a24870dad76e7747922aa88794c2e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2732279
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

3f58a798

03 Mar, 2021 5 commits

Revert "recipes/presubmit: Don't pass gerrit project and branch flags." · e0a2e122

Edward Lesmes authored Mar 03, 2021

This reverts commit 0d49bbb5.

Reason for revert:
Hopefully it doesn't take forever this time.

Original change's description:
> recipes/presubmit: Don't pass gerrit project and branch flags.
>
> Hopefully this will unblock autoroller.
>
> Recipe-Nontrivial-Roll: build
> Change-Id: I7335f49afd6fb93763cd5966489966e6c15ce7b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730283
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: Iab1b8a2a2378028b26a84f96ecdbd08bcaa5f3fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2733472
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

e0a2e122

Roll recipe dependencies (trivial). · e839df87

recipe-roller authored Mar 03, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b0005c750146f4b802849924f328cb9c7f02f165
b0005c7 (qyearsley@chromium.org)
Add inclusive language check to list of tricium "legacy" analyzers

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia9de46295255216e1d3d9e756af50a70e98b9c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2733197
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e839df87

recipes/presubmit: Don't pass gerrit project and branch flags. · 0d49bbb5

Edward Lesmes authored Mar 03, 2021

Hopefully this will unblock autoroller.

Recipe-Nontrivial-Roll: build
Change-Id: I7335f49afd6fb93763cd5966489966e6c15ce7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730283
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0d49bbb5

Fix python2 wrapper for msys. · 2e149f26

Dirk Pranke authored Mar 03, 2021

The python_bin_reldir.txt path to find the python2 binary will
contain backslashes instead of forward slashes on Windows, so
this tweaks the wrapper in //python2-bin/python2 to handle that
and start working under msys.

Bug: 1168365
Change-Id: If0876054f0a73c9a53a1eb23ea03c60c1e756c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729410
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

2e149f26

Update whitespace · bf0766c3

Josip Sokcevic authored Mar 03, 2021

Change-Id: I89fe5184e13040ced6e016433db42093223be0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730056
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

bf0766c3

02 Mar, 2021 3 commits

Update origin HEAD when running git migration · 94ba8a26

Josip Sokcevic authored Mar 02, 2021

This updates local reference to origin/HEAD, which is necessary for
new-branch to work as expected.

R=ehmaldonado@google.com

Change-Id: Ia620b3b01c0ad23bb4e969f9026fa6bcfdd88b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730051
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

94ba8a26

Add upstream parameter when building an owners client. · 1eaaab5c

Edward Lesmes authored Mar 02, 2021

code-owners plugins wants a git ref in Gerrit (e.g. refs/heads/master)
while Depot Tools wants a local git ref (e.g. refs/remotes/origin/main,
or a git hash).

Add an upstream parameters to be used by Depot Tools, separate from
a Gerrit ref expected by owners_client.

Change-Id: Ieed97a186e3140b3f82830efa189dbe3e4d8c806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730049
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

1eaaab5c

Make autoninja.py handle git bash better · c3a48f9d

Bruce Dawson authored Mar 02, 2021

If autoninja.py detects that goma is not running when it should be then
it prints 'cmd /c exit 1' as the command to be run. This ensures that
errorlevel will be set so that the failure will be detected.
Unfortunately this doesn't work when running autoninja from git bash.
Instead of launching a cmd.exe instance which immediately exits, it
launches a cmd.exe instance which the user must manually exit.

This change adds quotes so that this works from git bash (which invokes
the shell script) as well as from cmd.exe (invoking the batch file).

Bug: 868590
Change-Id: I482f22830f9bd4f7b70c51de9647a70d946ec145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726085Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Owners-Override: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>

c3a48f9d