Commits · 34e039a17537ef9c8c7e900a44bd3a1a4e173625 · Linshizhi / Chromium_Depot_tools

19 Oct, 2012 1 commit

Revert "Fix a specific use case for the CQ." · 34e039a1

cmp@chromium.org authored Oct 19, 2012

This reverts commit r162769.

TBR=maruel@google.com
BUG=156778


Review URL: https://chromiumcodereview.appspot.com/11190067

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162892 0039d316-1c4b-4281-b951-d872f2087c98

34e039a1

18 Oct, 2012 1 commit

Fix a specific use case for the CQ. · 87dad410

maruel@chromium.org authored Oct 18, 2012

Ensure the gcl change directory is created when gcl was never used by itself but
used through trychange.py

R=nsylvain@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11193040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162769 0039d316-1c4b-4281-b951-d872f2087c98

87dad410

17 Oct, 2012 3 commits

Add script to look up a user's activity · 04d119d5

cjhopman@chromium.org authored Oct 17, 2012

Found to be particularly helpful in writing snippets.

This tool looks up all activity for a particular user across many
different services. It looks up changes and reviews across various
Rietveld and Gerrit instances and looks up issues in various google code
projects.

Running with no arguments will look up activity of $USER over the
current week (last week on Monday). I.e. the primary use case is for
looking up your activity for writing snippets.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11140010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162561 0039d316-1c4b-4281-b951-d872f2087c98

04d119d5

implement per-file OWNERS support · 17cc244c

dpranke@chromium.org authored Oct 17, 2012

R=maruel@chromium.org
BUG=119394


Review URL: https://chromiumcodereview.appspot.com/11114005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162529 0039d316-1c4b-4281-b951-d872f2087c98

17cc244c

Add recursion=n syntax to DEPS files. · 27ca3a99

ilevy@chromium.org authored Oct 17, 2012

This will let DEPS files specify a higher local bound for recursion.
Note there is an edge case where a dependency can be initially pulled
in with a lower recursion level and then gets ignored subsequently
when a lower level DEPS overrides it's inclusion level and then
includes the same dependency. I do not solve this case, as
I am intending to use this syntax for top level deps files.

BUG=155780

Review URL: https://chromiumcodereview.appspot.com/11146032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162464 0039d316-1c4b-4281-b951-d872f2087c98

27ca3a99

16 Oct, 2012 1 commit

Make gclient sync use cpu count for default jobs · 13691508

ilevy@chromium.org authored Oct 16, 2012

- On high core, fast machines, jobs=8 is does not offer good
  parallelization.  Switch to use number of local cpus.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11140019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162072 0039d316-1c4b-4281-b951-d872f2087c98

13691508

15 Oct, 2012 2 commits

Fix Issue 154553: gcl upload from within drover throws error · b531354f

srdjan@google.com authored Oct 15, 2012

Adjust timeouts in PrimeLint.

BUG=154553

Review URL: https://chromiumcodereview.appspot.com/11122005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161950 0039d316-1c4b-4281-b951-d872f2087c98

b531354f

Restore previous behavior of GetSha1ForSvnRev, so unit tests pass. · c51def3f

szager@chromium.org authored Oct 15, 2012

Review URL: https://chromiumcodereview.appspot.com/11148019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161909 0039d316-1c4b-4281-b951-d872f2087c98

c51def3f

11 Oct, 2012 2 commits

Fix safesync_url handling for git. · 312a6a4e

szager@google.com authored Oct 11, 2012

Takes into account the new submodule-enabled repository layout.
Review URL: https://codereview.chromium.org/11098064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161403 0039d316-1c4b-4281-b951-d872f2087c98

312a6a4e

Add option to synthesize a consistent lkgr commit by running deps2git.py · 1d23a428

szager@google.com authored Oct 11, 2012

and deps2submodules.py.

Depends on https://codereview.chromium.org/11085027
Review URL: https://codereview.chromium.org/11090038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161305 0039d316-1c4b-4281-b951-d872f2087c98

1d23a428

10 Oct, 2012 2 commits

Fix multi-solution use case with conflicting custom_deps overrides. · b848d5b7

maruel@chromium.org authored Oct 10, 2012

Let's say there's 2 solutions, solA and solB, both fetching the dependency depA
with different urls, solA has 'depA': 'http://foo/bar' and solB has 'depA':
From('depB', 'bar').

This case used to not work, because LateOverride() was not called in
verify_validity(), so it was not comparing the resolved urls but instead what is
textually specified in both DEPS files.

Also because LateOverride() was not called, verify_validity() was comparing the
original urls even if custom_deps is specified in the solution(s).

Finally, allow one to mismatch the other IFF one is None.

R=szager@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11088023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161228 0039d316-1c4b-4281-b951-d872f2087c98

b848d5b7

Adding *.pm and *.pl files to the list searched by 'git gs'. · d3734c9c

mkwst@chromium.org authored Oct 10, 2012

BUG=155016

Review URL: https://chromiumcodereview.appspot.com/11028112

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161109 0039d316-1c4b-4281-b951-d872f2087c98

d3734c9c

09 Oct, 2012 2 commits

Make repos without VIEW_VC also post Committed to the codereview. · c22ea4bc

cmp@chromium.org authored Oct 09, 2012

R=maruel@chromium.org
BUG=153446


Review URL: https://chromiumcodereview.appspot.com/11094033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160960 0039d316-1c4b-4281-b951-d872f2087c98

c22ea4bc

Allow special java statements (for example imports) to be as long as neccessary. · 270db5c2

sivachandra@chromium.org authored Oct 09, 2012


BUG=152209


Review URL: https://chromiumcodereview.appspot.com/11043031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160956 0039d316-1c4b-4281-b951-d872f2087c98

270db5c2

04 Oct, 2012 1 commit

Add .isolate to git-gs. · e6b162cf

maruel@chromium.org authored Oct 04, 2012

TBR=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11065002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160027 0039d316-1c4b-4281-b951-d872f2087c98

e6b162cf

03 Oct, 2012 2 commits

Add protected against empty binary file and disable all binary file support. · de85d9c7

maruel@chromium.org authored Oct 03, 2012

If a file is empty, it's not a binary file in the first place. This is to
protect against improper uploads.
From light testing, it seems binary file support is totally broken. This needs to be verified throughout before being enabled back.

TBR=rogerta@chromium.org
BUG=23608

Review URL: https://chromiumcodereview.appspot.com/11016032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159941 0039d316-1c4b-4281-b951-d872f2087c98

de85d9c7

Correct invalid use of 'is' when '==' should have been used. · cd8d8e17

maruel@chromium.org authored Oct 03, 2012

R=nsylvain@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11046016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159909 0039d316-1c4b-4281-b951-d872f2087c98

cd8d8e17

02 Oct, 2012 3 commits

Added extra error message to trychange for empty diffs · 791be0bc

hinoka@chromium.org authored Oct 02, 2012


BUG=


Review URL: https://chromiumcodereview.appspot.com/11046004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159765 0039d316-1c4b-4281-b951-d872f2087c98

791be0bc

Add option to specify similarity level for git diff operations on commandline · 53937ba7

iannucci@chromium.org authored Oct 02, 2012


BUG=125983

Review URL: https://chromiumcodereview.appspot.com/10945002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159732 0039d316-1c4b-4281-b951-d872f2087c98

53937ba7

Update upload.py at 6edc5bf0ceb2. · 3836bb2c

maruel@chromium.org authored Oct 02, 2012

TBR=iannucci@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11032023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159715 0039d316-1c4b-4281-b951-d872f2087c98

3836bb2c

01 Oct, 2012 4 commits

Fix private issues, take two. · a73435aa

maruel@chromium.org authored Oct 01, 2012

The object creation order was wrong

TBR=rogerta@chromium.org
BUG=149941


Review URL: https://chromiumcodereview.appspot.com/11024009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159524 0039d316-1c4b-4281-b951-d872f2087c98

a73435aa

Enforce the checkout object to use an absolute path. · 0aca0f96

maruel@chromium.org authored Oct 01, 2012

Stop using stderr so the output is more readable on buildbot.
Otherwise stderr arrives before stdout in apply_issue step.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11038002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98

0aca0f96

Make apply_issue.py much more verbose about what it's doing. · 4dd9f720

maruel@chromium.org authored Oct 01, 2012

It's to help users figuring out what is happening.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11028002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159504 0039d316-1c4b-4281-b951-d872f2087c98

4dd9f720

Works around rate limiting by trying to apply CL unauthenticated first. · 9d5f4ad1

maruel@chromium.org authored Oct 01, 2012

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159488 0039d316-1c4b-4281-b951-d872f2087c98

9d5f4ad1

28 Sep, 2012 1 commit

Add --no-backup-if-mismatch so no .orig file is created when fuzzing occurs. · ec4a9181

maruel@chromium.org authored Sep 28, 2012

Nobody cares about those .orig files and they get in the way on the try server
for some specific license check.

R=cmp@chromium.org
BUG=152507


Review URL: https://chromiumcodereview.appspot.com/10983092

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159329 0039d316-1c4b-4281-b951-d872f2087c98

ec4a9181

27 Sep, 2012 1 commit

Add 'git clean -f -d' to 'gclient revert' when in a git repo. · ade83db1

lliabraa@chromium.org authored Sep 27, 2012

The try slaves run 'git revert' to clean up from the previous run. This only runs 'git reset --hard', which does not remove any untracked files, so if a CL adds a new file it will still be present after 'gclient revert'. Adding git clean -f -d removes untracked files (-f) and directories (-d).

Review URL: https://chromiumcodereview.appspot.com/10986032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159020 0039d316-1c4b-4281-b951-d872f2087c98

ade83db1

26 Sep, 2012 1 commit

git command to find a git revision corresponding to lkgr. · 5a307924

szager@chromium.org authored Sep 26, 2012

Review URL: https://chromiumcodereview.appspot.com/10958056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158892 0039d316-1c4b-4281-b951-d872f2087c98

5a307924

24 Sep, 2012 2 commits

Disable jobs sent directly to triggered bots · f3b2123a

ilevy@chromium.org authored Sep 24, 2012

- and display a warning message

BUG=146713


Review URL: https://chromiumcodereview.appspot.com/10956062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158377 0039d316-1c4b-4281-b951-d872f2087c98

f3b2123a

Fix applying svn:executable on Windows. · e1a0376a

maruel@chromium.org authored Sep 24, 2012

For an unknown reason, 'svn propset svn:executable * foo.sh' doesn't work on
Windows. It is even more awkward that 'svn propset svn:executable . foo.sh'
works just fine, in particular, subversion replaces the value, as long as it's
not an empty string, back to '*'.

R=petermayo@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10967071

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158281 0039d316-1c4b-4281-b951-d872f2087c98

e1a0376a

21 Sep, 2012 5 commits

Allow the password to be specified through stdin. · 98246291

rogerta@chromium.org authored Sep 21, 2012

BUG=149941

Review URL: https://chromiumcodereview.appspot.com/10958049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158068 0039d316-1c4b-4281-b951-d872f2087c98

98246291

make pylint behave the same with or without -v · 7fc75cac

sbc@chromium.org authored Sep 21, 2012

BUG=http://code.google.com/p/chromium/issues/detail?id=151110

Review URL: https://chromiumcodereview.appspot.com/10956047

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158064 0039d316-1c4b-4281-b951-d872f2087c98

7fc75cac

Mark the apply_issue and apply_issue.bat files as executable. BUG=149941 · 3e38ff49
rogerta@chromium.org authored Sep 21, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158049 0039d316-1c4b-4281-b951-d872f2087c98
```
3e38ff49

Add wrapper scripts around apply_issue.py so that it can be called directly · 11ac30f9

rogerta@chromium.org authored Sep 21, 2012

if depot tools is in the path.

BUG=149941

Review URL: https://chromiumcodereview.appspot.com/10966042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158039 0039d316-1c4b-4281-b951-d872f2087c98

11ac30f9

Fix applying git diff with new file mode 644 on a svn checkout. · dffc73cb

maruel@chromium.org authored Sep 21, 2012

svn propdel svn:executable shouldn't be called on it.

R=petermayo@chromium.org
BUG=150960


Review URL: https://chromiumcodereview.appspot.com/10962038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158038 0039d316-1c4b-4281-b951-d872f2087c98

dffc73cb

20 Sep, 2012 1 commit

Do not enforce HEAD when a revision is not specified. · 072d94b6

maruel@chromium.org authored Sep 20, 2012

This brings back git cl try to try at LKGR instead of HEAD, which is coherent
with git-try and gcl try.

R=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10963013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157810 0039d316-1c4b-4281-b951-d872f2087c98

072d94b6

18 Sep, 2012 3 commits

update windows ninja binaries to 75f1b00cc · a5b79b69

scottmg@google.com authored Sep 18, 2012

Note that this unforks, windows ninja is now built from martine/ninja.

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/10947018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157451 0039d316-1c4b-4281-b951-d872f2087c98

a5b79b69

Allow the caller to specify a username and password so that private issues · 33578fe2

rogerta@chromium.org authored Sep 18, 2012

can be applied. This is the first part for this bug; the second part is in commands.py where this is called by the TS.

BUG=149941

Review URL: https://chromiumcodereview.appspot.com/10917306

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157355 0039d316-1c4b-4281-b951-d872f2087c98

33578fe2

Do not assume gclient is in the PATH. · 6afd0c36

maruel@chromium.org authored Sep 18, 2012

Also specify the batch file on Windows. Python's subprocess is picky about that.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10939008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157337 0039d316-1c4b-4281-b951-d872f2087c98

6afd0c36

17 Sep, 2012 1 commit

When a DEPS file is modified, run gclient sync. · 1833e57b

maruel@chromium.org authored Sep 17, 2012

It runs it by specifying BASE/HEAD to stay at the current revision.
This works around the lack of gclient sync when a DEPS file is applied on the
Try Server when triggered from Rietveld. This was handled my the Try Server
inside scripts/slave/chromium_command.py manually in the case a 'patch' is
specified.

TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10918264

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157110 0039d316-1c4b-4281-b951-d872f2087c98

1833e57b

15 Sep, 2012 1 commit

Fix svn copies for apply_issue · b0f852f3

ilevy@chromium.org authored Sep 15, 2012

_check_output_svn sets the cwd to project_path
therefore files should not have project_path.

R=maruel@chromium.org,cmp@chromium.org
BUG=149702


Review URL: https://chromiumcodereview.appspot.com/10909254

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156953 0039d316-1c4b-4281-b951-d872f2087c98

b0f852f3