- 29 Jun, 2017 1 commit
-
-
Aaron Gable authored
Using the remote url is much more useful than the hash of the first commit in the repo, since we can use it to track down repos, teams, and people still using Rietveld for review. Bug: 600469 Change-Id: I067594794ba77692c11daf63b5f5844d36209a08 Reviewed-on: https://chromium-review.googlesource.com/556301Reviewed-by:
Andrew Bonventre <andybons@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 15 Mar, 2017 1 commit
-
-
Aaron Gable authored
This issue is fixed in Python 2.7.12, but we don't guarantee that we use that version everywhere. The root issue is that, on certain platforms (e.g. Mac), the exception indicating that the underlying command (e.g. 'hg') was not found is too large, and loading the pickle representing the exception fails. This CL catches this specific exception and treats it identically to the OS properly raising a 'command not found' code. BUG=699173 Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f Reviewed-on: https://chromium-review.googlesource.com/455537Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 28 Nov, 2016 2 commits
-
-
Mike Stipicevic authored
BUG=668526 Change-Id: Id49f1c1394a72880410eb06ba7356307fff7e8c5 Reviewed-on: https://chromium-review.googlesource.com/414496 Commit-Queue: Mike Stipicevic <stip@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
Sergiy Byelozyorov authored
BUG=668526 Change-Id: I8aa762e8836ddc4838baaca803de17f3ffcb1ad2 Reviewed-on: https://chromium-review.googlesource.com/414908Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 08 Nov, 2016 1 commit
-
-
scottmg authored
It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as opposed to one that's in the current patch). BUG=544889 Review-Url: https://codereview.chromium.org/2488823002
-
- 19 Oct, 2016 1 commit
-
-
Aaron Gable authored
BUG=657216 R=dnj@chromium.org Review URL: https://codereview.chromium.org/2431893002 .
-
- 24 Aug, 2016 1 commit
-
-
agable authored
R=tandrii@chromium.org BUG=638750 Review-Url: https://codereview.chromium.org/2271873003
-
- 27 Jun, 2016 1 commit
-
-
nodir authored
R=pauljensen@chromium.org BUG= TEST=PatchSet 3 of this CL Review-Url: https://codereview.chromium.org/2096123003
-
- 22 Jun, 2016 1 commit
-
-
vapier authored
The ConfigParser module was renamed to configparser, so update the two modules using it to try both (and default to the new name). Review-Url: https://codereview.chromium.org/2076653002
-
- 17 Jun, 2016 1 commit
-
-
mgiuca authored
Review-Url: https://codereview.chromium.org/2075923003
-
- 16 Jun, 2016 3 commits
-
-
vapier authored
The newer form works with python2 and python3. Review-Url: https://codereview.chromium.org/2076643002
-
vapier authored
This makes the code work both in python2 and python3. Review-Url: https://codereview.chromium.org/2078553002
-
vapier authored
Review-Url: https://codereview.chromium.org/2076613002
-
- 09 Jun, 2016 1 commit
-
-
nodir authored
git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG=582419 Review-Url: https://codereview.chromium.org/1868313002
-
- 09 Mar, 2016 1 commit
-
-
tandrii@chromium.org authored
R=andybons@chromium.org,phajdan@chromium.org BUG= Review URL: https://codereview.chromium.org/1772293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Dec, 2015 1 commit
-
-
bratell@opera.com authored
R=dpranke@chromium.org,tandrii@chromium.org BUG= Review URL: https://codereview.chromium.org/1545913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298097 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Dec, 2015 1 commit
-
-
bratell@opera.com authored
If the stderr buffer used in git diff became full before stdout was completely consumed, git cl upload would deadlock. This also sets GIT_PAGER to be perfectly sure no pager is triggered by the git commands run. I haven't seen that as a problem but it's a reasonable (and common) precaution. BUG=558726 Review URL: https://codereview.chromium.org/1544813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298090 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Oct, 2015 1 commit
-
-
stip@chromium.org authored
Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ ) Reason for revert: Outage is now over Original issue's description: > Temporary fix for codereview cert issue. > > BUG=537763 > R=stip@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 TBR=tandrii@google.com,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537763 Review URL: https://codereview.chromium.org/1374223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Sep, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=537763 R=stip@chromium.org Review URL: https://codereview.chromium.org/1376333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 1 commit
-
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
Internal Rietveld exposes OAuth2 compatible API via /bots/* endpoints, not via /* as public one does. See crbug.com/476690. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1082033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
This CL introduces new top level command for managing cached auth tokens: $ depot-tools-auth login codereview.chromium.org $ depot-tools-auth info codereview.chromium.org $ depot-tools-auth logout codereview.chromium.org All scripts that use rietveld.Rietveld internally should be able to use cached credentials created by 'depot-tools-auth' subcommand. Also 'depot-tools-auth' is the only way to run login flow. If some scripts stumbles over expired or revoked token, it dies with the error, asking user to run 'depot-tools-auth login <hostname>'. Password login is still default. OAuth2 can be enabled by passing --oauth2 to all scripts. R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1074673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294764 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2015 4 commits
-
-
dnj@chromium.org authored
BUG=chromium:356813 TEST=local - Actually failed login, watched error message get printed. Review URL: https://codereview.chromium.org/1063143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294705 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@google.com authored
BUG=chromium:356813 TEST=None R=vadimsh@chromium.org, stip@chromium.org Review URL: https://codereview.chromium.org/1060633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294704 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@chromium.org authored
BUG=chromium:356813 TEST=local - Deleted cookies file, ran without patch, 404. - Deleted cookies file, ran on internal network, works! Review URL: https://codereview.chromium.org/1068973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294701 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
The corresponding Rietveld change is here: https://codereview.chromium.org/1054683003/ BUG=chromium:472690 Review URL: https://codereview.chromium.org/1053653004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294699 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2014 1 commit
-
-
rmistry@google.com authored
This change goes hand in hand with the corresponding Rietveld change here: https://codereview.chromium.org/773083004/ The motivation for both CLs came from the discussion in the internal CL: https://chromereviews.googleplex.com/115567013/ AFAIK either change can be submitted first without breaking anything in the other framework. Observe the "Tracked Ref" field in the below CLs- Tracking a remote ref: * https://skia-codereview-staging.appspot.com/8861001 (Tracking skiabot-test's refs/heads/master) * https://skia-codereview-staging.appspot.com/851002 (Tracking skiabot-test's refs/diff/test1) * https://skia-codereview-staging.appspot.com/2891001 (Tracking Chromium's refs/heads/master) * https://skia-codereview-staging.appspot.com/1931003 (Tracking Chromium's refs/branch-heads/1916) Tracking a local branch which in turn tracks a remote ref: * https://skia-codereview-staging.appspot.com/3891002 (Transitively tracking skiabot-test's refs/heads/master) * https://skia-codereview-staging.appspot.com/4921001 (Transitively tracking Chromium's refs/branch-heads/1916) CL when no target_ref is specified in depot_tools/third_party/upload.py: * https://skia-codereview-staging.appspot.com/3871003 (CL with missing target_ref should default to /refs/heads/master) Try the above links with and without the 'Deprecated UI' checked in https://skia-codereview-staging.appspot.com/settings BUG=435702 Review URL: https://codereview.chromium.org/781523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293334 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2014 1 commit
-
-
iannucci@chromium.org authored
Includes fix for bug 388937. R=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org BUG=388937 Review URL: https://codereview.chromium.org/785433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293259 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none TBR=jrobbins@chromium.org Review URL: https://codereview.chromium.org/733923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293010 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Oct, 2014 1 commit
-
-
jrobbins@chromium.org authored
This is just making the same change to the copy of upload.py that is in depot_tools. BUG=419156 R=iannucci@chromium.org Original Review URL: https://codereview.chromium.org/624513002 Review URL: https://codereview.chromium.org/639503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292432 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Aug, 2014 1 commit
-
-
jrobbins@chromium.org authored
BUG=339068 Review URL: https://codereview.chromium.org/442893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287615 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2014 1 commit
-
-
sheyang@chromium.org authored
BUG=374398 Review URL: https://codereview.chromium.org/298703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@276491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2014 1 commit
-
-
agable@chromium.org authored
When rietveld.py overrides upload.py's logging module, it generally works fine... until someone tries to run upload.py with any level of verbosity. Then the calls to logging.getLogger and logging.INFO/logging.DEBUG fail. This patches upload.py to properly use a module-scope logger so that rietveld.py doesn't have to perform invasive surgery, and everything just works. This version of upload.py taken from upstream Rietveld at: changeset: 1267:d7b39eca7dbe branch: chromium R=djacques@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/221423007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Oct, 2013 1 commit
-
-
maruel@chromium.org authored
TBR=stip@chromium.org BUG= Review URL: https://codereview.chromium.org/26937003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229012 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Sep, 2013 1 commit
-
-
maruel@chromium.org authored
R=iannucci@chromium.org BUG=23608 Review URL: https://chromiumcodereview.appspot.com/24135003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224175 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Jul, 2013 1 commit
-
-
ilevy@chromium.org authored
Add an option to apply_issue to fail if anonymous access triggers a login prompt. - cherry-pick upload.py rietveld cl 37c73ece82d0 which allows clients to request no authentication. BUG=240634 Review URL: https://chromiumcodereview.appspot.com/20634003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214023 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2013 1 commit
-
-
iannucci@chromium.org authored
This pulls r1084 from the chromium on upstream rietveld. R=jparent@chromium.org, maruel@chromium.org BUG=247791 Review URL: https://chromiumcodereview.appspot.com/16744006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@206743 0039d316-1c4b-4281-b951-d872f2087c98
-