- 11 Mar, 2021 1 commit
-
-
Yoshisato Yanagisawa authored
Bug: b/179630263 Change-Id: Iec0fbe3af1c206d9b5ccf5706156c1b7008f3200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2752426Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
- 10 Mar, 2021 5 commits
-
-
Josip Sokcevic authored
This reverts commit c2c576e9. Reason for revert: windows zip archived linked in documentation only fetches master branch, so that needs to resolved first. Original change's description: > Update depot_tools using main branch > > R=ehmaldonado@chromium.org > > Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935 > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: I873f84f8fbe3a6cde60955ca63eb81e6976dd1f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748946 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Change-Id: Ie8d00331d649fa33158bb78d0bb64eacd121f044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2748935 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Dirk Pranke authored
This reverts commit 0e8b3107. Reason for revert: wrappers aren't being created in python2-bin, other disruptions Original change's description: > Remove py batch wrappers from root dir > > This removes python.bat and python3.bat batch wrappers from root of this > repository. This change brings Windows set up closer to unix. > > depot_tools provides batch wrappers in python-bin and python2-bin > directories and user can opt in to use it by adding them to PATH. > > Bug: 777069 > Change-Id: Ie7571a49f940e7a69b6c18779499c39aee94d06a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2742181 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 777069 Change-Id: Ieaadb032249fa5d6eea39668355c0c7de06dfbeb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747702 Auto-Submit: Dirk Pranke <dpranke@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7c53ea7f7671c0e33dc0a95a2f87abbcb76c95fc 7c53ea7 (olivernewman@google.com) [cipd] Accept ensure files as paths More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I565726b2174532143028591d5641ec1610232675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747353 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/921d2cffbab87ffa5cf8f86cc48e01954b251d46 921d2cf (jwata@google.com) add jwata@ to recipe_modules/swarming/OWNERS More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I156204f6e860fd7f9179223867e7b4d4209b79a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2747014 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 09 Mar, 2021 4 commits
-
-
Josip Sokcevic authored
This removes python.bat and python3.bat batch wrappers from root of this repository. This change brings Windows set up closer to unix. depot_tools provides batch wrappers in python-bin and python2-bin directories and user can opt in to use it by adding them to PATH. Bug: 777069 Change-Id: Ie7571a49f940e7a69b6c18779499c39aee94d06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2742181Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/396b52a55bb1fbb4937b9489be668822f5d952cb 396b52a (iannucci@chromium.org) [step_runner/subproc] Track and kill all processes on Windows a... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I721de3238dcad999204ad5245840aa1cd487e610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2746094 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/02b67c942554ede07fe6d9b57c379d13e0d2d836 02b67c9 (vadimsh@chromium.org) [cipd] Add `-metadata` and `set-metadata` support. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I12e2df5730dad62f82d1d118d40aea3b1b84f570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2745675 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9e63c4c60a1eb5b7db07f8e12593b6c3975b9a5e 9e63c4c (bryner@google.com) Fix recipes.py on Windows. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org, sokcevic@google.com, tandrii@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I197756661f65205dd08f2ec04591ddb4effa6234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2744255 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 08 Mar, 2021 2 commits
-
-
Mike Frysinger authored
Change-Id: I2f16f0fda382d25af55c735de69cd97e95f4b61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727068Reviewed-by:
Alex Klein <saklein@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0dfd500e7b91f883ce716ead0b3c0a9dae0ad669 0dfd500 (chanli@chromium.org) [ResultDB] wrap: add require_build_inv flag More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id5f585876350bdc22a0c951e98b41941fa45a9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2743199 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 05 Mar, 2021 2 commits
-
-
Takuto Ikuta authored
This reverts commit 20815505. Reason for revert: This is not necessary after https://crrev.com/c/1929653 Original change's description: > Modify fix_encodng to make it use fix_win_sys_argv for python2 only and > not for python3 on windows. > > The function works around <https://bugs.python.org/issue2128>, and the bug is fixed for python3 now. > > Bug: 1182016 > Change-Id: I3880843b109d5b9779e5bbd1e39a3132f925ecc4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738234 > Commit-Queue: Momo Sasaki <momosasaki@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Junji Watanabe <jwata@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Bug: 1182016 Change-Id: I153640b174a78990e39b3597208b6785003ca321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738936Reviewed-by:
Junji Watanabe <jwata@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
Momo Sasaki authored
not for python3 on windows. The function works around <https://bugs.python.org/issue2128>, and the bug is fixed for python3 now. Bug: 1182016 Change-Id: I3880843b109d5b9779e5bbd1e39a3132f925ecc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738234 Commit-Queue: Momo Sasaki <momosasaki@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org>
-
- 04 Mar, 2021 1 commit
-
-
Dean Michael Berris authored
This update includes: - Support for job result downloads - Support for job cancellation - Support for waiting for started and ongoing jobs R=dpranke@google.com Bug: chromium:1175615 Change-Id: Ica3617413a24870dad76e7747922aa88794c2e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2732279 Auto-Submit: Dean Berris <dberris@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 03 Mar, 2021 5 commits
-
-
Edward Lesmes authored
This reverts commit 0d49bbb5. Reason for revert: Hopefully it doesn't take forever this time. Original change's description: > recipes/presubmit: Don't pass gerrit project and branch flags. > > Hopefully this will unblock autoroller. > > Recipe-Nontrivial-Roll: build > Change-Id: I7335f49afd6fb93763cd5966489966e6c15ce7b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730283 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Iab1b8a2a2378028b26a84f96ecdbd08bcaa5f3fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2733472 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b0005c750146f4b802849924f328cb9c7f02f165 b0005c7 (qyearsley@chromium.org) Add inclusive language check to list of tricium "legacy" analyzers More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia9de46295255216e1d3d9e756af50a70e98b9c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2733197 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Hopefully this will unblock autoroller. Recipe-Nontrivial-Roll: build Change-Id: I7335f49afd6fb93763cd5966489966e6c15ce7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730283 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Dirk Pranke authored
The python_bin_reldir.txt path to find the python2 binary will contain backslashes instead of forward slashes on Windows, so this tweaks the wrapper in //python2-bin/python2 to handle that and start working under msys. Bug: 1168365 Change-Id: If0876054f0a73c9a53a1eb23ea03c60c1e756c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729410 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
Change-Id: I89fe5184e13040ced6e016433db42093223be0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730056 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 Mar, 2021 10 commits
-
-
Josip Sokcevic authored
This updates local reference to origin/HEAD, which is necessary for new-branch to work as expected. R=ehmaldonado@google.com Change-Id: Ia620b3b01c0ad23bb4e969f9026fa6bcfdd88b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730051 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
code-owners plugins wants a git ref in Gerrit (e.g. refs/heads/master) while Depot Tools wants a local git ref (e.g. refs/remotes/origin/main, or a git hash). Add an upstream parameters to be used by Depot Tools, separate from a Gerrit ref expected by owners_client. Change-Id: Ieed97a186e3140b3f82830efa189dbe3e4d8c806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730049 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Bruce Dawson authored
If autoninja.py detects that goma is not running when it should be then it prints 'cmd /c exit 1' as the command to be run. This ensures that errorlevel will be set so that the failure will be detected. Unfortunately this doesn't work when running autoninja from git bash. Instead of launching a cmd.exe instance which immediately exits, it launches a cmd.exe instance which the user must manually exit. This change adds quotes so that this works from git bash (which invokes the shell script) as well as from cmd.exe (invoking the batch file). Bug: 868590 Change-Id: I482f22830f9bd4f7b70c51de9647a70d946ec145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726085Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Owners-Override: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Josip Sokcevic authored
This reverts commit 2cf835a9. Reason for revert: doesn't work with depot_tools error 404 Not found: tools (with applied patch from 2729404) Bug: 1183975 Original change's description: > presubmit: Skip owners checks if code-owners plugin is enabled. > > If code-owners plugin is enable for the repo, skip owners check on > commit, and skip checking owners format, as that will be done by > the plugin. > > Change-Id: I1663baef4f0f27b00423071343fe740f6da50ce7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727131 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Id4d560701e4b0144e0aafc5263e09ed6927f6222 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729409 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Josip Sokcevic authored
This reverts commit 70405c2f. Reason for revert: doesn't work with depot_tools error 404 Not found: tools Bug: 1183975 Original change's description: > presubmit: Fix checking if code-owners enabled for repo. > > Change-Id: I22e6a9d4405d92d26dfbfba64735b6e9ce92674c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729404 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: Ib358f31e7c4c6fc07f98db4758004097234eaa87 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729408 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Dirk Pranke authored
The python3_bin_reldir.txt path to find the python binary will contain backslashes instead of forward slashes on windows, so this tweaks the wrapper in //python-bin/python3 to handle that and start working under msys. Bug: 1168365 Change-Id: I0c83f36f48f229276803c2e5d73ec86ecb55ada1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2721367Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Edward Lesmes authored
Change-Id: I22e6a9d4405d92d26dfbfba64735b6e9ce92674c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729404 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
If code-owners plugin is enable for the repo, skip owners check on commit, and skip checking owners format, as that will be done by the plugin. Change-Id: I1663baef4f0f27b00423071343fe740f6da50ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727131 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dbdb4601a494804eaf83d06b6bb18c94e5f776c9 dbdb460 (gbeaty@chromium.org) Update the version of attrs used in recipe engine. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5f580b2ef32f53a2cda447c02d48a3b7ae48db62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729401 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
We have to use refs/remotes/origin/foo instead of refs/heads/foo, as refs/heads/foo might not be defined. https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8853851694141987488/+/u/build/git_cl_upload/stdout Change-Id: Ic729510d7beca63c25ea84394758cb62f76c572f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729615 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 01 Mar, 2021 7 commits
-
-
Edward Lesmes authored
Change-Id: Iaca829ed8af6d040bbd588aeb1ec9a021594d705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2728130 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Edward Lesmes authored
Bug: 1183447 Change-Id: I11c67b13ace08eb5bafb90756bd45af6ff39f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727569 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/653da17a19d3fd054c7811afc9a83a4cfc7a6c58 653da17 (iannucci@chromium.org) [engine] Improve recipe engine behavior in cancelation/timeout... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a9e715fa2e8046221cf290f201a665c84b8deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727014 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
John Budorick authored
Matching chromium. (I'm sure this is asking for trouble.) Bug: chromium:1007101 Change-Id: Iba3200bd093697f41551c99f58a9c5261c958436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726729Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lesmes authored
Will be used in a follow-up CL to initialize code-owners client. Recipe-Nontrivial-Roll: build Change-Id: Iefe9176320b4d1ae7715e88a8db132e815be76ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2717979 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c5b9437ca18dd89b247ab4115e0a1d5530f1b7ac c5b9437 (tikuta@chromium.org) runtime: fix comment of experiments field usage More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10475fdc3be031fd646feebaaf813466a13c5b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727568 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Mike Frysinger authored
Debian is deleting /usr/bin/python by default, so re-use the existing python3 interp that our wrapper was invoked with. Bug: 1182059 Test: `./repo` still works w/out /usr/bin/python Change-Id: I1806f2ae2f8c6fe8b5f5a95fd2e50735d6e3196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2715994Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 27 Feb, 2021 1 commit
-
-
Bruce Dawson authored
This reverts commit 428143ee. Reason for revert: Fixing the issues revealed by the original change by avoiding python3 and by checking for the existence of gomacc[.exe] before running it. This also relands 2241db8a - "Avoid capture_output to support Python 3.6", to simplify relanding and any possible reverts. Original change's description: > Revert "Check whether goma is running when it is enabled" > > This reverts commit b7ddc5a0. > > Reason for revert: > This broke the builder where depot_tools is not in PATH. > https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858077852309878080/+/u/build/stdout > > Original change's description: > > Check whether goma is running when it is enabled > > > > One of the mistakes one can make when running ninja is having goma > > enabled (use_goma=true in args.gn) but not having goma running. This can > > lead to ~1,000 failed compile steps, which is messy. > > > > This change teaches autoninja.py to check whether goma is running. If > > not then it tells autoninja to just print a warning message. The > > check costs roughly 30 ms which seems reasonable. > > > > In fact, because this change also switches away from vpython (necessary > > to use python3 to use subprocess.run) it actually runs about 600 ms > > _faster_ than before this change. > > > > If build acceleration is requested through use_rbe then no checking for > > whether the service is running is done. That could be added in the > > future. > > > > autoninja.py could auto-start goma but that is error prone and has > > limited additional value. > > > > This was tested on Linux, OSX, and Windows. > > > > Bug: 868590, b/174673874 > > Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I57a6c73ea853259f3d1ec7ad0ce51e495acc96db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868590 > Bug: b/174673874 > Bug: 1167064 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 868590 Bug: b/174673874 Bug: 1167064 Change-Id: I8aa6830259bc18f8e7926cd0bf5c62e671c74a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2634201Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 26 Feb, 2021 2 commits
-
-
Takuto Ikuta authored
This is for python3 compatibility. Bug: b/177465438 Change-Id: I4770136ea702bcaf7a8b644ef842db2f1a7d1200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2717272Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a5ac18a9966dab7f09069ede9ec3128547535882 a5ac18a (iannucci@chromium.org) [StepPresentation] Replace spaces in urls with %20. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I13c8ffc26838f3c1b2ed8c6eb619dadf341a012e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2720710 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-