- 12 Mar, 2020 5 commits
-
-
Edward Lemur authored
Bug: 1042324 Change-Id: I72db082f086f69bf49256d0613c39dc92ae0a07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101471 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
If the Change-Id in the description is different from the one fetched from Gerrit, automatically set the right one instead of asking the user to do so. Change-Id: I0f681d9e7d98f3ed50adc4b6e4929981530e901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2101368 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
Interrupt tests after 3 min, so that failures can be surfaced before the presubmit step gets interrupted on the bot. Change-Id: Ia0efebaac5a0c5072b974a4fbbcb14fe672017ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098942Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Implicitly concatenated strings are not supported when setting new revisions, so raise an error when attempting to do se. Bug: 1060772 Change-Id: I74d39b9eb8dcc420e9b7787c90bee642beb783cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099407Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
This also applies to git map-branches. R=ehmaldonado Change-Id: Ica9bc92660716c15cbdd6bfd77b93f08bd0d8f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099329 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 11 Mar, 2020 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/caf3b9371438a8ef80c7cc977f770d8ed939731b (mikenichols@chromium.org) update.py: Add GCE Provider protos to list of protos More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie47304611f9964f9d2137fa3c3b23e05bae191ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2099426Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lemur authored
gclient executes `git rev-parse <ref>` to check if <ref> already exists in the local clone, which succeeds when <ref> is a git revision hash, even if it doesn't exist. We execute `git rev-parse <ref>^{commit}` instead, which only succeeds when <ref> resolves to a valid commit in the local repo. Change-Id: Ia1cdf7162c4c82a7e4214c6af375c1a9522d7b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095745Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
When running `git rev-parse REV^{commit}` in Windows, `^` must be escaped. However, it was escaped more times than necessary. Split IsValidRevision to call ResolveCommit, add tests to ResolveCommit, and run scm.py tests on Windows. Change-Id: I761a820394c8b5410d68b6ccd6c352c41c30c88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2092904Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/6b8de18a4a0c44f518f2c68e119cb71bee118e5a (mikenichols@chromium.org) go.chromium.org: Update recipe protos More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4deee1c7c503722ecf71865bdeb1aeaca47ff1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2098123Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Andrii Shyshkalov authored
R=apolito@google.com Bug: 1060018 Change-Id: I384e8bda14341159674e941abb6f723329ca5d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097341Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
Edward Lemur authored
stdout and stderr are bytes in Python 3 and must be decoded before printing the exception. Bug: 1060409 Change-Id: Ib855f6104919734b7505aa5e978ebe394a1e9db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097595Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 10 Mar, 2020 4 commits
-
-
George Engelbrecht authored
BUG=chromium:1060257 TEST=./recipes.py test run Change-Id: Ie081430ff5f83964a53401099ce3c9bee682c7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2097040Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
David Burger <dburger@chromium.org> Reviewed-by:
George Engelbrecht <engeg@google.com> Commit-Queue: George Engelbrecht <engeg@google.com>
-
Andrii Shyshkalov authored
CQ added support to project-scoped accounts instead of previously hardcoded commit-bot@ for working with Gerrit. R=ehmaldonado Test: `git cl status` on this very CL :) Bug: 911811 Change-Id: I8f48a7bdc9dad9a5b71d266ccf7e9a493aa94aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095986Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
John Budorick authored
Updating to match crrev.com/i/2720965. Bug: 1059948 Change-Id: I36a24a488978d00e164504e9a6d3eeb51aab6da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095862Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Yoshisato Yanagisawa authored
Bug: b/150814527 Change-Id: I58e5590de034b02a25be5eb35d36932b53607716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2095605 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Ye Kuang <yekuang@google.com> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
-
- 09 Mar, 2020 1 commit
-
-
Edward Lemur authored
Also refactor code to eliminate multiple calls to _create_description_from_log. Change-Id: I113134fbd90f396bdb6d561ed0369ea5ee9c78ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2090448Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 07 Mar, 2020 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/e15cecbc906eef0583e364eeaeef4fd2b4352e6f (yiwzhang@google.com) Profile memory before every step execution if enabled in properties More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I113d4203995f482739be105b79ce7470c28a29b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2093096Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 06 Mar, 2020 4 commits
-
-
Edward Lemur authored
Bug: 1059141 Change-Id: I0a4501946014bd567548fb5396c3dd761606a9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091584 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/0e747474f9f9d02568598aec9070c361cd057163 (yuanjunh@google.com) Buildbucket recipe raises infraFailure on HTTP 500 rpc failures More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I88bfaf4ddeddd3bf9ab09903f42ef4522aac40e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091925Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Andrii Shyshkalov authored
R=yiwzhang Bug: 1056725 Change-Id: Id09e1a243e7071b5dc5715d156063e4b08230e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080764Reviewed-by:
Yiwei Zhang <yiwzhang@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
Takuto Ikuta authored
context: http://shortn/_nIAnsMynAk Change-Id: I578779b3a235bf32094cf0769e69dfae73727be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2091174 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 05 Mar, 2020 2 commits
-
-
Quinten Yearsley authored
Bug: 1057745 Change-Id: Ic1b977634e15b163e627c0f389047a26f7b0c7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083677 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
Edward Lemur authored
When user.email is not configured in git, git-cl tries to call presubmit support with --author None, which makes git-cl crash. Bug: b/150870673 Change-Id: Idc42ba2b970340ed93e1e92f65850fc1a12336d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2090375Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 04 Mar, 2020 7 commits
-
-
Fumitoshi Ukai authored
Bug: b/150257427 Change-Id: I82358c1c0d9e1e980433b4923244e7983ae4fd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2087351Reviewed-by:
Ye Kuang <yekuang@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
-
Edward Lemur authored
Bug: 809671 Change-Id: I74103304651417e6b6889cb713fe494c95279d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088422Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Quinten Yearsley authored
Change-Id: I3310db47604dafead241db4d8d3540277daeb07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083675 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/529c1c9fa9ed3a118c777ca6a09033bfb0b56853 (olivernewman@google.com) [docs] Add recipes.cfg option to disable doc generation More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If605022323d0b94bb6cc447f985b9fbcf2c4d350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088428Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lemur authored
When no -v flag is given, the verbosity defaults to None instead of 0, so set 0 as a default. Bug: 1058315 Change-Id: Id69e62550b33cd18bb1e5aed9cdc3c94f1488516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2088193Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
file does not exist on Python 3. Change-Id: I9392fd797b730784cff4d1144c5a3ab1027c7dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086493Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
- Don't encode description when calling presubmit, codecs.open already takes care of that. - Don't use raw_input on Python 3 - Encode stdin when calling clang-format. Bug: 1058318, 1058318 Change-Id: I825422e160c00b33b2c52b6e64e5f0a3e44606f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086631Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 03 Mar, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/b6adffa3a5c4cf889bc56c167aaa7872e87751d6 (yiwzhang@google.com) Make _setup_build_step instance method More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2962a728b687082a786df6c82aa3e917b0a9bf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2086491Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. Please review the expectation changes, and LGTM+CQ. recipe_engine: https://crrev.com/1c1b5028819c1e6ec876b2574f848f8b4b5f5f1c (yuanjunh@google.com) Prompt errors when README.recipes.md is not regenerated More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idcfb75c8434492e2f2a296d90e9a3966cf8bb828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2084400 Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org>
-
Edward Lemur authored
Change-Id: If33fe4531841921d79101ec8f0c1534a5308b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083580Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Change-Id: I7215335eb4592cba80d31595b3bac75f55372dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2083589Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 Mar, 2020 2 commits
-
-
Edward Lemur authored
Fix issue with gerrit_util.py and add tests. Change-Id: Ie523ea59ddb93cf5c7fa35f3761310ce96747720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2081092Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1042324 Change-Id: I9d554d8ffe5c17278d4cd90d2aa0a49fc329f695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2075797Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 29 Feb, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/ca01a2f6cb0d44631e89064dfbcef954b81417e6 (gbeaty@chromium.org) Change the behavior of debug with no arguments to debug recent failure. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I70da6cf488bf206bdb5cb94c1249baf1c862d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2081311Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/0677e84086bd93f6d4ec1faefd1dfdff4b0225fb (gbeaty@chromium.org) Add a function for parsing test names. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iaa8bab59faafb653a39ea1cecc45f0fe4bf7924f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2079395Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Andrii Shyshkalov authored
R=erikchen Recipe-Nontrivial-Roll: build Change-Id: I171daa3d61b2c20f963b8d587df8662740d80e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050537Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
-
Andrii Shyshkalov authored
R=smut Change-Id: Ie919e4f90378ecdeb6a2e015cb313f044aa2d214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2080206 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
smut <smut@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-