- 07 Sep, 2017 2 commits
-
-
Paweł Hajdan Jr authored
This reverts commit bfa05c83. Reason for revert: breaks bot bootstrap Original change's description: > update_depot_tools: make cipd_bin_setup failures fatal > > This should make them more noticeable. > > Bug: 762568 > Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc > Reviewed-on: https://chromium-review.googlesource.com/653157 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> TBR=phajdan.jr@chromium.org,dnj@chromium.org Change-Id: I14e8aae77beca52ebbd21567e2ea20954e2b34d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762894, 762568 Reviewed-on: https://chromium-review.googlesource.com/654977Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Pawel Hajdan, Jr authored
This should make them more noticeable. Bug: 762568 Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc Reviewed-on: https://chromium-review.googlesource.com/653157Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 02 Aug, 2017 1 commit
-
-
Dirk Pranke authored
The update_depot_tools script had a line where a call out to the test operator ([]) wasn't quoting all of the arguments, leading to errors if a directory had spaces in the name. R=dnj@chromium.org, phajdan.jr@chromium.org Bug: Change-Id: Ie1f5f51891a2582614ed3d9b16375d2ad522360b Reviewed-on: https://chromium-review.googlesource.com/598427Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
- 28 Jul, 2017 1 commit
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logs, if it does happen. This will ensure that users who execute the tools don't see unexpected output. BUG=chromium:748651 TEST=local - Tested on Mac and Windows. Change-Id: I1aad897d885a07beeac40a372a658681720efd2a Reviewed-on: https://chromium-review.googlesource.com/591229 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 26 Jul, 2017 1 commit
-
-
Dirk Pranke authored
This reverts commit 4d92fe43. Reason for revert: This moved the logging from invoking `led` or `vpython` to whenever someone would run something that would end up invoking `update_depot_tools`. It's good that we are calling this when we run update_depot_tools, but we probably should've suppressed the logging there in at least the success case, because now things are even more confusing. See crbug.com/748651. Original change's description: > [bootstraps] Sync at gclient, suppress output. > > Have the "update_depot_tools" script also do a CIPD tool sync. This will > ensure that users and systems have access to tooling at sync-time rather > than just-in-time loading them at execution time. > > Update the tool boostraps to suppress any sort of syncing logic, if it > does happen. This will ensure that users who execute the tools don't se > unexpected output. > > BUG=None > TEST=local > - Tested on Mac and Windows. > > R=dpranke@chromium.org, iannucci@chromium.org > > Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 > Reviewed-on: https://chromium-review.googlesource.com/581494 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,dpranke@chromium.org,dnj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I2485c9dd2e48a8dbdeebfff5da9d4c708e0edcb7 Reviewed-on: https://chromium-review.googlesource.com/585867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 24 Jul, 2017 1 commit
-
-
Dan Jacques authored
Have the "update_depot_tools" script also do a CIPD tool sync. This will ensure that users and systems have access to tooling at sync-time rather than just-in-time loading them at execution time. Update the tool boostraps to suppress any sort of syncing logic, if it does happen. This will ensure that users who execute the tools don't se unexpected output. BUG=None TEST=local - Tested on Mac and Windows. R=dpranke@chromium.org, iannucci@chromium.org Change-Id: I8efce8c73cc4e82ffdf5067ba9b917119a81e843 Reviewed-on: https://chromium-review.googlesource.com/581494 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 07 Jul, 2017 1 commit
-
-
Dan Jacques authored
Remove Windows SVN bootstrapping and some SVN tooling. Since "depot_tools" is no longer sync'd to SVN, and we have been committed to Git for years now, this is obsolete. Any transition code will never reach SVN users, and any remaining code should not be used by Chromium developers. BUG=chromium:630904 TEST=unit Change-Id: Ie984e8400a748702b125eaeed8157719ef4b88cc Reviewed-on: https://chromium-review.googlesource.com/562748 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 01 Jun, 2017 1 commit
-
-
Dan Jacques authored
Enable a sentinel file to enable/disable "depot_tools" auto-updating. This file, if present, indicates that automatic updating should not occur. Add a simple control script to enable/disable automatic updating. BUG=chromium:727917 TEST=local - Ran locally, --enable, --disable. R=iannucci@chromium.org, maruel@chromium.org, nodir@chromium.org Change-Id: Id30a17586248228849d046f79d7e0bc445d97f97 Reviewed-on: https://chromium-review.googlesource.com/521884 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
- 21 Jun, 2016 1 commit
-
-
Aaron Gable authored
R=maruel@chromium.org BUG=600446 Review URL: https://codereview.chromium.org/2088653003 .
-
- 23 May, 2016 1 commit
-
-
agable@chromium.org authored
R=iannucci@chromium.org BUG=600446 Review URL: https://codereview.chromium.org/2000913002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300660 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2016 1 commit
-
-
iannucci@chromium.org authored
R=agable@chromium.org, dnj@chromium.org, mmoss@chromium.org BUG=600028 Review URL: https://codereview.chromium.org/1848353003 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299677 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Mar, 2016 2 commits
-
-
iannucci@chromium.org authored
R=dnj@chromium.org, pkasting@chromium.org BUG=598941 Review URL: https://codereview.chromium.org/1847433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299559 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=dnj@chromium.org, pkasting@chromium.org BUG=598941 Review URL: https://codereview.chromium.org/1845493003 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299556 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2015 3 commits
-
-
sergiyb@chromium.org authored
Original CL: https://codereview.chromium.org/1437483002/. R=dnj@google.com, tandrii@chromium.org, dnj@chromium.org, pgervais@chromium.org BUG=542922, 503067 Review URL: https://codereview.chromium.org/1407953011 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297494 0039d316-1c4b-4281-b951-d872f2087c98
-
dnj@google.com authored
Revert of Removed virtualenv from depot_tools (patchset #1 id:1 of https://codereview.chromium.org/1437483002/ ) Reason for revert: This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this. update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems. I'm reverting to restore the toolchain so we can create new Windows bots. Original issue's description: > Removed virtualenv from depot_tools > > This effectively reverts http://crrev.com/1195423002 and > http://crrev.com/1205873002. > > R=pgervais@chromium.org, tandrii@chromium.org > TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) > BUG=542922,503067 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491 TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542922,503067 Review URL: https://codereview.chromium.org/1431173002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
This effectively reverts http://crrev.com/1195423002 and http://crrev.com/1205873002. R=pgervais@chromium.org, tandrii@chromium.org TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) BUG=542922,503067 Review URL: https://codereview.chromium.org/1437483002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Sep, 2015 1 commit
-
-
sky@chromium.org authored
Without this I get prompted if I really want to remote the file. BUG=none TEST=none Review URL: https://codereview.chromium.org/1332303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296651 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Jun, 2015 1 commit
-
-
pkasting@chromium.org authored
BUG=none TEST=update_depot_tools actually works in msysgit Review URL: https://codereview.chromium.org/1208053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295866 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2015 1 commit
-
-
sergiyb@chromium.org authored
Original CL: https://chromiumcodereview.appspot.com/1200843003/ R=pgervais@chromium.org BUG=503067 TEST=tested on Mac, Windows and Linux bots Review URL: https://codereview.chromium.org/1205873002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295842 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jun, 2015 2 commits
-
-
akuegel@chromium.org authored
Revert of Added virtualenv for depot_tools (patchset #10 id:180001 of https://chromiumcodereview.appspot.com/1200843003/) Reason for revert: Doesn't work, virtualenv is missing in depot_tools checkout. Original issue's description: > Added virtualenv for depot_tools > > R=pgervais@chromium.org > BUG=503067 > TEST=tested on Mac, Windows and Linux bots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295811 TBR=pgervais@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503067 Review URL: https://codereview.chromium.org/1202843005. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295813 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
R=pgervais@chromium.org BUG=503067 TEST=tested on Mac, Windows and Linux bots Review URL: https://codereview.chromium.org/1200843003. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295811 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Apr, 2015 1 commit
-
-
sergiyb@chromium.org authored
This is needed to prevent auto_deploy.py in CQ send alert each time depot_tools get's updated as cron job will send alert on any output. R=stip@chromium.org CC=akuegel@chromium.org BUG=475049 Review URL: https://codereview.chromium.org/1073113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Dec, 2014 1 commit
-
-
pkasting@chromium.org authored
Use grep -e --force instead of grep "--force" since apparently the latter doesn't work properly in all cases. BUG=441072 TEST=No errors from gclient :/ Review URL: https://codereview.chromium.org/802513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293380 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2014 1 commit
-
-
pkasting@chromium.org authored
This uses grep instead. Note that just grepping for "--force" matches other things, e.g. "foo--force--foo", but that's a problem with the original code as well, I think. BUG=435729 TEST=Run gclient under msysgit bash. No error should occur. Review URL: https://codereview.chromium.org/789353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293340 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Nov, 2014 1 commit
-
-
agable@chromium.org authored
R=iannucci@chromium.org, szager@chromium.org, pdr@chromium.org BUG=435729 Review URL: https://codereview.chromium.org/756233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293112 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Mar, 2014 1 commit
-
-
szager@chromium.org authored
Also, allow multiple git installations to exist side-by-side. This makes it easier to revert back to an old version quickly. BUG= R=maruel@chromium.org Review URL: https://codereview.chromium.org/203463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258058 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Feb, 2014 1 commit
-
-
mmoss@chromium.org authored
The git path is based on the git version, so it might change whenever git is updated. Run git.bat instead, since that's updated with new git installs and should always point to the right path. The mingw logic is based on similar handling of python.bat in git-cl. Review URL: https://codereview.chromium.org/166273024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252584 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Jan, 2014 1 commit
-
-
pkasting@chromium.org authored
This is necessary so that Cygwin users have a python directory in depot_tools/, which will soon be used by gyp_chromium. BUG=335180 Review URL: https://codereview.chromium.org/141523009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245704 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Jan, 2014 2 commits
-
-
rnk@chromium.org authored
Revert of Fetch Windows tools on Cygwin and use that Python for some scripts (https://codereview.chromium.org/140843004/) Reason for revert: This broke auto-updating depot_tools on Cygwin due to use of exec Original issue's description: > Fetch Windows tools on Cygwin and use that Python for some scripts > > Tested by running gclient sync a couple of times from a Cygwin shell. > > R=dpranke@chromium.org > CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org > BUG=335180 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245315 TBR=dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=335180 Review URL: https://codereview.chromium.org/132883007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245330 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
Tested by running gclient sync a couple of times from a Cygwin shell. R=dpranke@chromium.org CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org BUG=335180 Review URL: https://codereview.chromium.org/140843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245315 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Oct, 2013 1 commit
-
-
stuart@fivemicro.com authored
Previous code checked the exit status of 'echo' instead of 'read' to determine if the 'read' command had timed out. TEST=Create a mirror of depot_tools.git, git clone it, then run ./update_depot_tools, see prompt for changing the URL, wait at least 60 seconds and verify that you get the timeout message. R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/25110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227427 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jan, 2013 1 commit
-
-
szager@chromium.org authored
BUG=169945 Review URL: https://chromiumcodereview.appspot.com/12047061 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@178430 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Jan, 2013 1 commit
-
-
szager@chromium.org authored
Review URL: https://codereview.chromium.org/11778024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175419 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2013 1 commit
-
-
szager@chromium.org authored
BUG=168205 Review URL: https://chromiumcodereview.appspot.com/11742032 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175040 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Nov, 2012 1 commit
-
-
newt@chromium.org authored
The bash command "local myvar=$(mycommand)" has the exit status of the bash builtin "local" rather than the exit status of mycommand. To get the exit status of mycommand, "local myvar" should be run separately on a previous line. Review URL: https://chromiumcodereview.appspot.com/11308129 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169446 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2012 1 commit
-
-
ilevy@chromium.org authored
R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/11360150 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166846 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jul, 2012 1 commit
-
-
maruel@chromium.org authored
Otherwise, the output was: fatal: Needed a single revision invalid upstream origin R=szager@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10784045 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@147064 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 May, 2012 1 commit
-
-
cmp@chromium.org authored
Until recently, no proper Git clone of depot_tools existed. All Git clones were set up locally via git svn clone. The way repos of that type are updated is via 'git svn rebase'. Now, a supported Git clone of depot_tools exists. The update process for repos of this type is via 'git fetch' and 'git rebase'. Modify the update_depot_tools* scripts so they can update depot_tools for git cloned or git svn cloned methods. This also means that git svn is no longer required, so move that test after we check for git cloned repos. R=maruel@chromium.org TEST=Linux + git clone: on Linux, git clone https://git.chromium.org/chromium/tools/depot_tools.git. Apply and commit this patch locally. Note commit hash of HEAD. Run 'git reset --hard "HEAD^^^"'. Run 'git cherry-pick HASH_OF_UPDATE_CHANGE'. Run './update_depot_tools'. Verify depot_tools is updated to latest available revision + this change. TEST=Linux + git svn clone: on Linux, git svn clone svn://svn.chromium.org/chrome/trunk/tools/depot_tools. Apply and commit this patch locally. Note commit hash of HEAD. Run 'git reset --hard "HEAD^^^"'. Run 'git cherry-pick HASH_OF_UPDATE_CHANGE'. Run './update_depot_tools'. Verify depot_tools is updated to latest available revision + this change. TEST=Windows command prompt + git clone: on Windows command prompt, run Linux+git clone test, except use update_depot_tools.bat. Verify depot_tools is updated to latest available revision + this change. TEST=Windows command prompt + git svn clone: on Windows command prompt, run Linux+git svn clone test, except use update_depot_tools.bat. Verify depot_tools is updated to latest available revision + this change. TEST=Windows cygwin + git clone: on Windows command prompt, run Linux+git clone test. Verify depot_tools is updated to latest available revision + this change. TEST=Windows cygwin + git svn clone: on Windows command prompt, run Linux+git svn clone test. Verify depot_tools is updated to latest available revision + this change. Review URL: https://chromiumcodereview.appspot.com/10263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134732 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Apr, 2012 1 commit
-
-
maruel@chromium.org authored
In Windows (already worked correctly in posix): gclient wouldn't correctly update depot_tools when called. Refactored away the bootstrap depot_tools update flow which only still existed in Windows. Patch contributed by gab@chromium.org R=maruel@chromium.org BUG= TEST=Running `gclient sync` from src/ and see depot_tools being correctly updated under a git depot_tools checkout. Review URL: https://chromiumcodereview.appspot.com/9751009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@132191 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Sep, 2011 1 commit
-
-
dpranke@chromium.org authored
TBR=maruel@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8073008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103214 0039d316-1c4b-4281-b951-d872f2087c98
-