- 02 Feb, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/a7a17ae6545a9ff04b71b3655ff4d08a0de32926 [recipe_modules/path] add abs_to_path. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2674593002
-
- 01 Feb, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/0e4d4e97edb04696b0b1452522eb26f1dc633e8e step: expose methods to read values from context (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2667863006
-
- 31 Jan, 2017 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/4fb4d4bdfda85253b842648abf8588749c68a5eb Fix multi-repo workflow overrides and add tests (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2666123002
-
Andrii Shyshkalov authored
R=machenbach@chromium.org BUG=685318 Change-Id: I61192392eec98ad6b9a32ef933f2d22cf2aedd0e Reviewed-on: https://chromium-review.googlesource.com/435318 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
- 30 Jan, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/30a672d26b45289947783932d8062fc70dfb1611 Make it possible to override more than one package (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2664843003
-
- 29 Jan, 2017 1 commit
-
-
Andrii Shyshkalov authored
TBR=sergiyb@chromium.org,agable@chromium.org BUG= Change-Id: I37f02556f254fbdc78ab30e990a7cc6d05120038 Reviewed-on: https://chromium-review.googlesource.com/434477Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 27 Jan, 2017 3 commits
-
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org,agable@chromium.org BUG= Change-Id: I7684923c19fe7441cdd52b7707c28f01c95a4ba4 Reviewed-on: https://chromium-review.googlesource.com/433699 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/b120624b72ec851b0d9f2accccf58e525555be25 step: make all args to __call__ explicit (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2656133003
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/bbcf1dc6436d1f89ffd35fe3354b9ee7701e272a Whitelisting python's copy module for recipes. (robertocn@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2660583002
-
- 26 Jan, 2017 5 commits
-
-
Andrii Shyshkalov authored
R=agable@chromium.org BUG=681704 Change-Id: I3c0ab781e0357e0855d50157c5653df57f68ac9a Reviewed-on: https://chromium-review.googlesource.com/432336Reviewed-by: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
Also fixes git cl description <url> by propagating codereview host information in all cases. BUG=681704 R=agable@chromium.org Change-Id: Ia79c10b19d72b5a8797a1428ad8a79c8f4480901 Reviewed-on: https://chromium-review.googlesource.com/431036Reviewed-by: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
BUG=681704 Change-Id: I7c8fd09f3c19b9facf876ebeef853e5d77b72a9c Reviewed-on: https://chromium-review.googlesource.com/432316Reviewed-by: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
BUG=640299 R=rmistry@chromium.org,agable@chromium.org Change-Id: Iac987758065c57a4a08ce98f838fc0c30a8c1a02 Reviewed-on: https://chromium-review.googlesource.com/432676 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Jeff Carpenter authored
Also delete extraneous whitespace BUG=685326 Change-Id: If7f68346fd27edf9a5dca315cfcfbca0decc2da6 Reviewed-on: https://chromium-review.googlesource.com/433158Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 25 Jan, 2017 9 commits
-
-
Mike Stipicevic authored
Change-Id: Id841c4720996ca3568cec8a5721469c34f00cf77 Reviewed-on: https://chromium-review.googlesource.com/431803 Commit-Queue: Mike Stipicevic <stip@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/401a93b1055698158b3fb50a98aebb51e830ac44 [expect_tests] Add show_missing flag to coverage.report. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2655953002
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org BUG= Change-Id: I9b886100557bf6efa9be07d40175f7bb919f5294 Reviewed-on: https://chromium-review.googlesource.com/432456Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Change-Id: If14776d86a687a6edf5917f2a63ff984b812ecb8 Reviewed-on: https://chromium-review.googlesource.com/432376Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
TBR=phajdan.jr@chromium.org,sdefresne@chromium.org Change-Id: I95cc6e61d044fd983c613fa7eeb21c8b77d7cee0 Reviewed-on: https://chromium-review.googlesource.com/432356Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Refactor _GitNumbererState to two functions and remove no longer useful tests. BUG=644915 R=agable@chromium.org Change-Id: If5e3e3b141aee192211f6af130b01f20f9afdbfe Reviewed-on: https://chromium-review.googlesource.com/431976Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org BUG=681704 Change-Id: I48804955d8e5e579eae6e60fccac304aaaa9230e Reviewed-on: https://chromium-review.googlesource.com/430625Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Christopher Lam authored
BUG=684261 Change-Id: I2716864526fcedf44e561be8512843e12810e3a9 Reviewed-on: https://chromium-review.googlesource.com/431459Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/aae62c656032cf63284aecac5e974676064d8896 path module: fix tmp / cache dir creation (nodir@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2656753002
-
- 24 Jan, 2017 10 commits
-
-
Christopher Lam authored
This CL moves JS formatting behind the --js flag for git cl format due to issue with LayoutTests. It also adds an option to check javascript for the presubmit canned formatting check. BUG=567770 Change-Id: I9c080b1136f6ffef9fb1b08d3bfc97ce5b3185dc Reviewed-on: https://chromium-review.googlesource.com/430526Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Christopher Lam <calamity@chromium.org>
-
Robert Iannucci authored
BUG= Change-Id: I1dc7f20eea3f4b1be9179aa6d77bdee08ab8a04f Reviewed-on: https://chromium-review.googlesource.com/431576Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
This way we avoid extra RPC to codereview site. R=sergiyb@chromium.org BUG=681704 Change-Id: I81f9ac1b8fe4cfaa95458a5669735168185c47e5 Reviewed-on: https://chromium-review.googlesource.com/430639 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org BUG=681704 Change-Id: I5c320f7e6442a92ae0574e2ca6481a082e82568a Reviewed-on: https://chromium-review.googlesource.com/430795 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Andrii Shyshkalov authored
Previously, 1 CL was queried first, followed by all remaining ones in parallel. The purpose was to ensure that valid authentication token is present. However, it still required one call to Rietveld or Gerrit, needlessly increasing latency. This CL first loops over all CLs and ensures that credentials are present, refreshing refresh tokens for Rietveld if necessary. Then, all CLs are queried in parallel. R=sergiyb@chromium.org,clemensh@chromium.org BUG=681704 Change-Id: Ic125ac7c2a684d6f3c34e4e8b899192abbed01bb Reviewed-on: https://chromium-review.googlesource.com/431033Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Dirk Pranke authored
This reverts commit 66c50ea1. Reason for revert: Breaks some OWNERS checks. See https://crbug.com/684270 for details. Original change's description: > Fix OWNERS canned check to avoid duplicate output. > > 1. Update PanProjectChecks() to supply source_filter to CheckOwners(). > This prevents files under e.g. third_party/WebKit being checked both > by the top-level and sub-directory PRESUBMIT rules. > 2. Fix CheckOwners() to list missing-OWNERS only for the sub-directory > it is invoked on, rather than the whole CL. This prevents files under > sub-directories with their own PRESUBMIT rule, within the same repo, > from causing OWNERS to be checked for files outside that directory. > > BUG= > > Reviewed-on: https://chromium-review.googlesource.com/426003 TBR=wez@chromium.org,dcheng@chromium.org BUG=684270 Change-Id: I094818a6fa3e16fbac0d37d2596a40210611ee05 Reviewed-on: https://chromium-review.googlesource.com/431656Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Alan Cutter authored
Change-Id: I5dfa6017d1c938f8e1c55fbd6e607909aa4d6811 Reviewed-on: https://chromium-review.googlesource.com/422589Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/61760cd8bc43a539ddbf9bf69abe5049d3682f71 Remove ret code requirement (martiniss@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2655573002
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/d87e1df614c1b51a4bd09d9fd947fecc0c096f8b path module: make sure tmp / cache dirs exist (nodir@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2649893003
-
Aaron Gable authored
We have to clean up the title, but if the user hasn't expressed any input about the title (i.e. it's one we autogenerated), then don't bother them by pointing it out. BUG=684079 Change-Id: I8215e0a30f786466697fe1df178ca90e1980d9b0 Reviewed-on: https://chromium-review.googlesource.com/431162 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Bonventre <andybons@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 23 Jan, 2017 1 commit
-
-
Andrii Shyshkalov authored
BUG=681704 Change-Id: I1a774350aea901d4e9f2468cff111cbbcd7f3388 Reviewed-on: https://chromium-review.googlesource.com/430794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
- 21 Jan, 2017 3 commits
-
-
Andrii Shyshkalov authored
Git cl decides if git-numberer is enabled on a repository by writing Gerrit's project.config from refs/meta/config into a tempfile, which is then queried using `git config -f tempfile --get ...`. The file itself is only flushed, but not closed after writing because Python's tempfile.NamedTemporaryFile is deleted on closing. This worked fine on Linix/Mac, but not on Windows, where `git config` apparently doesn't see file or its contents. This CL rewrites the above using yet another contexmanager temp directory into which a file is written and closed before git config is ran. R=machenbach@chromium.org,grt@chromium.org BUG=683202 Change-Id: I7974d66b1b2b0478ab4b6f7ac04e547a4981c46c Reviewed-on: https://chromium-review.googlesource.com/430719 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/836fb28be142e5385a8715e4c61e23e8ee505ccd Whitelist CIPD_CACHE_DIR env var. (vadimsh@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2645173002
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/6c47cddd76e3159a41c353fd1c1b9bb53a8f065c Add multiprocessing.cpu_count access to platform module. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2647143002
-
- 20 Jan, 2017 2 commits
-
-
Aaron Gable authored
BUG= Change-Id: Ib8953a7fea4e3cd1c17ea277b5310a31821bfbe8 Reviewed-on: https://chromium-review.googlesource.com/431050Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/1bd274dae8c58ecc146fc9111aab9f95ec81e0bd Make --deps-path=- put the temp dir in the real temp folder. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2646073002
-
- 19 Jan, 2017 1 commit
-
-
Christopher Lam authored
This CL adds .js to the list of file extensions that get clang-formatted. BUG=567770 Change-Id: Ieed162a84ca68877e5107da1824b1f49c71d51ed Reviewed-on: https://chromium-review.googlesource.com/429551Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org>
-