Commits · 29d5cf85ac28d9ef59228e8805ab7b1078baa667 · Linshizhi / Chromium_Depot_tools

27 Feb, 2020 1 commit

Gregory Nisbet authored Feb 27, 2020

BUG=chromium:1056534
TEST=run git cl presubmit

Change-Id: I22a7951623b241b8b1cc49f107f024d95054506d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2077357
Auto-Submit: Gregory Nisbet <gregorynisbet@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

29d5cf85

26 Feb, 2020 3 commits

Roll recipe dependencies (trivial). · 005269a5

recipe-roller authored Feb 26, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a36bdfd1c28f088e1c39736babb987e71284d646 (yiwzhang@google.com)
    [warning] Support recipe warning registration

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a333b850ee5791df514a01171b7488b1644fe44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2076682Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

005269a5

Reland "cros: switch CrOS programs to python3" · b847c567

Mike Frysinger authored Feb 26, 2020

This is a reland of 35b70cac.
With the recent vpython3 PATH fixes, hopefully this should pass now.

Original change's description:
> cros: switch CrOS programs to python3
>
> We start warning if people have outdated systems.
>
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

Bug: 997354
Change-Id: Ic7e040af6a34d112cd0a1c1421cdd25bc557ee19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052625
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

b847c567

Roll out new goma client binary VERSION=192 · 2a9042f8

Ye Kuang authored Feb 26, 2020

Bug: b/149963110
Change-Id: Iced9b2db2f93c42c78a94430c5ba4f06f4e971a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072501Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Ye Kuang <yekuang@google.com>

2a9042f8

25 Feb, 2020 5 commits

git-cl: Invoke presubmit checks via subprocess execution instead of via module. · 227d5108

Edward Lemur authored Feb 25, 2020

PRESUBMIT.py scripts are executed in presubmit_support.py using exec().
Since PRESUBMIT.py scripts might not be yet compatible with python 3, we
have to execute presubmit_support.py using python 2.

git_cl.py imports presubmit_support.py, and executes presubmit checks using
presubmit_support as a module. This forces git_cl.py to be executed using
python 2 to maintain compatibility for PRESUBMIT.py scripts.

This change allows git_cl.py to be executed using python 3, while
presubmit_support.py is executed using python 2.

Similar changes for post-submit hooks and git-cl try masters will follow.

Bug: 1042324
Change-Id: Ic3bb1c2985459baf6aa04d0cc65017a1c2578153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068945Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

227d5108

Reland "gerrit-util: Fix GCE check from behind proxy." · 3b44ac67

Edward Lemur authored Feb 25, 2020

This is a reland of 9ee86e5a

Fix: s/Httplib2Error/HttpLib2Error

Original change's description:
> gerrit-util: Fix GCE check from behind proxy.
>
> Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
> to fail.
>
> The behavior of an unreachable server behind proxy is different from a direct
> connection, it won't throw a httplib2.ServerNotFoundError error,
> so catch httplib2.Httplib2Error instead.
>
> Bug: 1050380
> Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1050380
Change-Id: I9aec01088b0b1c408a1292106d0b21e6d8997040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2066666Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3b44ac67

my_activity: Add some tests and fix some bugs · ab9cc2c1

Edward Lemur authored Feb 25, 2020

Change-Id: Ib5625ae9d052eca9d6c6b64f12f64e6697aef7a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072874Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ab9cc2c1

[vpython] Update depot_tools vpython to match fleet. · 63832e90

Robert Iannucci authored Feb 25, 2020

This will make `vpython3` explicitly opt-in (so it will now behave the
same way that it does on bots).

R=qyearsley@chromium.org, smut@google.com, tandrii@chromium.org, vadimsh@chromium.org

Bug: 1051595
Change-Id: I80cbc640ec76756381d8b1cc2755363180534b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2072361
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

63832e90

git-cl: Add GetAuthor method and cache GetLocalDescription results · 9aa1a967

Edward Lemur authored Feb 25, 2020

Bug: 1051631
Change-Id: I5da32978bbed16bcc9854f15db91a901f5892cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067402Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9aa1a967

24 Feb, 2020 2 commits

git-cl: Fix get_cl_statuses for Python 3 and add tests. · 61bf4177

Edward Lemur authored Feb 24, 2020

In Python 3 the semantics of `raise StopIteration` inside a generator
function changed.

Bug: 1002209
Change-Id: I51222a5006c4024b3a6a06d344423ee36870825a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2071056Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

61bf4177

Roll bb tool to @36780e0 · f95054fa

Yiwei Zhang authored Feb 24, 2020

Old revision: 37d9960

infra/infra change log:
  https://chromium.googlesource.com/infra/infra/+log/37d9960..36780e0

luci_go change log:
  https://chromium.googlesource.com/infra/luci/luci-go/+log/7ffc196..f45bbc1

R=tandrii

Change-Id: Ic7e342c356d5e91d37aa89f70faae4adf3525e7f
Bug: 1054982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2070062
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>

f95054fa

22 Feb, 2020 1 commit

gclient_utils: Add temporary_file method. · 1773f37d

Edward Lemur authored Feb 22, 2020

Useful when passing information to a subcommand via a temporary file.

Bug: 1051631
Change-Id: I0b8deda921effd24a37109544e1e7ca22e00ba4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068942Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1773f37d

21 Feb, 2020 6 commits

git-cl: Fix invocation of git new-branch · 8410164a

Edward Lemur authored Feb 21, 2020

Bug: 1054787, 1051631
Change-Id: Ib36740a3f8158977897431c5b52e5ecbdaeb16b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068506
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

8410164a

presubmit: Add should_continue and more_cc to presubmit json output. · 1dc66e16

Edward Lemur authored Feb 21, 2020

Also, rename --all-files to --all_files to be consistent with other
options, and remove reviewers, since it's never set in presubmit_support.

Bug: 1042324
Change-Id: I34fa3162c56e39bcdd52ad1e19058357de934f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067351Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1dc66e16

git-cl: Fix Change object construction for git-cl split · 7c34a225

Edward Lesmes authored Feb 21, 2020

Changelist.GetChange signature was changed in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2038050

Bug: 1042324, 1054880
Change-Id: I6ba63e7f2f6c13bd8e8bef4e76cd66ee0525bba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067623Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7c34a225

git-cl: Fix split branch name · 4dc5b779

Edward Lesmes authored Feb 21, 2020

Bug: 998922, 1054888
Change-Id: I4ae14700cbd6eb483f318f6ed9f4d1f30b58153e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2068492Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4dc5b779

Fix build summary to classify *.mojom*.obj as .obj · 1eb16f67

Bruce Dawson authored Feb 21, 2020

The build summary script was overly aggressive about summarizing .mojom
files under the mojo category. This was intended to measure the cost of
generating source from mojo files but it accidentally pulled in the
.mojom object files.

Categorizing different types of object files might be worthwhile but
that should be done intentionally and consistently.

Change-Id: Iab6b7e94797ce7f1ed46805034b4f274c88617e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067647
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

1eb16f67

Roll out new goma client binary VERSION=191 · 7e4c38a4

Simon Que authored Feb 21, 2020

Bug: b/149440210
Change-Id: I818c556baa84b032172ea40263a1bc1cb7a592a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2064233Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

7e4c38a4

20 Feb, 2020 2 commits

gclient: setdep writes binary for windows newline support · 7aa68240

John Emau authored Feb 20, 2020

This fixes an issue on Windows where running `gclient setdep` would convert the DEPS file from LF to CRLF line endings.

From the python 2.7 docs:

" On Windows, 'b' appended to the mode opens the file in binary mode, so there are also modes like 'rb', 'wb', and 'r+b'. Python on Windows makes a distinction between text and binary files; the end-of-line characters in text files are automatically altered slightly when data is read or written. "

- https://docs.python.org/2.7/tutorial/inputoutput.html#reading-and-writing-files

Change-Id: I94183918789a8cdd4aa655db4b3dadfaae23d13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2067477Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: John Emau <John.Emau@microsoft.com>

7aa68240

git-cl: Mock DieWithError and GitSanityTests · d55c5077

Edward Lemur authored Feb 20, 2020

Bug: 1051631
Change-Id: I20f68db7dd0a901ff53513998e148cf4ba2c3eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2065133Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d55c5077

19 Feb, 2020 8 commits

repo: update to 2.4 launcher · 56c9bd5a

Mike Frysinger authored Feb 19, 2020

Bug: None
Test: `repo sync` still works
Change-Id: Ibef61ccda4640dfc6a28b9a919e50f7a8162bf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062618Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

56c9bd5a

git-cl: Mock GetChangeDetail on tests. · 7677e5cc

Edward Lesmes authored Feb 19, 2020

Mock GetChangeDetail instead of using self.calls to make the code
easier to change.

Bug: 1051631
Change-Id: I77361caccaf694644839825d890343864267688f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062716
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

7677e5cc

gclient_eval, gclient_utils: Fix Python 3.9 removal of collections members · 6693d092

Raul Tambre authored Feb 19, 2020

Various collections module members were removed in Python 3.9 after being deprecated and moved to collections.abc in earlier Python 3 versions.
For accessing these members alias collections_abc as:
* collections.abc on Python 3
* collections on Python 2

Traceback (most recent call last):
  File "C:\Google\depot_tools\gclient.py", line 107, in <module>
    import gclient_eval
  File "C:\Google\depot_tools\gclient_eval.py", line 11, in <module>
    import gclient_utils
  File "C:\Google\depot_tools\gclient_utils.py", line 1201, in <module>
    class FrozenDict(collections.Mapping):
AttributeError: module 'collections' has no attribute 'Mapping'

Traceback (most recent call last):
  File "C:\Google\depot_tools\gclient.py", line 107, in <module>
    import gclient_eval
  File "C:\Google\depot_tools\gclient_eval.py", line 25, in <module>
    class _NodeDict(collections.MutableMapping):
AttributeError: module 'collections' has no attribute 'MutableMapping'

Bug: 984182
Change-Id: I7a4417978b93e29397e63764e4570a598c075bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2043879
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6693d092

git-cl: Use scm.GIT.GetConfig in more places. · 26964072

Edward Lemur authored Feb 19, 2020

Bug: 1051631
Change-Id: I43460b72dfbc9c8210c2d8fdf5d29e876a5637f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2056648Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

26964072

Roll recipe dependencies (trivial). · 5e1d29fc

recipe-roller authored Feb 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/90eb05b0df05f7840e58ff3c9f3685af0c89a27d (guterman@google.com)
Add --stop flag to run/train which fails fast

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie51e696713fd0019828141d5a11b2914b08138a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2062620Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5e1d29fc

Roll recipe dependencies (trivial). · 68e5c907

recipe-roller authored Feb 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a7a70da79ed53f56f5150bb7d1eb577aca51c457 (yiwzhang@google.com)
    [bb] Fix the bug that search api only returns 1000 builds max when limit>1000

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ife6d21365e0f7707382c25caacf2a929ab2a193d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2064606Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

68e5c907

Roll bb tool to @ 37d99607 · 10e0e6d6

Andrii Shyshkalov authored Feb 19, 2020

Old revision: 1ab4441a

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/1ab4441a..37d99607
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/0f62d394..7ffc1965

Bug: 1052637
Change-Id: I49129e3f4e68961dbd6055a07f3d0a9cd7bc3111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2063381
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

10e0e6d6

Roll lucicfg tool to @ 3b479f0e v1.12.3. · 1fbe7c0b

Andrii Shyshkalov authored Feb 19, 2020

Old revision: 54dac392

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/54dac392..3b479f0e
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/addc6508..ae97ada2/lucicfg

Bug: 925080
Change-Id: I5fb37c83b7e8a4d3e8aacb7fe29e3ea89c9683e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2063216
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

1fbe7c0b

14 Feb, 2020 2 commits

git-cl: Use scm.GIT.{Get,Set}BranchConfig and {Get,Set}BranchRef instead of git calls. · 85153289

Edward Lemur authored Feb 14, 2020

scm.GIT functions are tested, and using them makes it easier to mock
git calls on git-cl tests.

Bug: 1051631
Change-Id: If067aa3f71b7478cafd7985d3020dacc0c6a41c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055464Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

85153289

[lucicfg] Update in depot_tools to 1.12.2 · c4243361

Marc-Antoine Ruel authored Feb 14, 2020

R=iannucci@chromium.org, tandrii@chromium.org

Bug: 1051164
Change-Id: I2c6cccc14cb8a86e27f5469c02d5a6af99160672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2056967
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

c4243361

13 Feb, 2020 9 commits

Roll bb tool to @ 1ab4441 · 86fbe04c

Yiwei Zhang authored Feb 13, 2020

Old revision: 9b687fbe

infra/infra change log:
  https://chromium.googlesource.com/infra/infra/+log/9b687fbe..1ab4441

luci_go change log:
  https://chromium.googlesource.com/infra/luci/luci-go/+log/fa8b9bf0..0f62d39

R=tandrii

Bug: 1039823
Change-Id: I85bafb139aa6b251418323bc839d978cf66038af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053730
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

86fbe04c

Roll recipe dependencies (trivial). · ca1907e5

recipe-roller authored Feb 13, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/33fed4343ba9723f8d4e16dd04978f27490f0a57 (gbeaty@chromium.org)
Report run steps in the order they were run.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77a0aba8f5fa355f96e51555b1aa9cf16dbf7927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055395Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ca1907e5

Revert "gerrit-util: Fix GCE check from behind proxy." · ca9a5ebc

Edward Lesmes authored Feb 13, 2020

This reverts commit 9ee86e5a.

Reason for revert: Typo.

Original change's description:
> gerrit-util: Fix GCE check from behind proxy.
> 
> Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
> to fail.
> 
> The behavior of an unreachable server behind proxy is different from a direct
> connection, it won't throw a httplib2.ServerNotFoundError error,
> so catch httplib2.Httplib2Error instead.
> 
> Bug: 1050380
> Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Idb17520e71fc1d892694e0d4d1cf1630a42bb482
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055390Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ca9a5ebc

gerrit-util: Fix GCE check from behind proxy. · 9ee86e5a

Edward Lemur authored Feb 13, 2020

Setting HTTP_PROXY or HTTPS_PROXY environment variables will cause git cl
to fail.

The behavior of an unreachable server behind proxy is different from a direct
connection, it won't throw a httplib2.ServerNotFoundError error,
so catch httplib2.Httplib2Error instead.

Bug: 1050380
Change-Id: I32e2220483de1fd6222c7fd6063039fb86277ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2050947Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9ee86e5a

Add tikuta, <user>@chromium.org to GOMA_OWNERS · e9ed65aa

Simon Que authored Feb 13, 2020

Bug: None
Change-Id: Ib8f349044e3ea1a6ac7dd0c5428f5c561e36ac5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053627Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

e9ed65aa

roll out new goma client binary (VERSION=190) · 0c4a5eb7

Simon Que authored Feb 13, 2020

https://chromium.googlesource.com/infra/goma/client/+/bf6b833ba9f59247d9b6542d9c9852c1bed22e04

BUG=b/148913740

Change-Id: I0d107d4c22daa86f0f3e0587530b7f651bca08ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2053623Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Simon Que <sque@chromium.org>

0c4a5eb7

git-cl: Use scm.GIT.FetchUpstreamTuple. · 15a9b8cc

Edward Lemur authored Feb 13, 2020

scm:
- Add methods to deal with git configs and tests for them.
  Will make it easier to mock git config calls as opposed
  to all git calls.
- Add tests to FetchUpstreamTuple

git-cl:
- Mock out settings.GetChangeRoot()
- Use scm.GIT.FetchUpstreamTuple() to reduce code duplication,
  and mock it out on tests.

Bug: 1051631
Change-Id: I1a3220b4c0f3e6221b3c00550259a433c2775798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052552
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

15a9b8cc

git-cl: Use mock.patch instead of custom mock. · da4b6c6e

Edward Lemur authored Feb 13, 2020

Bug: 1051631
Change-Id: I0c8222f89477300e6a14296b72ecaa01d65ca32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052627Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

da4b6c6e

repo: update to 2.3 launcher · da8eec5d

Mike Frysinger authored Feb 13, 2020

This pulls the latest version from upstream.  Largely should be
bugfixes, but there's a few new hot features too!

Bug: https://crbug.com/gerrit/10418
Test: `repo sync` still works
Change-Id: Icd901b490857083f047ce900990769efdf5f269b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052975Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

da8eec5d

12 Feb, 2020 1 commit

Revert "cros: switch CrOS programs to python3" · 3d37f4f7

John Budorick authored Feb 12, 2020

This reverts commit 35b70cac.

Reason for revert: causing problems for the chromium cq, e.g.
https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/471366
https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/197740

Original change's description:
> cros: switch CrOS programs to python3
> 
> We start warning if people have outdated systems.
> 
> Bug: 997354
> Test: `cros --help` uses python3 now
> Change-Id: I1491f1c0eea4d544cc508b461153c54c8072699d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052243
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

TBR=vapier@chromium.org,iannucci@chromium.org,saklein@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ie85691d9f847ad7edb4c9932a0788431c886fec2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2052543Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

3d37f4f7