Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 24 Mar, 2017 5 commits
  3. 23 Mar, 2017 9 commits
    • Robert Iannucci's avatar
      [recipes.cfg] convert to JSON · e9b94890
      Robert Iannucci authored 
      Bug: 699379
Change-Id: I917b34b36e7e7d3b0ef4773a57c7905ec4eccb18
Reviewed-on: https://chromium-review.googlesource.com/458595Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      e9b94890
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 2add8a99
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3125a3b89e18dff89cf6d59f0a0486d832521bf1 [recipes.cfg] Switch to json for real, add canonical_repo_url. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Icfb817ba78e282fdea90c45c0a3be881136f5dc0
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/458064
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
      2add8a99
    • Andrii Shyshkalov's avatar
      bot_update: don't retry rebasing Gerrit patches. · 8ec60852
      Andrii Shyshkalov authored 
      It's pointless, and sleeping between retries adds unnecessary delays
which wastes capacity and developers time.

BUG=690940
R=hinoka@chromium.org

Change-Id: I80cf52f04ed74e2407c373326a8c6f52a3a7d958
Reviewed-on: https://chromium-review.googlesource.com/458439Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
      8ec60852
    • Aaron Gable's avatar
      Use Bug: footer for Gerrit CLs · 3a16ed15
      Aaron Gable authored 
      Note that because it is now a gerrit footer, it both appears in the same block
as the Change-Id footer (no blank line between them), and isn't guaranteed to be
above the Change-Id footer. This doesn't matter during "git cl upload", when
a Change-Id hasn't been allocated yet, but will show up during "git cl
description".

Bug: 681184
Change-Id: I2ab6fc13be8e992709618a666012410b1a7c02de
Reviewed-on: https://chromium-review.googlesource.com/446660
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      3a16ed15
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 05c96f1f
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/033f8117b5cb6de01ad56606aca0437b2ba7cd7c Update documentation about recipe tests (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Iae8679bfec3435e6b05433279f6ae8b544d545e6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/458122
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
      05c96f1f
    • Raphael Kubo da Costa's avatar
      gerrit_util: Use httplib2 for communication instead of httplib. · 89d04858
      Raphael Kubo da Costa authored 
      Retain the httplib import to continue using its constants, but actually make
the http(s) connections using httplib2. The latter has built-in support for
proxy settings, which then actually allows people behind proxies to interact
with Gerrit.

Compared to httplib, the biggest changes are:
- There's only one Http class instead of HTTPConnection and HTTPSConnection.
- Http.request() returns a tuple (response, contents).
- Http.request() expects a full URI instead of just a path, as Http's
  constructor does not take a host parameter.
- The response object inherits from dict.
- All headers in a response are lower-cased.

All in all, it is possible to see that httplib2 support was retro-fitted
into the code, but that should not worsen its readability.

Changes since https://chromium-review.googlesource.com/c/458221/:
- Catch httplib2.ServerNotFoundError exceptions in GceAuthenticator, as httplib2
  catches socket.gaierror (which was previously being used to detect when
  metadata.google.internal was not accessible) and throws a ServerNotFoundError
  exception instead.

Patch written in collaboration with Alexis Menard <alexis.menard@intel.com>.

BUG=672729
R=alexis.menard@intel.com,agable@chromium.org,tandrii@chromium.org

Change-Id: Iaefa9caf3d8c0bc6ff67f562cd0b6bd9fade2f24
Reviewed-on: https://chromium-review.googlesource.com/458480Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
      89d04858
    • Aaron Gable's avatar
      Revert "gerrit_util: Use httplib2 for communication instead of httplib." · 25ab6a34
      Aaron Gable authored 
      This reverts commit d7568645.

Reason for revert:
third_party.httplib2.ServerNotFoundError: Unable to find the server at metadata.google.internal

Original change's description:
> gerrit_util: Use httplib2 for communication instead of httplib.
> 
> Retain the httplib import to continue using its constants, but actually make
> the http(s) connections using httplib2. The latter has built-in support for
> proxy settings, which then actually allows people behind proxies to interact
> with Gerrit.
> 
> Compared to httplib, the biggest changes are:
> - There's only one Http class instead of HTTPConnection and HTTPSConnection.
> - Http.request() returns a tuple (response, contents).
> - Http.request() expects a full URI instead of just a path, as Http's
>   constructor does not take a host parameter.
> - The response object inherits from dict.
> - All headers in a response are lower-cased.
> 
> All in all, it is possible to see that httplib2 support was retro-fitted
> into the code, but that should not worsen its readability overall.
> 
> Patch written in collaboration with Alexis Menard <alexis.menard@intel.com>.
> 
> BUG=672729
> R=​alexis.menard@intel.com,agable@chromium.org,tandrii@chromium.org
> 
> Change-Id: Ic40e804064e74e89bc2ad979572628f1bd78c19a
> Reviewed-on: https://chromium-review.googlesource.com/458221
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
> 

TBR=agable@chromium.org,alexis.menard@intel.com,raphael.kubo.da.costa@intel.com,tandrii@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672729

Change-Id: Idfacd314b381232733bb92a02ec2fb85f016effd
Reviewed-on: https://chromium-review.googlesource.com/457792Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      25ab6a34
    • Raphael Kubo da Costa's avatar
      gerrit_util: Use httplib2 for communication instead of httplib. · d7568645
      Raphael Kubo da Costa authored 
      Retain the httplib import to continue using its constants, but actually make
the http(s) connections using httplib2. The latter has built-in support for
proxy settings, which then actually allows people behind proxies to interact
with Gerrit.

Compared to httplib, the biggest changes are:
- There's only one Http class instead of HTTPConnection and HTTPSConnection.
- Http.request() returns a tuple (response, contents).
- Http.request() expects a full URI instead of just a path, as Http's
  constructor does not take a host parameter.
- The response object inherits from dict.
- All headers in a response are lower-cased.

All in all, it is possible to see that httplib2 support was retro-fitted
into the code, but that should not worsen its readability overall.

Patch written in collaboration with Alexis Menard <alexis.menard@intel.com>.

BUG=672729
R=alexis.menard@intel.com,agable@chromium.org,tandrii@chromium.org

Change-Id: Ic40e804064e74e89bc2ad979572628f1bd78c19a
Reviewed-on: https://chromium-review.googlesource.com/458221Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
      d7568645
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 8d631661
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3e8a9964590120020a29e2749a99c043197d088b repo_test_util: use new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Iab86dac75442c37b37e1af84c9f60b1d34da3c1e
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/458160
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>
      8d631661
  5. 22 Mar, 2017 4 commits
  7. 21 Mar, 2017 4 commits
  9. 20 Mar, 2017 5 commits
  11. 19 Mar, 2017 1 commit
  13. 17 Mar, 2017 6 commits
  15. 16 Mar, 2017 6 commits