Commits · 25eb8e4680acaa931f1987557513bd5f35537333 · Linshizhi / Chromium_Depot_tools

14 May, 2019 4 commits

Raul Tambre authored May 14, 2019

Fixes colorama unintentionally overriding multiple sys.stdout wrappers of our own.
And provides a fix for a SyntaxWarning on Python 3.8:
C:\Google\depot_tools\third_party\colorama\ansitowin32.py:43: SyntaxWarning: invalid escape sequence \[
ANSI_RE = re.compile('\033\[((?:\d|;)*)([a-zA-Z])')

Tests are updated to account for the annotation wrapper no longer being overriden.
A fix by agable for the annotation wrapper working with carriage returns is also included (https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592612).

Bug: 958138, 958321
Change-Id: I2fe1def85c66cfe5229a1c25c2f677e498593eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1591513Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>

25eb8e46

Roll recipe dependencies (trivial). · 8a964932

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0aae08882d042675016c1f44da43457958fe8054 Treat any cmd0 containing path sep as relative. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id7fe88eec793e24dbf8ae296bc1a73732291b117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611213Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

8a964932

Make presubmit scripts not inherit the executor script's context · 09e64b49

Raul Tambre authored May 14, 2019

This caused compatibility issues, because the executor script (presubmit_support.py) asks the parser for Python 3-style print functions and inherits this to the presubmit scripts it runs, of which some still use the old style statements.

Bug: 961783
Change-Id: I545d778991a53f484bce6c7e29089e0484dc19ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605917
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

09e64b49

scm: Replace invalid UTF-8 in Git output · 6a9b00e4

Raul Tambre authored May 14, 2019

This may occur when git diff is ran with binary changes in the diff.
Example: https://chromium-review.googlesource.com/c/chromium/src/+/1606595

Bug: 942522
Change-Id: I44caef559de44076ef394caa5abc3967db2bb0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1607840
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

6a9b00e4

13 May, 2019 7 commits

Roll recipe dependencies (trivial). · 06f5b226

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/13fa883dbdc89e258d7ef300035e4bba67bffc9f Replace paths in simulations sorted by -len. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4b6307c79dc50c9ad52bbb72f444bae5cb0fe62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610871Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

06f5b226

Roll recipe dependencies (nontrivial). · 70276606

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/125d102e429465dc3468b4b235f9e3a5df4b252c Reland: Refactor recipe engine step execution. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7736e6b20f8a7ec9d5cf9eeb21456a1d0b37f189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609964
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

70276606

Roll recipe dependencies (nontrivial). · 66eeedc2

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9b3ed1d5e912b8e9195060c3401da9b5370f2fce Revert "Refactor recipe engine step execution." (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I628d01d7a259024f677ca8fb5de7317ae9aa591f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609960
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

66eeedc2

Roll recipe dependencies (nontrivial). · 417f2332

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/440a45cae6b329192f60313e41714bd78e886c8d Refactor recipe engine step execution. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e85bbfdf2eb61a433a505f81db6b805b9231402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610858
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

417f2332

Roll recipe dependencies (trivial). · 7a3d1fb7

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f34152acbe36ba6b4dc513885271cfca8838a634 Fix invalid Python file encoding "utf8" (raul@tambre.ee)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb7c5a135e66bb134da01d4924b94364e8fafaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609860Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7a3d1fb7

Fix invalid Python file encoding "utf8" · a04028c2

Raul Tambre authored May 13, 2019

Since Python 3 it must be "utf-8", which is the official name.
This is backwards compatible with Python 2.

Bug: 962277
Change-Id: I21115a322944532f1870862c8c048f8455c1109f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1608562
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

a04028c2

Roll recipe dependencies (trivial). · 42db0b42

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/20932a9267873300fb27651bd9572bfbb284930c [buildbucket] Do not crash on empty input (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb0015245bd156829ec58198ef92ef8ae2cf3397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609041Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

42db0b42

10 May, 2019 4 commits

gclient_scm: Decode Git output centrally for better Python 3 support · cd862e37

Raul Tambre authored May 10, 2019

This avoids the need to do the decoding everywhere separately.
Also a small fix for filter() no longer returning a list on Py3.

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 942522
Change-Id: Id0f5153011b2ef1b64394359087864cd9434e45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595685
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

cd862e37

do not hardcode the path to bash by using the #!/usr/bin/env bash shebang · 059f26bc

Robert Nagy authored May 10, 2019

on non-linux systems bash is not the default shell (by default) and
lives in a completely different path

Change-Id: I6580c776dda1b60b3d5c5f5f1ce4d6694ac45fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605902Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

059f26bc

[bootstrap/win] Upgrade Python to 2.7.13. · 980d615e

Takuto Ikuta authored May 10, 2019

This is followup of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/571171/

Bug: 741001
TEST: > gclient version # to update python
TEST: > .\python.bat # start python 2.7.13 correctly
Change-Id: I07e596d3006104ccb1c5fe0fde097a3c29f8a5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605541
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

980d615e

[lucicfg] Bump lucicfg version v1.7.2 -> v1.7.4. · 006b2955

Andrii Shyshkalov authored May 10, 2019

Knows about CQ allow_owner_if_submittable.
No API changes.

R=vadimsh

Bug: 959098
Change-Id: Icfb3e201df4916b2e8d8923d87c474af1ae85b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604465Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>

006b2955

09 May, 2019 6 commits

Roll recipe dependencies (trivial). · 4145bd87

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/842aee7058c3e87013ef8d59aef4c39fcceef507 Fix masked ImportErrors for config.py and test_api.py. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e5584b6024a4e765d3f044ff9c2ae4613ed08ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604124Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4145bd87

Roll recipe dependencies (trivial). · 66ab0d69

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/90c7e6503a4950cb84a57b909bac36dd9eec595f Display scheduler input request as a log to avoid flooding the build page (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I804f3c4d1063078463d204837caa1b74f53936f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603902Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

66ab0d69

Reland "git-cl: Keep git push traces" · 1b52d87a

Edward Lemur authored May 09, 2019

This is a reland of dc8e23d3

Original change's description:
> git-cl: Keep git push traces
> 
> Keep the last N git push traces.
> Name them after the time when they were collected, and add a
> README file to each one to provide some context to developers.
> 
> Bug: 955206
> Change-Id: Ib5fcf2f78fb65f6ddd80a93619c14e1ef70c5564
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595108
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

Bug: 955206
Change-Id: Ie63a3ebfe3024d48ad7e0c8492a2939e635371aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1600246Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1b52d87a

Roll recipe dependencies (trivial). · 2e483122

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5a39fa23e6c9a2dcb570f8442da6fb0cd3874a92 Remove deprecated test recipe. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I305a6d1f62be7d6d8f879c1bd06767dde3125edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603402Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2e483122

Roll recipe dependencies (trivial). · 8a2a5a8d

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f9955f78cb9fa09207e05d3d0bd93164708baacc Fix accidental regression caused by PathClient fix. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I072a89d4f0651fe521fab1627d1b7b6c1904b814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603025Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8a2a5a8d

Roll recipe dependencies (trivial). · 370d193c

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3f1ace721c34a30de9e89f8721d4d42995a2c0f0 Update documentation in recipe_test_api. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e80f4b6e1c39897605d784984510400cdce54f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1602035Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

370d193c

08 May, 2019 9 commits

Roll recipe dependencies (trivial). · 59031c4e

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a552175dc3f1dd19da04013be850c511f111f58f Update implementation_details.md with upcoming refactor. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I05aee62d190437d31a4951cae25e15cc9a6e6566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601722Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

59031c4e

Roll recipe dependencies (trivial). · 43d3bb88

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6c5f5ab7c20a45535d0c7e4ebb7527ff1d05ee53 Backport little recipe changes from the big refactor. (iannucci@chromium.org)
  https://crrev.com/89de9b614d19f40ca3659686ca4a9718cc0cbc83 Enable subsequences and/or regexes checking in a Steps's command. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I537d08fc4cc43376fc68111d807c20ac98fa84a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601719Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

43d3bb88

Roll recipe dependencies (trivial). · bbb84e61

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aec728797e5061bcb52537478c1202df8ea80abb Fix buildbucket module properties in recipe runbuild API. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I127b98d7cba473d0e419fb3e50b2475c2d2f79f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601713Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bbb84e61

gclient: Fix applying patches to branch heads. · 8c665656

Edward Lemur authored May 08, 2019

Bug: 956807
Change-Id: I2eed6db1f338806812fca778986d51b0a007eddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592577
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

8c665656

Roll recipe dependencies (trivial). · 1c739917

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c56bf21def1e889dfc29fd4fc137a203a6164ec3 Explicitly pass start_dir path through RecipeEngine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I418be87802ed8a880f189540d792af20ab1b2630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601409Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c739917

Roll recipe dependencies (trivial). · e0337cf6

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/cf87dfeacf9d4704fe7a12c7a4a58a5f88b988f9 Move FakeEnviron and merge_envs to their own file. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2bc0425b2119424e679be228c47833a5a8ab319c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601407Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e0337cf6

Roll recipe dependencies (trivial). · ba3c8787

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3ba5a56b800ec3b6914ea433fbc8e376a653f405 Small improvement to PropertiesClient. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iae8f74dbc7ba5ff82a6031e4cdf0e44b582a620a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601533Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ba3c8787

Roll recipe dependencies (trivial). · 86ec1db0

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d114ff1c76cda45632eee3f5a414c8331afc2e74 Remove deprecated test suite. (iannucci@chromium.org)
  https://crrev.com/070d2629767dd69e3bc57058697d358936ffd600 Add attr_list_type to attr_util. (iannucci@chromium.org)
  https://crrev.com/00d1622e64d6c32d331c839953d309e2a21eb07f Add CrashEngine exception. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia30216d7374de0a08128ddb570392ea866cfe7c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601129Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

86ec1db0

Revert "git-cl: Keep git push traces" · e7f0b4c6

Michael Moss authored May 08, 2019

This reverts commit dc8e23d3.

Reason for revert: Breaking chrome releases crbug.com/960638

Original change's description:
> git-cl: Keep git push traces
> 
> Keep the last N git push traces.
> Name them after the time when they were collected, and add a
> README file to each one to provide some context to developers.
> 
> Bug: 955206
> Change-Id: Ib5fcf2f78fb65f6ddd80a93619c14e1ef70c5564
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595108
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=dpranke@chromium.org,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 955206
Change-Id: Id56dfb1b32a54070d761ef75bc26bbb9081f86fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1600535Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

e7f0b4c6

07 May, 2019 7 commits

Roll recipe dependencies (trivial). · e5e44404

recipe-roller authored May 07, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/db2cbdb914cf9ba6fd0a0c2fa7adf2e9f5494a19 [buildbucket] Fix field mask in search (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I68eeb1aa2063df0bc3bd29449603cf88197bfcf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1600452Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e5e44404

Roll bb · 4403107f

Nodir Turakulov authored May 07, 2019

Pick up a rename in proto.

R=tandrii@chromium.org

Change-Id: I95ea5f0496e36b9c19c8f5c440b4bf2bd7c26333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1598206
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

4403107f

Fix auto_stub.py for skipped tests. · bdce6c83

Marc-Antoine Ruel authored May 07, 2019

This is blocking a luci roll in infra.

R=nodir@chromium.org

Change-Id: I996a74ba519cf05f72d430ca4a2e63e76436b509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1598469Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

bdce6c83

Roll recipe dependencies (trivial). · 396ab3c6

recipe-roller authored May 07, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/027f3197fcb0c799794870ea3ee830b48e684f22 [buildbucket] Load all build fields (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibfb4e07468f83a24e2d79c1b899bfbaa577b737a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1599139Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

396ab3c6

autoninja: Don't echo command-line unless NINJA_SUMMARIZE_BUILD=1 · 94bcf1e4

Andrew Grieve authored May 07, 2019

I want to use autoninja from //build/android/generate_gradle.py, but I
invoke it with a *long* list of targets that I do not want echo'ed

Bug: 803493
Change-Id: I98ad85b64ec7ce60b7e3df9827fb613cd57638e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1596535Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>

94bcf1e4

git-cl: Keep git push traces · dc8e23d3

Edward Lemur authored May 07, 2019

Keep the last N git push traces.
Name them after the time when they were collected, and add a
README file to each one to provide some context to developers.

Bug: 955206
Change-Id: Ib5fcf2f78fb65f6ddd80a93619c14e1ef70c5564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595108
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

dc8e23d3

Roll recipe dependencies (trivial). · 76557d63

recipe-roller authored May 07, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/563a82246180d949917bcd444411bbeb82604e97 [buildbucket] Add an assertion in search.py (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idac029d6eb402e9ce26d6fe1e9d77f809135086e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1597992Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

76557d63

06 May, 2019 3 commits

Roll recipe dependencies (trivial). · a495093d

recipe-roller authored May 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b4dac2345a45f448221fba393266fbcf541619db [buildbucket] Add search limit (nodir@google.com)
  https://crrev.com/a9d4612406b19eb642d31bff5b5a0705a783b5b0 Move StepData to its own file. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I183b37653a17f8d2e396b8f1e58f536e404718e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1596540Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a495093d

Roll recipe dependencies (nontrivial). · 8c810f0c

recipe-roller authored May 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a71df95b9d2348c680f05746607e12822d34517e Final simplification to RecipeResult. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ac4981a2c16031efcef7920647ead968069a0fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1596994
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

8c810f0c

Convert print statements to Python 3 style · 80ee78e7

Raul Tambre authored May 06, 2019

Ran "2to3 -w -n -f print ./" and manually added imports.
Ran "^\s*print " and "\s+print " to find batch/shell scripts, comments and the like with embedded code, and updated them manually.
Also manually added imports to files, which used print as a function, but were missing the import.

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 942522
Change-Id: Id777e4d4df4adcdfdab1b18bde89f235ef491b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595684Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

80ee78e7