Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 16 Nov, 2017 7 commits
  3. 15 Nov, 2017 2 commits
  5. 14 Nov, 2017 2 commits
  7. 13 Nov, 2017 1 commit
  9. 10 Nov, 2017 3 commits
    • Jonathan Nieder's avatar
      Do not delete users' draft comments · 1ea21322
      Jonathan Nieder authored 
      Gerrit's "Set Review" API has a built-in trap:

 drafts (optional)
	How draft comments are handled that are already in the
	database but that were not also described in this input.

	Allowed values are DELETE, PUBLISH, PUBLISH_ALL_REVISIONS and
	KEEP. All values except PUBLISH_ALL_REVISIONS operate only on
	drafts for a single revision.

	If not set, the default is DELETE.

That destructive default is almost never what a person wants.  Use
KEEP instead.

Noticed because "git cl try" was losing people's comments.

Bug: gerrit:6812
Change-Id: I1d09231ea23b13c925d301241bef266df2ddf1cf
Reviewed-on: https://chromium-review.googlesource.com/764488Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jonathan Nieder <jrn@google.com>
      1ea21322
    • Raphael Kubo da Costa's avatar
      presubmit: Add InputApi.CreateTemporaryFile() · f2d1615b
      Raphael Kubo da Costa authored 
      Sometimes, InputApi users need to create temporary files, write to them and
pass them to another process, like this:

  with input_api.tempfile.NamedTemporaryFile() as f:
    f.write('foo')
    input_api.subprocess.check_output(['/path/to/script',
        '--reading-from', f.name])

While this works fine on Unix, on Windows subprocess cannot open and read
the file while we have it open for writing.

To work around this, we now offer a CreateTemporaryFile() that wraps a call
to tempfile.NamedTemporaryFile(delete=False), and we then take care of
removing all files created this way at the end of a presubmit run.

The idea is for users to do something like this:

  with input_api.CreateTemporaryFile() as f:
    f.write('foo')
    f.close()
    input_api.subprocess.check_output(['/path/to/script',
        '--reading-from', f.name])

with the temporary file being removed automatically in a transparent fashion
later.

Bug: 780629
Change-Id: I0d705a5d52928a43f39a51f94a2c48d277bd5ced
Reviewed-on: https://chromium-review.googlesource.com/758637
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      f2d1615b
    • Nodir Turakulov's avatar
      [gclient hooks] add .bat to vpython on windows · 0ffcc877
      Nodir Turakulov authored 
      Bug: 781430
Change-Id: Idcba016f78078aa9678b8a246e964b3dcb09a016
Reviewed-on: https://chromium-review.googlesource.com/762389Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
      0ffcc877
  11. 09 Nov, 2017 5 commits
  13. 08 Nov, 2017 4 commits
  15. 07 Nov, 2017 4 commits
  17. 06 Nov, 2017 6 commits
  19. 04 Nov, 2017 1 commit
  21. 03 Nov, 2017 5 commits