- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 20 Nov, 2014 2 commits
-
-
vapier@chromium.org authored
The reason cited for reverting was invalid, so reland the update. BUG=chromium:431514 Review URL: https://codereview.chromium.org/739393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293049 0039d316-1c4b-4281-b951-d872f2087c98
-
smut@google.com authored
This reverts commit e642ee86. Conflicts: pylintrc Reason: All repos are borked. TBR=vapier Review URL: https://codereview.chromium.org/741023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293042 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2014 1 commit
-
-
vapier@chromium.org authored
People are just ignoring these and bypassing the presubmit entirely, so disable all the warnings until someone feels like shaving these yaks one by one. BUG=chromium:431514 TEST=ran presubmit on build/ and so no more warnings Review URL: https://codereview.chromium.org/721833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292997 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Nov, 2014 1 commit
-
-
vapier@chromium.org authored
The current pylint is very old at this point. Pull in the latest version as it supports a lot more features. Also need to fix the pylint wrapper to actually update sys.path to use the local modules. We include the six module since not all bots have it, and it's small. This will trigger new warnings in files, but they look like legitimate issues that should be fixed at some point. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/741503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292988 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Nov, 2014 2 commits
-
-
kbr@chromium.org authored
This reverts commit 451939d5. Throws an exception with a missing import, breaking Telemetry's presubmit checks and presumably presubmit checks for all Python files in Chromium. See comment on https://codereview.chromium.org/707353002/ . BUG=chromium:431514 Review URL: https://codereview.chromium.org/719313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292955 0039d316-1c4b-4281-b951-d872f2087c98
-
vapier@chromium.org authored
The current pylint is very old at this point. Pull in the latest version as it supports a lot more features. Also need to fix the pylint wrapper to actually update sys.path to use the local modules. This will trigger new warnings in files, but they look like legitimate issues that should be fixed at some point. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/707353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292954 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Dec, 2012 1 commit
-
-
iannucci@chromium.org authored
Because it's generated :) R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11439022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171518 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2012 3 commits
-
-
maruel@chromium.org authored
It's member are generated and confuse pylint. TBR=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10169032 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@133719 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Update pylintrc to be near the pylint 0.25.1 default file. R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10199016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@133707 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Pylint fails to parse generated members in a __init__() function. R=cmp@chromium.org BUG= TEST=Manually tested on linux, cygwin and windows Review URL: http://codereview.chromium.org/10202010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@133705 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2011 2 commits
-
-
maruel@chromium.org authored
Instead of crashing, prints an error message. BUG= TEST= Review URL: http://codereview.chromium.org/8363030 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106867 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
isatty() wasn't defined on Windows, causing it to crash. R=dpranke@chromium.org BUG= TEST=manually gclient sync on windows Review URL: http://codereview.chromium.org/8371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106865 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Oct, 2011 2 commits
-
-
maruel@chromium.org authored
Crashes. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106709 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
For now only affect gclient help to figure out if there is any issue with it. Because of the way it's done, there is no way to disable coloring, which could be annoying when redirected. This needs to be taken in consideration. R=dpranke@chromium.org TEST=manually tested on linux, cygwin and windows, both run manually and redirected to a text file. BUG= Review URL: http://codereview.chromium.org/8365001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106708 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Jul, 2011 1 commit
-
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7487001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93451 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
It will be used for: - git cl patch so binary files can be patched - try jobs instead of doing a curl <url> | patch BUG= TEST= Review URL: http://codereview.chromium.org/6792028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80355 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Feb, 2011 1 commit
-
-
maruel@chromium.org authored
Disable warning W0404 in pylint. BUG=none TEST=should now work on googlers workstations Review URL: http://codereview.chromium.org/6456010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@74242 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
TBR=dpranke BUG= TEST= Review URL: http://codereview.chromium.org/6051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69848 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Change RunPylint to parse all .py files when one is modified. Make all depot_tools/tests pass on pylint. That mostly meant fixing some builtins aliasing, wrong alignment and turning off most remaining warnings. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/5695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Nov, 2010 1 commit
-
-
maruel@chromium.org authored
When an HTTP exception information is logged, no information is sent by default. Add an helper function to manually extract interesting information to append it to the exception type. Also disable another pylint warning. TEST=manual test BUG=none Review URL: http://codereview.chromium.org/5303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 2 commits
-
-
maruel@chromium.org authored
This causes some code clutter. TEST=Increased pylint warning level BUG=none Review URL: http://codereview.chromium.org/4321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Most of them are style issues or variable aliasing. TEST=Can almost enable pylint warnings BUG=none Review URL: http://codereview.chromium.org/4360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Oct, 2010 1 commit
-
-
maruel@chromium.org authored
Doing static analysis on the script greatly easy refactoring since it reduces the chances of leaving a typo in rarely executed & untested & untested code. This is in preparation to refactor changelist on-disk format to use json. TEST=none BUG=none Review URL: http://codereview.chromium.org/4184008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64427 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
pylint is useful to catch errors before they go live so fix little annoyances. BUG=none TEST=none Review URL: http://codereview.chromium.org/3372001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58817 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
Fix a bug in scm.SVN.DiffItem() Reduce variable aliasing, fix alignments, etc. Review URL: http://codereview.chromium.org/2673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48943 0039d316-1c4b-4281-b951-d872f2087c98
-