Commits · 22775d8e1755edb0d832703f29ac9fee9293a5e5 · Linshizhi / Chromium_Depot_tools

05 Nov, 2020 3 commits

Retry CIPD client download on Windows · 22775d8e

Matt Kotsenas authored Nov 05, 2020

Transient network conditions can cause the CIPD client download to fail,
so add a retry to the download.

As part of adding the retry, also extracted the download code to its own
function to ensure the WebClient is disposed promptly.

Bug: 1145741
Change-Id: I66bb5cde7ec4f637dd1161252c2b096af6abb8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2519730Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

22775d8e

move the cipd pin of infra/tools/rdb · b503f5ff

Chan Li authored Nov 05, 2020

This release is mainly to release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2489217

Bug: 1137513
Change-Id: I200facf28d34b38a305206134a519cd88b14fe2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2518477Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

b503f5ff

pylint-2.6: use newer pyquotes · 8ca189d4

Mike Frysinger authored Nov 05, 2020

Bug: 1123433
Change-Id: I60dc7bbcf6216fc90b58d32d99072f998501509d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2518471Reviewed-by: Owen Rodley <orodley@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

8ca189d4

04 Nov, 2020 1 commit

Add unit tests for guessing main as upstream · deff57f9

Josip Sokcevic authored Nov 04, 2020

R=ehmaldonado@chromium.org

Bug: 1143724
Change-Id: I69ce296a27b36c1073999f2b3c51421ac94e7ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2519254
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

deff57f9

03 Nov, 2020 1 commit

Add `main` when guessing origin remote · 5bdfcd8f

Josip Sokcevic authored Nov 03, 2020

This fixes presubmit checks that rely on FetchUpstreamTuple which is
used in patching.

R=ehmaldonado@chromium.org

Bug: 1143724
Change-Id: I163fa0ea6f1b356280d497196869bb206463ad4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2515268
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

5bdfcd8f

02 Nov, 2020 1 commit

Support autoninja -o/--offline to disable goma · 655afebf

Bruce Dawson authored Nov 02, 2020

It is sometimes helpful to do a full build of Chrome using goma while
online and then do incremental builds without goma while offline or with
poor network bandwidth. Turning off goma in gn args triggers a full
rebuild but the GOMA_DISABLED environment variable can be used to
disable goma without triggering a rebuild.

In order to make this feature easier to discover and use this change
adds support for -o/--offline to autoninja. autoninja -h will mention
this flag and autoninja.bat/autoninja.py handle it appropriately. This
means setting the environment variable in autoninja.bat, and using it
to adjust the -j value and stripping it out in autoninja.py.

The bash script that wraps autoninja.py on Linux and OSX did not need
updating because the Python script can emit 'GOMA_DISABLED=1 ninja ...'
and this is executed by bash.

This was produced during pair programming with jessemckenna@

Bug: b/172039612
Change-Id: Ifcfbc598ac20f23e5fe013e02979b5b8c2851b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2510818
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

655afebf

30 Oct, 2020 3 commits

Roll recipe dependencies (trivial). · 9396c2b0

recipe-roller authored Oct 30, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2a047c3e77c1dc47e236e284554fd39c01226d51
  2a047c3 (yiwzhang@google.com)
      [terminate] Handle GreenletExit exception

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01b724cca20bc36df412701498ef7b64afbefbbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2510904Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9396c2b0

Ping mac_toolchain to 6e584bf785867bc3b340f82bb2f7a6cd42ba22a8 · c7be37e1

Sylvain Defresne authored Oct 30, 2020

To release change: https://crrev.com/c/2507431

Bug: 1143664
Change-Id: Idd8cefcd525d87bca98fb3c990558e3f95ca3930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2510049Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

c7be37e1

Roll recipe dependencies (trivial). · 75ae6296

recipe-roller authored Oct 30, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ed160e8309749854f21123705a3bd5af592e5d49
  ed160e8 (tikuta@chromium.org)
      [swarming] update swarming binary

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib0b43125f0f28546eedb98996e2b8b7b2e5a3626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2509209Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

75ae6296

28 Oct, 2020 1 commit

Roll recipe dependencies (trivial). · e8dff372

recipe-roller authored Oct 28, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d33db3fb9897789a9179b7e532d4b2bbd7a6a441
d33db3f (qyearsley@chromium.org)
Proofread a part of the recipe docs

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I713c536a801fb7a1c9878d0a79a702b20fc85aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2505503Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e8dff372

27 Oct, 2020 4 commits

Add git-migrate-default-branch · dfa44dae

Josip Sokcevic authored Oct 27, 2020

R=ehmaldonado@chromium.org

Change-Id: Ib43132afd914bc3ea66f8a634ce8ead9bf2d3b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2496064
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

dfa44dae

Print message when waiting for editor · fc48704f

Bruce Dawson authored Oct 27, 2020

Running "git cl upload" can take a while so I tend to switch to other
tasks while it runs. On a regular basis I get frustrated because it is
taking an extremely long time only to realize that it has been waiting
for me.

This change adds a message saying "Waiting for editor..." to make it
clear who is waiting for whom.

Change-Id: I8cf08c3d2be0c7a843a4c07529682bc049b30426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2503689Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

fc48704f

git-cache: pack refs to reduce # of files downloaded. · 46b91c04

Andrii Shyshkalov authored Oct 27, 2020

I've observed today that V8 builder spends ~1 minute to download
a bunch of lose files representing tags[1]. This CL should
shrink ~2K files to just 72.

[1]
https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8865281064556718960/+/steps/initialization/0/steps/bot_update/0/stdout

R=jochen@chromium.org, machenbach@chromium.org

Change-Id: Ib8f245e6ed67ea91b53b22a8e4f729ab899a1cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2502476
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

46b91c04

Roll recipe dependencies (trivial). · ebb6a552

recipe-roller authored Oct 27, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/940151b7b14d59ccbc3ca702c83ae25ff119c0c3
  940151b (yiwzhang@google.com)
      [gevent] Do not monkey patch signal module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57ec9e170339343a5783ee4f94b8f262cd513893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2503469Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ebb6a552

26 Oct, 2020 2 commits

Roll recipe dependencies (trivial). · 77cd4b45

recipe-roller authored Oct 26, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/103411aea8b9331f783aea49814962031b254c54
  103411a (yiwzhang@google.com)
      [Deadline] Add deadline and SIGTERM support to recipe_engine.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I211dab405d3b182098363c8a43c10232490402a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2499505Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

77cd4b45

[depot_tools] Roll led to latest · c5453953

Chan Li authored Oct 26, 2020

To release change: crrev.com/c/2490615

Bug: 1141272
Change-Id: I7b21f48881a42d98c1f4ea0883609f478e2d134e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2495573
Auto-Submit: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>

c5453953

23 Oct, 2020 3 commits

setup_color: Disable colorama on pre-Windows-10 · 6f9b1bfd

Jesse McKenna authored Oct 23, 2020

This change disables colorama wrapping on versions of Windows prior to
10.

Currently, this wrapping causes "TypeError: cannot use a string
pattern on a bytes-like object" on Windows 7 and 8.1 when running
`gclient sync`, `gclient fetch`, and other utilities that use
colorama.

Bug: 1114548
Change-Id: Id6b4a6f9a8ae0721765da34b5625b4524b9d36b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2485882Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>

6f9b1bfd

Roll recipe dependencies (trivial). · f28949d6

recipe-roller authored Oct 23, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c210466b5c2bcb4d94191efa30d5d1a6f7ebbcc8
  c210466 (olivernewman@google.com)
      [cipd] Handle empty responses from CIPD

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id1a1947bbd38c5f371e9ef397238ab443b9275f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2495566Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f28949d6

Roll recipe dependencies (trivial). · 751a6ed6

recipe-roller authored Oct 23, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/409188f97be0a541f7b7094e7113014c684926b7
  409188f (olivernewman@google.com)
      [test] Make expectation file filter more strict

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id60066ff3a7eefe028145884beb26c7ff7a43465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2495720Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

751a6ed6

22 Oct, 2020 2 commits

Roll recipe dependencies (trivial). · 805ba2ef

recipe-roller authored Oct 22, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/55d317f2d1099557eeaa87bfac0a8364676d4493~..3b02f8181024472eee02fcb55fd7f9291accbf94
  55d317f (olivernewman@google.com)
      [recipe_deps] Extract recipes_dir and modules_dir properties
  3b02f81 (olivernewman@google.com)
      [test] Clean up expectation files from deleted recipes

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2941e39ebe8212baa64796d05b8305a2fa34c669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2493075Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

805ba2ef

Allow TLS 1.2 and print error codes · bf66f2d5

Bruce Dawson authored Oct 22, 2020

An external developer reported that gclient sync fails on Windows 8.1
unless TLS 1.2 is explicitly enabled. This allows that security protocol
and prints a more detailed error message on failures.

Change-Id: I07ab832d4f922264a1ee1890f9b71949a313a7ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2480605
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

bf66f2d5

21 Oct, 2020 1 commit

[resultdb] move the cipd pin of infra/tools/rdb · b3a1dbae

Scott Lee authored Oct 21, 2020

This release includes the following changes:

- print the invocation URL when finalizing it
1) crrev.com/c/2466271

- test-metadata
1) crrev.com/c/2472852
2) crrev.com/c/2486284
3) crrev.com/c/2486287
4) crrev.com/c/2486667

R=chanli@google.com

Bug: 1137506
Change-Id: I047b5cd90a11b777acdef6778d360cf3805139b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2490082Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

b3a1dbae

20 Oct, 2020 1 commit

Add retry on git push failure · f736cabb

Josip Sokcevic authored Oct 20, 2020

This adds retry if target is old default branch. This may happen only if
user didn't fetch remote for extended period of time and old default
branch no longer exists.

R=ehmaldonado@chromium.org

Change-Id: I81981049ee006f68a073718180b454c230d055e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2473757
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

f736cabb

19 Oct, 2020 3 commits

git cl try-results: show running jobs in YELLOW color. · 792630c4

Andrii Shyshkalov authored Oct 19, 2020

R=dpranke@google.com

Change-Id: I62f198d03e8326196476c42cd7c317871894f4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2485093
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

792630c4

Roll out new goma client binary VERSION=207 · 4c45ca0d

Yoshisato Yanagisawa authored Oct 19, 2020

Bug: b/170594475
Change-Id: Iaddc95be2fdcf95340e03ddd57156bcf5ddf8690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2484151Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

4c45ca0d

Roll recipe dependencies (trivial). · 8ecad526

recipe-roller authored Oct 19, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/70514f2891aaac01472c04a498cc724a6f54c7d7
  70514f2 (tikuta@chromium.org)
      [swarming] update swarming client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id505554d26875d3ef920f710e63a68a6a4b62055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2483354Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8ecad526

18 Oct, 2020 1 commit

Fix goma regex detection and add optional nice launching · 958dc626

Peter McNeeley authored Oct 18, 2020

Here we add slightly improved detection for the goma flag.
The detection of goma in autoninja does not work for the use_goma flag
when it does not simply appear at the beginning of the line.

Below are examples of multi-arg lines we now support:
is_debug=false use_goma=true is_official_build=false
use_goma=false# use_goma=true This comment is ignored


Also adding linux nice process launch feature to improve the user
experience when running a large build. This feature is disabled by
default like other autoninja features.



R=brucedawson@chromium.org

Change-Id: I8a04e7480c5e8d37d57fb71143c6066d46abb004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2479683
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

958dc626

16 Oct, 2020 2 commits

Roll recipe dependencies (trivial). · 4761cf50

recipe-roller authored Oct 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7e3be54729659656666407fddc6a29906f1662f8
  7e3be54 (tikuta@chromium.org)
      [cas] use os.environ to get SWARMING_SERVER envvar

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie07673210ee5a56e258f885c0ae5aa34c77d4eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2478806Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4761cf50

Roll recipe dependencies (trivial). · 2eec1c07

recipe-roller authored Oct 16, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/36a9f82370729f8c7f8a2eafabc077e35f26a9af
  36a9f82 (tikuta@chromium.org)
      [cas] inherit default_instance from SWARMING_SERVER envvar

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6720af8a9a1b4a188d981c9d48e44c25849e03ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2478803Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2eec1c07

15 Oct, 2020 3 commits

Fix `git map-branches` when branch is named after a file/directory · 39d870e1

Sylvain Defresne authored Oct 15, 2020

If there is a branch named after a file in the repository root, the
command `git rev-list --count $branch ^$base` is ambiguous. This is
because `git` does not know whether $branch needs to be parsed as a
revision or a filename.

Adding a trailing `--` parameter to the command-line resolves this
ambiguity since when present, everything before the `--` cannot be
a filename and everything after `--` has to one.

From git documentation:

  Paths may need to be prefixed with -- to separate them from
  options or the revision range, when confusion arises.

Bug: none
Change-Id: Ieb10aa8701e12fc3c88d5f75ff624f61ee8d8aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2475773Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>

39d870e1

Add pylint 2.6.0 to depot_tools. · 5d099fcb

Owen Rodley authored Oct 15, 2020

This is the latest version, which supports Python 3 only.

Bug: 1123433
Change-Id: I7516ed52d64f38f8214c6295e9ad3d08a98e2b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2473704
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

5d099fcb

Roll recipe dependencies (trivial). · 8e567c5c

recipe-roller authored Oct 15, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0d7a977e5ce07f8d5b1f24269dac438851f9f721
  0d7a977 (tikuta@chromium.org)
      [swarming] add assertion for isolated format

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I86294659d0975537ba014adc0b9e37bb5a8e9085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2474173Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8e567c5c

13 Oct, 2020 2 commits

Roll recipe dependencies (trivial). · 6e970e59

recipe-roller authored Oct 13, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0e4ad7bf162bfd36d111e475c75763b1d8c25c7a
0e4ad7b (gbeaty@chromium.org)
Add swarming_task_url property to LedLaunchData.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I218c2bbe95d3f7af23a6beb0d1372d1560b2b058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2469478Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6e970e59

[vpython] Update to e5cc6d29d10646efa. · aa45aa62

Owen Rodley authored Oct 13, 2020

This contains https://crrev.com/c/2465408, which has a workaround to
make ${vpython_platform} work on Python 3.

Bug: 1123433
Change-Id: I62eb96b8caaae5b954a06f6bdcbd1169200f3523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2465360
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

aa45aa62

09 Oct, 2020 2 commits

git-cl: Print response content on Gerrit transient errors. · b073999c

Edward Lesmes authored Oct 09, 2020

Response contents contain useful information when debugging Gerrit
transient errors.

For example, trying to land a WIP CL fails with a 409 Conflict status,
which is not very useful when trying to troubleshoot.
The message returned by Gerrit makes it clearer:

  Failed to submit 1 change due to the following problems:
  Change XXXXXXX: Change XXXXXXX is work in progress

Bug: 1136295
Change-Id: I7e0036785cb3146eae49e29d3c4fa3e156ae7c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2463987Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b073999c

git-drover: Fix error printing. · d7d0b90f

Edward Lesmes authored Oct 09, 2020

Exceptions have no '.message' field.

Bug: 1135320
Change-Id: I30aba548895f1863c9cf65bf3e81a370405c32fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2451375Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d7d0b90f

08 Oct, 2020 3 commits

Roll recipe dependencies (trivial). · 80d095c4

recipe-roller authored Oct 08, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/01b9c522df32a1f5d0dbb31e0b86bd22e3085bf1
  01b9c52 (ddoman@chromium.org)
      [resultdb] add coerce_negative_duration to api.resultdb.wrap()

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I876e43a74e061e62bd3b55b3ec4f55589f277a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2460754Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

80d095c4

[resultdb] move cipd pin of rdb · acad80a9

Scott Lee authored Oct 08, 2020

This is to release a new rdb binary with the following patch
: https://crrev.com/c/2455175

R=chanli@chromium.org

Bug: 1135892
Change-Id: I089ad008e54fcd67d1b1cf603582ff342fa99561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2459616Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>

acad80a9

Roll recipe dependencies (trivial). · c267a558

recipe-roller authored Oct 08, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/778c4c88bc5819d7527d9decd3d91919520ae32c
  778c4c8 (ddoman@chromium.org)
      [resultdb] update OWNERS of api.resultdb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8cbb1272321aaf1e669e685f0c59c44fbe3c72a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2460031Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c267a558

07 Oct, 2020 1 commit

Revert "Roll out new goma client binary VERSION=206" · 306f8358

Takuto Ikuta authored Oct 07, 2020

This reverts commit 8274c197.

Reason for revert: b/170284879

Original change's description:
> Roll out new goma client binary VERSION=206
>
> Bug: b/167500848
> Change-Id: I6819bad98fd39787c91582dc0ed4ee3cf11dccc4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2449282
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Fumitoshi Ukai <ukai@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,jwata@google.com,yekuang@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Bug: b/167500848, b/170284879
Change-Id: Ia2cadff395be2570c4f5c7c0dd283979380038c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2455566Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>

306f8358