Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 13 Jan, 2020 1 commit
  3. 10 Jan, 2020 2 commits
  5. 07 Jan, 2020 1 commit
  7. 06 Jan, 2020 2 commits
  9. 04 Dec, 2019 1 commit
  11. 02 Dec, 2019 2 commits
  13. 29 Nov, 2019 1 commit
  15. 28 Nov, 2019 1 commit
  17. 12 Nov, 2019 1 commit
  19. 11 Nov, 2019 2 commits
  21. 04 Nov, 2019 1 commit
  23. 30 Oct, 2019 2 commits
  25. 24 Oct, 2019 2 commits
    • Jamie Madill's avatar
      git-cl: Add 'format-full-by-default' setting. · dc4d19ee
      Jamie Madill authored 
      Lets the client repository make 'git cl format' use the
'--full' option by default. This solves issues when using less
common clang-format options that don't behave well with small
diffs. For example, AlignConsecutiveAssignments.

This is a replacement for the 'diff-lines-of-context' setting.

Bug: angleproject:4003
Change-Id: I81dc3b4992a7420e7235da88ec78e51ec4c0d24f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1879148Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
      dc4d19ee
    • Jamie Madill's avatar
      Revert "git-cl: Add diff lines of context setting." · 3671a6a2
      Jamie Madill authored 
      This reverts commit 812ac228.

Reason for revert: The fix was not sufficient to solve the git cl
format difference between 'git cl format' and 'git cl format --full'.
Looks like we'll need a different solution.

Original change's description:
> git-cl: Add diff lines of context setting.
> 
> Clients using some Clang-Format options can run into bugs when using
> 0 lines of context. AlignConsecutiveAssignments in particular is picky
> and behaves differently with 0 lines of context.
> 
> This behaviour lead to 'git cl format' behaving differently from
> 'git cl format --full'. That could also break presubmit format checks.
> Using >0 lines of context for 'git diff' fixes the inconsistency.
> 
> Add a setting 'DIFF_LINES_OF_CONTEXT' that can be controlled via
> codereview.settings. Defaults to zero to preserve the old behaviour.
> The setting allows the client to control the number of lines of context
> to use when running 'git cl format'.
> 
> Bug: angleproject:4003
> Change-Id: Ied2ebf23df4c41ba19bfbd5b8ddf526b56a20b31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1864309
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:4003
Change-Id: Ib6b70969509a1e5446922d488f11d13a0c59c536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1877003Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
      3671a6a2
  27. 23 Oct, 2019 1 commit
  29. 22 Oct, 2019 1 commit
  31. 21 Oct, 2019 2 commits
  33. 16 Oct, 2019 1 commit
    • Jamie Madill's avatar
      git-cl: Add diff lines of context setting. · 812ac228
      Jamie Madill authored 
      Clients using some Clang-Format options can run into bugs when using
0 lines of context. AlignConsecutiveAssignments in particular is picky
and behaves differently with 0 lines of context.

This behaviour lead to 'git cl format' behaving differently from
'git cl format --full'. That could also break presubmit format checks.
Using >0 lines of context for 'git diff' fixes the inconsistency.

Add a setting 'DIFF_LINES_OF_CONTEXT' that can be controlled via
codereview.settings. Defaults to zero to preserve the old behaviour.
The setting allows the client to control the number of lines of context
to use when running 'git cl format'.

Bug: angleproject:4003
Change-Id: Ied2ebf23df4c41ba19bfbd5b8ddf526b56a20b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1864309Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
      812ac228
  35. 14 Oct, 2019 1 commit
  37. 11 Oct, 2019 2 commits
  39. 10 Oct, 2019 1 commit
  41. 09 Oct, 2019 3 commits
  43. 08 Oct, 2019 3 commits
  45. 03 Oct, 2019 3 commits
  47. 30 Sep, 2019 1 commit
  49. 26 Sep, 2019 1 commit
  51. 25 Sep, 2019 1 commit