Also fixes bug where gclient fails because options isn't defined.


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19498 0039d316-1c4b-4281-b951-d872f2087c98

It was totally broken until I actually tried it. Fix the test accordingly.

TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/149096

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19433 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/147162

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19429 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/147014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19277 0039d316-1c4b-4281-b951-d872f2087c98

The unit tests could modify global state in hard-to-revert ways and would make the PRESUBMIT.py check flaky.
Having the test running out of process alleviate any potential issue at the cost of speed (more noticeable on Windows).

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/147035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19248 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/147119

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19206 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/146050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19063 0039d316-1c4b-4281-b951-d872f2087c98

the --delete_unversioned flag is specified.  This only affects the update
command.  Reverts will still delete the unversioned tree.

Review URL: http://codereview.chromium.org/125147

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19021 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18764 0039d316-1c4b-4281-b951-d872f2087c98

TEST=new unit tests
BUG=none

Review URL: http://codereview.chromium.org/131056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18739 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18737 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/126272

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18704 0039d316-1c4b-4281-b951-d872f2087c98

Now update git depot_tools checkouts, also add automatic update for git-cl-repo and git-try-repo.

The difference with 18633 is that it leaves bootstrap/gclient.sh along. I'll remove it in a month or so to not break anyone in the meantime.

TEST=none
BUG=none
TBR=evan
Review URL: http://codereview.chromium.org/129001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18637 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18634 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/125259

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18633 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests now runs
BUG=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/126278

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18620 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/125252

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18619 0039d316-1c4b-4281-b951-d872f2087c98

Also adding unit tests.

TEST=new unit tests
BUG=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/125253

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18618 0039d316-1c4b-4281-b951-d872f2087c98

Ah cygwin...

Patch contributed by cmp@google.com

TBR=nsylvain
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/125249

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18613 0039d316-1c4b-4281-b951-d872f2087c98

This is a redo of http://codereview.chromium.org/123020 (revision 18198) that was reverted in revision 18232 because of a codereview.settings misconfiguration and not because the script was broken.

The misconfiguration was fixed in http://codereview.chromium.org/126021

Review URL: http://codereview.chromium.org/125135

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18612 0039d316-1c4b-4281-b951-d872f2087c98

Also fix argument processing.

It doesn't works at the moment but doesn't throw an exception either. :)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/125095

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18611 0039d316-1c4b-4281-b951-d872f2087c98

This is slightly messy but seemingly necessary because cygwin doesn't consider a .bat file when running the command without the .bat extension.

TEST=shouldn't break everything
BUG=none
Review URL: http://codereview.chromium.org/125032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18337 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/125079

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18325 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/126068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18309 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=maruel

Review URL: http://codereview.chromium.org/126057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18279 0039d316-1c4b-4281-b951-d872f2087c98

I had used the old method name. watchlists needs a unit test.

TEST=none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/125053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18278 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/126051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18274 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/126050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18273 0039d316-1c4b-4281-b951-d872f2087c98

Small refactor of ChangeInfo to not hardcode the use of GetRepositoryRoot().

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/125051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18272 0039d316-1c4b-4281-b951-d872f2087c98

Stop presubmit_support.py from calling gcl.GetRepositoryRoot(). Instead, save the repository root in ChangeInfo and name it GetLocalRoot() to make it less confusing.
Add GetFileList() and GetFileNames() to ChangeInfo to make it less confusing and more "interface-like".

TEST=updated unit tests with a lot of pain
BUG=none

Review URL: http://codereview.chromium.org/119442

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18266 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/126032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18265 0039d316-1c4b-4281-b951-d872f2087c98

TESTS=still none
BUG=none
TBR=nirnimesh

Review URL: http://codereview.chromium.org/126031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18245 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18244 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
R=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18238 0039d316-1c4b-4281-b951-d872f2087c98

Will reapply in 3 days.

TEST=gcl try works.
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/126020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18232 0039d316-1c4b-4281-b951-d872f2087c98

Watchlists provides an opportunity for someone interested in a particular
code section to make comments before commit. One can subscribe to watchlists
depending on filepath (regular expressions) and she'll automatically get
cc-ed to changes when the watchlist is triggered.

Additional examples of watchlist_rules in diff repo:
http://codereview.chromium.org/118431
http://codereview.chromium.org/119356
Review URL: http://codereview.chromium.org/118432

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18209 0039d316-1c4b-4281-b951-d872f2087c98

Don't rely on the freaky tryserver.py script anymore. Use gcl codereview settings instead.

TEST=gcl try still works, shouldn't break git-try
BUG=none

Review URL: http://codereview.chromium.org/123020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18198 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18179 0039d316-1c4b-4281-b951-d872f2087c98

Remove old unused git-cl test files.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/122040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18177 0039d316-1c4b-4281-b951-d872f2087c98

This is annoying when using gcl presubmit.

TEST=unit test
BUG=none
Review URL: http://codereview.chromium.org/122010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18141 0039d316-1c4b-4281-b951-d872f2087c98