Commits · 1fc333a7d7723a969f68a6d36d0a391944fbd954 · Linshizhi / Chromium_Depot_tools

26 May, 2020 5 commits

Roll recipe dependencies (trivial). · 1fc333a7

recipe-roller authored May 26, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/567bbd0e945b1144e2343441deac92a661a17f9d (yiwzhang@google.com)
    [proto_module] Remove unused DEPS

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia55b38048e9e1cca05c967289c65a114bac09f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216579Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1fc333a7

[luci-auth] Update to the latest version. · 0ec48260

Vadim Shtayura authored May 26, 2020

Has support for generating tokens through LUCI Token Server.
Has somewhat nicer UX around `luci-auth context` usage.

R=iannucci@chromium.org
BUG=1082960

Change-Id: I2a77649b7ebbc5c99af4435afa929022a0e93ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216533Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

0ec48260

Document the parameter {heading} avilable to --output-format-heading. · 2be61a1d

Vincent Scheib authored May 26, 2020

R=jsbell@chromium.org

Change-Id: Ia0db8fe7494306147e0e80f49e229f50b8603f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2214243Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>

2be61a1d

add clarification for Python 3 · 603989e2

Andreas Papacharalampous authored May 26, 2020

Bug: None
Change-Id: Ie9cfc90b1dd4b241238e5f0a4c995979f7a0fbdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2213175
Auto-Submit: Andreas Papacharalampous <andreas@apap04.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

603989e2

Roll recipe dependencies (trivial). · ea71aeab

recipe-roller authored May 26, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/bf5c53d04c84487f31275133294f5a57145fecf4 (olivernewman@google.com)
    [swarming] Use ensure_tool() to install swarming
  https://crrev.com/9ddf1e1c6ae354ee17de8abd99dc37acdf4dbe60 (olivernewman@google.com)
    [isolated] Use ensure_tool() to install isolated

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2a56b974f6d840e5c846a43881211c82ca3c956b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216058Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ea71aeab

22 May, 2020 2 commits

Fix gclient-new-workdir when source repo is shallow clone · 42033b2c

Richard He authored May 22, 2020

When source repo is a 'shallow clone', `.git/shallow` is not linked to
the new workdir. Which makes running git command fails in new workdir.

Change-Id: I81d38b7b2cccc482711dcc1dd02ea06fbd01a56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211635Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Richard He <linyhe@microsoft.com>

42033b2c

Roll recipe dependencies (trivial). · 74f67e29

recipe-roller authored May 22, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/4af7811ff97185909adb1a058be892162eaeca92 (olivernewman@google.com)
    [cipd] Add helper method for ensuring a CIPD tool

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I646a55a45f3c53b81ebddadebc28ddb50405e5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2213182Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

74f67e29

21 May, 2020 4 commits

Roll recipe dependencies (trivial). · db1a7975

recipe-roller authored May 21, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/db16f4a77fed59430dec426ff459339638a5bebd (iannucci@chromium.org)
    [comprehensive_ui] Use python instead of echo for windows compat.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1713e654fa76c4ce80569324a6902928863eb278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2212954Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

db1a7975

update_depot_tools: Pull changes first before updating tools on Win. · 942c97d6

Edward Lesmes authored May 21, 2020

Update git checkout before updating the tools.
If the scripts to update the tools are broken in the current revision,
this will allow us to get a new, hopefully working, revision instead of
leaving us stuck on a broken one.

We already do this for Linux.

Change-Id: I31856ebbd659d5360ad705dc39e5856b4140a19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208625Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

942c97d6

Update lucicfg version. · c9eb1c37

Owen Rodley authored May 21, 2020

Change-Id: Id0913dd89874a234b956bcba8905c5684b3892be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211111
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

c9eb1c37

Reland "Use OS level locking in git_cache.py" · 14a83aec

Josip Sokcevic authored May 21, 2020

This is a reland of d3affaa6

Original change's description:
> Use OS level locking in git_cache.py
> 
> Without OS level locking it's possible to leave "lock" files on disk
> which will prevent next run to acquire those locks. This can easily
> happen if SIGKIL is issued.
> 
> R=apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1049610
> Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1049610
Change-Id: I58e65a10f7c779e0de1121ba7167c694996e390c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211189Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

14a83aec

20 May, 2020 9 commits

Revert "Use OS level locking in git_cache.py" · 8f6bfe30

Josip Sokcevic authored May 20, 2020

This reverts commit d3affaa6.

Reason for revert: no attribute ignore_lock

Original change's description:
> Use OS level locking in git_cache.py
> 
> Without OS level locking it's possible to leave "lock" files on disk
> which will prevent next run to acquire those locks. This can easily
> happen if SIGKIL is issued.
> 
> R=apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1049610
> Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: Iecc963e0a99d7f59f3f8801e529839346f9fbaf3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211186Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

8f6bfe30

Fix `git cl format` for metrics XML files on Windows · 7aed4bb8

Ilya Sherman authored May 20, 2020

* Call `os.path.normpath()` prior to comparing file paths
* Run Python files with `vpython`
* Pass `shell=True` for Windows commands, so that the PATH variable is
  defined: https://stackoverflow.com/a/32799942
  * While here, clean up similar call sites to drop an unnecessary cast.

Fixed: 1081763
Change-Id: I8096b3ad14a4675036a579fab537af1d94f12725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2203422
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>

7aed4bb8

Add git cl format support for "structured" metrics · b67e60cd

Ilya Sherman authored May 20, 2020

This matches the support for the other metrics subdirectories.

R=ehmaldonado@chromium.org

Bug: none
Change-Id: Ibf84e1d1b33e38843b8a11ff3299d4c0c3aa5eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173743
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>

b67e60cd

Use OS level locking in git_cache.py · d3affaa6

Josip Sokcevic authored May 20, 2020

Without OS level locking it's possible to leave "lock" files on disk
which will prevent next run to acquire those locks. This can easily
happen if SIGKIL is issued.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1049610
Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

d3affaa6

Roll recipe dependencies (trivial). · 008b71ab

recipe-roller authored May 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/33d170546318d569bda45360dde56b4bde7784cf (yiwzhang@google.com)
Reland "[engine] export `LOGDOG_NAMESPACE` env var when running a step"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f3eb84d60274d3c70e64ad25f7f0ec19f6372c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2210842Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

008b71ab

Roll recipe dependencies (trivial). · a0139c0a

recipe-roller authored May 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/6e7cf734a384f0d1daef9c1404474e70fd75798f (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I99bca58c2f32e9064e7d8fb43eb7864230d0d015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209918Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a0139c0a

Roll recipe dependencies (trivial). · f56c82ff

recipe-roller authored May 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/69ea67ccefa38df2b05a9320879eebba9d3bd676 (yiwzhang@google.com)
Revert "[engine] export `LOGDOG_NAMESPACE` env var when running a step"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5875585b29c811875985fdc9148267c683d100c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209916Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f56c82ff

Roll recipe dependencies (trivial). · d8c6146c

recipe-roller authored May 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/0655aa3e1de7c0167302fb582a13f7cafd4866e7 (iannucci@chromium.org)
    Update go.chromium.org/luci protobufs.
  https://crrev.com/9ed63c7585afba169c36ef08ada467e210fcec3c (yiwzhang@google.com)
    [engine] export `LOGDOG_NAMESPACE` env var when running a step

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I00b981af1ab7f51cac3ad7eb644023d59a293c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209664Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d8c6146c

Fix extra spaces in git cl completion · 4cfa04ff

Ng Zhi An authored May 20, 2020

The commands come from the output of git cl -h, which then goes through
an sed filter, matching on the ANSI escape sequence for green and reset.
This ends up having extra spaces, since the output aligns the
subcommands based on the longest subcommand. For shorter commands like
archive, it becomes "archive ". So, tweak the sed regex to only
capture the part without the whitespaces.

Change-Id: I80a84f142520478547895f85def68331575fdd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209582Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>

4cfa04ff

19 May, 2020 4 commits

Fix git cl completion · 620c56e9

Ng Zhi An authored May 19, 2020

__git_cl_all_commands is a variable, so it should use the variable
parameter, ${}, not a command substitution $().

Change-Id: I81fc2c73afd85cc1f737af00fbc294d933145e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2205456Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

620c56e9

Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows · 002f97b3

Edward Lesmes authored May 19, 2020

We should fail when we fail to update depot_tools instead of continuing
the execution silently. Otherwise, developers might get stuck on a bad
depot_tools revision without knowing.

Change-Id: I0431a24a28a77aca8c66352939a0252c458b3e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208616Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

002f97b3

Roll out new goma client binary VERSION=200 · 5a7be3da

Ye Kuang authored May 19, 2020

https://chromium.googlesource.com/infra/goma/client/+/ccc8255ac04a4f79a4649168c04ffdaa59af649b

Bug: b/156546740
Change-Id: If754346ec49c7314b13160ea682c630e0e5ccd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208512
Commit-Queue: Ye Kuang <yekuang@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Auto-Submit: Ye Kuang <yekuang@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>

5a7be3da

Roll recipe dependencies (trivial). · e67e41aa

recipe-roller authored May 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/c032fdbdb5e726dbb2842c212a6ec237126fda56 (lamontjones@chromium.org)
cq: correct property name.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24d67cbe6b65d95f69eef08321102c9a9ec9c9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208209Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e67e41aa

16 May, 2020 2 commits

Roll recipe dependencies (trivial). · c4fb1974

recipe-roller authored May 16, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/935b52680cfbf06efe126de0f68980a51472bfcd (yiwzhang@google.com)
    [engine] Support merge step in Stream Engine
  https://crrev.com/9612029d01ef2c99345f6b53dd15ece8bc75400e (yiwzhang@google.com)
    [luciexe] set default log level to info

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43a2232ac8f1df0e29ece052f8e0edaa672bcb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204903Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c4fb1974

Roll recipe dependencies (trivial). · 728fc627

recipe-roller authored May 16, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/2209e8c4c0d99b6682a1c747015ba95a962bb088 (iannucci@chromium.org)
Fix luciexe mode when stdout is populated from user space.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e1c2a464ba1e69a4f5bafc35e0e9e89aedd938c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204919Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

728fc627

15 May, 2020 1 commit

Roll recipe dependencies (trivial). · 5e0a4a6b

recipe-roller authored May 15, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/270b341c5f36f1cdfa73ab7f190f961a1c8f7565 (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibc7e76407946ad6f3f9496fdd5c1b9827f640236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2203271Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5e0a4a6b

14 May, 2020 3 commits

depot_tools: bugfix for py3 syntax and bytes/str changes · beb877fe

Robert Brandt authored May 14, 2020

Also update copywrite header to conform to expectations.

BUG=chromium:1082354
TEST=locally, can upload commit with this fix

Change-Id: I5527cf9cc58fbab94f777b82008a422a3190f539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2199884
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

beb877fe

Roll recipe dependencies (trivial). · 176bf641

recipe-roller authored May 14, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/093ad4d4c27bcecdb3b80d36b4615692cde14524 (iannucci@chromium.org)
    [luciexe] Synthesize deprecated properties to ease transition.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a4349b13ab05d5c31b8439104acdf2e78c4c704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2202664Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

176bf641

Add a pan-project presubmit check for commits in tree · 053213d0

Derek Morris authored May 14, 2020

It's possible to add commit objects to the tree, and this can cause
some confusion for git's tools - if this happens to overlap with an
actual folder or a gclient-imported repo, the tree will be dirty.

This change finds this issue by scanning the tree and looking for a
commit object there.

Bug: 869594
Change-Id: Ia1f1fb22ab8f7ac1eed7b32dedad5c1296b1d67b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842637Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Derek Morris <demorri@microsoft.com>

053213d0

13 May, 2020 1 commit

Update cipd_manifest for Goma client 80180e1e · 30ef5cb4

Simon Que authored May 13, 2020

R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org

Bug: b/155444722
Change-Id: Idb8c4a08a8094a5ec923d4ba0157d1142d9271b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2198271Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

30ef5cb4

12 May, 2020 3 commits

Delete dirty bot_update workspace · 8280ae5e

Josip Sokcevic authored May 12, 2020

File marker '.dirty_bot_checkout' indicates that bot_update checkout has
started. Such marker is removed on successful checkout.

If such marker is present before creation, it means previous run wasn't
successful and may have left workspace in a bad state. In that case,
delete working directory and continue with a clean checkout.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074260
Change-Id: Ic089eedc26f7c269d5342fae366899571d8f8d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186273
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

8280ae5e

Roll recipe dependencies (trivial). · 1fbaf73a

recipe-roller authored May 12, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/0e48470a5ac2b31561146925f2d52ae3e120bc4e (iannucci@chromium.org)
    [luciexe] Map WARNING to SUCCESS to match previous behavior.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57738fe5cc30b18efbf737206a773b58a8b00c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2195556Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1fbaf73a

WATCHLISTS: CC chops-source-team@ on all depot_tools changes. · f90afd3e

Edward Lesmes authored May 12, 2020

Change-Id: I60572a93178038335b5a6af0f03ad6500a72c862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194898Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f90afd3e

11 May, 2020 2 commits

Roll recipe dependencies (trivial). · 454f4ba4

recipe-roller authored May 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/55bc6100c43ae642a9107242d8e122e924d0e9cd (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6119026a38399445d30c79fbc686e8ba7a468947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194881Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

454f4ba4

Roll recipe dependencies (trivial). · b833dd8a

recipe-roller authored May 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/e9bcb3b0c6c5d520cb48932b878212240a5b0bb1 (olivernewman@google.com)
    [test] Don't ignore --jobs argument

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1b3016fd88dcc1298f44748752f630aba299959a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194255Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b833dd8a

09 May, 2020 2 commits

Roll recipe dependencies (trivial). · aaf56699

recipe-roller authored May 09, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/70eb7a77b1f8a2482dc1bf6dd09c337485c13ca8 (yiwzhang@google.com)
    [luciexe] Always send one last build to lodgog before closing stream engine

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib4f5815aa9c66677cffb62506ad61f8854eec1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2191464Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

aaf56699

Use cached variable for git cl completion · 8b35029c

Henrique Ferreiro authored May 09, 2020

__git_cl_all_commands is used to cache the result of
__git_cl_commands(), but the actual code wasn't using it and was calling
the function everytime instead.

Change-Id: Ia2ce32b7de2812349808ec9aceeacf5adf463700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190337Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>

8b35029c

08 May, 2020 2 commits

Print the SHA of files downloaded from GS · 64dab2db

Yuly Novikov authored May 08, 2020

Bug: angleproject:4621
Change-Id: I85aefeeffa05712a63a62e9acef8df27b1933e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190862
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

64dab2db

Prune branches that no longer exist on remote · 6afaa6ca

Josip Sokcevic authored May 08, 2020

If a local branch tracks removed remote tracking branch (e.g. foo) and
remote has a branch that starts with such name (e.g. foo/bar), git fetch
will fail. --prune flag removes any remote-tracking branches that no
longer exist.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1079483
Change-Id: I9bc31bf961d52a86b6fa2342249971b99a003666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190341
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6afaa6ca