- 20 Jul, 2018 3 commits
-
-
Mike Frysinger authored
** WARNING: please do not revert this CL without checking with vapier@ first *** We disable new warnings that are triggered in depot_tools to pylintrc. So the lint output before & after this CL are mostly unchanged. The repos checked: depot_tools, src, and build. Also update its deps along the way: - Update astroid to 1.4.9. - Drop now unused logilab.common. - Import lazy_object_proxy 1.3.1. - Import wrapt 1.10.11. This should address the issue where some Chromium bots don't have the lazy_object_proxy/wrapt python modules installed. These have optional C modules that we don't compile either as they have Python fallbacks. Bug: 863669 Change-Id: Iade0e6d89598e2c836ed647996f43db356c43cd0 Reviewed-on: https://chromium-review.googlesource.com/1145485 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org>
-
Ned Nguyen authored
This reverts commit 3899f1bc. Reason for revert: causing PRESUBMIT error on catapult repo BUG:chromium:865897 Original change's description: > pylint: upgrade to 1.5.6 > > We disable new warnings that are triggered in depot_tools to pylintrc. > So the lint output before & after this CL are mostly unchanged. The > repos checked: depot_tools, src, and build. > > Also update astroid to 1.4.9 and drop logilab.common as needed. > > Bug: 863669 > Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044 > Reviewed-on: https://chromium-review.googlesource.com/1137382 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Mike Frysinger <vapier@chromium.org> TBR=vapier@chromium.org,iannucci@chromium.org,jbudorick@chromium.org Change-Id: I8ea087123db4e52fdf7ebff8b1ed356fd60a6059 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863669 Reviewed-on: https://chromium-review.googlesource.com/1145160Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com>
-
Mike Frysinger authored
We disable new warnings that are triggered in depot_tools to pylintrc. So the lint output before & after this CL are mostly unchanged. The repos checked: depot_tools, src, and build. Also update astroid to 1.4.9 and drop logilab.common as needed. Bug: 863669 Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044 Reviewed-on: https://chromium-review.googlesource.com/1137382Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 20 Jun, 2018 1 commit
-
-
Mike Frysinger authored
Grab a few random fixes like deleting old abstract-class-little-used, abstract-class-not-used, and star-args. Bug: None Test: `./pylint *.py` shows no regressions Change-Id: I494379e18da002d479cb193412fcc49f8c66f376 Reviewed-on: https://chromium-review.googlesource.com/1103763Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 11 Dec, 2014 1 commit
-
-
vapier@chromium.org authored
This is largely a bugfix release, so should be much easier to transition. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/753543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293355 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Nov, 2014 2 commits
-
-
vapier@chromium.org authored
The reason cited for reverting was invalid, so reland the update. BUG=chromium:431514 Review URL: https://codereview.chromium.org/739393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293049 0039d316-1c4b-4281-b951-d872f2087c98
-
smut@google.com authored
This reverts commit e642ee86. Conflicts: pylintrc Reason: All repos are borked. TBR=vapier Review URL: https://codereview.chromium.org/741023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293042 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Nov, 2014 1 commit
-
-
vapier@chromium.org authored
The current pylint is very old at this point. Pull in the latest version as it supports a lot more features. Also need to fix the pylint wrapper to actually update sys.path to use the local modules. We include the six module since not all bots have it, and it's small. This will trigger new warnings in files, but they look like legitimate issues that should be fixed at some point. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/741503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292988 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Nov, 2014 2 commits
-
-
kbr@chromium.org authored
This reverts commit 451939d5. Throws an exception with a missing import, breaking Telemetry's presubmit checks and presumably presubmit checks for all Python files in Chromium. See comment on https://codereview.chromium.org/707353002/ . BUG=chromium:431514 Review URL: https://codereview.chromium.org/719313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292955 0039d316-1c4b-4281-b951-d872f2087c98
-
vapier@chromium.org authored
The current pylint is very old at this point. Pull in the latest version as it supports a lot more features. Also need to fix the pylint wrapper to actually update sys.path to use the local modules. This will trigger new warnings in files, but they look like legitimate issues that should be fixed at some point. BUG=chromium:431514 TEST=ran on some code bases and checked output Review URL: https://codereview.chromium.org/707353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292954 0039d316-1c4b-4281-b951-d872f2087c98
-