- 30 Apr, 2021 4 commits
-
-
Edward Lesmes authored
If the DEPOT_TOOLS_REPORT_BUILD envvar is set, Depot Tools will report information about the builder running the command (e.g. buildbucket project, bucket, builder and build id). It will also authenticate to the metrics server, and ignore any requests not made by ChOps service accounts. Change-Id: I078a4c2170b4226086c42f289fa449bdebc87179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861213 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Scott Lee authored
This is to deploy the changes of crbug.com/1149662, which enables BatchCreateArtifacts in ResultSink. Bug: 1149662 Change-Id: Ib3669ad9c2f02deb62455a9e3ef05ef858ef1290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862880Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org>
-
Dean Michael Berris authored
This change includes the following commits from the infra/infra repository: $ git log --format='%h %s (%ae)' \ 97ee9cecaac4d99be09278169f987e61b8116672..HEAD \ -- go/src/infra/chromeperf/pinpoint/cli dabbed3140 pinpoint: Add support for experiment presets (dberris@google.com) 2c16cdc58a pinpoint: Initial support for user configurations (dberris@google.com) R=dpranke@google.com Change-Id: I0bb7a5a167e57b64d8328f497386d5b68f3e4a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2862344 Auto-Submit: Dean Berris <dberris@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:Dirk Pranke <dpranke@google.com>
-
Brian Ryner authored
This package version is also available for mac-arm64. Also, update bleeding_edge to pull a native cpython3 package on mac-arm64, to match https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2858534 Bug: 1124119 Change-Id: Ief3c44f72fddd832cd9fb1e099dfb889a492f4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861642Reviewed-by:
-
- 29 Apr, 2021 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/782fd4903e373bda1dd9d163176cd3fbb9984a00 782fd49 (yiwzhang@google.com) cq: accept modes instead of mode_regexp for cq.allow_reuse_for api More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1d24cd20449dd7c1f8915e8fc3a039a2be6aad90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2860878 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Nico Weber authored
With this, it's possible to run some things without export VPYTHON_BYPASS="manually managed python not supported by chrome operations" on an arm mac, such as `git cl upload` -- this CL was uploaded from my M1 MBP :) (Presubmits need py2 which we don't have yet, but with `--bypass-hooks` it works.) Bug: 1103326,1184767,1103236 Change-Id: I46f5b880dfd72b8d811d39b43311fdee17ccad3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2858534 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- 28 Apr, 2021 5 commits
-
-
Yiwei Zhang authored
To pickup support for generating tricium config and introducing mode_allowlist R=qyearsley, tandrii Bug: 1194244 Change-Id: I16a8792e8d4df4127c1d545dca246058c8f93066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2856909Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
-
Dirk Pranke authored
The change I landed in 61bf638 couldn't include the proper tests because of crbug.com/1201918 (I think), and so I split the test file out into this separate follow-up CL. Bug: 1157663 Change-Id: I06697a5b76f81f0dc96ad457406a8d4d942d882c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2846635Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Yoshisato Yanagisawa authored
Bug: b/185543547 Change-Id: Ide2f77ee37f3d650a9c5a5054ed962db5dda3d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2856514Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a80d44a95d495fe9e6deb16375dd6be4242334ed a80d44a (iannucci@chromium.org) [deps] Move dependant recipe discovery to be an option. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id5bb0bb56f8c956213ee4a3917197a0b9e6d36c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2856095 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Brian Ryner authored
Bug: 1184767 Change-Id: I62794e383bad8592ae1027b728426042a843c610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2846742 Commit-Queue: Brian Ryner <bryner@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
- 27 Apr, 2021 2 commits
-
-
Gavin Mak authored
This change is needed to enable CQ for the tricium plugin. Bug: 1201483 Change-Id: I685d04055a5cabd94c7f02a79a0b9cbc4694db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2847232Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/75cf2faf5db4d90a5485d5da05713faa3922383a 75cf2fa (iannucci@chromium.org) [deps] Add deps subcommand. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icef236b13c71d13b94d33bc0754ecfc4059a1b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2854976 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 26 Apr, 2021 3 commits
-
-
Scott Lee authored
This reverts commit 90aee2ac. Reason for revert: the new rdb caused blink web tests to fail Original change's description: > [resultdb] move cipd pin of rdb to enable BatchArtifactsUpload > > This is to deploy the changes of crbug.com/1149662, which enables > batch-uploading for artifacts in ResultSink. > > Bug: 1149662 > Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389 > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Chan Li <chanli@chromium.org> > Commit-Queue: Scott Lee <ddoman@chromium.org> Bug: 1149662 Change-Id: I7b3e5b5fae3e6262134582c0f002ff46065a9eb4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2852455 Auto-Submit: Scott Lee <ddoman@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org>
-
Scott Lee authored
This is to deploy the changes of crbug.com/1149662, which enables batch-uploading for artifacts in ResultSink. Bug: 1149662 Change-Id: Id4845fd421065cfc45442e16f5d41d0001818968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850389Reviewed-by:
-
Brian Ryner authored
This is to pick up https://chromium-review.googlesource.com/c/infra/infra/+/2850061 which we'll want in order to enable the native ARM64 package in a future CL. Bug: 1184767 Change-Id: I37491ac0591dfc37ca19c2cdfef5c133d78a5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2850328 Auto-Submit: Brian Ryner <bryner@google.com> Reviewed-by:
-
- 23 Apr, 2021 1 commit
-
-
Dirk Pranke authored
This CL adds support for running PRESUBMIT.py under either Python2 or Python3 as specified in each PRESUBMIT.py file. To run the checks under Python3, the PRESUBMIT.py file must contain a line exactly matching "^USE_PYTHON3 = True$". If the file does not contain this string, the checks will run under Python2. Different PRESUBMIT.py files in a single CL may thus contain a mix of 2- and 3-compatible checks, but each individual file will only be run in one or the other (it doesn't likely make sense to run them in both by default). Bug: 1157663 Change-Id: Ic74977941a6519388089328b6e1dfba2e885924b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2832654 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
- 22 Apr, 2021 1 commit
-
-
Edward Lesmes authored
Bug: 1200657 Change-Id: I9362a66d12d75d26e1236f9d8516b03561fb9383 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837689 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
-
- 21 Apr, 2021 4 commits
-
-
Brian Ryner authored
This is a prerequisite to enabling the native Mac ARM64 cpython3, since we don't have that package built at the old 3.8.0 version. Bug: 1184767 Change-Id: I68a7de836f9fae25ecbb2fc84aff389a24c32e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842053Reviewed-by:
-
Nico Weber authored
This was switched from python to vpython in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1962721 for a Windows module. Since vpython doesn't yet work on arm macs, switch this back to vanilla python on non-win for now. Bug: 1103236 Change-Id: Id083ad88d8474e283fb9f48d91e343b66aa67e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842346 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Weiwei Lin authored
The most notable change is to add support for configuring test presentation. Change list: * https://crrev.com/c/2788979 * https://crrev.com/c/2794800 * https://crrev.com/c/2830173 R=tandrii, vadimsh Change-Id: Ic38099e4748783699dcc9579cd7aa9d94918c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842052 Auto-Submit: Weiwei Lin <weiweilin@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d8993f4684839b58f5f966dd6273d1d8fd001eae d8993f4 (weiweilin@google.com) [recipe] Update test presentation config to match lucicfg imple... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4975618c9153b37a8139a6ab49822bd2b1988afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2842550 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 20 Apr, 2021 5 commits
-
-
Edward Lesmes authored
This is a reland of 4c67f856 Issues should have been fixed by crrev.com/c/2838026 Original change's description: > git-cache: Add option to fetch commits. > > Add option to git cache to fetch commits. > And use it in bot_update and gclient sync to make sure > the needed commits are present on the checkout. > > Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Ie5a29737f5a75d28bc7c5c2f6cb99ec7f87cd9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2841046Reviewed-by:
-
Takuto Ikuta authored
This is to have the latest version of underlying library. Bug: 1200494 Change-Id: I43f1628280e75b94b21c2c6a399f55a12970252c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2838848 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
Edward Lesmes authored
Bug: 1200657 Change-Id: Ib719b984a71cd944bbccf3ec7065aaa17f60e638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2838026Reviewed-by:
-
Edward Lesmes authored
This reverts commit 4c67f856. Reason for revert: crbug.com/1200657 Original change's description: > git-cache: Add option to fetch commits. > > Add option to git cache to fetch commits. > And use it in bot_update and gclient sync to make sure > the needed commits are present on the checkout. > > Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: I31a1defb26119bcb46894ab4084d626b65c45fed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837413 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Linkun Chen authored
Bug: 1199969 Change-Id: I5dcc5fc631cc417fd295d753171f3696f1c7ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837688Reviewed-by:
Linkun Chen <lkchen@chromium.org> Reviewed-by:
-
- 19 Apr, 2021 6 commits
-
-
Edward Lesmes authored
Add option to git cache to fetch commits. And use it in bot_update and gclient sync to make sure the needed commits are present on the checkout. Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942Reviewed-by:
-
Mike Frysinger authored
Change-Id: I60ed3a0c67d6dbc5c06afde928b7138d0837e8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837647 Auto-Submit: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Stephane Belmon <sbelmon@google.com> Commit-Queue: Stephane Belmon <sbelmon@google.com>
-
Jamie Madill authored
This is a reland of 75271a07 Should be safe to re-land now, as the roller will catch the build error. Then we can re-land in conjunction with the change to rename the angle gclient config. Original change's description: > Reland "Remove ANGLE recipe config." > > This is a reland of b8686d26 > Must land after https://crrev.com/c/2831999 > > Original change's description: > > Remove ANGLE recipe config. > > > > This config is now located in the ANGLE recipe_module. > > > > Bug: angleproject:5114 > > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242 > > Auto-Submit: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > > Bug: angleproject:5114 > Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I85c3d6218b790ef62b19c62eb42ec9a8622d613f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836327 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Garrett Beaty authored
This reverts commit 75271a07. Reason for revert: breaks CQ for chromium/tools/build Original change's description: > Reland "Remove ANGLE recipe config." > > This is a reland of b8686d26 > Must land after https://crrev.com/c/2831999 > > Original change's description: > > Remove ANGLE recipe config. > > > > This config is now located in the ANGLE recipe_module. > > > > Bug: angleproject:5114 > > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242 > > Auto-Submit: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > > Bug: angleproject:5114 > Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I8dc93e365f8f0615207050a306350461082efafa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836638 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Bug: 1199969 Change-Id: If05401f3f6c5c8e302220a52c4c237be0f721da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836346Reviewed-by:
-
Jamie Madill authored
This is a reland of b8686d26 Must land after https://crrev.com/c/2831999 Original change's description: > Remove ANGLE recipe config. > > This config is now located in the ANGLE recipe_module. > > Bug: angleproject:5114 > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242 > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Bug: angleproject:5114 Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386Reviewed-by:
-
- 16 Apr, 2021 4 commits
-
-
Edward Lesmes authored
Change-Id: Ib731a761674d7ee7db4d67f197611f7d1f8b2f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829987 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Mike Frysinger authored
We're looking at dropping Python 3.5 support from repo. Lets roll this back out in Chromium a little early to get a better idea of who is still relying on it. Change-Id: Idcdd5b0a957f5a2f8b146149c407c26347be0aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830590Reviewed-by:
-
Fumitoshi Ukai authored
Bug: 1182961, b/185198549, b/180579630, Change-Id: If4aaffe3ec17745cd1a2d36a563b4c25176e9883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830398Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
Jamie Madill authored
This reverts commit b8686d26. Reason for revert: Breaks presubmit bot. https://ci.chromium.org/ui/p/angle/builders/try/presubmit/20928/overview Original change's description: > Remove ANGLE recipe config. > > This config is now located in the ANGLE recipe_module. > > Bug: angleproject:5114 > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242 > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Bug: angleproject:5114 Change-Id: Ifcf762d5a9e2c57a2ac5963b765042534bc9769f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830370 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
-
- 15 Apr, 2021 3 commits
-
-
Gregory Nisbet authored
I recently encountered an error where I forgot to add a changeid locally to some-but-not-all commits in a stack of commits. When attempting to upload these commits via `git cl upload --no-squash`, I received a confusing message instructing me to install the Gerrit commit-msg hook even after the hook was installed. In order to debug this problem locally, I added the ability to prevent `git cl upload ...` from attempting to change the contents of messages. If the --no-add-changeid flag is passed, then the command will simply fail quasi-informatively. BUG=None TEST=attempted to upload this CL via `git cl upload --no-squash --no-add-changeid`, confirm that it fails. Change-Id: Id5f721c18143448db801095946f490880bb61786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828775Reviewed-by:
-
Edward Lesmes authored
Change-Id: Ie6bee1743859df364025350fc1a607f331346bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825426Reviewed-by:
-
Josip Sokcevic authored
This reverts commit 9a94a95e. Reason for revert: crbug/1199445 Original change's description: > Remove TAGS_REFSPEC if no_fetch_tags is true > > Bug: 1188627 > Change-Id: I6ee14ee9976b9aab60ce409ddd17f018ad966055 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2797933 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Gavin Mak <gavinmak@google.com> Bug: 1188627, 1199445 Change-Id: I776639709221d8e0505315c451f847d6cf592b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828772 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
