Commits · 1d2946bb084674c88231efb63f95f55639d5df5d · Linshizhi / Chromium_Depot_tools

08 Nov, 2018 4 commits

Revert "Roll recipe dependencies (trivial)." · 1d2946bb

Stephen Martinis authored Nov 08, 2018

This reverts commit fc810ab2.

Reason for revert: Broke everything

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
>   https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: Ieac443303891c032ddec11b24004774595cd954a
> Reviewed-on: https://chromium-review.googlesource.com/c/1327623
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: Iad38bee7bc5dcb0d342f5a3b1a072c458a8257d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1327505Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

1d2946bb

Roll recipe dependencies (trivial). · fc810ab2

recipe-roller authored Nov 08, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieac443303891c032ddec11b24004774595cd954a
Reviewed-on: https://chromium-review.googlesource.com/c/1327623Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

fc810ab2

git-cl: Print git push stdout. · edcefdcf

Edward Lemur authored Nov 08, 2018

Tbr: tandrii@chromium.org
Bug: 881860
Change-Id: I17dd5c3b6e3fc6da126487b03ea4fc5aa06c2898
Reviewed-on: https://chromium-review.googlesource.com/c/1326561Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

edcefdcf

git cl status: Force description encoding to utf-8 to avoid throwing · cf6df902

Dan Beam authored Nov 08, 2018

Example error: https://gist.github.com/danbeam/3c6b1f98b5d4a921a583a6f070ed0bf0

R=dpranke@chromium.org
BUG=none

Change-Id: Ib3406ce04782b08b1761506b494b96a827fa4a84
Reviewed-on: https://chromium-review.googlesource.com/c/1299615
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

cf6df902

07 Nov, 2018 6 commits

Quote the full path to ninja.exe. · 75fa8552

Allen Bauer authored Nov 07, 2018

Bug: 902930
Change-Id: I5f160cd2ff7a9da603b029c894c84db1c5ed8374
Reviewed-on: https://chromium-review.googlesource.com/c/1324650Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>

75fa8552

git-cl: Stop logging response headers on 404 Gerrit RPC status. · 49c8eafc

Edward Lemur authored Nov 07, 2018

Bug: 881860
Change-Id: I96a1e8f3ed9fe032307b49d7a130d512e050369e
Reviewed-on: https://chromium-review.googlesource.com/c/1306013Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

49c8eafc

Roll recipe dependencies (trivial). · 421605af

recipe-roller authored Nov 07, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5d8bfa9fef017493107749f2af885ba5e6b805f7 Add ability to override buildnumber via buildbucket module's test API (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5eebd5b44c729ebc4e1488d6c0ef498b25edf3d4
Reviewed-on: https://chromium-review.googlesource.com/c/1323869Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

421605af

Fix unhelpful error when gn.py run in wrong directory. · 4d2d5b4b

Lowell Manners authored Nov 07, 2018

Before this change, when running gn.py outside of
the checkout, the error was:
AttributeError: 'NoneType' object has no attribute 'endswith'

R=scottmg@chromium.org
Bug: gn:14

Change-Id: I4f2f83b2a861bd6f9436c16c2c422fe18fab8f2a
Reviewed-on: https://chromium-review.googlesource.com/c/1299023Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Lowell Manners <lowell@google.com>

4d2d5b4b

autoninja: use ninja in the autoninja.py directory · 4b49707c

Yoshisato Yanagisawa authored Nov 07, 2018

When people execute autoninja, I believe people would expect ninja
in the autoninja directory would be used.  However, the original code
find ninja from PATH, and ninja in other directory could be used.
People usually do not notice this because having depot_tools in
PATH is recommended for Chromium developers.  However, in some
environments, an old version ninja is pre-installed, and unexpected
version ninja could be used upon PATH environment.

Also, in most of bots, depot_tools directory is not included in PATH.
Autoninja execution would fail there because the system cannot find
ninja.

Bug: b/77176746
Change-Id: Iad8bd952dc1e34a9d303fd5b493c555156369a17
Reviewed-on: https://chromium-review.googlesource.com/c/1319489Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

4b49707c

Add android_internal fetch spec. · 52a091f4

John Budorick authored Nov 07, 2018

Bug: 856278
Change-Id: I9aa7cd933a54ba675bdeadb7888d0205a080ea62
Reviewed-on: https://chromium-review.googlesource.com/c/1315470Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

52a091f4

05 Nov, 2018 3 commits

Roll recipe dependencies (trivial). · 6d6e0a80

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c00f13df3e9b3c9bbd191ace36502341f1f2cc52 [isolated] Add ability to add an array of files. (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1da91c43f113b1536e744e0f93714dfaadd8b43c
Reviewed-on: https://chromium-review.googlesource.com/c/1318494Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

6d6e0a80

Roll recipe dependencies (trivial). · 8b0f609c

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0aa0d59a984e8a2fbc99205ea3de860416bc5107 [isolated] Update path to isolated binary (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I074d077d42c3637eb6f69f5841bbe26778da13ce
Reviewed-on: https://chromium-review.googlesource.com/c/1318492Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

8b0f609c

Roll recipe dependencies (trivial). · 459aaba0

recipe-roller authored Nov 05, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/834ac61e122d54c0409b2789490f7b5d5684aea2 [cipd] Permit unicode cipd tags (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ice67d5f088116fbfcde1c312325cae2c776deb27
Reviewed-on: https://chromium-review.googlesource.com/c/1318491Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

459aaba0

03 Nov, 2018 3 commits

Roll recipe dependencies (trivial). · 7e0b0c49

recipe-roller authored Nov 03, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/001848147e74b8f8e63e32dc8bed9ff16e11820f [isolated] Upstream fuchsia's isolated recipe module (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iad829cba40508e05be2a351474f35ceb6f3c48fd
Reviewed-on: https://chromium-review.googlesource.com/c/1316907Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7e0b0c49

git-cl: Add tests for metrics collection. · 01f4a4ff

Edward Lemur authored Nov 03, 2018

Bug: 897394
Change-Id: I07959e870fef4e6a6b8e6e7c974397d3306460c1
Reviewed-on: https://chromium-review.googlesource.com/c/1315839
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

01f4a4ff

Add CELab gclient config · a98da076

Mathieu Binette authored Nov 03, 2018

Change-Id: I97fc6e677cdbab0e2bd74b5b04a74badbd1b0b1e
Reviewed-on: https://chromium-review.googlesource.com/c/1313232
Commit-Queue: Mathieu Binette <mbinette@google.com>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

a98da076

01 Nov, 2018 6 commits

git-cl: Report git push information to metrics collection. · fec80c41

Edward Lemur authored Nov 01, 2018

Bug: 897394
Change-Id: I52a31bb4840b5de89b96545a3e7544c6708f148f
Reviewed-on: https://chromium-review.googlesource.com/c/1312240Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fec80c41

gclient: Make built-in vars available for expansion. · 8f8a50d0

Edward Lemur authored Nov 01, 2018

Make it possible to refer to built-in variables without having to declare
then in DEPS files.

Bug: None
Change-Id: I5403963052463befc074f29750de56cce13927ce
Reviewed-on: https://chromium-review.googlesource.com/c/1312234Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

8f8a50d0

Add brucedawson to OWNERS of autoninja file · 5ee6b6e6

Takuto Ikuta authored Nov 01, 2018

Change-Id: I6923bced3700434a15756fa33f713cf4521b9041
Reviewed-on: https://chromium-review.googlesource.com/c/1312416Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

5ee6b6e6

owners.py: Use os.path.split to handle file separators correctly · 24bca4e7

Daniel Cheng authored Nov 01, 2018

The script gets confused on Windows, because the path delimieter is \,
not /.

Bug: 899724
Change-Id: Id907aceb4f7bb6fcc0460245890b9e4716054ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1308897Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>

24bca4e7

recipe_modules/depot_tools: export autoninja_path · a870c969

Yoshisato Yanagisawa authored Nov 01, 2018

Make autoninja path also available via depot_tools recipe module,
and make autoninja used where it is needed.

Bug: b/77176746
Change-Id: I8553cb3fb32f98e2e3ff420c255461b7e7da7df6
Reviewed-on: https://chromium-review.googlesource.com/c/1293112Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

a870c969

autoninja: don't set -l. · 0db62fcf

Yoshisato Yanagisawa authored Nov 01, 2018

autoninja automatically sets -l <num_cores>. -l option makes ninja
not invoke a new command if current CPU load average is above -l.

However, as far as I investigated, -l <num_cores> make the build
much slower than without -l especially on Linux & OSX machines with
small numbers of cores. I should say -l decreases the build
performance. When I build Chromium with Goma with the same -j with
autoninja without -l, the load average goes more than the number of
cores while keeping the machine working as usual.
Also, ninja can invoke commands until the spike of command invocation
is reflected to load average, -l might not mitigate for a machine
to get stuck by too high load.

Note that from what I understand from the implementation, Windows
ninja's posix-compatible load average is always less than num_cores.
i.e. -l <num_cores> won't limit the process invocation.
https://github.com/ninja-build/ninja/blob/59849864592b421e0a8f993011e7e5c2ab27e77b/src/util.cc#L479

Let me make autoninja not set -l and bring better build performance
on machines with small number of cores.

Bug: b/117810340
Change-Id: I50f231f1a8976f8ecfc3a0c778f0f1ac98d3827f
Reviewed-on: https://chromium-review.googlesource.com/c/1290611Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

0db62fcf

31 Oct, 2018 1 commit

metrics: Collect git version. · 861640f6

Edward Lemur authored Oct 31, 2018

Bug: None
Change-Id: I73545ad59134c6e5dbeb47fb2e8168a5afc0e497
Reviewed-on: https://chromium-review.googlesource.com/c/1296861
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

861640f6

30 Oct, 2018 6 commits

Manual roll for new run logic · 9afc6490

Stephen Martinis authored Oct 30, 2018

Manual roll for https://crrev.com/c/1239574/

TBR=iannucci

Recipe-Manual-Change: build
Recipe-Manual-Change: infra
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: skia
Bug: 646142
Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7
Reviewed-on: https://chromium-review.googlesource.com/c/1305041
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

9afc6490

git-cl: Report Gerrit RPC requests information. · 5a9ff435

Edward Lemur authored Oct 30, 2018

Bug: 897394
Change-Id: I055e844299e262be81d5ac52ef24571b8fdfd47c
Reviewed-on: https://chromium-review.googlesource.com/c/1292245
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

5a9ff435

git cl upload: set CQ and Auto Submit labels through refspec. · e7a7fc42

Andrii Shyshkalov authored Oct 30, 2018

Except when TBR is active, because it's not clear how to
compute max score for Code-Review label before uploading a change.

Tested with this very own CL:
  To https://chromium.googlesource.com/chromium/tools/depot_tools.git
   * [new branch]        c78de165c7be156bdf8032c0ce3d8bad42778f1c ->
     refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado,
         cc=ajp,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org,
         l=Commit-Queue+1,hashtag=git-cl-upload
R=ehmaldonado

Bug: 877717
Change-Id: I464d9df2814bd830dd608bb881040e2dd3c41dbb
Reviewed-on: https://chromium-review.googlesource.com/c/1307052Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e7a7fc42

git cl upload: cc + reviewers in git push for chromium host. · 0da5e8f8

Andrii Shyshkalov authored Oct 30, 2018

For other hosts, behavior is not changed.

Tested on this very CL:
  To https://chromium.googlesource.com/chromium/tools/depot_tools.git
    * [new branch]        9057c2235b096f1feae61d65569641fc7c08a0e2 ->
      refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org,hashtag=git-cl-upload

R=ehmaldonado

Bug: 877717
Change-Id: I951fc576105211590c6c303ce0ed2fe142628224
Reviewed-on: https://chromium-review.googlesource.com/c/1307051Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

0da5e8f8

git cl: more accurate logging message and level. · f170af48

Andrii Shyshkalov authored Oct 30, 2018

R=ehmaldonado

Change-Id: I321de4b0f33dd17473b012bcaddbb925aab7929f
Bug: 877717
Reviewed-on: https://chromium-review.googlesource.com/c/1296855Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

f170af48

git cl: ensure logging is properly initialized. · 46f20cd3

Andrii Shyshkalov authored Oct 30, 2018

R=ehmaldonado

Bug: 877717
Change-Id: If8cce9453ca72b3b300902f5a03e7a8aa93d17b5
Reviewed-on: https://chromium-review.googlesource.com/c/1296856Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

46f20cd3

28 Oct, 2018 1 commit

Add an option to publish CL when posting comments · cb629a48

Sergiy Byelozyorov authored Oct 28, 2018

R=tandrii@chromium.org

Change-Id: Icc4a4432ee51f24bd46001180a009b5b6bff8998
Reviewed-on: https://chromium-review.googlesource.com/c/1296521Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

cb629a48

24 Oct, 2018 1 commit

Hide standard output from the browser when running git-cl-web · 2b71832f

Sergiy Byelozyorov authored Oct 24, 2018

R=nodir@chromium.org

Change-Id: I0816a109bc50cbc5c06339b832748f03abee372a
Reviewed-on: https://chromium-review.googlesource.com/c/1296511
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

2b71832f

23 Oct, 2018 2 commits

Roll recipe dependencies (trivial). · 879d5e37

recipe-roller authored Oct 23, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/04620158d8f45c68cc8bc39e30ce4a85c368046a [archive] Add extended-length path support for windows. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic26a7c96c2eda21b232e11c407a198fe928568e7
Reviewed-on: https://chromium-review.googlesource.com/c/1297194Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

879d5e37

metrics: Add function to extract metrics from HTTP requests · 03d6d118

Edward Lemur authored Oct 23, 2018

Bug: 897394
Change-Id: I92d2514e4347f02dbcf2884bef3a073095ee03a3
Reviewed-on: https://chromium-review.googlesource.com/c/1292242
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

03d6d118

22 Oct, 2018 1 commit

metrics: Add function to collect repeated metrics. · 149834e6

Edward Lemur authored Oct 22, 2018

Bug: 897394
Change-Id: Iece4507c7bf92d7a8aad045d31b4f06e54b3af15
Reviewed-on: https://chromium-review.googlesource.com/c/1292243Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

149834e6

19 Oct, 2018 1 commit

[git] Stop using git-retry wrapper on LUCI. · 98f1e59b

Robert Iannucci authored Oct 19, 2018

The LUCI environment alreadly does `git retry` style retries by virtue
of it's Go git-wrapper program. No need to put an extra python
interpreter in the middle.

R=hinoka@chromium.org, nodir@chromium.org

Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Change-Id: I2918d7f413dde667fccd45c83ad6f4b96c2afe2e
Reviewed-on: https://chromium-review.googlesource.com/c/1292236
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

98f1e59b

18 Oct, 2018 5 commits

git-cl: Don't report metrics for not-known repos. · 93277a7f

Edward Lesmes authored Oct 18, 2018

It is not recorded by the server, but causes a 500 status anyway.

Bug: 896868
Change-Id: Ic3bf0d989bf3c3641dae9ea49a58ffb28f52e865
Reviewed-on: https://chromium-review.googlesource.com/c/1289769Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

93277a7f

[roll-dep] Use Bug: instead of BUG= · c1e6594d

Robert Iannucci authored Oct 18, 2018

This is the more modern syntax and everything should already work with
it.

R=tandrii@chromium.org

Change-Id: I7acbe6cc7c663e03e9a72c2b6c155a7982477146
Reviewed-on: https://chromium-review.googlesource.com/c/1289233
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

c1e6594d

Support target_arch for WindowsSDK · e660e3fb

Scott Graham authored Oct 18, 2018

Bug: chromium:892712
Change-Id: I68e1822a9a7205aaab3836be3f57a2f1feb1c9a6
Reviewed-on: https://chromium-review.googlesource.com/c/1289231
Commit-Queue: Scott Graham <scottmg@chromium.org>
Auto-Submit: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

e660e3fb

metrics: Add a mechanism to notify users when we want to collect additional metrics. · 48836262

Edward Lemur authored Oct 18, 2018

When we change the version number in metrics_utils:

If the user is not a Googler, or has opted out explicitly, nothing happens
and we still don't collect metrics.

If we're collecting metrics from the user, we stop collecting metrics
and display a notice telling them what has changed.
That notice will be displayed ten times, after which we will
resume collecting metrics. A notice telling them we're collecting metrics
will still be displayed.

Bug: None
Change-Id: If1cc12b2fc06f0d6237714c4f182367b1afdf9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1285395
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

48836262

git cl land: remove Rietveld-only options. · 3e002fb8

Andrii Shyshkalov authored Oct 18, 2018

R=ehmaldonado

Bug: 770408
Change-Id: I6f460902e3282451f5761bebf176d180a8f88d26
Reviewed-on: https://chromium-review.googlesource.com/c/1279141
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3e002fb8