Commits · 1bd4ffa29510e095f3ee5d00310eb91c948622f5 · Linshizhi / Chromium_Depot_tools

28 Jul, 2021 1 commit

Remove wait-for-merge from gerrit client tool · 1bd4ffa2

Xinan Lin authored Jul 28, 2021

Following comment in crrev.com/c/3039331, submit call
is fully synchronous.

BUG=1207955
TEST=e2e

Change-Id: I9146d43b4d4530ad5064709e418d34e3229e19ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3049672
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

1bd4ffa2

27 Jul, 2021 10 commits

Roll recipe dependencies (trivial). · d9798a68

recipe-roller authored Jul 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b26ca6d25250558db80f05c8a515fea2c00b0a2a
  b26ca6d (yiwzhang@google.com)
      py3: add cffi to vpthon3 spec

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1cf5f2d1fbf077679ada297e9834f0dc8f54c04f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3057634
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d9798a68

Roll recipe dependencies (trivial). · e7f3118e

recipe-roller authored Jul 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/537f0cb4e80136462ca2a427b118f180c4e7ad52
  537f0cb (yiwzhang@google.com)
      py3: replace os.unsetenv with os.environ.pop

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibc373ae9d3619da9a60207a559ad89f5cbac87a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3057633
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e7f3118e

add infradata_rbe config · acc131ce

Fumitoshi Ukai authored Jul 27, 2021

Bug: 1233386
Change-Id: I0d83113e832f264b8be613c1fd48f9d9da3c6e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3055264
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

acc131ce

Add setbotcommit method to gerrit_client · 0b0738d9

Xinan Lin authored Jul 27, 2021

This is required if we want to land a bot-generated-cl.

BUG=1207955
TEST=e2e

Change-Id: Ib758b9782f9951a3ec23ce9970b0db2a48b1b5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3049573
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Moss <mmoss@chromium.org>

0b0738d9

recipe: import engine_types instead of types from recipe_engine · 2eba5297

Yiwei Zhang authored Jul 27, 2021

Motivation: https://crrev.com/c/3050650

Bug: 1227763
Change-Id: I2e7ce3a8a5652959bdc68f4b3cd3a783d0424c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3055154
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

2eba5297

tryserver getter for CL repo host/project · b992c425

Stephanie Kim authored Jul 27, 2021

Allows for quick retrieval of host and project without having to parse
gerrit_change_repo_url or hard coding.

Bug:
Change-Id: I43f6e0bfda4b54d742bfa7ea20ee781162796608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2971110
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b992c425

gerrit_client could retrieve the branch and tag info for a commit hash · c2fb26a3

Xinan Lin authored Jul 27, 2021

BUG=1207955
TEST=verified at local

Change-Id: Ife31456371f156d342ddd099bba1521051d700fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3044919Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Xinan Lin <linxinan@chromium.org>

c2fb26a3

Roll recipe dependencies (trivial). · 690ba8f9

recipe-roller authored Jul 27, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/32560ddd7db093bbef5b78a72e876d495db4dc8f
32560dd (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from 4d27bf4863b7 to 5849a0d29a3f

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I32adc75321676be02d2744f68d9c56973c39e4cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3055537
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

690ba8f9

New vpython release to depot_tools. · 576f8a26

Brian Ryner authored Jul 27, 2021

Bug: 1230447, 1213311
Change-Id: I57d68bc40e492d92854186bc78ad5a2f197ee19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3054158
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>

576f8a26

Roll out new goma client binary VERSION=228 · 00af2cc9

Yoshisato Yanagisawa authored Jul 27, 2021

Bug: b/194029819
Change-Id: I92ff5d9ea99f0bbb5523d9d8413195f4cf5cabe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3055209Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

00af2cc9

26 Jul, 2021 4 commits

Roll recipe dependencies (trivial). · b88ad8e6

recipe-roller authored Jul 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/a9d52afdf4c5b9641602e6a8d96fdd2c40010062~..14aeb4fc9d57d144be6ba3cc8b6b948fa5d74e6e
a9d52af (yiwzhang@google.com)
py3: add .vpython3 to .gitattributes so that it will be bundled
14aeb4f (yiwzhang@google.com)
py3: use zlib module to compress the build proto stream

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4d949bf030d00ea52290b6f0bf529cd9d6ccce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3054978
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b88ad8e6

Roll recipe dependencies (trivial). · d1aae6ca

recipe-roller authored Jul 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9f66864e525c9ebbaf4baa318593ab71d53deda7
9f66864 (yiwzhang@google.com)
stop calling basicconfig in subcommand because it is now always...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic85234da715d02b2011cd86e18c906c4c971badc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3052561
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d1aae6ca

Roll recipe dependencies (trivial). · c6c49264

recipe-roller authored Jul 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7d762708d4fafd9b0b3ed7fb60a369fdd4531a90
  7d76270 (tandrii@google.com)
      [doc] fix typo.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a80e97f3e4e5ae4a92ec1e74754a5c1ae4c832b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3054976
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c6c49264

Roll recipe dependencies (trivial). · 210fe05c

recipe-roller authored Jul 26, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/493b236de3e8fcbee1371bd9ceea1cba156b5cec
493b236 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from 8183425438f1 to 04c7051e7a02

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c41ae6051d26b9c9249b787c537ee307a61b6dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3053848
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

210fe05c

22 Jul, 2021 1 commit

Roll recipe dependencies (trivial). · 591a5588

recipe-roller authored Jul 22, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7caff240ba2cdb9ec5b4fb01b6e966ff6df4af86
7caff24 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from 2be056d01d3f to d5819a48e767

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id06afbe2fa8dea4eaa452f9074b769369f70b042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3047041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

591a5588

21 Jul, 2021 8 commits

Roll recipe dependencies (trivial). · 1e0e9638

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/af0b32cd5e64a71d3357047ba149a3e3c00445e1
af0b32c (yiwzhang@google.com)
py3: make run command py3 compatible and enable simple unittest...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I68a2f25cd5851734d2ecd9fb718321011ca402f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3043937
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1e0e9638

Roll recipe dependencies (trivial). · 96ca3559

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a3a73586fd370ae8552482a6a6885c494c8c4b28
a3a7358 (yiwzhang@google.com)
py3: upgrade parameterized to 0.8.1 and use new naming feature

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I68490de958fdde3415f9e66fe500e03989fb7fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042335
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

96ca3559

Roll recipe dependencies (trivial). · fd6209eb

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c80e36cb1fecf569f5b9e6da86722a90adf37ebe
c80e36c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from af829a9aede7 to 9555d5a16a0b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4092634e5f5f4b078872f9e02aa6e850be0b8681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3044469
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fd6209eb

Reland "Add python3 support to bot_update recipe module" · 11f53d69

Gavin Mak authored Jul 21, 2021

This is a reland of edb6e8c5

Original change's description:
> Add python3 support to bot_update recipe module
>
> Bug: 1227140
> Change-Id: Id4938c966da54957f84f59d0aef0c68c381ad5f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3016032
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 1227140
Change-Id: I2d35d29f87236ce10ecabca41712cf1c90de8136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3022310Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>

11f53d69

Roll recipe dependencies (trivial). · b2283a3d

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a73b2aa81f283794206a01089057287d003adfe2
  a73b2aa (yuanjunh@google.com)
      [python3] Use new Coverage pkg version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3da91b388e0415b32273bc20924d55f017276828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042350
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b2283a3d

Roll recipe dependencies (trivial). · 21ce30ac

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/67672a11407680eaf918a014d21a53bce86d7ca1
67672a1 (yuanjunh@google.com)
Reland "Support running different py version simulation recipe...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I744659f56b2317b7000f4714e15d5c0b075a2828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042349
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

21ce30ac

Roll recipe dependencies (trivial). · 7d8e0751

recipe-roller authored Jul 21, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5b4948dfc0eeb5f719972e1566483ba559f47d36
  5b4948d (yiwzhang@google.com)
      presubmit: do not execute run_test in parallel

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9d4283e090f7e944cbd37301893e010ff8bcfd4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042348
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7d8e0751

Add CMDsubmitchange to gerrit_client · 6ec7cd87

Xinan Lin authored Jul 21, 2021

Grant the power to gerrit_client cmd to submit a change. Once
we create a change and update it via CMDchangeedit, we can
submit it if the service account has permission.

BUG=1207955
TEST=e2e

Change-Id: Ia3102641ffe5bb72f8f63ad80bf15b5478cf5a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039331Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Xinan Lin <linxinan@chromium.org>

6ec7cd87

20 Jul, 2021 4 commits

Roll recipe dependencies (trivial). · 4e26781c

recipe-roller authored Jul 20, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/430a9b126fc95883f1259b6066f3cea4b12cbbe5~..6d333c309ab561bca61284f65a8da77a43d4590c
430a9b1 (yiwzhang@google.com)
py3: encode the inline program if it is unicode text
627423f (yiwzhang@google.com)
py3: make comprehensive_ui recipe python3 compatible
6d333c3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from c674152515af to ff25bdd47c92

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc501b536b8c2b3ef41c8c499f53ee532c1df5c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042346
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4e26781c

Use py3 for remaining tools in depot_tools path · 39120911

Josip Sokcevic authored Jul 20, 2021

R=apolito@google.com, dpranke@google.com

Bug: 1199102
Change-Id: I06ff344ac91464eb558e92598c87e43ecfa830dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2994488
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

39120911

Harden _PresubmitResult against varying string types · 61c72651

Tom McKee authored Jul 20, 2021

When presubmit checks fail, we want to print the error message from the
underlying check/tool. We use _PresubmitResult objects to collect these
diagnostics and output them to the console and json files.

This change ensures that the string values passed to the
_PresubmitResult constructor will be converted, as needed, to 'str'
instances. This way, we will avoid encoding errors and make sure to
print the actual messages instead of repr(message).

SHERIFFS: this patch breaks backwards compatibility of presubmit error
handling but we don't expect issues in downstream projects. Please
revert if downstream presubmit checks start failing spuriously.

Bug: 1225052
Change-Id: If7f5c99cb5d730c1bfbd6d108b912f77b5f2455c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3037262
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

61c72651

Roll recipe dependencies (trivial). · 1c3175be

recipe-roller authored Jul 20, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/8e0273d1386a0d58093730a508604d66f063961c
  8e0273d (yiwzhang@google.com)
      py3: run luciexe unitest in both py2 and py3

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e3b4c676151ebcfe9eb0e347f6e34f36abf9639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3040718
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c3175be

19 Jul, 2021 9 commits

Roll recipe dependencies (trivial). · e5c9423f

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fcea2752f66155b22774bbf1a0261bfa507fd1c8
  fcea275 (yiwzhang@google.com)
      test: separate luciexe test from run test

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0b4009e240658e82ba7160159e29337e013fb251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039336
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e5c9423f

Roll recipe dependencies (trivial). · 99d79bd0

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/01cb0aabd697ac473d44c5f896e299f555cbf0ec
  01cb0aa (yiwzhang@google.com)
      py3: make a few recipe modules work in python3

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1926cca80845baa5bd3abbcae85ba0f10f4baed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039333
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

99d79bd0

Roll recipe dependencies (trivial). · ec365ffc

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d284048d5a319a8d55b36ddbc83915b89f5c7570
d284048 (yiwzhang@google.com)
py3: decode bytes to utf-8 string before writing to log stream

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6b46c1725bab65131dfc4f1a2263cd970d28e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039332
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ec365ffc

cpython3 3.8.10.chromium.20 to depot_tools stable. · 5b118d14

Brian Ryner authored Jul 19, 2021

Bug: 1220743
Change-Id: I72dac4c01f21670cb61edf19f73fa3b89b8d78e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3038232
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

5b118d14

Roll recipe dependencies (trivial). · e8a3398b

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0d98efcd78f032759ae59c32130dc63865a464b7
  0d98efc (yiwzhang@google.com)
      fix the script that updates 3p lib

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I00f26b0c43d6b6a554eba9e4375ed133d864c0a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039329
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e8a3398b

Roll recipe dependencies (trivial). · 041924eb

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5530960b3265abdf6b4b55a7b62e5891da3262cc
  5530960 (iannucci@chromium.org)
      Clean up OWNERS files

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21d046944d6d3b2b274e8813ab591e609a894711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039327
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

041924eb

Roll recipe dependencies (trivial). · 439a2dc6

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b4e57a6c1a268c232de6f44dee7a1b6a4f51ffb6
b4e57a6 (gbeaty@chromium.org)
Reduce the severity of logs for recipe_modules non-issues.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifac6a3e3657af199addfe3d4466382bdc5b1f6ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3039324
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

439a2dc6

Roll out new goma client binary VERSION=227 · eaa87fa1

Yoshisato Yanagisawa authored Jul 19, 2021

Bug: b/193482371
Change-Id: I2e22598198a41eb1eb02b4180d7b1c2f8fb5da18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3037902Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

eaa87fa1

Roll recipe dependencies (trivial). · 9e5625f1

recipe-roller authored Jul 19, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/02021564421b427b145fc433bdd48d5a42612a29
0202156 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from 56d8faf61a03 to 175b811c1eeb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e5c8f04924faf71b167c2e2edf29b0bd94e1a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3037470
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9e5625f1

16 Jul, 2021 3 commits

Roll recipe dependencies (trivial). · cad99671

recipe-roller authored Jul 16, 2021

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/3a8a334ce198b1b1147109daaa3baf952ae13e93
  3a8a334 (yiwzhang@google.com)
      engine: upgrade third-party library

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I907856902b22ef76c7edad38bf41a75e07159ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3035633
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

cad99671

cpython3 3.8.10.chromium.20 to depot_tools bleeding edge. · 92c396e4

Brian Ryner authored Jul 16, 2021

Bug: 1220743
Change-Id: I9ba3f445c72d802925bf6e042dc1785fe4f08867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3034710
Auto-Submit: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

92c396e4

Revert "[depot_tools] Add --fork-point when computing merge-base" · a3d1aaf1

Josip Sokcevic authored Jul 16, 2021

This reverts commit 934ac6eb.

Reason for revert: https://crbug.com/1225658, git reparent-branch
may result in data loss (recoverable if gc doesn't remove it).

Original change's description:
> [depot_tools] Add --fork-point when computing merge-base
>
> Using --fork-point when possible reduces the number of merge conflicts when running merge-base.
>
> Bug: 1111269
> Change-Id: I7240fdc9a613d2eb4e856b5677fc713551d7afe9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2519729
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

R=gavinmak@google.com

Bug: 1111269
Bug: 1225658
Change-Id: I2aeadeb2fbff18abcab5552e07254dfc1c2499a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3034831
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

a3d1aaf1