Commits · 1bb04aa1c0e1773bc0e97b0d61446eb113eec979 · Linshizhi / Chromium_Depot_tools

01 Jun, 2009 1 commit

Rewrite the presubmit test to be much more hermetic. · ca14c12a

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115964

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17314 0039d316-1c4b-4281-b951-d872f2087c98

ca14c12a

29 May, 2009 4 commits

Save 50 lines by converting the unit test to mox.MoxTestBase. · 388f1d26

maruel@chromium.org authored 15 years ago

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/118019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17215 0039d316-1c4b-4281-b951-d872f2087c98

388f1d26

Convert gclient_test.py to mox.MoxTestBase and saves 40+ lines · b7622768

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/118014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17213 0039d316-1c4b-4281-b951-d872f2087c98

b7622768

Remove SVN-specific function InputApi.FilterTextFiles(). · 77c4f0f1

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115923

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98

77c4f0f1

Make AffectedFile member variables private. · 15bdffa0

maruel@chromium.org authored 15 years ago

Cache SvnAffectedFile.IsTextFile() return value.

Improve the unit test by not/less relying on the local file system.

Review URL: http://codereview.chromium.org/113964

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98

15bdffa0

28 May, 2009 2 commits

warnings.catch_warnings() is only available on python 2.5 · 78688625

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115881

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17114 0039d316-1c4b-4281-b951-d872f2087c98

78688625

Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles(). · 1e08c00d

maruel@chromium.org authored 15 years ago

Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.

Review URL: http://codereview.chromium.org/113933

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98

1e08c00d

27 May, 2009 3 commits

Make the member variable 'protected' in the python sense. · 6ebe68a7

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113899

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98

6ebe68a7

Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code. · e1a524ff

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113883

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98

e1a524ff

Add a unit test for input_api.change.tags. · f3eee569

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113859

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98

f3eee569

22 May, 2009 3 commits

Add InputApi.version so the presubmit script can mark a minimum supported version for instance. · 9711bbaf

maruel@chromium.org authored 15 years ago

BUG=None
R=joi

Review URL: http://codereview.chromium.org/115719

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98

9711bbaf

Factor out SVN-specific methods out of AffectedFile. · dbbeedc6

maruel@chromium.org authored 15 years ago

TEST=New unit tests.
BUG=None

Review URL: http://codereview.chromium.org/113783

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98

dbbeedc6

Add repository root presubmit support. · 0ff1fab8

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115616

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98

0ff1fab8

21 May, 2009 2 commits

Add support to cache arbitrary file. · 98fc2b9b

maruel@chromium.org authored 15 years ago

Rename repository_root to REPOSITORY_ROOT.

Review URL: http://codereview.chromium.org/115615

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16598 0039d316-1c4b-4281-b951-d872f2087c98

98fc2b9b

Move the changelist files into a subdirectory for cached files implementation. · 374d65e5

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115612

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16597 0039d316-1c4b-4281-b951-d872f2087c98

374d65e5

20 May, 2009 2 commits

Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests. · 8c3ccf39

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113650

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16499 0039d316-1c4b-4281-b951-d872f2087c98

8c3ccf39

When -s or --server is used, don't try the patch. · 003c269b

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115534

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16477 0039d316-1c4b-4281-b951-d872f2087c98

003c269b

19 May, 2009 2 commits

Add new presubmit check RunPythonUnitTests. · 7b305e8c

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115516

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98

7b305e8c

Clean up revert.py and fixes an issue when only one file is reverted in a subdirectory. · 5771f262

maruel@chromium.org authored 15 years ago

Add a basic unit test.

Review URL: http://codereview.chromium.org/115514

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16388 0039d316-1c4b-4281-b951-d872f2087c98

5771f262

15 May, 2009 2 commits

Add more presubmit support. Add PRESUBMIT.py to depot_tools. · 3d23524c

maruel@chromium.org authored 15 years ago

Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98

3d23524c

Remove two seams options.gclient and options.scm_wrapper in gclient. · 2806acc5

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/115322

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16155 0039d316-1c4b-4281-b951-d872f2087c98

2806acc5

13 May, 2009 3 commits

Remove the options.path_exists which only existed as a seam. It's not really needed in python. · 0329e67b

maruel@chromium.org authored 15 years ago

Also fix 2 other mocks.
Review URL: http://codereview.chromium.org/115286

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15976 0039d316-1c4b-4281-b951-d872f2087c98

0329e67b

Rename presubmit.py to presubmit_support.py to reduce confusion and be able to... · 1033accb

maruel@chromium.org authored 15 years ago

Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.
Review URL: http://codereview.chromium.org/113337

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98

1033accb

Fix unit test due to change r15911. · 39593706

maruel@chromium.org authored 15 years ago

TBR=estade
Review URL: http://codereview.chromium.org/115283

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15928 0039d316-1c4b-4281-b951-d872f2087c98

39593706

12 May, 2009 11 commits

Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2). · 00c41e45

kuchhal@chromium.org authored 15 years ago

BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.

Review URL: http://codereview.chromium.org/113294

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98

00c41e45

Deprecate gcl.GetSVNStatus() for gclient.CaptureSVNStatus() and fix some... · 4810a966

maruel@chromium.org authored 15 years ago

Deprecate gcl.GetSVNStatus() for gclient.CaptureSVNStatus() and fix some status information that was lost.
This was breaking gclient revert on unversioned files.

TEST=ran "for %a in (tests\*test.py) do python %a" and all tests succeeded.
Review URL: http://codereview.chromium.org/115264

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15894 0039d316-1c4b-4281-b951-d872f2087c98

4810a966

Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo(). · 46a94109

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113290

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15891 0039d316-1c4b-4281-b951-d872f2087c98

46a94109

Add a flag not print errors in CaptureSVN() · 5c3a2ff6

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113288

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15887 0039d316-1c4b-4281-b951-d872f2087c98

5c3a2ff6

Add more tests and cleanup ChangeInfo class. · be0d1ca0

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113269

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15885 0039d316-1c4b-4281-b951-d872f2087c98

be0d1ca0

Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly. · df7a3134

maruel@chromium.org authored 15 years ago

Fix breakage caused by r15861 and add a regression test.
Review URL: http://codereview.chromium.org/113278

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15872 0039d316-1c4b-4281-b951-d872f2087c98

df7a3134

Revert 15861 because of · 96b91712

maruel@chromium.org authored 15 years ago

 File "D:\b\depot_tools\bootstrap\\..\gclient.py", line 446, in SubprocessCallAndCapture
   out.write(in_byte)

TBR=nsylvain
Review URL: http://codereview.chromium.org/115244

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15862 0039d316-1c4b-4281-b951-d872f2087c98

96b91712

Simplify some functions by removing the options.stdout mock. Fix the unit test accordingly. · e77173e5

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113272

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15861 0039d316-1c4b-4281-b951-d872f2087c98

e77173e5

Revert changes 15823 and 15824 because they broke gclient revert. · 11e0fd69

maruel@chromium.org authored 15 years ago

TBR=sgk
Review URL: http://codereview.chromium.org/115217

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15827 0039d316-1c4b-4281-b951-d872f2087c98

11e0fd69

Starts reusing functions in gclient.py from gcl.py. · 46b9ae69

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113218

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15824 0039d316-1c4b-4281-b951-d872f2087c98

46b9ae69

Cleanup gclient.py use of options where unnecessary. · 09b3ba21

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113216

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15823 0039d316-1c4b-4281-b951-d872f2087c98

09b3ba21

11 May, 2009 1 commit

Change CaptureSVNInfo() to return a dictionary instead of a object. · 2dc8a4d3

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/113086

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15750 0039d316-1c4b-4281-b951-d872f2087c98

2dc8a4d3

01 May, 2009 1 commit

- Add '!' and 'L' status support. · edd27d17

maruel@chromium.org authored 15 years ago

- Fix gclient revert/status when one of the dependency directory is deleted.
- Remove an unneeded svn update after svn checkout.
- Updated tests.
Review URL: http://codereview.chromium.org/100256

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15068 0039d316-1c4b-4281-b951-d872f2087c98

edd27d17

30 Apr, 2009 1 commit

Pull gclient revision 72 and add the gclient unit test. · e105d8d0

maruel@chromium.org authored 15 years ago

Review URL: http://codereview.chromium.org/99226

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14957 0039d316-1c4b-4281-b951-d872f2087c98

e105d8d0

28 Apr, 2009 1 commit

Convert gcl.GetSVNFileInfo() to xml format. · 207fdf36

maruel@chromium.org authored 15 years ago

Add gcl's first unit test.
Add version string.
Review URL: http://codereview.chromium.org/100095

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14771 0039d316-1c4b-4281-b951-d872f2087c98

207fdf36

27 Apr, 2009 1 commit

Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRESUBMIT.py scripts. · c1675e27

maruel@chromium.org authored 15 years ago

Also add a version number to gcl.py.
Review URL: http://codereview.chromium.org/99072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14644 0039d316-1c4b-4281-b951-d872f2087c98

c1675e27