- 01 May, 2020 2 commits
-
-
Anthony Polito authored
Bug: 1074167 Change-Id: I9f0c1c8a1fa76d6bf2899000fd0b3665f7bf0994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174818Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/db2f179387abaf196eb8221f376a2174663a4d28 (olivernewman@google.com) [buildbucket] Add fields arg to get() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibeb5ed96b7db5b8be4e988519f6cc67b5db5ee48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176038Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 30 Apr, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/53ed08a539ff9e24188417136109b8cac0f8b47e (chanli@chromium.org) [ResultDB] Add link to ResultDB concepts doc More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10ef0ade65b087e10e51d4a46d54ec65a571de9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174863Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/1b1574d044a7f44430825aa929cdc5b4fe17ab7b (erikchen@chromium.org) Update user guide. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8aa0e687647a484b4bf08eb4928b10fb94de666a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173836Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Bruce Dawson authored
__except () is the canonical layout for code that uses __try/__except, Microsoft's structured exception handling. The majority of __except uses in our code use a space after the keyword. However cpplint.py thinks that __except is a function name. Apparently we have been forcing this through by ignoring the presubmits. This just adds __except to the list of exceptions to the whitespace/parens rule. Change-Id: I2384cd32f26e3aa6a4b0150451a9a61147483e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173644 Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Yoshisato Yanagisawa authored
https://chromium.googlesource.com/infra/goma/client/+/b398f18fab944184f795cdcf0062994597578912 Bug: b/153832839 Change-Id: I24a4e8b5df26b2aa0d3bbec79987385993ca2c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2174069 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Simon Que <sque@chromium.org>
-
- 29 Apr, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/d937e9525fff04f0a92f9ef1e41ceb0e985ecf7b (chanli@chromium.org) Mock resultdb info in buildbucket test_api More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib72d02dc1dfab2535b076fa672fa7f983f887fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171992Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/e9ccc9dd63ce31ec535c7b4b69d1f15618bf4d78 (olivernewman@google.com) [swarming] Fix typos and pylint errors More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I54fe12f43ec6ff07dd26b36d1582766337e6687a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172340Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/1ec8faaaa559d4876f9c9c009a1be564286a8bba (olivernewman@google.com) [swarming] Roll swarming client version More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6801c67e3c1ff66128144eb064012d407143c09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2172337Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Josip Sokcevic authored
R=apolito@google.com, ehmaldonado@chromium.org Change-Id: Ie453bb95208561a09a5f1f62cb9543e31cbe031f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2171923 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 28 Apr, 2020 5 commits
-
-
Josip Sokcevic authored
Introduce a process observer that terminates child process if there is not stdout activity. It can be overridden by an environment variable. R=apolito@google.com, ehmaldonado@chromium.org Bug: 1074355 Change-Id: I11de9d29e716587614cf336725c8d4a368a9d61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167220Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
When interactive is true, check_call is used instead of check_output, and check_call doesn't return the command output. Bug: 1074357 Change-Id: Ib9e761d41d754df58c9ee1f897dde173ce4d9eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2170805Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
This is a reland of 50c6d8d3 Original change's description: > Print ps in intervals while the process is running > > R=apolito@google.com, ehmaldonado@chromium.org > > Bug: 1074355 > Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> R=apolito@google.com, ehmaldonado@chromium.org Bug: 1074355 Change-Id: I488b521e4a3b859c37f0bb1e21cad7d037f8f97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169392Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
This reverts commit 50c6d8d3. Reason for revert: self argument missing Original change's description: > Print ps in intervals while the process is running > > R=apolito@google.com, ehmaldonado@chromium.org > > Bug: 1074355 > Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: I3c90576d0c6403f0d2f9119876a400c1380a8e14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1074355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2169391Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/3809ffa82d6bc08da66eae89bc87cdbe5c5b5905 (olivernewman@google.com) [swarming] Roll swarming client version More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9dd8ee949024310a048cddad2abec07f1c43288e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168955Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 27 Apr, 2020 5 commits
-
-
Takuto Ikuta authored
This reverts commit 8533236d. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086/4#message-dcd4603d5914c681d0e1ad498e7bb9b59576a24d Original change's description: > git_cl: add --parallel for yapf > > see > https://github.com/google/yapf#usage > > Bug: 1073708 > Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073708 Change-Id: Ib8245dca57a11a386e78089630df61ff773b1789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168971Reviewed-by: Aaron Gable <agable@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Edward Lesmes authored
The support for Dart in canned_checks.CheckPatchFormatted can be removed. It was used in Chromium, when Chromium included a Dart SDK in its checkout. Dart was removed from Chromium years ago, and none of the current Dart repositories use this in their presubmit. Current repositories using Dart and depot_tools are dart.googlesource.com/sdk and Flutter engine. The SDK source tree has extensive custom code written for format checking in the presubmit, and Flutter engine has none. So adapting the exiting code to work with a new SDK location, or searching the path for any Dart SDK (which would be too fragile) would not be useful for these projects. The support code was introduced in: https://codereview.chromium.org/933383002 Bug: 1075502 Change-Id: I1ceed1ed6c1b4ff05071b0db1c52016f03c47c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168851Reviewed-by: Anthony Polito <apolito@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
R=apolito@google.com, ehmaldonado@chromium.org Bug: 1074355 Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/a1f700042dd072e39d521f74c71bea4f488282eb (yiwzhang@google.com) [warning] add user guide for warning feature in recipe engine More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia1c601b76b74c87f1543c965c2474a8b469fec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167224Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/d305b98624bda32f20b4b4a25499f3e8464a3868 (olivernewman@google.com) [swarming] Add `verbose` argument to collect() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3c44602b3cd09aaeaa93fb4b2572d6562959d1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166819Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 24 Apr, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/1362e821b88409d2bde0c95b65813f9f5daf701a (iannucci@chromium.org) [pywin32] Remove pywin32 dependency completely. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib3a65fb390502e380df7d15ab3bd0dc254571f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166148Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/3a620b0ada4e8b3aa6c436828d94cdaf0eef3086 (olivernewman@google.com) [swarming] Pass -verbose to collect More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifac46fbe076199cf5569c69a95936d03ee0d4173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2165419Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 23 Apr, 2020 11 commits
-
-
Josip Sokcevic authored
Use ISO8601 time format standard to avoid localized result and need to encode. R=ehmaldonado@chromium.org Bug: 1074002 Change-Id: I95c2ddd55a9661351f2b45601f7bba24c2951c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163401Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Fletcher Woodruff authored
There is a cpplint include check that ensures that all includes have a directory name preceding them. However, if all source lives in the root of a repository, there is no point in having a directory. Because this check lives under 'build/include', it's impossible to filter without filtering other useful checks. Move it to 'build/include_directory' so it can be more easily filtered. BUG=chromium:1073191 TEST=cros lint on a file with 'filter=-build/include_directory' in CPPLINT.cfg Change-Id: Ie15fb2398a6d0297ef96219e67076ea262abf853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159690Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Fletcher Woodruff <fletcherw@chromium.org>
-
Takuto Ikuta authored
see https://github.com/google/yapf#usage Bug: 1073708 Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Takuto Ikuta authored
see https://github.com/google/yapf#usage Bug: 1073708 Change-Id: I3824bbecc6c52d6b7f82aaa05e5108a8619124d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162227Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/fed4eae33606a63ad477a80c895e965bb929f69e (yiwzhang@google.com) [luciexe] Fix the issue where build status is not properly updated More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9b32a1dae9a51bb9b68078f1dc893abedef7f806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163198Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Josip Sokcevic authored
Reverted commit 4511b131 had a bug where squash_ret.success = True and empty_rebase = False. In that case, stdout and stderr would already be string and trying to decode would fail. Bug: 1071280 Change-Id: Iadcc526147ebb98aa7a91a7daa64ef44066e83b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163387 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Bruce Dawson authored
Slashes and backslashes are interchangeable on Windows in many contexts. But not all. In particular, if you add a path to a dictionary and then try looking it up with an equivalent path that has different slashes then - not surprisingly - the lookup will fail. Therefore it is important to always use slashes when populating _paths_to_owners. This is now done, and documented. Additionally, while fnmatch.fnmatch handles comparing slash separated paths to backslash separated paths, fnmatch.translate does not. This is arguably a bug in fnmatch.translate, or at least something that should be documented. This bug is worked around by having _fnmatch sanitize file names to always use slashes, and asserting that the patterns do not contain backslashes. With these changes this command: git cl owners --ignore-current --show-all chrome/browser/BUILD.gn now correctly gives the same results as this command on Windows: git cl owners --ignore-current --show-all chrome\browser\BUILD.gn The modified test fails without the other changes, passes with them. Bug: 1009104 Change-Id: I416c7131281f00e352c1d2b85c30fcc463417fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915410 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/ac4b520aa1f7a8cec925349bc7cf6c3a2d0fb78c (olivernewman@google.com) [swarming] Add eager argument to collect() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ida26f1bd4a50d28e95bd989b15cb19de6fc40828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163186Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Wez authored
This reverts commit 4511b131. Reason for revert: Broke git_rebase_update.py under Python3, which does not support calling decode() on string objects. Original change's description: > Fix printing error on git-rebase failure > > R=ehmaldonado@chromium.org > > Bug: 1071280 > Change-Id: I8b1f00bb7c454297b10d5e047ae35c2686f69fb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2155154 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071280, 1073768 Change-Id: I58c1b24ba2aef255068c81be25475b2abbbf4fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161111Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/3559ca4d7586d19e6e3d548a5708b32d64a3c08a (mseaborn@google.com) [swarming] Sort dictionary keys when constructing swarming request More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibe9775200beaaa743fc7bc03bb88032ce3f490f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162145Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/36f4d31f57f0ab3d5e6925a724dced97cc3eeac2 (mseaborn@google.com) [file][json] Sort dictionary keys when writing JSON data More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I27f2d22bf8f032256adcbed9f60b10c5c3320ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161902Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 22 Apr, 2020 7 commits
-
-
Josip Sokcevic authored
Users can still set GCLIENT_PY3=0 to use Python 2. R=ehmaldonado@chromium.org Change-Id: Ic7657a091bfe3b9c426ab36063b106aadf2d1c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161266 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Allen Bauer authored
Change-Id: I30284634b2c5bdf1d155fe2f8d6f72538c9e2f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161634 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/9c7dd835e208fa6268d7c06f0ba15823b257b4bb (iannucci@chromium.org) [vpython] Bump version of pywin32 to 227. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0afd28e145f05ecae5c87332e4807fe7bbc7e0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161270Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Robert Iannucci authored
Having it in %PATH% means that powershell users will accidentally run 'cipd.ps1' when they should be running 'cipd.bat'; This would cause them to get requests for input parameters (like the backend URL) which they have no idea how to supply. R=agable@chromium.org, nodir@chromium.org, vadimsh@google.com Bug: 1073529 Change-Id: I62a3bd9e00229a2047293dba1ba480d28f77bf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161645Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/096f05fa40b6864c8d22e6df8e154e43d7c778c6 (jsca@google.com) Add milo recipe module. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4c91f04e85e69605beb6df1a5da91e33041f48a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160407Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/940d2483cca29dba541c42f1bdb6d33745269e97 (yekuang@google.com) Roll swarming client version More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia332e0d33da35942374efdd379dd2bd9eba361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160214Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Dale Curtis authored
This avoids the toolchain being wiped after using WinDbg. Bug: None Change-Id: I989ef7744b46254bab4c5a707724dc38a9b9a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159998 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
-